37516 2010-04-13 12:34:27 -0700 Re-write testProfilerTab to match the new profiler implementation 2010-04-14 01:51:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov commit-queue pfeldman yurys oldest_to_newest 212046 0 mnaganov 2010-04-13 12:34:27 -0700 Here is how js_page.html will look like: <html> <head> <script> function fib(n) { return n < 2 ? 1 : fib(n - 1) + fib(n - 2); } function eternal_fib() { console.profile(); for (var i = 0; i < 50; ++i) { fib(20); } console.profileEnd(); } function load() { // Let the page do initial rendering, then go. setTimeout(eternal_fib, 200); } </script> </head> <body onload="load()"> </body> </html> 212047 1 53272 mnaganov 2010-04-13 12:37:03 -0700 Created attachment 53272 proposed patch 212296 2 53272 commit-queue 2010-04-14 01:51:41 -0700 Comment on attachment 53272 proposed patch Clearing flags on attachment: 53272 Committed r57571: <http://trac.webkit.org/changeset/57571> 212297 3 commit-queue 2010-04-14 01:51:45 -0700 All reviewed patches have been landed. Closing bug. 53272 2010-04-13 12:37:03 -0700 2010-04-14 01:51:40 -0700 proposed patch re-enable-profiler-test-patch text/plain 3550 mnaganov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDVlOThmZWUuLjg4ODZhYzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTA0LTEzICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmUt d3JpdGUgdGVzdFByb2ZpbGVyVGFiIHRvIG1hdGNoIHRoZSBuZXcgaW1wbGVtZW50YXRpb24uCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NTE2CisK KyAgICAgICAgKiBzcmMvanMvVGVzdHMuanM6CisgICAgICAgICguVGVzdFN1aXRlLnByb3RvdHlw ZS50ZXN0UHJvZmlsZXJUYWIuZmluZERpc3BsYXllZE5vZGUpOgorICAgICAgICAoLlRlc3RTdWl0 ZS5wcm90b3R5cGUudGVzdFByb2ZpbGVyVGFiLmZpbmRWaXNpYmxlVmlldyk6CisgICAgICAgICgu VGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0UHJvZmlsZXJUYWIpOgorCiAyMDEwLTA0LTEyICBNaWto YWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgWXVyeSBTZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMv VGVzdHMuanMgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL1Rlc3RzLmpzCmluZGV4IDAzYThmNzcu Ljc1OGI4YzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMKKysr IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5qcwpAQCAtNDIxLDQ5ICs0MjEsNDQgQEAg VGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0Q2FjaGVkUmVzb3VyY2VNaW1lVHlwZSA9IGZ1bmN0aW9u KCkKIC8qKgogICogVGVzdHMgdGhhdCBwcm9maWxlciB3b3Jrcy4KICAqLwotLyoKLS8vIEZJWE1F OiBkaXNhYmxlIGZvciBub3cuIE5lZWQgdG8gY2hhbmdlIGpzX3Rlc3QuaHRtbCBwYWdlIGluIENo cm9taXVtIHJlcG8gZmlyc3QuCi0KIFRlc3RTdWl0ZS5wcm90b3R5cGUudGVzdFByb2ZpbGVyVGFi ID0gZnVuY3Rpb24oKQogewogICAgIHRoaXMuc2hvd1BhbmVsKCJwcm9maWxlcyIpOwogCisgICAg dmFyIHBhbmVsID0gV2ViSW5zcGVjdG9yLnBhbmVscy5wcm9maWxlczsKICAgICB2YXIgdGVzdCA9 IHRoaXM7Ci0gICAgdGhpcy5hZGRTbmlmZmVyKFdlYkluc3BlY3Rvci5wYW5lbHMucHJvZmlsZXMs ICJhZGRQcm9maWxlSGVhZGVyIiwKLSAgICAgICAgZnVuY3Rpb24odHlwZU9yUHJvZmlsZSwgcHJv ZmlsZSkgewotICAgICAgICAgICAgaWYgKCFwcm9maWxlKQotICAgICAgICAgICAgICAgIHByb2Zp bGUgPSB0eXBlT3JQcm9maWxlOwotICAgICAgICAgICAgdmFyIHBhbmVsID0gV2ViSW5zcGVjdG9y LnBhbmVscy5wcm9maWxlczsKLSAgICAgICAgICAgIHBhbmVsLnNob3dQcm9maWxlKHByb2ZpbGUp OwotICAgICAgICAgICAgdmFyIG5vZGUgPSBwYW5lbC52aXNpYmxlVmlldy5wcm9maWxlRGF0YUdy aWRUcmVlLmNoaWxkcmVuWzBdOwotICAgICAgICAgICAgLy8gSXRlcmF0ZSBvdmVyIGRpc3BsYXll ZCBmdW5jdGlvbnMgYW5kIHNlYXJjaCBmb3IgYSBmdW5jdGlvbgotICAgICAgICAgICAgLy8gdGhh dCBpcyBjYWxsZWQgImZpYiIgb3IgImV0ZXJuYWxfZmliIi4gSWYgZm91bmQsIGl0IHdpbGwgbWVh bgotICAgICAgICAgICAgLy8gdGhhdCB3ZSBhY3R1YWxseSBoYXZlIHByb2ZpbGVkIHBhZ2UncyBj b2RlLgotICAgICAgICAgICAgd2hpbGUgKG5vZGUpIHsKLSAgICAgICAgICAgICAgICBpZiAobm9k ZS5mdW5jdGlvbk5hbWUuaW5kZXhPZigiZmliIikgIT09IC0xKQotICAgICAgICAgICAgICAgICAg ICB0ZXN0LnJlbGVhc2VDb250cm9sKCk7Ci0gICAgICAgICAgICAgICAgbm9kZSA9IG5vZGUudHJh dmVyc2VOZXh0Tm9kZSh0cnVlLCBudWxsLCB0cnVlKTsKLSAgICAgICAgICAgIH0KIAotICAgICAg ICAgICAgdGVzdC5mYWlsKCk7Ci0gICAgICAgIH0pOwotICAgIHZhciB0aWNrc0NvdW50ID0gMDsK LSAgICB2YXIgdGlja1JlY29yZCA9ICJcbnQsIjsKLSAgICB0aGlzLmFkZFNuaWZmZXIoUmVtb3Rl UHJvZmlsZXJBZ2VudCwgImRpZEdldExvZ0xpbmVzIiwKLSAgICAgICAgZnVuY3Rpb24ocG9zSWdu b3JlZCwgbG9nKSB7Ci0gICAgICAgICAgICB2YXIgcG9zID0gMDsKLSAgICAgICAgICAgIHdoaWxl ICgocG9zID0gbG9nLmluZGV4T2YodGlja1JlY29yZCwgcG9zKSkgIT09IC0xKSB7Ci0gICAgICAg ICAgICAgICAgcG9zICs9IHRpY2tSZWNvcmQubGVuZ3RoOwotICAgICAgICAgICAgICAgIHRpY2tz Q291bnQrKzsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGlmICh0aWNrc0NvdW50ID4gMTAw KQotICAgICAgICAgICAgICAgIEluc3BlY3RvckJhY2tlbmQuc3RvcFByb2ZpbGluZygpOwotICAg ICAgICB9LCB0cnVlKTsKKyAgICBmdW5jdGlvbiBmaW5kRGlzcGxheWVkTm9kZSgpIHsKKyAgICAg ICAgdmFyIG5vZGUgPSBwYW5lbC52aXNpYmxlVmlldy5wcm9maWxlRGF0YUdyaWRUcmVlLmNoaWxk cmVuWzBdOworICAgICAgICBpZiAoIW5vZGUpIHsKKyAgICAgICAgICAgIC8vIFByb2ZpbGUgaGFk bid0IGJlZW4gcXVlcmllZCB5ZXQsIHJlLXNjaGVkdWxlLgorICAgICAgICAgICAgd2luZG93LnNl dFRpbWVvdXQoZmluZERpc3BsYXllZE5vZGUsIDEwMCk7CisgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIH0KKworICAgICAgICAvLyBJdGVyYXRlIG92ZXIgZGlzcGxheWVkIGZ1bmN0aW9ucyBh bmQgc2VhcmNoIGZvciBhIGZ1bmN0aW9uCisgICAgICAgIC8vIHRoYXQgaXMgY2FsbGVkICJmaWIi IG9yICJldGVybmFsX2ZpYiIuIElmIGZvdW5kLCB0aGlzIHdpbGwgbWVhbgorICAgICAgICAvLyB0 aGF0IHdlIGFjdHVhbGx5IGhhdmUgcHJvZmlsZWQgcGFnZSdzIGNvZGUuCisgICAgICAgIHdoaWxl IChub2RlKSB7CisgICAgICAgICAgICBpZiAobm9kZS5mdW5jdGlvbk5hbWUuaW5kZXhPZigiZmli IikgIT09IC0xKQorICAgICAgICAgICAgICAgIHRlc3QucmVsZWFzZUNvbnRyb2woKTsKKyAgICAg ICAgICAgIG5vZGUgPSBub2RlLnRyYXZlcnNlTmV4dE5vZGUodHJ1ZSwgbnVsbCwgdHJ1ZSk7Cisg ICAgICAgIH0KKworICAgICAgICB0ZXN0LmZhaWwoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBm aW5kVmlzaWJsZVZpZXcoKSB7CisgICAgICAgIGlmICghcGFuZWwudmlzaWJsZVZpZXcpIHsKKyAg ICAgICAgICAgIHNldFRpbWVvdXQoZmluZFZpc2libGVWaWV3LCAwKTsKKyAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgfQorICAgICAgICBzZXRUaW1lb3V0KGZpbmREaXNwbGF5ZWROb2RlLCAw KTsgICAgICAgICAgICAKKyAgICB9CiAKLSAgICBJbnNwZWN0b3JCYWNrZW5kLnN0YXJ0UHJvZmls aW5nKCk7CisgICAgZmluZFZpc2libGVWaWV3KCk7CiAgICAgdGhpcy50YWtlQ29udHJvbCgpOwog fTsKLSovCiAKIAogLyoqCg==