37500 2010-04-13 07:01:44 -0700 [Gtk] Fix leaking the FontPlatformData instance used to create the the small caps font data. 2010-05-03 09:57:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 0 superstippi webkit-unassigned commit-queue zecke oldest_to_newest 211930 0 superstippi 2010-04-13 07:01:44 -0700 WebCore::SimpleFontData::smallCapsFontData() is allocating a FontPlatformData object on the heap and assigns it to a const pointer and never frees it. The FontPlatformData is used for assigning the member of the same type in a SimpleFontData object. Usually, ports implement the data of FontPlatformData to be reference counted, and the instance in SimpleFontData takes over the ownership (same in the Gtk port). The Haiku port contained the same problem initially, that's why I spotted it when cross referencing the Gtk port. 211931 1 53243 superstippi 2010-04-13 07:04:01 -0700 Created attachment 53243 Patch to fix the problem 220103 2 53243 zecke 2010-05-03 07:49:04 -0700 Comment on attachment 53243 Patch to fix the problem > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 57513) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,18 @@ > +2010-04-13 Stephan Aßmus <superstippi@gmx.de> > + > + Reviewed by NOBODY (OOPS!). > + > + [Gtk] Fix leaking the FontPlatformData instance used to create the the > + small caps font data. > + https://bugs.webkit.org/show_bug.cgi?id=37500 > + > + No new tests needed. > + > + * platform/graphics/gtk/SimpleFontDataPango.cpp: > + (WebCore::SimpleFontData::smallCapsFontData): > + - Use a stack allocated FontPlatformData instead of a heap allocated > + one that is never freed. Thanks a lot! 220105 3 zecke 2010-05-03 07:57:28 -0700 git grep "const FontPlatformData\* pdata = new" WebCore/platform/graphics/ WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp: const FontPlatfo WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp: const FontPlatform WebCore/platform/graphics/wx/SimpleFontDataWx.cpp: so, we need to fix these two as well. 220149 4 53243 commit-queue 2010-05-03 09:57:02 -0700 Comment on attachment 53243 Patch to fix the problem Clearing flags on attachment: 53243 Committed r58679: <http://trac.webkit.org/changeset/58679> 220150 5 commit-queue 2010-05-03 09:57:06 -0700 All reviewed patches have been landed. Closing bug. 53243 2010-04-13 07:04:01 -0700 2010-05-03 09:57:01 -0700 Patch to fix the problem SimpleFontDataPango.diff text/plain 1710 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzUxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMTMgIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlA Z214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHdGtdIEZpeCBsZWFraW5nIHRoZSBGb250UGxhdGZvcm1EYXRhIGluc3RhbmNlIHVzZWQgdG8g Y3JlYXRlIHRoZSB0aGUKKyAgICAgICAgc21hbGwgY2FwcyBmb250IGRhdGEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzUwMAorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvU2lt cGxlRm9udERhdGFQYW5nby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6 c21hbGxDYXBzRm9udERhdGEpOgorICAgICAgICAgICAgLSBVc2UgYSBzdGFjayBhbGxvY2F0ZWQg Rm9udFBsYXRmb3JtRGF0YSBpbnN0ZWFkIG9mIGEgaGVhcCBhbGxvY2F0ZWQKKyAgICAgICAgICAg ICAgb25lIHRoYXQgaXMgbmV2ZXIgZnJlZWQuCisKIDIwMTAtMDQtMTMgIFN0ZXBoYW4gQcOfbXVz ICA8c3VwZXJzdGlwcGlAZ214LmRlPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmlu LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvU2ltcGxlRm9udERhdGFQYW5n by5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvU2ltcGxl Rm9udERhdGFQYW5nby5jcHAJKHJldmlzaW9uIDU3Mjc0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9ndGsvU2ltcGxlRm9udERhdGFQYW5nby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg0 LDkgKzg0LDkgQEAgU2ltcGxlRm9udERhdGEqIFNpbXBsZUZvbnREYXRhOjpzbWFsbENhcAogewog ICAgIGlmICghbV9zbWFsbENhcHNGb250RGF0YSkgewogICAgICAgICBGb250RGVzY3JpcHRpb24g ZGVzYyA9IEZvbnREZXNjcmlwdGlvbihmb250RGVzY3JpcHRpb24pOwotICAgICAgICBkZXNjLnNl dFNwZWNpZmllZFNpemUoMC43MGYqZm9udERlc2NyaXB0aW9uLmNvbXB1dGVkU2l6ZSgpKTsKLSAg ICAgICAgY29uc3QgRm9udFBsYXRmb3JtRGF0YSogcGRhdGEgPSBuZXcgRm9udFBsYXRmb3JtRGF0 YShkZXNjLCBkZXNjLmZhbWlseSgpLmZhbWlseSgpKTsKLSAgICAgICAgbV9zbWFsbENhcHNGb250 RGF0YSA9IG5ldyBTaW1wbGVGb250RGF0YSgqcGRhdGEpOworICAgICAgICBkZXNjLnNldFNwZWNp ZmllZFNpemUoMC43MGYgKiBmb250RGVzY3JpcHRpb24uY29tcHV0ZWRTaXplKCkpOworICAgICAg ICBGb250UGxhdGZvcm1EYXRhIHBsYXRmb3JtRGF0YShkZXNjLCBkZXNjLmZhbWlseSgpLmZhbWls eSgpKTsKKyAgICAgICAgbV9zbWFsbENhcHNGb250RGF0YSA9IG5ldyBTaW1wbGVGb250RGF0YShw bGF0Zm9ybURhdGEpOwogICAgIH0KICAgICByZXR1cm4gbV9zbWFsbENhcHNGb250RGF0YTsKIH0K