37499 2010-04-13 06:50:30 -0700 Web Inspector: Cannot effectively delete properties in the Styles sidebar pane 2010-04-13 13:30:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue eric joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 211925 0 apavlov 2010-04-13 06:50:30 -0700 Style properties disappear in the pane when deleted, but effectively they remain in the respective stylesheet and appear in the pane if the Web Inspector is re-opened. 211934 1 53244 apavlov 2010-04-13 07:12:35 -0700 Created attachment 53244 [PATCH] Trivial fix 211938 2 53244 joepeck 2010-04-13 07:18:11 -0700 Comment on attachment 53244 [PATCH] Trivial fix Nice! 211939 3 joepeck 2010-04-13 07:19:56 -0700 Hmm, I am not a Reviewer yet in commiters.py. So if this fails I will take care of things (either having someone else mark these flags, landing myself, or updating commiters.py). 211941 4 53244 commit-queue 2010-04-13 07:20:59 -0700 Comment on attachment 53244 [PATCH] Trivial fix Rejecting patch 53244 from review queue. joepeck@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 211943 5 pfeldman 2010-04-13 07:22:56 -0700 It would be great to have a test for this one. 211948 6 53244 commit-queue 2010-04-13 07:37:03 -0700 Comment on attachment 53244 [PATCH] Trivial fix Clearing flags on attachment: 53244 Committed r57514: <http://trac.webkit.org/changeset/57514> 211949 7 commit-queue 2010-04-13 07:37:08 -0700 All reviewed patches have been landed. Closing bug. 212058 8 eric 2010-04-13 13:27:11 -0700 Joe is still listed as a committer: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py#L122 212060 9 eric 2010-04-13 13:30:31 -0700 Joe, you'll need to update committers.py, moving your entry from committers to reviewers if you're not a reviewer. 53244 2010-04-13 07:12:35 -0700 2010-04-13 07:37:03 -0700 [PATCH] Trivial fix delprops.patch text/plain 1469 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQ3NTEyYS4uZjE3Y2FiYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0xMyAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbm5vdCBlZmZlY3RpdmVseSBk ZWxldGUgcHJvcGVydGllcyBpbiB0aGUgU3R5bGVzIHNpZGViYXIgcGFuZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc0OTkKKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0 b3JET01BZ2VudDo6YXBwbHlTdHlsZVRleHQpOgorCiAyMDEwLTA0LTEzICBTdGVwaGFuIEHDn211 cyAgPHN1cGVyc3RpcHBpQGdteC5kZT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZp bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAppbmRleCA3YTJiNzAzLi4z MWZhZDgwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5j cHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBAIC05MTcs NyArOTE3LDcgQEAgdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6YXBwbHlTdHlsZVRleHQobG9uZyBj YWxsSWQsIGxvbmcgc3R5bGVJZCwgY29uc3QgU3RyaW5nJgogICAgICAgICAvLyBUaGUgaW5wdXQg d2FzIHBhcnNhYmxlIG9yIHRoZSB1c2VyIGRlbGV0ZWQgZXZlcnl0aGluZywgc28gcmVtb3ZlIHRo ZQogICAgICAgICAvLyBvcmlnaW5hbCBwcm9wZXJ0eSBmcm9tIHRoZSByZWFsIHN0eWxlIGRlY2xh cmF0aW9uLiBJZiB0aGlzIHJlcHJlc2VudHMKICAgICAgICAgLy8gYSBzaG9ydGhhbmQgcmVtb3Zl IGFsbCB0aGUgbG9uZ2hhbmQgcHJvcGVydGllcy4KLSAgICAgICAgaWYgKHN0eWxlLT5nZXRQcm9w ZXJ0eVNob3J0aGFuZChwcm9wZXJ0eU5hbWUpLmlzRW1wdHkoKSkgeworICAgICAgICBpZiAoIXN0 eWxlLT5nZXRQcm9wZXJ0eVNob3J0aGFuZChwcm9wZXJ0eU5hbWUpLmlzRW1wdHkoKSkgewogICAg ICAgICAgICAgVmVjdG9yPFN0cmluZz4gbG9uZ2hhbmRQcm9wcyA9IGxvbmdoYW5kUHJvcGVydGll cyhzdHlsZSwgcHJvcGVydHlOYW1lKTsKICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7 ICFlYyAmJiBpIDwgbG9uZ2hhbmRQcm9wcy5zaXplKCk7ICsraSkKICAgICAgICAgICAgICAgICBz dHlsZS0+cmVtb3ZlUHJvcGVydHkobG9uZ2hhbmRQcm9wc1tpXSwgZWMpOwo=