37494 2010-04-13 00:00:34 -0700 REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html fails on Windows 2010-04-15 16:53:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://build.webkit.org/results/Windows%20Debug%20(Tests)/r57340%20(11968)/fast/events/mouse-drag-from-frame-to-other-frame-pretty-diff.html InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 1 aroben ap ap darin oldest_to_newest 211880 0 aroben 2010-04-13 00:00:34 -0700 Since r57340 <http://trac.webkit.org/changeset/57340>, fast/events/mouse-drag-from-frame-to-other-frame.html has been failing on Windows. 211881 1 aroben 2010-04-13 00:01:22 -0700 <rdar://problem/7857060> 211882 2 ap 2010-04-13 00:25:30 -0700 Hmm. What about bug 29963? I don't see how r57340 could affect this. 211888 3 aroben 2010-04-13 00:36:18 -0700 (In reply to comment #2) > Hmm. What about bug 29963? That bug was fixed in r54400, and the expected failure result was removed in r54459. But now we're failing the test again. > I don't see how r57340 could affect this. Given that r48884 likely caused bug 29963, and r54400 fixed it, it seems this test is sensitive to some details of our implementation of event listeners. Since r57340 changes some of those details, I'm not that surprised that it could have caused this. 212212 4 53312 aroben 2010-04-13 21:40:49 -0700 Created attachment 53312 Add Windows failing results for mouse-drag-from-frame-to-other-frame.html 212231 5 53312 eric 2010-04-13 22:38:18 -0700 Comment on attachment 53312 Add Windows failing results for mouse-drag-from-frame-to-other-frame.html I assume you're going to leave this bug open. 212232 6 aroben 2010-04-13 22:38:55 -0700 (In reply to comment #5) > I assume you're going to leave this bug open. Yes, exactly. Thanks for the review! 212262 7 53312 aroben 2010-04-13 23:25:22 -0700 Comment on attachment 53312 Add Windows failing results for mouse-drag-from-frame-to-other-frame.html Committed r57563. 213104 8 ap 2010-04-15 16:40:12 -0700 The problem here is that after r57340, ScriptController for one of the frames is created later than it used to be. It's created during replaySavedEvents in DRT, which results in EventSender state being lost: JSObjectRef makeEventSender(JSContextRef context) { down = false; dragMode = true; replayingSavedEvents = false; ... We don't have such code on the Mac, because the state machine for replaySavedEvents is different there, and resetting wasn't needed. See <http://trac.webkit.org/changeset/29724> for the original fix that introduced resetting. 213106 9 53488 ap 2010-04-15 16:43:31 -0700 Created attachment 53488 proposed fix 213108 10 53488 ggaren 2010-04-15 16:49:40 -0700 Comment on attachment 53488 proposed fix r=me 213110 11 ap 2010-04-15 16:53:59 -0700 Committed <http://trac.webkit.org/changeset/57685>. 53312 2010-04-13 21:40:49 -0700 2010-04-13 23:25:22 -0700 Add Windows failing results for mouse-drag-from-frame-to-other-frame.html bug-37494-20100413214044.patch text/plain 1284 aroben ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4OTc3ZDJkLi41MTZlYmRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDQt MTMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBXaW5kb3dz IGZhaWxpbmcgcmVzdWx0cyBmb3IgbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRvLW90aGVyLWZyYW1l Lmh0bWwKKworICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8zNzQ5ND4gdHJhY2tzIGZpeGlu ZyB0aGlzIHRlc3QuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMvbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRv LW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKKzIwMTAtMDQtMTMgIEFkYW0gUm9i ZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBXaW5kb3dzIGZhaWxpbmcgcmVz dWx0cyBmb3IgZm9udC1mYWNlLW9wZW50eXBlLmh0bWwKIAogICAgICAgICA8aHR0cDovL3dlYmtp dC5vcmcvYi8zNzA4OT4gdHJhY2tzIGZpeGluZyB0aGlzIHRlc3QuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMvbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRv LW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0 L2V2ZW50cy9tb3VzZS1kcmFnLWZyb20tZnJhbWUtdG8tb3RoZXItZnJhbWUtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjI5Y2NlZTkKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMvbW91c2UtZHJhZy1m cm9tLWZyYW1lLXRvLW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1Ro aXMgdGVzdHMgdGhhdCBkcmFnZ2luZyBmcm9tIGFuIGVsZW1lbnQgdGhhdCByZXR1cm5zIGZhbHNl IGZyb20gaXRzIG1vdXNlZG93biBoYW5kbGVyIHdpbGwgbm90IGxldCB0aGUgc3Vic2VxdWVudCBt b3VzZW1vdmUgZXZlbnRzIGJlIGNhcHR1cmVkIGJ5IHRoZSBjb250YWluaW5nIGZyYW1lLCBhbmQg YWxsb3dzIHRoZSBtb3VzZSBtb3ZlIHRvIGdldCB0byBvdGhlciBzdWJmcmFtZXMuCisgIAorRHJh ZyBTdGFydGVkCityZWNlaXZlZCBtb3VzZW1vdmUK 53488 2010-04-15 16:43:31 -0700 2010-04-15 16:49:40 -0700 proposed fix ResetEventSender.txt text/plain 5187 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3NjgzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDQtMTUgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NDk0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODU3MDYwPiBSRUdSRVNTSU9OIChyNTczNDApOiBm YXN0L2V2ZW50cy9tb3VzZS1kcmFnLWZyb20tZnJhbWUtdG8tb3RoZXItZnJhbWUuaHRtbAorICAg ICAgICBmYWlscyBvbiBXaW5kb3dzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRXZl bnRTZW5kZXIuY3BwOiAobWFrZUV2ZW50U2VuZGVyKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS93aW4vRXZlbnRTZW5kZXIuaDoKKyAgICAgICAgVGVsbCBFdmVudFNlbmRlciBpZiBpdCdzIGJl aW5nIGNyZWF0ZWQgZm9yIGEgdG9wIGZyYW1lLgorICAgICAgICAKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUuY3BwOgorICAgICAgICAoRnJhbWVMb2FkRGVs ZWdhdGU6OmRpZENsZWFyV2luZG93T2JqZWN0Rm9yRnJhbWVJblN0YW5kYXJkV29ybGQpOiBXZSBv bmx5IHdhbnQgdG8gcmVzZXQKKyAgICAgICAgRXZlbnRTZW5kZXIgbWFjaGluZXJ5IHdoZW4gYSBu ZXcgdGVzdCBpcyBsb2FkZWQsIG5vdCB3aGVuIGFuIGlmcmFtZSAob3IganVzdCBpdHMgZ2xvYmFs CisgICAgICAgIG9iamVjdCkgaXMgY3JlYXRlZC4KKwogMjAxMC0wNC0xNSAgT2phbiBWYWZhaSAg PG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCklu ZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRXZlbnRTZW5kZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9FdmVudFNlbmRlci5jcHAJ KHJldmlzaW9uIDU3NjU0KQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0V2ZW50 U2VuZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjY3LDIwICs2NjcsMjEgQEAgc3RhdGljIEpT Q2xhc3NSZWYgZ2V0Q2xhc3MoSlNDb250ZXh0UmVmIAogICAgIHJldHVybiBldmVudFNlbmRlckNs YXNzOwogfQogCi1KU09iamVjdFJlZiBtYWtlRXZlbnRTZW5kZXIoSlNDb250ZXh0UmVmIGNvbnRl eHQpCitKU09iamVjdFJlZiBtYWtlRXZlbnRTZW5kZXIoSlNDb250ZXh0UmVmIGNvbnRleHQsIGJv b2wgaXNUb3BGcmFtZSkKIHsKLSAgICBkb3duID0gZmFsc2U7Ci0gICAgZHJhZ01vZGUgPSB0cnVl OwotICAgIHJlcGxheWluZ1NhdmVkRXZlbnRzID0gZmFsc2U7Ci0gICAgdGltZU9mZnNldCA9IDA7 Ci0gICAgbGFzdE1vdXNlUG9zaXRpb24ueCA9IDA7Ci0gICAgbGFzdE1vdXNlUG9zaXRpb24ueSA9 IDA7CisgICAgaWYgKGlzVG9wRnJhbWUpIHsKKyAgICAgICAgZG93biA9IGZhbHNlOworICAgICAg ICBkcmFnTW9kZSA9IHRydWU7CisgICAgICAgIHJlcGxheWluZ1NhdmVkRXZlbnRzID0gZmFsc2U7 CisgICAgICAgIHRpbWVPZmZzZXQgPSAwOworICAgICAgICBsYXN0TW91c2VQb3NpdGlvbi54ID0g MDsKKyAgICAgICAgbGFzdE1vdXNlUG9zaXRpb24ueSA9IDA7CiAKLSAgICBlbmRPZlF1ZXVlID0g MDsKLSAgICBzdGFydE9mUXVldWUgPSAwOwotCi0gICAgZGlkRHJhZ0VudGVyID0gZmFsc2U7Ci0g ICAgZHJhZ2dpbmdJbmZvID0gMDsKKyAgICAgICAgZW5kT2ZRdWV1ZSA9IDA7CisgICAgICAgIHN0 YXJ0T2ZRdWV1ZSA9IDA7CiAKKyAgICAgICAgZGlkRHJhZ0VudGVyID0gZmFsc2U7CisgICAgICAg IGRyYWdnaW5nSW5mbyA9IDA7CisgICAgfQogICAgIHJldHVybiBKU09iamVjdE1ha2UoY29udGV4 dCwgZ2V0Q2xhc3MoY29udGV4dCksIDApOwogfQpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvd2luL0V2ZW50U2VuZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0V2ZW50U2VuZGVyLmgJKHJldmlzaW9uIDU3NjU0KQorKysgV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvd2luL0V2ZW50U2VuZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1 LDcgKzM1LDcgQEAgdHlwZWRlZiBsb25nIEhSRVNVTFQ7CiB0eXBlZGVmIGNvbnN0IHN0cnVjdCBP cGFxdWVKU0NvbnRleHQqIEpTQ29udGV4dFJlZjsKIHR5cGVkZWYgc3RydWN0IE9wYXF1ZUpTVmFs dWUqIEpTT2JqZWN0UmVmOwogCi1KU09iamVjdFJlZiBtYWtlRXZlbnRTZW5kZXIoSlNDb250ZXh0 UmVmIGNvbnRleHQpOworSlNPYmplY3RSZWYgbWFrZUV2ZW50U2VuZGVyKEpTQ29udGV4dFJlZiBj b250ZXh0LCBib29sIGlzVG9wRnJhbWUpOwogdm9pZCByZXBsYXlTYXZlZEV2ZW50cyhIUkVTVUxU KiBvbGVEcmFnQW5kRHJvcFJldHVyblZhbHVlID0gMCk7CiAKIGV4dGVybiBEcmFnZ2luZ0luZm8q IGRyYWdnaW5nSW5mbzsKSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9GcmFt ZUxvYWREZWxlZ2F0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvd2luL0ZyYW1lTG9hZERlbGVnYXRlLmNwcAkocmV2aXNpb24gNTc2NTQpCisrKyBXZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS93aW4vRnJhbWVMb2FkRGVsZWdhdGUuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMzYsNiArMzM2LDkgQEAgdm9pZCBGcmFtZUxvYWREZWxlZ2F0ZTo6ZGlkQ2xlYXJX aW5kb3dPYgogICAgIEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0ID0gZnJhbWUtPmdsb2JhbENv bnRleHQoKTsKICAgICBKU09iamVjdFJlZiB3aW5kb3dPYmplY3QgPSBKU0NvbnRleHRHZXRHbG9i YWxPYmplY3QoY29udGV4dCk7CiAKKyAgICBJV2ViRnJhbWUqIHBhcmVudEZyYW1lID0gMDsKKyAg ICBmcmFtZS0+cGFyZW50RnJhbWUoJnBhcmVudEZyYW1lKTsKKwogICAgIEpTVmFsdWVSZWYgZXhj ZXB0aW9uID0gMDsKIAogICAgIDo6Z0xheW91dFRlc3RDb250cm9sbGVyLT5tYWtlV2luZG93T2Jq ZWN0KGNvbnRleHQsIHdpbmRvd09iamVjdCwgJmV4Y2VwdGlvbik7CkBAIC0zNDgsNyArMzUxLDcg QEAgdm9pZCBGcmFtZUxvYWREZWxlZ2F0ZTo6ZGlkQ2xlYXJXaW5kb3dPYgogICAgIEFTU0VSVCgh ZXhjZXB0aW9uKTsKIAogICAgIEpTU3RyaW5nUmVmIGV2ZW50U2VuZGVyU3RyID0gSlNTdHJpbmdD cmVhdGVXaXRoVVRGOENTdHJpbmcoImV2ZW50U2VuZGVyIik7Ci0gICAgSlNWYWx1ZVJlZiBldmVu dFNlbmRlciA9IG1ha2VFdmVudFNlbmRlcihjb250ZXh0KTsKKyAgICBKU1ZhbHVlUmVmIGV2ZW50 U2VuZGVyID0gbWFrZUV2ZW50U2VuZGVyKGNvbnRleHQsICFwYXJlbnRGcmFtZSk7CiAgICAgSlNP YmplY3RTZXRQcm9wZXJ0eShjb250ZXh0LCB3aW5kb3dPYmplY3QsIGV2ZW50U2VuZGVyU3RyLCBl dmVudFNlbmRlciwga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0 cmlidXRlRG9udERlbGV0ZSwgMCk7CiAgICAgSlNTdHJpbmdSZWxlYXNlKGV2ZW50U2VuZGVyU3Ry KTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3NjgzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMTUgIEFsZXhleSBQcm9z a3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM3NDk0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODU3MDYwPiBSRUdSRVNTSU9OIChyNTcz NDApOiBmYXN0L2V2ZW50cy9tb3VzZS1kcmFnLWZyb20tZnJhbWUtdG8tb3RoZXItZnJhbWUuaHRt bAorICAgICAgICBmYWlscyBvbiBXaW5kb3dzCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vZmFz dC9ldmVudHMvbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRvLW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4 dDogUmVtb3ZlZC4KKwogMjAxMC0wNC0xNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS93aW4vZmFzdC9ldmVudHMvbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRvLW90aGVyLWZyYW1lLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9l dmVudHMvbW91c2UtZHJhZy1mcm9tLWZyYW1lLXRvLW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gNTc2NTQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMv bW91c2UtZHJhZy1mcm9tLWZyYW1lLXRvLW90aGVyLWZyYW1lLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtMSw0ICswLDAgQEAKLVRoaXMgdGVzdHMgdGhhdCBkcmFnZ2luZyBmcm9tIGFu IGVsZW1lbnQgdGhhdCByZXR1cm5zIGZhbHNlIGZyb20gaXRzIG1vdXNlZG93biBoYW5kbGVyIHdp bGwgbm90IGxldCB0aGUgc3Vic2VxdWVudCBtb3VzZW1vdmUgZXZlbnRzIGJlIGNhcHR1cmVkIGJ5 IHRoZSBjb250YWluaW5nIGZyYW1lLCBhbmQgYWxsb3dzIHRoZSBtb3VzZSBtb3ZlIHRvIGdldCB0 byBvdGhlciBzdWJmcmFtZXMuCi0gIAotRHJhZyBTdGFydGVkCi1yZWNlaXZlZCBtb3VzZW1vdmUK