37481 2010-04-12 20:15:02 -0700 Minor fix to pass RenderProgress instead of RenderObject 2010-04-13 11:33:35 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned commit-queue eric oldest_to_newest 211820 0 yael 2010-04-12 20:15:02 -0700 Per https://bugs.webkit.org/show_bug.cgi?id=37275#c4, should pass RenderProgress* instead of RenderObject* to AccessibilityProgressIndicator::create(). 211823 1 53215 yael 2010-04-12 20:19:58 -0700 Created attachment 53215 Patch, minor. 211848 2 53215 commit-queue 2010-04-12 21:43:19 -0700 Comment on attachment 53215 Patch, minor. Rejecting patch 53215 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53215', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: mon/config/committers.py:275: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal if committer.full_name == name: Tor Arne Vestbø found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 211967 3 eric 2010-04-13 08:44:56 -0700 Tor strikes again! We need to fix committers.py to like him. Setting cq+ again is not the solution, I have a bug to fix here first. 211979 4 eric 2010-04-13 09:40:52 -0700 The reviewer_text string parsed with ChangeLogEntry._parse_entry() does not seem to be unicode. When I attempt to convert it to unicode I get: Parsing ChangeLog: /Projects/WebKit/WebCore/ChangeLog Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 56, in <module> main() File "/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 51, in main WebKitPatch(__file__).main() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main result = command.check_arguments_and_execute(options, args, self) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 57, in execute print "%s" % tool.checkout().commit_message_for_this_commit().message() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 99, in commit_message_for_this_commit changelog_entry = ChangeLog(changelog_path).latest_entry() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py", line 121, in latest_entry return self.parse_latest_entry_from_file(changelog_file) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py", line 114, in parse_latest_entry_from_file return ChangeLogEntry(''.join(entry_lines[:-1])) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py", line 53, in __init__ self._parse_entry() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py", line 66, in _parse_entry print unicode(self._reviewer_text) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 14: ordinal not in range(128) 212015 5 53215 commit-queue 2010-04-13 11:07:10 -0700 Comment on attachment 53215 Patch, minor. Rejecting patch 53215 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53215', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: mon/config/committers.py:275: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal if committer.full_name == name: Tor Arne Vestbø found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 212020 6 yael 2010-04-13 11:18:44 -0700 Committed in r57527. 212021 7 eric 2010-04-13 11:22:54 -0700 I have a fix, will post. 212026 8 eric 2010-04-13 11:33:35 -0700 Fixed in bug 37511. Sorry for the trouble. 53215 2010-04-12 20:19:58 -0700 2010-04-13 11:07:10 -0700 Patch, minor. 37481.patch text/plain 3526 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzQ5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMTIgIHlhZWwgYWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1pbm9yIGZpeCB0byBwYXNzIFJlbmRlclByb2dyZXNzIGluc3RlYWQgb2YgUmVuZGVyT2JqZWN0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ4MQor CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmdldE9yQ3JlYXRlKToKKyAgICAgICAgKiBhY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlQcm9ncmVzc0luZGljYXRvci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3I6OkFjY2Vzc2liaWxpdHlQcm9ncmVzc0lu ZGljYXRvcik6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0 b3I6OmNyZWF0ZSk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UHJvZ3Jl c3NJbmRpY2F0b3IuaDoKKwogMjAxMC0wNC0xMiAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFdl YkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAJKHJldmlzaW9uIDU3NDk2KQorKysg V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02MCw2ICs2MCw3IEBACiAjaW5jbHVkZSAiSW5wdXRFbGVtZW50LmgiCiAjaW5jbHVkZSAiUGFn ZS5oIgogI2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgorI2luY2x1ZGUgIlJlbmRlclByb2dyZXNz LmgiCiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgogCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIu aD4KQEAgLTIxMyw3ICsyMTQsNyBAQCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBWE9iamVjdENhY2hl OjpnZXRPCiAjaWYgRU5BQkxFKFBST0dSRVNTX1RBRykKICAgICAgICAgLy8gcHJvZ3Jlc3MgYmFy CiAgICAgICAgIGVsc2UgaWYgKHJlbmRlcmVyLT5pc1Byb2dyZXNzKCkpCi0gICAgICAgICAgICBu ZXdPYmogPSBBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3I6OmNyZWF0ZShyZW5kZXJlcik7 CisgICAgICAgICAgICBuZXdPYmogPSBBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3I6OmNy ZWF0ZSh0b1JlbmRlclByb2dyZXNzKHJlbmRlcmVyKSk7CiAjZW5kaWYKIAogICAgICAgICAvLyBp bnB1dCB0eXBlPXJhbmdlCkluZGV4OiBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eVByb2dyZXNzSW5kaWNhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yLmNwcAkocmV2aXNpb24gNTc0OTYpCisr KyBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzQsMTIgKzM0LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKLUFjY2Vzc2liaWxpdHlQcm9ncmVz c0luZGljYXRvcjo6QWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yKFJlbmRlck9iamVjdCog cmVuZGVyZXIpCitBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3I6OkFjY2Vzc2liaWxpdHlQ cm9ncmVzc0luZGljYXRvcihSZW5kZXJQcm9ncmVzcyogcmVuZGVyZXIpCiAgICAgOiBBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0KHJlbmRlcmVyKQogewogfQogCi1QYXNzUmVmUHRyPEFjY2Vzc2li aWxpdHlQcm9ncmVzc0luZGljYXRvcj4gQWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yOjpj cmVhdGUoUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKK1Bhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVBy b2dyZXNzSW5kaWNhdG9yPiBBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3I6OmNyZWF0ZShS ZW5kZXJQcm9ncmVzcyogcmVuZGVyZXIpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBBY2Nl c3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3IocmVuZGVyZXIpKTsKIH0KSW5kZXg6IFdlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3IuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9y LmgJKHJldmlzaW9uIDU3NDk2KQorKysgV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlQcm9ncmVzc0luZGljYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCwxMCArMjgsMTEgQEAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgSFRNTFByb2dyZXNzRWxlbWVudDsKK2NsYXNz IFJlbmRlclByb2dyZXNzOwogCiBjbGFzcyBBY2Nlc3NpYmlsaXR5UHJvZ3Jlc3NJbmRpY2F0b3Ig OiBwdWJsaWMgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdCB7CiBwdWJsaWM6Ci0gICAgc3RhdGlj IFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yPiBjcmVhdGUoUmVuZGVy T2JqZWN0Kik7CisgICAgc3RhdGljIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVByb2dyZXNzSW5k aWNhdG9yPiBjcmVhdGUoUmVuZGVyUHJvZ3Jlc3MqKTsKIAogcHJpdmF0ZToKICAgICB2aXJ0dWFs IEFjY2Vzc2liaWxpdHlSb2xlIHJvbGVWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIFByb2dyZXNzSW5k aWNhdG9yUm9sZTsgfQpAQCAtNDIsNyArNDMsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgZmxv YXQgbWF4VmFsdWVGb3JSYW5nZSgpIGNvbnN0OwogICAgIHZpcnR1YWwgZmxvYXQgbWluVmFsdWVG b3JSYW5nZSgpIGNvbnN0OwogCi0gICAgQWNjZXNzaWJpbGl0eVByb2dyZXNzSW5kaWNhdG9yKFJl bmRlck9iamVjdCopOworICAgIEFjY2Vzc2liaWxpdHlQcm9ncmVzc0luZGljYXRvcihSZW5kZXJQ cm9ncmVzcyopOwogCiAgICAgSFRNTFByb2dyZXNzRWxlbWVudCogZWxlbWVudCgpIGNvbnN0Owog ICAgIHZpcnR1YWwgYm9vbCBhY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkgY29uc3Q7Cg==