37480 2010-04-12 19:54:57 -0700 Add query string tests from Google URL 2010-04-13 00:40:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth commit-queue joth oldest_to_newest 211817 0 dbates 2010-04-12 19:54:57 -0700 We should implement at least all of the non-encoding specific query string tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>. 211819 1 53214 dbates 2010-04-12 19:59:53 -0700 Created attachment 53214 Layout Test 211825 2 53214 abarth 2010-04-12 20:23:15 -0700 Comment on attachment 53214 Layout Test +<script src="resources/utilities.js"></script> I don't think we can edit these files because they are generated from the make-test-wrappers script. + ["as#df", "as%23df"], I don't think this result is correct, but I agree that we should just literally land what's in the unit tests. We can do a separate pass to understand the different behaviors here. Review- because we can't change the generated files. I think it's ok to copy/paste that small function between tests. 211826 3 dbates 2010-04-12 20:28:59 -0700 (In reply to comment #2) > (From update of attachment 53214 [details]) > +<script src="resources/utilities.js"></script> > > I don't think we can edit these files because they are generated from the > make-test-wrappers script. I added the external JavaScript file to the TEMPLATE.html file. So, when you run make-script-test-wrappers, it will generate ipv4.html, trivial.html, and query.html with this external JavaScript. > > + ["as#df", "as%23df"], > > I don't think this result is correct, but I agree that we should just literally > land what's in the unit tests. We can do a separate pass to understand the > different behaviors here. Yes, I was skeptical about this as well being valid. I can remove it. 211827 4 53214 abarth 2010-04-12 20:35:43 -0700 Comment on attachment 53214 Layout Test I stand corrected. You are awesome. Let's leave the test in. I'd like to do a pass through the whole test suite once we've got it checked in. 211850 5 53214 commit-queue 2010-04-12 21:53:06 -0700 Comment on attachment 53214 Layout Test Clearing flags on attachment: 53214 Committed r57501: <http://trac.webkit.org/changeset/57501> 211851 6 commit-queue 2010-04-12 21:53:12 -0700 All reviewed patches have been landed. Closing bug. 211874 7 joth 2010-04-12 23:37:48 -0700 Tip for the follow up pass: you can use http://rishida.net/tools/conversion/ to do the character set conversion utf 8 -> utf 16, e.g. q=\xe4\xbd\xa0\xe5\xa5\xbd translates to q=\u4F60\u597D in JS escaping. (i.e. enter "e4 bd a0 e5 a5 bd" into the UTF-8 code units box) 211889 8 abarth 2010-04-13 00:40:45 -0700 Sweet! 53214 2010-04-12 19:59:53 -0700 2010-04-12 21:53:06 -0700 Layout Test bug-37480-20100412195952.patch text/plain 5954 dbates SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU3NDk3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDQtMTIgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ4MAorCisg ICAgICAgIEltcGxlbWVudHMgYWxsIG9mIHRoZSBub24tZW5jb2Rpbmcgc3BlY2lmaWMgcXVlcnkg c3RyaW5nIHRlc3RzIGZyb20KKyAgICAgICAgPGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9nb29n bGUtdXJsL3NvdXJjZS9icm93c2UvdHJ1bmsvc3JjL3VybF9jYW5vbl91bml0dGVzdC5jYyMxMDE2 Pi4KKworICAgICAgICBBbHNvLCBtb3ZlZCBKYXZhU2NyaXB0IGZ1bmN0aW9uIGNhbm9uaWNhbGl6 ZSB0byBleHRlcm5hbCBKYXZhU2NyaXB0CisgICAgICAgIHNjcmlwdCAvcmVzb3VyY2VzL3V0aWxp dGllcy5qcyBzaW5jZSB0aGlzIGZ1bmN0aW9uIGlzIGJlaW5nIGNhbGxlZAorICAgICAgICBieSB0 ZXN0cyBpcHY0Lmh0bWwsIHF1ZXJ5Lmh0bWwsIGFuZCB0cml2aWFsLmh0bWwuCisKKyAgICAgICAg KiBmYXN0L3VybC9pcHY0Lmh0bWw6CisgICAgICAgICogZmFzdC91cmwvcXVlcnktZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3VybC9xdWVyeS5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L3VybC9yZXNvdXJjZXM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdXJsL3Jlc291 cmNlcy91dGlsaXRpZXMuanM6IEFkZGVkLgorICAgICAgICAoY2Fub25pY2FsaXplKToKKyAgICAg ICAgKiBmYXN0L3VybC9zY3JpcHQtdGVzdHMvVEVNUExBVEUuaHRtbDogSW5jbHVkZSBleHRlcm5h bCBKYXZhU2NyaXB0IHNjcmlwdCByZXNvdXJjZXMvdXRpbGl0aWVzLmpzLgorICAgICAgICAqIGZh c3QvdXJsL3NjcmlwdC10ZXN0cy9xdWVyeS5qczogQWRkZWQuCisgICAgICAgICogZmFzdC91cmwv dHJpdmlhbC5odG1sOgorCiAyMDEwLTA0LTEyICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC91cmwvaXB2NC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvdXJsL2lwdjQuaHRtbAkocmV2aXNpb24gNTc0OTQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L3Vy bC9pcHY0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMsNiArMyw3IEBACiA8aGVhZD4KIDxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4KIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy91dGlsaXRpZXMuanMiPjwvc2NyaXB0PgogPC9oZWFk PgogPGJvZHk+CiA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvdXJsL3F1ZXJ5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L3VybC9xdWVyeS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L3VybC9xdWVyeS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTggQEAKK1Rl c3QgVVJMcyB0aGF0IGhhdmUgYSBxdWVyeSBzdHJpbmcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGNhbm9uaWNhbGl6ZSgnaHR0cDovL3d3dy5leGFtcGxlLmNvbS8/Zm9v PWJhcicpIGlzICdodHRwOi8vd3d3LmV4YW1wbGUuY29tLz9mb289YmFyJworUEFTUyBjYW5vbmlj YWxpemUoJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vP2FzP2RmJykgaXMgJ2h0dHA6Ly93d3cuZXhh bXBsZS5jb20vP2FzP2RmJworRkFJTCBjYW5vbmljYWxpemUoJ2h0dHA6Ly93d3cuZXhhbXBsZS5j b20vP2FzI2RmJykgc2hvdWxkIGJlIGh0dHA6Ly93d3cuZXhhbXBsZS5jb20vP2FzJTIzZGYuIFdh cyBodHRwOi8vd3d3LmV4YW1wbGUuY29tLz9hcyNkZi4KK0ZBSUwgY2Fub25pY2FsaXplKCdodHRw Oi8vd3d3LmV4YW1wbGUuY29tLz8CaGVsbG9/IGJ5ZScpIHNob3VsZCBiZSBodHRwOi8vd3d3LmV4 YW1wbGUuY29tLz8lMDJoZWxsbyU3RiUyMGJ5ZS4gV2FzIGh0dHA6Ly93d3cuZXhhbXBsZS5jb20v P2hlbGxvJTdGJTIwYnllLgorUEFTUyBjYW5vbmljYWxpemUoJ2h0dHA6Ly93d3cuZXhhbXBsZS5j b20vPyU0MCU0MTEyMycpIGlzICdodHRwOi8vd3d3LmV4YW1wbGUuY29tLz8lNDAlNDExMjMnCitQ QVNTIGNhbm9uaWNhbGl6ZSgnaHR0cDovL3d3dy5leGFtcGxlLmNvbS8/cT3DpMK9wqDDpcKlwr0n KSBpcyAnaHR0cDovL3d3dy5leGFtcGxlLmNvbS8/cT0lRTQlQkQlQTAlRTUlQTUlQkQnCitGQUlM IGNhbm9uaWNhbGl6ZSgnaHR0cDovL3d3dy5leGFtcGxlLmNvbS8/cT3DrcOtJykgc2hvdWxkIGJl IGh0dHA6Ly93d3cuZXhhbXBsZS5jb20vP3E9JUVGJUJGJUJEJUVGJUJGJUJELiBXYXMgaHR0cDov L3d3dy5leGFtcGxlLmNvbS8/cT0lRUQlRUQuCitQQVNTIGNhbm9uaWNhbGl6ZSgnaHR0cDovL3d3 dy5leGFtcGxlLmNvbS8/cT08YXNkZj4nKSBpcyAnaHR0cDovL3d3dy5leGFtcGxlLmNvbS8/cT0l M0Nhc2RmJTNFJworUEFTUyBjYW5vbmljYWxpemUoJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vP3E9 ImFzZGYiJykgaXMgJ2h0dHA6Ly93d3cuZXhhbXBsZS5jb20vP3E9JTIyYXNkZiUyMicKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L3VybC9xdWVyeS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvdXJsL3F1ZXJ5Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3VybC9x dWVyeS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgSFRNTCBQ VUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVs PSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgor PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8 c2NyaXB0IHNyYz0icmVzb3VyY2VzL3V0aWxpdGllcy5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+ Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL3F1ZXJ5LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQg c3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdXJsL3RyaXZpYWwuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3VybC90cml2aWFsLmh0bWwJKHJldmlzaW9uIDU3NDk0 KQorKysgTGF5b3V0VGVzdHMvZmFzdC91cmwvdHJpdmlhbC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0zLDYgKzMsNyBAQAogPGhlYWQ+CiA8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pz L3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+CiA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvdXRp bGl0aWVzLmpzIj48L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgogPHAgaWQ9ImRlc2NyaXB0aW9u Ij48L3A+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3VybC9yZXNvdXJjZXMvdXRpbGl0aWVzLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdXJsL3Jlc291cmNlcy91dGlsaXRpZXMu anMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3VybC9yZXNvdXJjZXMvdXRpbGl0 aWVzLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK2Z1bmN0aW9uIGNhbm9uaWNhbGl6 ZSh1cmwpCit7CisgIHZhciBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOworICBhLmhy ZWYgPSB1cmw7CisgIHJldHVybiBhLmhyZWY7Cit9CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3Vy bC9zY3JpcHQtdGVzdHMvVEVNUExBVEUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L3VybC9zY3JpcHQtdGVzdHMvVEVNUExBVEUuaHRtbAkocmV2aXNpb24gNTc0OTQpCisrKyBM YXlvdXRUZXN0cy9mYXN0L3VybC9zY3JpcHQtdGVzdHMvVEVNUExBVEUuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMyw2ICszLDcgQEAKIDxoZWFkPgogPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVm PSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgogPHNjcmlwdCBzcmM9Ii4uL2pz L3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3Vy Y2VzL3V0aWxpdGllcy5qcyI+PC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIDxwIGlkPSJkZXNj cmlwdGlvbiI+PC9wPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC91cmwvc2NyaXB0LXRlc3RzL3F1 ZXJ5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdXJsL3NjcmlwdC10ZXN0cy9x dWVyeS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdXJsL3NjcmlwdC10ZXN0 cy9xdWVyeS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMCBAQAorZGVzY3JpcHRpb24oIlRl c3QgVVJMcyB0aGF0IGhhdmUgYSBxdWVyeSBzdHJpbmcuIik7CisKK2Nhc2VzID0gWyAKKyAgWyJm b289YmFyIiwgImZvbz1iYXIiXSwKKyAgWyJhcz9kZiIsICJhcz9kZiJdLAorICBbImFzI2RmIiwg ImFzJTIzZGYiXSwKKyAgWyJceDAyaGVsbG9ceDdmIGJ5ZSIsICIlMDJoZWxsbyU3RiUyMGJ5ZSJd LAorICBbIiU0MCU0MTEyMyIsICIlNDAlNDExMjMiXSwKKyAgWyJxPVx4ZTRceGJkXHhhMFx4ZTVc eGE1XHhiZCIsICJxPSVFNCVCRCVBMCVFNSVBNSVCRCJdLAorICBbInE9XHhlZFx4ZWQiLCAicT0l RUYlQkYlQkQlRUYlQkYlQkQiXSwKKyAgWyJxPTxhc2RmPiIsICJxPSUzQ2FzZGYlM0UiXSwKKyAg WyJxPVwiYXNkZlwiIiwgInE9JTIyYXNkZiUyMiJdLAorXTsKKworZm9yICh2YXIgaSA9IDA7IGkg PCBjYXNlcy5sZW5ndGg7ICsraSkgeworICBzaG91bGRCZSgiY2Fub25pY2FsaXplKCdodHRwOi8v d3d3LmV4YW1wbGUuY29tLz8iICsgY2FzZXNbaV1bMF0gKyAiJykiLAorICAgICAgICAgICAiJ2h0 dHA6Ly93d3cuZXhhbXBsZS5jb20vPyIgKyBjYXNlc1tpXVsxXSArICInIik7Cit9CisKK3ZhciBz dWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=