37478 2010-04-12 17:18:05 -0700 Update PluginViewNone and PluginPackageNone to the last Plugin API 2010-04-20 10:12:36 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 barbieri webkit-unassigned aroben cjerdonek commit-queue dbates dglazkov eric joepeck rakuco webkit.review.bot oldest_to_newest 211783 0 53203 barbieri 2010-04-12 17:18:05 -0700 Created attachment 53203 Update WebCore/plugins/Plugin*None.cpp to new API Plugin API was updated but Plugin*None were not, leading to users of it to not link due unknown symbols. The following patch by my co-worker Leandro Pereira fixes it. We noticed so while changing bugs #35761 and #35762 to use Plugin*None as requested by Zecke. No runtime tests are requested. 211785 1 webkit.review.bot 2010-04-12 17:22:52 -0700 Attachment 53203 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1682241 211793 2 53206 barbieri 2010-04-12 17:52:48 -0700 Created attachment 53206 Update WebCore/plugins/Plugin*None.cpp to new API, isolated to XP_UNIX and NETSCAPE_PLUGIN_API Isolates handleFocusInEvent and handleFocusOutEvent inside defined(XP_UNIX) && ENABLE(NETSCAPE_PLUGIN_API). 211927 3 53241 leandro 2010-04-13 06:55:13 -0700 Created attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API Updated patch adds a reference to this bug report on the ChangeLog entry. 212036 4 53241 hyatt 2010-04-13 11:55:48 -0700 Comment on attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API r=me 212045 5 53241 commit-queue 2010-04-13 12:32:06 -0700 Comment on attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API Rejecting patch 53241 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53241', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=53241&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=37478&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 53241 from bug 37478. WARNING: Creating invalid ChangeLogEntry: ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 212054 6 eric 2010-04-13 13:21:02 -0700 I'm not sure what went wrong for the commit-queue, I'll investigate. 212059 7 53241 eric 2010-04-13 13:28:55 -0700 Comment on attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API Trying again? 212063 8 53241 commit-queue 2010-04-13 13:42:21 -0700 Comment on attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API Rejecting patch 53241 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53241', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=53241&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=37478&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 53241 from bug 37478. WARNING: Creating invalid ChangeLogEntry: ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 212064 9 eric 2010-04-13 13:44:54 -0700 I'll figure out what's going wrong and fix it this afternoon. Sorry again! 212075 10 eric 2010-04-13 14:07:09 -0700 The patch is failing to apply correctly: diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 2a5dc84..1d287cb 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,4 +1,15 @@ 2010-04-13 Mikhail Naganov <mnaganov@chromium.org> +2010-04-13 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by David Hyatt. + + Update WebCore/plugins/Plugin*None.cpp to conform to the + respective Plugin*.cpp API. + http://webkit.org/b/37478 + + * plugins/PluginPackageNone.cpp: Changed. + * plugins/PluginViewNone.cpp: Changed. + Reviewed by Pavel Feldman. This may be a svn-apply bug, or this may be a problem with the patch. 212120 11 cjerdonek 2010-04-13 15:48:46 -0700 (In reply to comment #10) > The patch is failing to apply correctly: > > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 2a5dc84..1d287cb 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,4 +1,15 @@ > 2010-04-13 Mikhail Naganov <mnaganov@chromium.org> > +2010-04-13 Leandro Pereira <leandro@profusion.mobi> > + It could have to do with the fact that the patch attachment's ChangeLog has no leading or ending context (the -1,0 means that the "before" chunk has 0 lines): diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 1de8c1e..e9a8738 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,0 +1,11 @@ +2010-04-12 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by NOBODY (OOPS!). (from https://bugs.webkit.org/attachment.cgi?id=53241 ) 212335 12 53330 leandro 2010-04-14 07:33:33 -0700 Created attachment 53330 Update PluginViewNone and PluginPackageNone to the last Plugin API This patch has been already r+'d by Hyatt, but was not created with the WebKit tools, so it didn't apply correctly. Here's an updated version that applies cleanly with svn-apply. 212363 13 53330 eric 2010-04-14 09:07:34 -0700 Comment on attachment 53330 Update PluginViewNone and PluginPackageNone to the last Plugin API OK. 212390 14 53330 commit-queue 2010-04-14 09:41:02 -0700 Comment on attachment 53330 Update PluginViewNone and PluginPackageNone to the last Plugin API Rejecting patch 53330 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: ORT_DIR /Developer/Library/Xcode setenv XCODE_VERSION_ACTUAL 0313 setenv XCODE_VERSION_MAJOR 0300 setenv XCODE_VERSION_MINOR 0310 setenv YACC /Developer/usr/bin/yacc /bin/sh -c /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh ** BUILD FAILED ** The following build commands failed: WebCore: Ld /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal i386 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/1602469 212393 15 eric 2010-04-14 09:45:13 -0700 Undefined symbols: "__ZN7WebCore10PluginView19setJavaScriptPausedEb", referenced from: __ZN7WebCore17ScriptDebugServer19setJavaScriptPausedEPNS_9FrameViewEb in ScriptDebugServer.o "__ZN7WebCore10PluginView27privateBrowsingStateChangedEb", referenced from: __ZN7WebCore4Page27privateBrowsingStateChangedEv in Page.o "__ZN7WebCore10PluginView9keepAliveEP4_NPP", referenced from: __NPN_Evaluate in NP_jsobject.o ld: symbol(s) not found collect2: ld returned 1 exit status 212469 16 joepeck 2010-04-14 11:39:15 -0700 You asked on IRC, so I took a brief look. For the first one issue It looks like PluginView's setJavaScriptPaused, which you change in this patch is actually used elsewhere: http://trac.webkit.org/browser/trunk/WebCore/bindings/js/ScriptDebugServer.cpp#L395 > -void PluginView::setJavaScriptPaused(bool) > +void PluginView::handleFocusOutEvent() Also, you can reverse the symbol using the c++filt command. Even though its normally pretty obvious sometimes this helps: > shell> c++filt __ZN7WebCore10PluginView19setJavaScriptPausedEb > WebCore::PluginView::setJavaScriptPaused(bool) > shell> c++filt __ZN7WebCore17ScriptDebugServer19setJavaScriptPausedEPNS_9FrameViewEb > WebCore::ScriptDebugServer::setJavaScriptPaused(WebCore::FrameView*, bool) Hopefully that gives you some leads. 213010 17 53467 leandro 2010-04-15 13:43:20 -0700 Created attachment 53467 Update PluginViewNone and PluginPackageNone to the last Plugin API This updated patch should build correctly under Mac. 213845 18 53241 eric 2010-04-18 16:26:19 -0700 Comment on attachment 53241 Update PluginViewNone and PluginPackageNone to the last Plugin API Cleared David Hyatt's review+ from obsolete attachment 53241 so that this bug does not appear in http://webkit.org/pending-commit. 213846 19 53330 eric 2010-04-18 16:26:31 -0700 Comment on attachment 53330 Update PluginViewNone and PluginPackageNone to the last Plugin API Cleared Eric Seidel's review+ from obsolete attachment 53330 so that this bug does not appear in http://webkit.org/pending-commit. 214496 20 53467 commit-queue 2010-04-19 23:30:10 -0700 Comment on attachment 53467 Update PluginViewNone and PluginPackageNone to the last Plugin API Clearing flags on attachment: 53467 Committed r57873: <http://trac.webkit.org/changeset/57873> 214497 21 commit-queue 2010-04-19 23:30:18 -0700 All reviewed patches have been landed. Closing bug. 214654 22 barbieri 2010-04-20 07:39:03 -0700 Hi all, The applied patch still does not fix all the issues, if one links PluginView.cpp with PluginViewNone.cpp, it will not work since the following methods are defined in both: * void PluginPackage::determineQuirks(const String& mimeType); * void PluginView::keepAlive(NPP instance); * void PluginView::setJavaScriptPaused(bool paused); * void PluginView::privateBrowsingStateChanged(bool privateBrowsingEnabled); If we remove these from Plugin*None.cpp as we suggested before, it will not work on Mac/XCode as it will not link PluginView.cpp, just PluginViewNone.cpp and thus the error. I see two options: 1. Link Mac with PluginView.cpp, but needs someone from Mac to review; 2. ifdef these functions in PluginViewNone.cpp to just provide them if platform is MAC, or not XP_UNIX... I guess the first is more correct, but I'm not aware of the side effects. 214657 23 aroben 2010-04-20 07:48:49 -0700 (In reply to comment #22) > The applied patch still does not fix all the issues, if one links > PluginView.cpp with PluginViewNone.cpp, it will not work since the following > methods are defined in both: What port is trying to link both PluginView.cpp and PluginViewNone.cpp? That doesn't seem right. I think all ports should either: 1) Link PluginViewNone.cpp, or 2) Link PluginView.cpp plus PluginViewYourPort.cpp 214729 24 barbieri 2010-04-20 10:12:36 -0700 (In reply to comment #23) > (In reply to comment #22) > > The applied patch still does not fix all the issues, if one links > > PluginView.cpp with PluginViewNone.cpp, it will not work since the following > > methods are defined in both: > > What port is trying to link both PluginView.cpp and PluginViewNone.cpp? That > doesn't seem right. I think all ports should either: > > 1) Link PluginViewNone.cpp, or > 2) Link PluginView.cpp plus PluginViewYourPort.cpp Well, after your help at IRC, I finally managed to fix it by using just PluginViewNone.cpp, not requiring PluginView.cpp. However I had to manually disable some code paths that would call Plugin* code, like the PluginDatabase and so on. Given this, I'm closing this bug. But it would be really good to have PluginView.cpp to be able to link with PluginViewNone.cpp and the methods would disable automatically. 53203 2010-04-12 17:18:05 -0700 2010-04-12 17:52:48 -0700 Update WebCore/plugins/Plugin*None.cpp to new API WebCore-plugins-PluginNone.patch text/plain 1376 barbieri ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWRlOGMxZS4uZTlhODczOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMCArMSwxMCBAQAorMjAxMC0wNC0xMiAgTGVhbmRybyBQZXJl aXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgV2ViQ29yZS9wbHVnaW5zL1BsdWdpbipOb25l LmNwcCB0byBjb25mb3JtIHRvIHRoZQorICAgICAgICByZXNwZWN0aXZlIFBsdWdpbiouY3BwIEFQ SS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwOiBDaGFuZ2VkLgor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwOiBDaGFuZ2VkLgorCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwIGIvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcAppbmRleCBiOTQzZDg4Li5lMmU3N2RhIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCisrKyBiL1dlYkNvcmUv cGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKQEAgLTI4LDggKzI4LDkgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi12b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyhjb25z dCBTdHJpbmcmKQordWludDE2IFBsdWdpblBhY2thZ2U6Ok5QVmVyc2lvbigpIGNvbnN0CiB7Cisg ICAgcmV0dXJuIDA7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKCkKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAgYi9XZWJDb3JlL3BsdWdp bnMvUGx1Z2luVmlld05vbmUuY3BwCmluZGV4IDE2MzgzY2MuLmFjZDY0NDYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcApAQCAtMTIwLDE3ICsxMjAsMTEgQEAgdm9pZCBQbHVnaW5WaWV3 OjpyZXN0YXJ0KCkKIHsKIH0KIAotI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQotdm9p ZCBQbHVnaW5WaWV3OjprZWVwQWxpdmUoTlBQKQotewotfQotI2VuZGlmCi0KLXZvaWQgUGx1Z2lu Vmlldzo6cHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKGJvb2wpCit2b2lkIFBsdWdpblZpZXc6 OmhhbmRsZUZvY3VzSW5FdmVudCgpCiB7CiB9CiAKLXZvaWQgUGx1Z2luVmlldzo6c2V0SmF2YVNj cmlwdFBhdXNlZChib29sKQordm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVGb2N1c091dEV2ZW50KCkK IHsKIH0KIAo= 53206 2010-04-12 17:52:48 -0700 2010-04-13 07:14:55 -0700 Update WebCore/plugins/Plugin*None.cpp to new API, isolated to XP_UNIX and NETSCAPE_PLUGIN_API WebCore-plugins-PluginNone-2.patch text/plain 1437 barbieri ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWRlOGMxZS4uZTlhODczOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMCArMSwxMCBAQAorMjAxMC0wNC0xMiAgTGVhbmRybyBQZXJl aXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgV2ViQ29yZS9wbHVnaW5zL1BsdWdpbipOb25l LmNwcCB0byBjb25mb3JtIHRvIHRoZQorICAgICAgICByZXNwZWN0aXZlIFBsdWdpbiouY3BwIEFQ SS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwOiBDaGFuZ2VkLgor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwOiBDaGFuZ2VkLgorCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwIGIvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcAppbmRleCBiOTQzZDg4Li5lMmU3N2RhIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCisrKyBiL1dlYkNvcmUv cGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKQEAgLTI4LDggKzI4LDkgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi12b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyhjb25z dCBTdHJpbmcmKQordWludDE2IFBsdWdpblBhY2thZ2U6Ok5QVmVyc2lvbigpIGNvbnN0CiB7Cisg ICAgcmV0dXJuIDA7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKCkKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAgYi9XZWJDb3JlL3BsdWdp bnMvUGx1Z2luVmlld05vbmUuY3BwCmluZGV4IDE2MzgzY2MuLmFjZDY0NDYgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcApAQCAtMTIwLDE3ICsxMjAsMTMgQEAgdm9pZCBQbHVnaW5WaWV3 OjpyZXN0YXJ0KCkKIHsKIH0KIAotI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQotdm9p ZCBQbHVnaW5WaWV3OjprZWVwQWxpdmUoTlBQKQotewotfQotI2VuZGlmCi0KLXZvaWQgUGx1Z2lu Vmlldzo6cHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKGJvb2wpCisjaWYgZGVmaW5lZChYUF9V TklYKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKK3ZvaWQgUGx1Z2luVmlldzo6aGFu ZGxlRm9jdXNJbkV2ZW50KCkKIHsKIH0KIAotdm9pZCBQbHVnaW5WaWV3OjpzZXRKYXZhU2NyaXB0 UGF1c2VkKGJvb2wpCit2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUZvY3VzT3V0RXZlbnQoKQogewog fQorI2VuZGlmCiAK 53241 2010-04-13 06:55:13 -0700 2010-04-18 16:26:19 -0700 Update PluginViewNone and PluginPackageNone to the last Plugin API x.diff text/plain 1472 leandro ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWRlOGMxZS4uZTlhODczOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMCArMSwxMSBAQAorMjAxMC0wNC0xMiAgTGVhbmRybyBQZXJl aXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgV2ViQ29yZS9wbHVnaW5zL1BsdWdpbipOb25l LmNwcCB0byBjb25mb3JtIHRvIHRoZQorICAgICAgICByZXNwZWN0aXZlIFBsdWdpbiouY3BwIEFQ SS4KKyAgICAgICAgaHR0cDovL3dlYmtpdC5vcmcvYi8zNzQ3OAorCisgICAgICAgICogcGx1Z2lu cy9QbHVnaW5QYWNrYWdlTm9uZS5jcHA6IENoYW5nZWQuCisgICAgICAgICogcGx1Z2lucy9QbHVn aW5WaWV3Tm9uZS5jcHA6IENoYW5nZWQuCisKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9Q bHVnaW5QYWNrYWdlTm9uZS5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUu Y3BwCmluZGV4IGI5NDNkODguLmUyZTc3ZGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9Q bHVnaW5QYWNrYWdlTm9uZS5jcHAKKysrIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2VO b25lLmNwcApAQCAtMjgsOCArMjgsOSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQg UGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5lUXVpcmtzKGNvbnN0IFN0cmluZyYpCit1aW50MTYgUGx1 Z2luUGFja2FnZTo6TlBWZXJzaW9uKCkgY29uc3QKIHsKKyAgICByZXR1cm4gMDsKIH0KIAogYm9v bCBQbHVnaW5QYWNrYWdlOjpmZXRjaEluZm8oKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAK aW5kZXggMTYzODNjYy4uYWNkNjQ0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXdOb25lLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwCkBA IC0xMjAsMTcgKzEyMCwxMyBAQCB2b2lkIFBsdWdpblZpZXc6OnJlc3RhcnQoKQogewogfQogCi0j aWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCi12b2lkIFBsdWdpblZpZXc6OmtlZXBBbGl2 ZShOUFApCi17Ci19Ci0jZW5kaWYKLQotdm9pZCBQbHVnaW5WaWV3Ojpwcml2YXRlQnJvd3NpbmdT dGF0ZUNoYW5nZWQoYm9vbCkKKyNpZiBkZWZpbmVkKFhQX1VOSVgpICYmIEVOQUJMRShORVRTQ0FQ RV9QTFVHSU5fQVBJKQordm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVGb2N1c0luRXZlbnQoKQogewog fQogCi12b2lkIFBsdWdpblZpZXc6OnNldEphdmFTY3JpcHRQYXVzZWQoYm9vbCkKK3ZvaWQgUGx1 Z2luVmlldzo6aGFuZGxlRm9jdXNPdXRFdmVudCgpCiB7CiB9CisjZW5kaWYKIAo= 53330 2010-04-14 07:33:33 -0700 2010-04-18 16:26:31 -0700 Update PluginViewNone and PluginPackageNone to the last Plugin API webcore_plugins_-1.diff text/plain 1539 leandro SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CisrKyBXZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA0LTE0ICBMZWFu ZHJvIFBlcmVpcmEgIDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBwbHVnaW5zL1BsdWdpbipOb25l LmNwcCB0byBjb25mb3JtIHRvIHRoZSByZXNwZWN0aXZlCisgICAgICAgIFBsdWdpbiogQVBJLgor ICAgICAgICBodHRwOi8vd2Via2l0Lm9yZy9iLzM3NDc4CisKKyAgICAgICAgKiBwbHVnaW5zL1Bs dWdpblZpZXdOb25lLmNwcDogLgorICAgICAgICAqIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUu Y3BwOiAuCisKIDIwMTAtMDQtMTQgIEFudG9uIE11aGluICA8YW50b25tQGNocm9taXVtLm9yZz4K IAogICAgICAgICBOb3QgcmV2aWV3LCBidWlsZCBmaXguCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMv UGx1Z2luVmlld05vbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5W aWV3Tm9uZS5jcHAKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKQEAgLTEy MCwxOCArMTIwLDE0IEBAIHZvaWQgUGx1Z2luVmlldzo6cmVzdGFydCgpCiB7CiB9CiAKLSNpZiBF TkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKLXZvaWQgUGx1Z2luVmlldzo6a2VlcEFsaXZlKE5Q UCkKLXsKLX0KLSNlbmRpZgotCi12b2lkIFBsdWdpblZpZXc6OnByaXZhdGVCcm93c2luZ1N0YXRl Q2hhbmdlZChib29sKQorI2lmIGRlZmluZWQoWFBfVU5JWCkgJiYgRU5BQkxFKE5FVFNDQVBFX1BM VUdJTl9BUEkpCit2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUZvY3VzSW5FdmVudCgpCiB7CiB9CiAK LXZvaWQgUGx1Z2luVmlldzo6c2V0SmF2YVNjcmlwdFBhdXNlZChib29sKQordm9pZCBQbHVnaW5W aWV3OjpoYW5kbGVGb2N1c091dEV2ZW50KCkKIHsKIH0KKyNlbmRpZgogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKKysrIFdl YkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKQEAgLTI4LDggKzI4LDkgQEAKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJr cyhjb25zdCBTdHJpbmcmKQordWludDE2IFBsdWdpblBhY2thZ2U6Ok5QVmVyc2lvbigpIGNvbnN0 CiB7CisgICAgcmV0dXJuIDA7CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKCkK 53467 2010-04-15 13:43:20 -0700 2010-04-19 23:30:10 -0700 Update PluginViewNone and PluginPackageNone to the last Plugin API pluginnone.patch text/plain 1669 leandro SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzY2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMTUgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJv ZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIG1pc3NpbmcgZHVtbXkgaW1wbGVtZW50YXRpb25zIGluIFBsdWdpblBhY2thZ2VO b25lIGFuZCBQbHVnaW5WaWV3Tm9uZS4KKyAgICAgICAgaHR0cDovL3dlYmtpdC5vcmcvYi8zNzQ3 OAorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpQbHVnaW5QYWNrYWdlOjpOUFZlcnNpb24pOiBBZGQgZHVtbXkgaW1wbGVtZW50YXRp b24uCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVGb2N1c0luRXZlbnQpOiBBZGQgZHVtbXkgaW1wbGVtZW50 YXRpb24uCisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVGb2N1c091dEV2ZW50 KTogQWRkIGR1bW15IGltcGxlbWVudGF0aW9uLgorCiAyMDEwLTA0LTE1ICBaaGVueWFvIE1vICA8 em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6 IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcAkocmV2aXNpb24gNTc1NzgpCisrKyBX ZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 Miw0ICs0MiwxMSBAQCBib29sIFBsdWdpblBhY2thZ2U6OmxvYWQoKQogICAgIHJldHVybiBmYWxz ZTsKIH0KIAorI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQordWludDE2IFBsdWdpblBh Y2thZ2U6Ok5QVmVyc2lvbigpIGNvbnN0Cit7CisgICAgcmV0dXJuIDA7Cit9CisjZW5kaWYKKwog fQpJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwCShyZXZpc2lvbiA1NzU3OCkKKysr IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEz NCw0ICsxMzQsMTQgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRKYXZhU2NyaXB0UGF1c2VkKGJvbwog ewogfQogCisjaWYgZGVmaW5lZChYUF9VTklYKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkKK3ZvaWQgUGx1Z2luVmlldzo6aGFuZGxlRm9jdXNJbkV2ZW50KCkKK3sKK30KKwordm9pZCBQ bHVnaW5WaWV3OjpoYW5kbGVGb2N1c091dEV2ZW50KCkKK3sKK30KKyNlbmRpZgorCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCg==