37464 2010-04-12 13:15:30 -0700 new-run-webkit-tests: run_webkit_tests.py should not call sys.exit() 2010-04-12 16:15:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth cjerdonek eric ojan oldest_to_newest 211708 0 dpranke 2010-04-12 13:15:30 -0700 Current the run_webkit_tests.py script used by new-run-webkit-tests to do all the real work calls sys.exit(). This makes it difficult to call the functions repeatedly for unit testing, and is kind of a goofy layering violation. The exit call should be pushed up into the main new-run-webkit-tests script. 211725 1 53186 dpranke 2010-04-12 14:13:43 -0700 Created attachment 53186 Patch 211739 2 53186 eric 2010-04-12 16:06:38 -0700 Comment on attachment 53186 Patch OK. 211743 3 53186 dpranke 2010-04-12 16:15:17 -0700 Comment on attachment 53186 Patch Clearing flags on attachment: 53186 Committed r57486: <http://trac.webkit.org/changeset/57486> 211745 4 dpranke 2010-04-12 16:15:23 -0700 All reviewed patches have been landed. Closing bug. 53186 2010-04-12 14:13:43 -0700 2010-04-12 16:15:17 -0700 Patch bug-37464-20100412141342.patch text/plain 4120 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjOGRkZjZhLi4xNDA1ZTgxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQt MTIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kaWZ5IHJ1bl93ZWJraXRfdGVzdHMu cHkgdG8gbm90IGNhbGwgc3lzLmV4aXQoKSBhdCB0aGUgZW5kIG9mIHRlc3QKKyAgICAgICAgcnVu OyBkb2luZyBzbyBtYWtlcyBpdCBtb3JlIGRpZmZpY3VsdCB0byBlbWJlZCB0aGUgcm91dGluZSBm b3IsCisgICAgICAgIGFtb25nIG90aGVyIHRoaW5ncywgdW5pdCB0ZXN0cy4gV2UgcHVzaCB0aGUg ZXhpdCBjYWxsaW5nIHVwIGludG8KKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtdGVzdHMuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NDY0CisKKyAg ICAgICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0LXRlc3RzOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMDQtMTIg IEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0 LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC10ZXN0cwppbmRleCBk NGYzOWY3Li4yZWJlMWRhIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL25ldy1ydW4t d2Via2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtdGVz dHMKQEAgLTI4LDkgKzI4LDEwIEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKICIiIldyYXBwZXIgYXJvdW5k IHdlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IiIiCitpbXBvcnQgc3lz CiAKIGltcG9ydCB3ZWJraXRweS5sYXlvdXRfdGVzdHMucnVuX3dlYmtpdF90ZXN0cyBhcyBydW5f d2Via2l0X3Rlc3RzCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CiAgICAgb3B0aW9ucywg YXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFyc2VfYXJncygpCi0gICAgcnVuX3dlYmtpdF90ZXN0 cy5tYWluKG9wdGlvbnMsIGFyZ3MpCisgICAgc3lzLmV4aXQocnVuX3dlYmtpdF90ZXN0cy5tYWlu KG9wdGlvbnMsIGFyZ3MpKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXggNjAxNmU1Yy4u OTY5MmZmMiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC02MTQsNyArNjE0LDcgQEAg Y2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICByZXN1bHRfc3VtbWFyeTogYSBzdW1tYXJ5IG9i amVjdCB0cmFja2luZyB0aGUgdGVzdCByZXN1bHRzLgogCiAgICAgICAgIFJldHVybjoKLSAgICAg ICAgICBXZSByZXR1cm4gbm9uemVybyBpZiB0aGVyZSBhcmUgcmVncmVzc2lvbnMgY29tcGFyZWQg dG8gdGhlIGxhc3QgcnVuLgorICAgICAgICAgIFRoZSBudW1iZXIgb2YgdW5leHBlY3RlZCByZXN1 bHRzICgwID09IHN1Y2Nlc3MpCiAgICAgICAgICIiIgogICAgICAgICBpZiBub3Qgc2VsZi5fdGVz dF9maWxlczoKICAgICAgICAgICAgIHJldHVybiAwCkBAIC0xMzY4LDExICsxMzY4LDE0IEBAIGRl ZiBjcmVhdGVfbG9nZ2luZ193cml0ZXIob3B0aW9ucywgbG9nX29wdGlvbik6CiAKIAogZGVmIG1h aW4ob3B0aW9ucywgYXJncyk6Ci0gICAgIiIiUnVuIHRoZSB0ZXN0cy4gIFdpbGwgY2FsbCBzeXMu ZXhpdCB3aGVuIGNvbXBsZXRlLgorICAgICIiIlJ1biB0aGUgdGVzdHMuCiAKICAgICBBcmdzOgog ICAgICAgb3B0aW9uczogYSBkaWN0aW9uYXJ5IG9mIGNvbW1hbmQgbGluZSBvcHRpb25zCiAgICAg ICBhcmdzOiBhIGxpc3Qgb2Ygc3ViIGRpcmVjdG9yaWVzIG9yIGZpbGVzIHRvIHRlc3QKKyAgICBS ZXR1cm5zOgorICAgICAgdGhlIG51bWJlciBvZiB1bmV4cGVjdGVkIHJlc3VsdHMgdGhhdCBvY2N1 cnJlZCwgb3IgLTEgaWYgdGhlcmUgaXMgYW4KKyAgICAgICAgICBlcnJvci4KICAgICAiIiIKIAog ICAgIGlmIG9wdGlvbnMuc291cmNlczoKQEAgLTE0NzAsNyArMTQ3Myw3IEBAIGRlZiBtYWluKG9w dGlvbnMsIGFyZ3MpOgogICAgICAgICBtZXRlci51cGRhdGUoIiIpCiAgICAgICAgIHByaW50ICgi SWYgdGhlcmUgYXJlIG5vIGZhaWwgbWVzc2FnZXMsIGVycm9ycyBvciBleGNlcHRpb25zLCB0aGVu IHRoZSAiCiAgICAgICAgICAgICAibGludCBzdWNjZWVkZWQuIikKLSAgICAgICAgc3lzLmV4aXQo MCkKKyAgICAgICAgcmV0dXJuIDAKIAogICAgIHdyaXRlID0gY3JlYXRlX2xvZ2dpbmdfd3JpdGVy KG9wdGlvbnMsICJjb25maWciKQogICAgIHdyaXRlKCJVc2luZyBwb3J0ICclcyciICUgcG9ydF9v YmoubmFtZSgpKQpAQCAtMTQ5MCw3ICsxNDkzLDcgQEAgZGVmIG1haW4ob3B0aW9ucywgYXJncyk6 CiAKICAgICBtZXRlci51cGRhdGUoIkNoZWNraW5nIGJ1aWxkIC4uLiIpCiAgICAgaWYgbm90IHBv cnRfb2JqLmNoZWNrX2J1aWxkKHRlc3RfcnVubmVyLm5lZWRzX2h0dHAoKSk6Ci0gICAgICAgIHN5 cy5leGl0KDEpCisgICAgICAgIHJldHVybiAtMQogCiAgICAgbWV0ZXIudXBkYXRlKCJTdGFydGlu ZyBoZWxwZXIgLi4uIikKICAgICBwb3J0X29iai5zdGFydF9oZWxwZXIoKQpAQCAtMTQ5OSw3ICsx NTAyLDcgQEAgZGVmIG1haW4ob3B0aW9ucywgYXJncyk6CiAgICAgaWYgbm90IG9wdGlvbnMubm9j aGVja19zeXNfZGVwczoKICAgICAgICAgbWV0ZXIudXBkYXRlKCJDaGVja2luZyBzeXN0ZW0gZGVw ZW5kZW5jaWVzIC4uLiIpCiAgICAgICAgIGlmIG5vdCBwb3J0X29iai5jaGVja19zeXNfZGVwcyh0 ZXN0X3J1bm5lci5uZWVkc19odHRwKCkpOgotICAgICAgICAgICAgc3lzLmV4aXQoMSkKKyAgICAg ICAgICAgIHJldHVybiAtMQogCiAgICAgbWV0ZXIudXBkYXRlKCJQcmVwYXJpbmcgdGVzdHMgLi4u IikKICAgICB3cml0ZSA9IGNyZWF0ZV9sb2dnaW5nX3dyaXRlcihvcHRpb25zLCAiZXhwZWN0ZWQi KQpAQCAtMTUxMywxMiArMTUxNiwxMiBAQCBkZWYgbWFpbihvcHRpb25zLCBhcmdzKToKICAgICAg ICAgaWYgb3B0aW9ucy5mdXp6eV9waXhlbF90ZXN0czoKICAgICAgICAgICAgIHRlc3RfcnVubmVy LmFkZF90ZXN0X3R5cGUoZnV6enlfaW1hZ2VfZGlmZi5GdXp6eUltYWdlRGlmZikKIAotICAgIGhh c19uZXdfZmFpbHVyZXMgPSB0ZXN0X3J1bm5lci5ydW4ocmVzdWx0X3N1bW1hcnkpCisgICAgbnVt X3VuZXhwZWN0ZWRfcmVzdWx0cyA9IHRlc3RfcnVubmVyLnJ1bihyZXN1bHRfc3VtbWFyeSkKIAog ICAgIHBvcnRfb2JqLnN0b3BfaGVscGVyKCkKIAotICAgIF9sb2cuZGVidWcoIkV4aXQgc3RhdHVz OiAlZCIgJSBoYXNfbmV3X2ZhaWx1cmVzKQotICAgIHN5cy5leGl0KGhhc19uZXdfZmFpbHVyZXMp CisgICAgX2xvZy5kZWJ1ZygiRXhpdCBzdGF0dXM6ICVkIiAlIG51bV91bmV4cGVjdGVkX3Jlc3Vs dHMpCisgICAgcmV0dXJuIG51bV91bmV4cGVjdGVkX3Jlc3VsdHMKIAogCiBkZWYgcGFyc2VfYXJn cyhhcmdzPU5vbmUpOgpAQCAtMTYyMCw0ICsxNjIzLDQgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1O b25lKToKIAogaWYgJ19fbWFpbl9fJyA9PSBfX25hbWVfXzoKICAgICBvcHRpb25zLCBhcmdzID0g cGFyc2VfYXJncygpCi0gICAgbWFpbihvcHRpb25zLCBhcmdzKQorICAgIHN5cy5leGl0KG1haW4o b3B0aW9ucywgYXJncykpCg==