37461 2010-04-12 12:13:54 -0700 Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed 2010-04-20 13:21:39 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 18662 35784 36463 1 tonikitoo tonikitoo hausmann kenneth simon.fraser oldest_to_newest 211698 0 tonikitoo 2010-04-12 12:13:54 -0700 As discussed in [1], renderer's absoluteClippedOverflowRect() method can return an empty IntRect when node() of renderer is offscreen. For this case, make spatial navigation to fallback to getRect of Element instead. [1] http://old.nabble.com/AbsoluteClippedOverflowRect-return-empty-IntRect-td28005341.html 211705 1 53182 tonikitoo 2010-04-12 12:57:08 -0700 Created attachment 53182 (committed in r57496) patch v1 fallback to getRect method Element when absoluteClippedOverflowRect of RenderObject returns a empty rect. 211815 2 53182 tonikitoo 2010-04-12 19:49:48 -0700 Comment on attachment 53182 (committed in r57496) patch v1 (From update of attachment 53182) Clearing flags on attachment: 53182 Committed r57496: <http://trac.webkit.org/changeset/57496> 211816 3 tonikitoo 2010-04-12 19:50:51 -0700 Thank you Simon Fraser!!! 214910 4 hausmann 2010-04-20 13:21:29 -0700 Revision r57496 cherry-picked into qtwebkit-2.0 with commit 7d5c02b80c68d5cebe067bd0968b7dc9b6a12e92 53182 2010-04-12 12:57:08 -0700 2010-04-12 19:49:48 -0700 (committed in r57496) patch v1 0001-Spatial-Navigation-make-renderRectRelativeToRootDoc.patch text/plain 6866 tonikitoo RnJvbSA4NzkwY2ZlNDdmODExYWRjNjM5ZDZmYjQ3ZDNjOWY4YmU3NTJjMTVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxMiBBcHIgMjAxMCAxNTo1Mjo0MCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogbWFrZSByZW5kZXJSZWN0UmVsYXRpdmVUb1Jvb3REb2N1bWVudCBt ZXRob2QgdG8gZmFsbGJhY2sgdG8gZ2V0UmVjdCgpIG9mIEVsZW1lbnQgd2hlbiBuZWVkZWQKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ2MQoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuClBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQu b3JnPgoKV2ViQ29yZToKCmdldFJlY3QoKSBvZiBFbGVtZW50IGNhbiBiZSB1c2VkIGluc3RlYWQg b2YgYWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0IG9mIFJlbmRlck9iamVjdCB3aGVuCnRoZSBu b2RlIGlzIGN1cnJlbnRseSBvZmZzY3JlZW4gaW4gYW4gc2Nyb2xsIG92ZXJmbG93ZWQgY29udGVu dC4KClRlc3Q6IGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbXBsZS1jb250 ZW50LW92ZXJmbG93Lmh0bWwKCiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHA6CihXZWJDb3Jl OjpyZW5kZXJSZWN0UmVsYXRpdmVUb1Jvb3REb2N1bWVudCk6CgpMYXlvdXRUZXN0czoKCiogZmFz dC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2ltcGxlLWNvbnRlbnQtb3ZlcmZsb3ct ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25h di1zaW1wbGUtY29udGVudC1vdmVyZmxvdy5odG1sOiBBZGRlZC4KLS0tCiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTAgKysrCiAuLi4vc25h di1zaW1wbGUtY29udGVudC1vdmVyZmxvdy1leHBlY3RlZC50eHQgICAgICB8ICAgMjQgKysrKysr CiAuLi4vc25hdi1zaW1wbGUtY29udGVudC1vdmVyZmxvdy5odG1sICAgICAgICAgICAgICB8ICAg NzQgKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrCiBXZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmln YXRpb24uY3BwICAgICAgICAgICAgICAgICB8ICAgIDUgKysKIDUgZmlsZXMgY2hhbmdlZCwgMTI4 IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2ltcGxlLWNvbnRlbnQt b3ZlcmZsb3ctZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2ltcGxlLWNvbnRlbnQtb3ZlcmZsb3cu aHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCAyZGQ0MTdhLi5kMWM3OTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MTAtMDQtMTIgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGF0aWFsIE5hdmlnYXRp b246IG1ha2UgcmVuZGVyUmVjdFJlbGF0aXZlVG9Sb290RG9jdW1lbnQgbWV0aG9kIHRvIGZhbGxi YWNrIHRvIGdldFJlY3QoKSBvZiBFbGVtZW50IHdoZW4gbmVlZGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ2MQorCisgICAgICAgICogZmFzdC9l dmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtc2ltcGxlLWNvbnRlbnQtb3ZlcmZsb3ctZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRp b24vc25hdi1zaW1wbGUtY29udGVudC1vdmVyZmxvdy5odG1sOiBBZGRlZC4KKwogMjAxMC0wNC0x MSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9z cGF0aWFsLW5hdmlnYXRpb24vc25hdi1zaW1wbGUtY29udGVudC1vdmVyZmxvdy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1zaW1w bGUtY29udGVudC1vdmVyZmxvdy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uMGI2MGUzNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbXBsZS1jb250ZW50LW92ZXJmbG93LWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDI0IEBACitJdCBoYXMgYSB2aXNpYmxlIGxpbmtfMS4KKwor CisKKworCisKKworCisKKworLi4uIGFuZCBhbiBvdmVyZmxvd2VkIGxpbmsgbGlrZSB0aGlzLgor CisKKworCisKKworCisKK1RoaXMgbGluayBzaG91bGQgTk9UIGdldCBmb2N1c2VkLgorCitQQVNT IGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJzdGFydCIKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3Nu YXYtc2ltcGxlLWNvbnRlbnQtb3ZlcmZsb3cuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbXBsZS1jb250ZW50LW92ZXJmbG93Lmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTNlOWY1OQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbXBs ZS1jb250ZW50LW92ZXJmbG93Lmh0bWwKQEAgLTAsMCArMSw3NCBAQAorPGh0bWw+CisgIDwhLS0K KyAgICBUaGlzIHRlc3QgZW5zdXJlcyB0aGF0IG92ZXJmbG93ZWQgY29udGVudCBjYW4gYmUgZm9j dXNlZCBieSBTcGF0aWFsIE5hdmlnYXRpb24uCisKKyAgICAqIFByZS1jb25kaXRpb25zOgorICAg IDEpIERSVCBzdXBwb3J0IGZvciBTTmF2IGVuYWJsZS9kaXNhYmxlLgorCisgICAgKiBOYXZpZ2F0 aW9uIHN0ZXBzOgorICAgIDEpIExvYWRzIHRoaXMgcGFnZSwgZm9jdXMgZ29lcyB0byAic3RhcnQi IGF1dG9tYXRpY2FsbHkuCisgICAgMykgVHJ5IHRvIHRyYXZlcnNlIHRoZSBsaW5rcyBvbiBwYWdl IGRvd24uCisgICAgICAgYW5kIHRoZW4gYmFjayB1cC4KKworICAgICogRXhwZWN0ZWQgcmVzdWx0 czogQWZ0ZXIgJ3N0YXJ0JyBnZXRzIHRoZSBmb2N1cywgdGFwcGluZyBkb3duIGFycm93IHNob3Vs ZCBzY3JvbGwgaXRzCisgICAgICBlbmNsb3Npbmcgc2Nyb2xsYWJsZSBjb250YWluZXIgKDxkaXY+ KSBkb3duLCBhbmQgKm5vdCogbW92ZSBmb2N1cyB0byB0aGUgbGluayB3aG9zZSBpZCBpcyAnMicu CisgIC0tPgorICA8aGVhZD4KKyAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorICAgICAgZGl2 LnNjcm9sbCB7CisgICAgICAgIGhlaWdodDogMjAwcHg7CisgICAgICAgIHdpZHRoOiAzMDBweDsK KyAgICAgICAgb3ZlcmZsb3c6IGF1dG87CisgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkICM2NjY7 CisgICAgICAgIGJhY2tncm91bmQtY29sb3I6ICNjY2M7CisgICAgICAgIHBhZGRpbmc6IDhweDsK KyAgICAgIH0KKyAgICA8L3N0eWxlPgorCisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9InJlc291cmNl cy9zcGF0aWFsLW5hdmlnYXRpb24tdXRpbHMuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgdHlw ZT0iYXBwbGljYXRpb24vamF2YXNjcmlwdCI+CisKKyAgICB2YXIgcmVzdWx0TWFwID0gWworICAg ICAgWyJEb3duIiwgInN0YXJ0Il0sCisgICAgICBbIkRPTkUiLCAiRE9ORSJdCisgICAgXTsKKwor ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldFNw YXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCh0cnVlKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0VGFiVG9MaW5rc1ByZWZlcmVuY2VLZXkiLCAxKTsK KyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAg ICBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICB7CisgICAgICAvLyBzdGFydGluZyB0aGUgdGVzdCBp dHNlbGY6IGdldCB0byBhIGtub3duIHBsYWNlLgorICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInN0YXJ0IikuZm9jdXMoKTsKKworICAgICAgaW5pdFRlc3QocmVzdWx0TWFwLCB0ZXN0Q29t cGxldGVkKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiB0ZXN0Q29tcGxldGVkKCkKKyAgICB7Cisg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorCisgICAgd2luZG93Lm9ubG9hZCA9IHJ1 blRlc3Q7CisKKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CisgIDwvaGVhZD4KKworICA8Ym9keSBpZD0ic29t ZS1jb250ZW50IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CisgICAgPGRp diBjbGFzcz0ic2Nyb2xsIj4KKyAgICAgIDxwPkl0IGhhcyBhIHZpc2libGUgPGEgaWQ9InN0YXJ0 IiBocmVmPSJhIj5saW5rXzE8L2E+LjwvcD4KKyAgICAgIDxicj48YnI+PGJyPjxicj48YnI+PGJy Pjxicj48YnI+PGJyPgorICAgICAgPHA+Li4uIGFuZCBhbiBvdmVyZmxvd2VkIGxpbmsgbGlrZSA8 YSBpZD0iMSIgaHJlZj0iYSI+dGhpczwvYT4uPC9wPgorICAgIDwvZGl2PgorICAgIDxicj48YnI+ PGJyPjxicj48YnI+PGJyPjxicj4KKyAgICA8cD5UaGlzIGxpbmsgc2hvdWxkIE5PVCBnZXQgPGEg aWQ9InN0YXJ0IiBocmVmPSJhIj5mb2N1c2VkPC9hPi48L3A+CisgICAgPGRpdiBpZD0iY29uc29s ZSI+PC9kaXY+CisgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI1N2M3Mi4uOWU1MmJlNSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwy MCBAQAogMjAxMC0wNC0xMiAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgog CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwYXRpYWwg TmF2aWdhdGlvbjogbWFrZSByZW5kZXJSZWN0UmVsYXRpdmVUb1Jvb3REb2N1bWVudCBtZXRob2Qg dG8gZmFsbGJhY2sgdG8gZ2V0UmVjdCgpIG9mIEVsZW1lbnQgd2hlbiBuZWVkZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NDYxCisKKyAgICAgICAg Z2V0UmVjdCgpIG9mIEVsZW1lbnQgY2FuIGJlIHVzZWQgaW5zdGVhZCBvZiBhYnNvbHV0ZUNsaXBw ZWRPdmVyZmxvd1JlY3Qgb2YgUmVuZGVyT2JqZWN0IHdoZW4KKyAgICAgICAgdGhlIG5vZGUgaXMg Y3VycmVudGx5IG9mZnNjcmVlbiBpbiBhbiBzY3JvbGwgb3ZlcmZsb3dlZCBjb250ZW50LgorCisg ICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LXNpbXBsZS1j b250ZW50LW92ZXJmbG93Lmh0bWwKKworICAgICAgICAqIHBhZ2UvU3BhdGlhbE5hdmlnYXRpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVuZGVyUmVjdFJlbGF0aXZlVG9Sb290RG9jdW1lbnQp OgorCisyMDEwLTA0LTEyICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisK ICAgICAgICAgVW5yZXZpZXdlZCBzdHlsZSBmaXguCiAKICAgICAgICAgKiBwYWdlL0ZvY3VzQ29u dHJvbGxlci5jcHA6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24u Y3BwIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcAppbmRleCA1Y2ZiZmIzLi4y YWVkZTcxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHAKQEAgLTEwNSw2ICsxMDUsMTEg QEAgc3RhdGljIEludFJlY3QgcmVuZGVyUmVjdFJlbGF0aXZlVG9Sb290RG9jdW1lbnQoUmVuZGVy T2JqZWN0KiByZW5kZXIpCiAgICAgQVNTRVJUKHJlbmRlcik7CiAgICAgSW50UmVjdCByZWN0KHJl bmRlci0+YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCkpOwogCisgICAgaWYgKHJlY3QuaXNF bXB0eSgpKSB7CisgICAgICAgIEVsZW1lbnQqIGUgPSBzdGF0aWNfY2FzdDxFbGVtZW50Kj4ocmVu ZGVyLT5ub2RlKCkpOworICAgICAgICByZWN0ID0gZS0+Z2V0UmVjdCgpOworICAgIH0KKwogICAg IC8vIEluIGNhc2VzIHdoZW4gdGhlIHxyZW5kZXJ8J3MgYXNzb2NpYXRlZCBub2RlIGlzIGluIGEg c2Nyb2xsYWJsZSBpbm5lcgogICAgIC8vIGRvY3VtZW50LCB3ZSBvbmx5IGNvbnNpZGVyIGl0cyBz Y3JvbGxPZmZzZXQgaWYgaXQgaXMgbm90IG9mZnNjcmVlbi4KICAgICBOb2RlKiBub2RlID0gcmVu ZGVyLT5ub2RlKCk7Ci0tIAoxLjYuMC40Cgo=