37455 2010-04-12 10:57:31 -0700 REGRESSION: :visited doesn't work when used with multiple classes/ids 2010-04-12 11:43:13 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 211664 0 hyatt 2010-04-12 10:57:31 -0700 <rdar://problem/7849485> REGRESSION (r57292): Visited links on reddit.com lose their color after reloading the page 4/10/10 5:21 AM Mark Rowe: * SUMMARY While reading the intarwebs this evening I've noticed that visited links on reddit.com lose their purple coloring after reloading the page. * STEPS TO REPRODUCE 1. Log in to a reddit account. 2. Command-click a link on reddit.com. Observe the link turning purple. 3. Reload the reddit.com page. * RESULTS The link turns blue when the page reloads. * REGRESSION This didn't happen in r57282, but I'm seeing it with r57404. * NOTES r57299 seems like a likely cause for this. It claims to be updating some of our behavior to match Firefox, but this behavior does not reproduce in Firefox. This bug does not appear to reproduce if you're not logged in to a reddit account. 211665 1 53177 hyatt 2010-04-12 10:59:55 -0700 Created attachment 53177 Patch 211683 2 53177 sam 2010-04-12 11:33:57 -0700 Comment on attachment 53177 Patch This may need some skip list love. Please check before landing. 211687 3 hyatt 2010-04-12 11:43:13 -0700 Fixed in r57476. 53177 2010-04-12 10:59:55 -0700 2010-04-12 11:33:57 -0700 Patch patch.txt text/plain 4425 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzQ3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMTIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQ1NSwgOnZpc2l0ZWQgZG9lc24n dCB3b3JrIHdpdGggbXVsdGlwbGUgY2xhc3Nlcy9pZHMuCisKKyAgICAgICAgQWRkZWQgZmFzdC9o aXN0b3J5L211bHRpcGxlLWNsYXNzZXMtdmlzaXRlZC5odG1sLgorCisgICAgICAgICogY3NzL0NT U1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6 U2VsZWN0b3JDaGVja2VyOjpjaGVja1NlbGVjdG9yKToKKwogMjAxMC0wNC0xMiAgRGlyayBTY2h1 bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpJ bmRleDogV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDU3MzYyKQorKysgV2ViQ29y ZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxOSw4ICs5MTks NyBAQCBFSW5zaWRlTGluayBDU1NTdHlsZVNlbGVjdG9yOjpTZWxlY3RvckNoCiBib29sIENTU1N0 eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tTZWxlY3RvcihDU1NTZWxlY3Rvciog c2VsLCBFbGVtZW50KiBlbGVtZW50KSBjb25zdAogewogICAgIFBzZXVkb0lkIGR5bmFtaWNQc2V1 ZG8gPSBOT1BTRVVETzsKLQotICAgIHJldHVybiBjaGVja1NlbGVjdG9yKHNlbCwgZWxlbWVudCwg MCwgZHluYW1pY1BzZXVkbywgdHJ1ZSwgZmFsc2UpID09IFNlbGVjdG9yTWF0Y2hlczsKKyAgICBy ZXR1cm4gY2hlY2tTZWxlY3RvcihzZWwsIGVsZW1lbnQsIDAsIGR5bmFtaWNQc2V1ZG8sIGZhbHNl LCBmYWxzZSkgPT0gU2VsZWN0b3JNYXRjaGVzOwogfQogCiAjaWZkZWYgU1RZTEVfU0hBUklOR19T VEFUUwpAQCAtMTgyOSw3ICsxODI4LDcgQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6U2VsZWN0b3JNYXRj aCBDU1NTdHlsZQogICAgICAgICAgICAgcmV0dXJuIFNlbGVjdG9yRmFpbHNDb21wbGV0ZWx5Owog CiAgICAgLy8gQ2hlY2sgZm9yIG5lc3RlZCBsaW5rcy4KLSAgICBpZiAobV9tYXRjaFZpc2l0ZWRQ c2V1ZG9DbGFzcykgeworICAgIGlmIChtX21hdGNoVmlzaXRlZFBzZXVkb0NsYXNzICYmICFpc1N1 YlNlbGVjdG9yKSB7CiAgICAgICAgIFJlbmRlclN0eWxlKiBjdXJyZW50U3R5bGUgPSBlbGVtZW50 U3R5bGUgPyBlbGVtZW50U3R5bGUgOiBlLT5yZW5kZXJTdHlsZSgpOwogICAgICAgICBpZiAoY3Vy cmVudFN0eWxlICYmIGN1cnJlbnRTdHlsZS0+aW5zaWRlTGluaygpICYmIGUtPmlzTGluaygpKSB7 CiAgICAgICAgICAgICBpZiAoZW5jb3VudGVyZWRMaW5rKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTc0 NzQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MiBAQAorMjAxMC0wNC0xMiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3NDU1LCA6dmlzaXRlZCBkb2Vzbid0IHdvcmsgd2l0 aCBtdWx0aXBsZSBjbGFzc2VzL2lkcy4KKworICAgICAgICAqIGZhc3QvaGlzdG9yeS9tdWx0aXBs ZS1jbGFzc2VzLXZpc2l0ZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2hp c3RvcnkvbXVsdGlwbGUtY2xhc3Nlcy12aXNpdGVkLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA0LTEy ICBKZWZmIFNjaGlsbGVyICA8Y29kZWRyZWFkQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEaXJrIFNjaHVsemUuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvbXVsdGlw bGUtY2xhc3Nlcy12aXNpdGVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2hpc3RvcnkvbXVsdGlwbGUtY2xhc3Nlcy12aXNpdGVkLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9tdWx0aXBsZS1jbGFzc2VzLXZp c2l0ZWQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKK1RoZXNlIHR3 byBsaW5rcyBzaG91bGQgYmUgdGhlIHNhbWUgY29sb3IgKG9yYW5nZSk6CisKK09uZSBUd28KK1BB U1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9tdWx0aXBsZS1jbGFzc2VzLXZpc2l0 ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvbXVsdGlwbGUt Y2xhc3Nlcy12aXNpdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2hp c3RvcnkvbXVsdGlwbGUtY2xhc3Nlcy12aXNpdGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNDkgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikgeworICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5rZWVwV2ViSGlz dG9yeSgpOworICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9 CisKK2Z1bmN0aW9uIGNvbXBhcmVTdHlsZXMoKQoreworICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpIHsKKyAgICAgICAgdmFyIGZpcnN0U3R5bGUgPSB3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIuY29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvKGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdvbmUnKSk7CisgICAgICAgIHZhciBzZWNvbmRTdHlsZSA9IHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlci5jb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRlZEluZm8oZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3R3bycpKTsKKyAgICAgICAgaWYgKGZpcnN0U3R5bGUuY29s b3IgIT0gc2Vjb25kU3R5bGUuY29sb3IpIHsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUwgPSAnRkFJTCc7CisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIH0KKyAgICB9CisgICAgCisgICAgdmFyIGZpcnN0U3R5bGUgPSB3aW5kb3cuZ2V0 Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb25lJyksICIiKTsKKyAgICB2 YXIgc2Vjb25kU3R5bGUgPSB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgndHdvJyksICIiKTsKKyAgICBpZiAoZmlyc3RTdHlsZS5jb2xvciA9PSBzZWNvbmRT dHlsZS5jb2xvcikgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0Jyku aW5uZXJIVE1MID0gJ0ZBSUwnOworICAgICAgICByZXR1cm47CisgICAgfQorfQorPC9zY3JpcHQ+ Cis8c3R5bGU+Cisjb25lOmxpbmsgeyBjb2xvcjogZ3JlZW4gfQorI3R3bzpsaW5rIHsgY29sb3I6 IHB1cnBsZSB9Cisjb25lOnZpc2l0ZWQgeyBjb2xvcjogb3JhbmdlIH0KKyN0d28udGVzdDp2aXNp dGVkIHsgY29sb3I6IG9yYW5nZSB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJj b21wYXJlU3R5bGVzKCkiPgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9kdW1teS5odG1sIiBzdHls ZT0iZGlzcGxheTpub25lIj48L2lmcmFtZT4KKworPHA+CitUaGVzZSB0d28gbGlua3Mgc2hvdWxk IGJlIHRoZSBzYW1lIGNvbG9yIChvcmFuZ2UpOgorPC9wPgorPHA+Cis8YSBocmVmPSJyZXNvdXJj ZXMvZHVtbXkuaHRtbCIgaWQ9Im9uZSI+T25lPC9hPiAKKzxhIGhyZWY9InJlc291cmNlcy9kdW1t eS5odG1sIiBpZD0idHdvIiBjbGFzcz0idGVzdCI+VHdvPC9hPjxicj4KKzwvcD4KKzxwIGlkPXJl c3VsdD4KK1BBU1MKKzwvcD4KKzwvYm9keT4KKzwvaHRtbD4K