37448 2010-04-12 09:09:56 -0700 Web Inspector: Replace hand-written profiler bindings with idl-based, [Chromium] plug in new JSC-aligned V8 profiler API 2010-04-13 01:44:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov abarth eric pfeldman timothy webkit.review.bot yurys oldest_to_newest 211633 0 mnaganov 2010-04-12 09:09:56 -0700 I replaced hand-written JavaScriptProfile* bindings with idl-based, and in Chromium port, I bound them to the new V8's profiler API that is aligned with JSC. 211637 1 53171 mnaganov 2010-04-12 09:23:00 -0700 Created attachment 53171 proposed patch I'll better land it myself to avoid surprising build breakages. 211887 2 webkit.review.bot 2010-04-13 00:34:11 -0700 http://trac.webkit.org/changeset/57505 might have broken Chromium Linux Release 211898 3 mnaganov 2010-04-13 01:44:06 -0700 Manually committed http://trac.webkit.org/changeset/57505 Then followed up with build fixes for Qt and Chromium: http://trac.webkit.org/changeset/57508 53171 2010-04-12 09:23:00 -0700 2010-04-12 10:42:07 -0700 proposed patch webkit-script-profile-changes-patch text/plain 4825 mnaganov SW5kZXg6IFdlYkNvcmUuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlLmd5cGkJKHJldmlzaW9u IDU1NTEyKQorKysgV2ViQ29yZS5neXBpCSh3b3JraW5nIGNvcHkpCkBAIC04MTYsNiArODE2LDcg QEAKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9TY3JpcHRJbnN0YW5jZS5oJywKICAgICAgICAg ICAgICdiaW5kaW5ncy92OC9TY3JpcHRPYmplY3QuY3BwJywKICAgICAgICAgICAgICdiaW5kaW5n cy92OC9TY3JpcHRPYmplY3QuaCcsCisgICAgICAgICAgICAnYmluZGluZ3MvdjgvU2NyaXB0UHJv ZmlsZS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGUuaCcsCiAg ICAgICAgICAgICAnYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIuY3BwJywKICAgICAgICAgICAg ICdiaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5oJywKSW5kZXg6IGJpbmRpbmdzL3Y4L1Njcmlw dFByb2ZpbGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBiaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmgJKHJl dmlzaW9uIDU1NTEyKQorKysgYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zMywyOCArMzMsMzAgQEAKIAogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAK K25hbWVzcGFjZSB2OCB7CitjbGFzcyBDcHVQcm9maWxlOworfQorCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIGNsYXNzIFNjcmlwdFByb2ZpbGUgOiBwdWJsaWMgUmVmQ291bnRlZDxTY3JpcHRQcm9m aWxlPiB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZT4gY3Jl YXRlKGNvbnN0IFN0cmluZyYgdGl0bGUsIHVuc2lnbmVkIHVpZCkKKyAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxTY3JpcHRQcm9maWxlPiBjcmVhdGUoY29uc3Qgdjg6OkNwdVByb2ZpbGUqIHByb2ZpbGUp CiAgICAgewotICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTY3JpcHRQcm9maWxlKHRpdGxlLCB1 aWQpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTY3JpcHRQcm9maWxlKHByb2ZpbGUp KTsKICAgICB9CiAgICAgdmlydHVhbCB+U2NyaXB0UHJvZmlsZSgpIHt9CiAKLSAgICBTdHJpbmcg dGl0bGUoKSBjb25zdCB7IHJldHVybiBtX3RpdGxlOyB9Ci0gICAgdW5zaWduZWQgaW50IHVpZCgp IGNvbnN0IHsgcmV0dXJuIG1fdWlkOyB9CisgICAgU3RyaW5nIHRpdGxlKCkgY29uc3Q7CisgICAg dW5zaWduZWQgaW50IHVpZCgpIGNvbnN0OwogCiBwcm90ZWN0ZWQ6Ci0gICAgU2NyaXB0UHJvZmls ZShjb25zdCBTdHJpbmcmIHRpdGxlLCB1bnNpZ25lZCB1aWQpCi0gICAgICAgIDogbV90aXRsZSh0 aXRsZSkKLSAgICAgICAgLCBtX3VpZCh1aWQpCisgICAgU2NyaXB0UHJvZmlsZShjb25zdCB2ODo6 Q3B1UHJvZmlsZSogcHJvZmlsZSkKKyAgICAgICAgOiBtX3Byb2ZpbGUocHJvZmlsZSkKICAgICB7 fQogCiBwcml2YXRlOgotICAgIFN0cmluZyBtX3RpdGxlOwotICAgIHVuc2lnbmVkIGludCBtX3Vp ZDsKKyAgICBjb25zdCB2ODo6Q3B1UHJvZmlsZSogbV9wcm9maWxlOwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpJbmRleDogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAJKHJldmlzaW9uIDApCisrKyBi aW5kaW5ncy92OC9TY3JpcHRQcm9maWxlLmNwcAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0OSBA QAorLyoKKyAqIENvcHlyaWdodCAoYykgMjAxMCwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5 IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBw cm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoKKyAqCisg KiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhl IGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGljZSwgdGhp cyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorICogaW4g dGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRo ZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUg SW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRv IGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMgc29mdHdh cmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgorICogVEhJ UyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRS SUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNVTEFSIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyAq IE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNU LCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERB TUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0Yg U1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBM SUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0Up IEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwg RVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLwor CisjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpbmNsdWRlICJTY3JpcHRQcm9maWxlLmgiCisKKyNp bmNsdWRlICJWOEJpbmRpbmcuaCIKKworI2luY2x1ZGUgPHY4LXByb2ZpbGVyLmg+CisKK25hbWVz cGFjZSBXZWJDb3JlIHsKKworU3RyaW5nIFNjcmlwdFByb2ZpbGU6OnRpdGxlKCkgY29uc3Qgewor ICAgIHJldHVybiB0b1dlYkNvcmVTdHJpbmcobV9wcm9maWxlLT5HZXRUaXRsZSgpKTsKK30KKwor dW5zaWduZWQgaW50IFNjcmlwdFByb2ZpbGU6OnVpZCgpIGNvbnN0IHsKKyAgICByZXR1cm4gbV9w cm9maWxlLT5HZXRVaWQoKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQoKUHJvcGVydHkg Y2hhbmdlcyBvbjogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZS5jcHAKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRl ZDogc3ZuOmVvbC1zdHlsZQogICArIExGCgpJbmRleDogYmluZGluZ3MvdjgvU2NyaXB0UHJvZmls ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGJpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcAkocmV2 aXNpb24gNTU1MTIpCisrKyBiaW5kaW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMxLDIwICszMSwyMCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaW5jbHVk ZSAiU2NyaXB0UHJvZmlsZXIuaCIKKyNpbmNsdWRlICJTY3JpcHRTdHJpbmcuaCIKIAorI2luY2x1 ZGUgPHY4LXByb2ZpbGVyLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBTY3JpcHRQ cm9maWxlcjo6c3RhcnQoU2NyaXB0U3RhdGUqIHN0YXRlLCBjb25zdCBTdHJpbmcmIHRpdGxlKQog ewotICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKLSAgICB2ODo6Q29udGV4dDo6U2NvcGUgY29u dGV4dFNjb3BlKHY4OjpDb250ZXh0OjpHZXRDdXJyZW50KCkpOwotICAgIHY4OjpWODo6UmVzdW1l UHJvZmlsZXIoKTsKKyAgICB2ODo6Q3B1UHJvZmlsZXI6OlN0YXJ0UHJvZmlsaW5nKHY4U3RyaW5n KHRpdGxlKSk7CiB9CiAKIFBhc3NSZWZQdHI8U2NyaXB0UHJvZmlsZT4gU2NyaXB0UHJvZmlsZXI6 OnN0b3AoU2NyaXB0U3RhdGUqIHN0YXRlLCBjb25zdCBTdHJpbmcmIHRpdGxlKQogewotICAgIHY4 OjpWODo6UGF1c2VQcm9maWxlcigpOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBTY3JpcHRQ cm9maWxlOjpjcmVhdGUodjg6OkNwdVByb2ZpbGVyOjpTdG9wUHJvZmlsaW5nKHY4U3RyaW5nKHRp dGxlKSkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==