37445 2010-04-12 03:22:01 -0700 [Qt] Regression: Google calendar edit event details gets stuck on loading 2014-02-03 03:16:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED INVALID http://www.google.com/calendar Qt, QtTriaged P2 Major --- 1 jturcotte webkit-unassigned hausmann jesus jturcotte jwieczorek kenneth laszlo.gombos yael oldest_to_newest 211584 0 jturcotte 2010-04-12 03:22:01 -0700 - Go to Google calendar, log in - Click on "Create Event" on the left menu (or click in the calendar to create an event and click "edit event details") Expecting to see the edit event panel Got instead a big white panel and sometimes the "Loading..." notice in the top right corner stays on. The website cannot be used. Reproduced in QtLauncher on Windows 7 with Qt 4.7 trunk and WebKit trunk Could not reproduce the problem in the demo browser of Qt 4.5.3 219083 1 54718 jturcotte 2010-04-29 10:32:57 -0700 Created attachment 54718 Patch: Disable XSLT The problem turns out to be a bug in Qt's xmlpattern. See: http://bugreports.nokia.troll.no/browse/QTBUG-10309 Mozilla's xslt test page is broken as well since Qt's xslt implementation doesn't support xsl:attribute-set yet. http://www.mozilla.org/projects/xslt/test.xml This patch sets xslt in QtWebKit as disabled by default 219239 2 54748 jwieczorek 2010-04-29 16:07:06 -0700 Created attachment 54748 A patch for Qt Thanks for CCing me. (In reply to comment #1) > Created an attachment (id=54718) [details] > Patch: Disable XSLT > > The problem turns out to be a bug in Qt's xmlpattern. > See: http://bugreports.nokia.troll.no/browse/QTBUG-10309 I posted a comment on that bug about why I think this doesn't work: "I don't think http://www.w3.org/TR/xslt#dt-shadows is what matters here. The specified parameters for a template should not be inherited by a nested call of another template in the first place, so shadowing does not seem to apply here. I'm pretty sure that the actual problem here is that the processor maintains one list of the parameter values that it should supply to the template being called. In this case it reuses the same list for a nested call when computing the subtree of the param2 parameter, which is when it hits the duplicate." I think it would be better if this particular bug was simply fixed instead of the whole thing disabled. I'm attaching a patch for QtXmlPatterns that could be a possible solution. I haven't tested it properly yet, I only checked your test case as well as the other one posted on that bug, they both work fine with the patch. Provided that isn't too late to get this into Qt so that XSLT does not have to be disabled in QtWebKit, I'm going to prepare an official merge request with the patch tomorrow after I make sure it's correct. 219504 3 jwieczorek 2010-04-30 09:23:12 -0700 (In reply to comment #2) > Provided that isn't too late to get this into Qt so that XSLT does not have to > be disabled in QtWebKit, I'm going to prepare an official merge request with > the patch tomorrow after I make sure it's correct. http://qt.gitorious.org/qt/qt/merge_requests/2376 220071 4 54718 jturcotte 2010-05-03 05:59:42 -0700 Comment on attachment 54718 Patch: Disable XSLT Removing flags on the patch until we see how it goes by fixing Qt's xslt We should also see if we disable is for Qt 4.6 or get the xslt fix in Qt 4.6.3 as well 222638 5 kenneth 2010-05-07 14:55:56 -0700 Are you following up on getting this fix into Qt, Jocelyn? 225283 6 jesus 2010-05-13 07:37:51 -0700 Reproduced on Snow Leopard with Qt 4.7 trunk (HEAD 03f8f1df0d88f5ffe0b3120cffce614cbeefdb70) and WebKit trunk (r59155), using QtLauncher. 225747 7 jturcotte 2010-05-14 04:13:17 -0700 (In reply to comment #5) > Are you following up on getting this fix into Qt, Jocelyn? XSLT has been disabled in the qtwebkit-2.0 branch at the commit 25c6b4daf01b70fe8cd368f78bb7e8257085c0b1. Fixing only this bug in Qt might not be enough. The documentation states that the XSLT support in Qt is still experimental and passes 42% of the XSLT test suite. http://doc.trolltech.com/4.7/xmlprocessing.html#xslt-2-0 IMHO I think that we should try to support a good part of XSLT 1.0 use cases before enabling it in a QtWebKit release since web sites might rely on the XSLTProcessor being supported totally or not at all. 225855 8 hausmann 2010-05-14 08:53:57 -0700 Removing this issue from the 2.0 release blockers, as we've applied the workaround there to disable XSLT. 403378 9 laszlo.gombos 2011-05-12 22:05:01 -0700 Would XSLT support significantly improve in Qt 4.8 ? I do not see progress on the original bug - http://bugreports.qt.nokia.com/browse/QTBUG-10309. 403464 10 jturcotte 2011-05-13 03:23:55 -0700 (In reply to comment #9) > Would XSLT support significantly improve in Qt 4.8 ? I do not see progress on the original bug - http://bugreports.qt.nokia.com/browse/QTBUG-10309. I don't think anybody of Qt is working on this, especially since Frans left the company. 403717 11 laszlo.gombos 2011-05-13 11:51:06 -0700 (In reply to comment #10) > (In reply to comment #9) > > Would XSLT support significantly improve in Qt 4.8 ? I do not see progress on the original bug - http://bugreports.qt.nokia.com/browse/QTBUG-10309. > > I don't think anybody of Qt is working on this, especially since Frans left the company. I see 2 options here - plan on turning off XSLT longer term (perhaps turn it off even on trunk) or switch to libxslt. 511660 12 laszlo.gombos 2011-11-30 05:27:30 -0800 Related e-mail thread about turning on XSLT and using libxslt as a back-end if available - https://lists.webkit.org/pipermail/webkit-qt/2011-November/002166.html 975119 13 jturcotte 2014-02-03 03:16:21 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 54718 2010-04-29 10:32:57 -0700 2010-06-11 12:30:25 -0700 Patch: Disable XSLT disable_xslt.patch text/plain 1156 jturcotte ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjM0OWYwZC4uYTM5MTBjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0yOSAgSm9jZWx5biBUdXJj b3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU2V0IFhTTFQgYXMgZGlzYWJsZWQgYnkg ZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM3NDQ1CisKKyAgICAgICAgUXQncyBYU0xUIGltcGxlbWVudGF0aW9uIGhhcyBhbiBpc3N1ZSBw cmV2ZW50aW5nIEdvb2dsZSBjYWxlbmRhcgorICAgICAgICBmcm9tIHdvcmtpbmcgcHJvcGVybHku IFRoaXMgc2hvdWxkIGJlIGZpeGVkIGJlZm9yZSB3ZSByZS1lbmFibGUgaXQuCisKKyAgICAgICAg KiBXZWJDb3JlLnByaToKKwogMjAxMC0wNC0yMSAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4u dHVyY290dGVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1dlYkNvcmUv V2ViQ29yZS5wcmkKaW5kZXggN2RkMzExNS4uMGMxNjlmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9X ZWJDb3JlLnByaQorKysgYi9XZWJDb3JlL1dlYkNvcmUucHJpCkBAIC0xMDMsOCArMTAzLDggQEAg Z3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNSkgewogCiAjIFhTTFQgc3VwcG9ydCB3aXRo IFF0WG1sUGF0dGVybnMKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfWFNMVD0uKSB7Ci0gICAg Y29udGFpbnMoUVRfQ09ORklHLCB4bWxwYXR0ZXJucyk6REVGSU5FUyArPSBFTkFCTEVfWFNMVD0x Ci0gICAgZWxzZTpERUZJTkVTICs9IEVOQUJMRV9YU0xUPTAKKyAgICAjIERpc2FibGUgWFNMVCBi eSBkZWZhdWx0IGJlY2F1c2Ugb2YgYnVnICMzNzQ0NQorICAgIERFRklORVMgKz0gRU5BQkxFX1hT TFQ9MAogfQogCiAhQ09ORklHKFFURElSX2J1aWxkKTohY29udGFpbnMoREVGSU5FUywgRU5BQkxF X1FUX0JFQVJFUj0uKSB7Cg== 54748 2010-04-29 16:07:06 -0700 2010-04-29 16:07:06 -0700 A patch for Qt xslt-with-param.patch text/plain 4156 jwieczorek ZGlmZiAtLWdpdCBhL3NyYy94bWxwYXR0ZXJucy9wYXJzZXIvcXBhcnNlcmNvbnRleHRfcC5oIGIv c3JjL3htbHBhdHRlcm5zL3BhcnNlci9xcGFyc2VyY29udGV4dF9wLmgKaW5kZXggNDAzZjkxMS4u Y2Y2OWE3YSAxMDA2NDQKLS0tIGEvc3JjL3htbHBhdHRlcm5zL3BhcnNlci9xcGFyc2VyY29udGV4 dF9wLmgKKysrIGIvc3JjL3htbHBhdHRlcm5zL3BhcnNlci9xcGFyc2VyY29udGV4dF9wLmgKQEAg LTM1Niw5ICszNTYsMTAgQEAgbmFtZXNwYWNlIFFQYXR0ZXJuaXN0CiAgICAgICAgIFZhcmlhYmxl RGVjbGFyYXRpb246Okxpc3QgdGVtcGxhdGVQYXJhbWV0ZXJzOwogCiAgICAgICAgIC8qKgotICAg ICAgICAgKiBUaGUgQGMgeHNsOndpdGgtcGFyYW0gYXBwZWFyaW5nIGluIHRlbXBsYXRlIGNhbGxp bmcgaW5zdHJ1Y3Rpb24uCisgICAgICAgICAqIFRoZSBAYyB4c2w6d2l0aC1wYXJhbSBhcHBlYXJp bmcgaW4gdGVtcGxhdGUgY2FsbGluZyBpbnN0cnVjdGlvbnMuCisgICAgICAgICAqIFRoZSBzdGFj ayBwcmVzZXJ2ZXMgdGhlIG5lc3Rpbmcgb2YgdGhlIGluc3RydWN0aW9ucyBzcGVjaWZ5aW5nIHRo ZXNlIHBhcmFtZXRlcnMuCiAgICAgICAgICAqLwotICAgICAgICBXaXRoUGFyYW06Okhhc2ggdGVt cGxhdGVXaXRoUGFyYW1zOworICAgICAgICBRU3RhY2s8V2l0aFBhcmFtOjpIYXNoPiB0ZW1wbGF0 ZVdpdGhQYXJhbXM7CiAKICAgICAgICAgaW5saW5lIHZvaWQgdGVtcGxhdGVQYXJhbWV0ZXJzSGFu ZGxlZCgpCiAgICAgICAgIHsKQEAgLTM2OCw3ICszNjksNyBAQCBuYW1lc3BhY2UgUVBhdHRlcm5p c3QKIAogICAgICAgICBpbmxpbmUgdm9pZCB0ZW1wbGF0ZVdpdGhQYXJhbWV0ZXJzSGFuZGxlZCgp CiAgICAgICAgIHsKLSAgICAgICAgICAgIHRlbXBsYXRlV2l0aFBhcmFtcy5jbGVhcigpOworICAg ICAgICAgICAgdGVtcGxhdGVXaXRoUGFyYW1zLnBvcCgpOwogICAgICAgICB9CiAKICAgICAgICAg aW5saW5lIGJvb2wgaXNQYXJzaW5nV2l0aFBhcmFtKCkgY29uc3QKZGlmZiAtLWdpdCBhL3NyYy94 bWxwYXR0ZXJucy9wYXJzZXIvcXVlcnl0cmFuc2Zvcm1wYXJzZXIueXBwIGIvc3JjL3htbHBhdHRl cm5zL3BhcnNlci9xdWVyeXRyYW5zZm9ybXBhcnNlci55cHAKaW5kZXggODA3NTY3MS4uY2I2MjAx NyAxMDA2NDQKLS0tIGEvc3JjL3htbHBhdHRlcm5zL3BhcnNlci9xdWVyeXRyYW5zZm9ybXBhcnNl ci55cHAKKysrIGIvc3JjL3htbHBhdHRlcm5zL3BhcnNlci9xdWVyeXRyYW5zZm9ybXBhcnNlci55 cHAKQEAgLTMzMTcsMTMgKzMzMTcsMTggQEAgU3RlcEV4cHI6IEZpbHRlcmVkQXhpc1N0ZXAKICAg ICAgICAgcGFyc2VJbmZvLT5zdGF0aWNDb250ZXh0LT5zZXROYW1lc3BhY2VCaW5kaW5ncyhwYXJz ZUluZm8tPnJlc29sdmVycy5wb3AoKSk7CiAgICAgICAgICQkID0gJDg7CiAgICAgfQotfCBDQUxM X1RFTVBMQVRFIEVsZW1lbnROYW1lIExQQVJFTiBUZW1wbGF0ZVdpdGhQYXJhbWV0ZXJzIFJQQVJF TgorfCBDYWxsVGVtcGxhdGUgRWxlbWVudE5hbWUgTFBBUkVOIFRlbXBsYXRlV2l0aFBhcmFtZXRl cnMgUlBBUkVOCiAgICAgewotICAgICAgICAkJCA9IGNyZWF0ZShuZXcgQ2FsbFRlbXBsYXRlKCQy LCBwYXJzZUluZm8tPnRlbXBsYXRlV2l0aFBhcmFtcyksIEAkLCBwYXJzZUluZm8pOworICAgICAg ICAkJCA9IGNyZWF0ZShuZXcgQ2FsbFRlbXBsYXRlKCQyLCBwYXJzZUluZm8tPnRlbXBsYXRlV2l0 aFBhcmFtcy50b3AoKSksIEAkLCBwYXJzZUluZm8pOwogICAgICAgICBwYXJzZUluZm8tPnRlbXBs YXRlV2l0aFBhcmFtZXRlcnNIYW5kbGVkKCk7CiAgICAgICAgIHBhcnNlSW5mby0+dGVtcGxhdGVD YWxscy5hcHBlbmQoJCQpOwogICAgIH0KIAorQ2FsbFRlbXBsYXRlOiBDQUxMX1RFTVBMQVRFCisg ICAgeworICAgICAgICBwYXJzZUluZm8tPnRlbXBsYXRlV2l0aFBhcmFtcy5wdXNoKFdpdGhQYXJh bTo6SGFzaCgpKTsKKyAgICB9CisKIFRlbXBsYXRlV2l0aFBhcmFtZXRlcnM6CiAgICAgewogICAg ICAgICBwYXJzZUluZm8tPnN0YXJ0UGFyc2luZ1dpdGhQYXJhbSgpOwpAQCAtMzM5NSw3ICszNDAw LDcgQEAgVGVtcGxhdGVQYXJhbWV0ZXI6IElzVHVubmVsIERPTExBUiBWYXJOYW1lIFR5cGVEZWNs YXJhdGlvbiBPcHRpb25hbEFzc2lnbgogICAgICAgICBlbHNlCiAgICAgICAgIHsKICAgICAgICAg ICAgIGlmKCghaXNQYXJzaW5nV2l0aFBhcmFtICYmIFZhcmlhYmxlRGVjbGFyYXRpb246OmNvbnRh aW5zKHBhcnNlSW5mby0+dGVtcGxhdGVQYXJhbWV0ZXJzLCAkMykpIHx8Ci0gICAgICAgICAgICAg ICAoaXNQYXJzaW5nV2l0aFBhcmFtICYmIHBhcnNlSW5mby0+dGVtcGxhdGVXaXRoUGFyYW1zLmNv bnRhaW5zKCQzKSkpCisgICAgICAgICAgICAgICAoaXNQYXJzaW5nV2l0aFBhcmFtICYmIHBhcnNl SW5mby0+dGVtcGxhdGVXaXRoUGFyYW1zLnRvcCgpLmNvbnRhaW5zKCQzKSkpCiAgICAgICAgICAg ICB7CiAgICAgICAgICAgICAgICAgcGFyc2VJbmZvLT5zdGF0aWNDb250ZXh0LT5lcnJvcihRdFht bFBhdHRlcm5zOjp0cigiRWFjaCBuYW1lIG9mIGEgdGVtcGxhdGUgcGFyYW1ldGVyIG11c3QgYmUg dW5pcXVlOyAlMSBpcyBkdXBsaWNhdGVkLiIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC5hcmcoZm9ybWF0S2V5d29yZChw YXJzZUluZm8tPnN0YXRpY0NvbnRleHQtPm5hbWVQb29sKCksICQzKSksCkBAIC0zNDA0LDcgKzM0 MDksNyBAQCBUZW1wbGF0ZVBhcmFtZXRlcjogSXNUdW5uZWwgRE9MTEFSIFZhck5hbWUgVHlwZURl Y2xhcmF0aW9uIE9wdGlvbmFsQXNzaWduCiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICB7 CiAgICAgICAgICAgICAgICAgaWYoaXNQYXJzaW5nV2l0aFBhcmFtKQotICAgICAgICAgICAgICAg ICAgICBwYXJzZUluZm8tPnRlbXBsYXRlV2l0aFBhcmFtc1skM10gPSBXaXRoUGFyYW06OlB0cihu ZXcgV2l0aFBhcmFtKCQzLCAkNCwgZXhwcikpOworICAgICAgICAgICAgICAgICAgICBwYXJzZUlu Zm8tPnRlbXBsYXRlV2l0aFBhcmFtcy50b3AoKVskM10gPSBXaXRoUGFyYW06OlB0cihuZXcgV2l0 aFBhcmFtKCQzLCAkNCwgZXhwcikpOwogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAg ICAgICB7CiAgICAgICAgICAgICAgICAgICAgIFFfQVNTRVJUKHR5cGUpOwpAQCAtMzYzMSwxNiAr MzYzNiwyMSBAQCBQcmltYXJ5RXhwcjogTGl0ZXJhbAogfCBGdW5jdGlvbkNhbGxFeHByCiB8IE9y ZGVyaW5nRXhwcgogfCBDb25zdHJ1Y3RvcgotfCBBUFBMWV9URU1QTEFURSBPcHRpb25hbE1vZGUg TFBBUkVOIFRlbXBsYXRlV2l0aFBhcmFtZXRlcnMgUlBBUkVOCit8IEFwcGx5VGVtcGxhdGUgT3B0 aW9uYWxNb2RlIExQQVJFTiBUZW1wbGF0ZVdpdGhQYXJhbWV0ZXJzIFJQQVJFTgogICAgIHsKICAg ICAgICAgJCQgPSBjcmVhdGUobmV3IEFwcGx5VGVtcGxhdGUocGFyc2VJbmZvLT5tb2RlRm9yKCQy KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFyc2VJbmZvLT50ZW1w bGF0ZVdpdGhQYXJhbXMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh cnNlSW5mby0+dGVtcGxhdGVXaXRoUGFyYW1zLnRvcCgpLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBwYXJzZUluZm8tPm1vZGVGb3IoUVhtbE5hbWUoU3RhbmRhcmROYW1l c3BhY2VzOjpJbnRlcm5hbFhTTFQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTdGFuZGFyZExvY2FsTmFtZXM6OkRlZmF1 bHQpKSksCiAgICAgICAgICAgICAgICAgICAgIEAxLCBwYXJzZUluZm8pOwogICAgICAgICBwYXJz ZUluZm8tPnRlbXBsYXRlV2l0aFBhcmFtZXRlcnNIYW5kbGVkKCk7CiAgICAgfQogCitBcHBseVRl bXBsYXRlOiBBUFBMWV9URU1QTEFURQorICAgIHsKKyAgICAgICAgcGFyc2VJbmZvLT50ZW1wbGF0 ZVdpdGhQYXJhbXMucHVzaChXaXRoUGFyYW06Okhhc2goKSk7CisgICAgfQorCiBMaXRlcmFsOiBO dW1lcmljTGl0ZXJhbCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAvKiBbODVdICovCiB8IFN0cmluZ0xpdGVyYWwKICAgICB7Cg==