37442 2010-04-12 01:20:31 -0700 [PATCH] [Qt] Fix compilation with system tray disabled. 2010-04-26 09:07:36 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 ismail webkit-unassigned commit-queue cshu hausmann laszlo.gombos webkit.review.bot oldest_to_newest 211570 0 ismail 2010-04-12 01:20:31 -0700 Notification support should be disabled if QT_NO_SYSTEMTRAYICON is defined. 211571 1 53158 ismail 2010-04-12 01:22:04 -0700 Created attachment 53158 Compile if QT_NO_SYSTEMTRAYICON is defined 211572 2 ismail 2010-04-12 01:25:40 -0700 Patch missing some more checks. I will fix it. 211574 3 ismail 2010-04-12 01:34:44 -0700 WebCore::ChromeClient::notificationPresenter() is abstract, it should be implemented in all conditions. 211575 4 53159 ismail 2010-04-12 01:36:05 -0700 Created attachment 53159 Implement WebCore::ChromeClient::notificationPresenter() in all cases 211576 5 webkit.review.bot 2010-04-12 01:37:50 -0700 Attachment 53159 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:482: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 211577 6 53160 ismail 2010-04-12 01:38:58 -0700 Created attachment 53160 Fix style error 211928 7 hausmann 2010-04-13 06:58:49 -0700 Wouldn't it be better to disable ENABLE(NOTIFICATIONS) if there's no system tray icon class instead of adding another condition to every use of ENABLE(NOTIFICATIONS)? It may be easiest to do that in WebCore/config.h 212268 8 53160 laszlo.gombos 2010-04-13 23:32:37 -0700 Comment on attachment 53160 Fix style error I agree with Simon's proposal, I'd like to give an r- this time. I similar mechanism exists to disable certain WebKit features if sqlite is not available. Would the following work .. contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0 213904 9 laszlo.gombos 2010-04-18 21:33:39 -0700 *** Bug 37716 has been marked as a duplicate of this bug. *** 214005 10 cshu 2010-04-19 06:45:25 -0700 (In reply to comment #8) > (From update of attachment 53160 [details]) > I agree with Simon's proposal, I'd like to give an r- this time. I similar > mechanism exists to disable certain WebKit features if sqlite is not available. > > Would the following work .. > > contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0 I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is defined. 214705 11 laszlo.gombos 2010-04-20 09:49:53 -0700 (In reply to comment #10) > (In reply to comment #8) > > (From update of attachment 53160 [details] [details]) > > I agree with Simon's proposal, I'd like to give an r- this time. I similar > > mechanism exists to disable certain WebKit features if sqlite is not available. > > > > Would the following work .. > > > > contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0 > > I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is > defined. Chang, you're right that unless QT_NO_SYSTEMTRAYICON is explicitly listed in the DEFINES qmake will not pick it up as it is only defined in a Qt header. A compromise would be not to disable the ENABLE_NOTIFICATIONS feature but only guard the SysTray dependent code with SYSTEMTRAYICON. I think in the future we should allow QtWebKit clients to render the notification themselves. 214712 12 cshu 2010-04-20 09:59:35 -0700 > > > contains(DEFINES, QT_NO_SYSTEMTRAYICON):DEFINES += ENABLE_NOTIFICATIONS=0 > > > > I don't think the pri file is able to detect if QT_NO_SYSTEMTRAYICON is > > defined. > > Chang, you're right that unless QT_NO_SYSTEMTRAYICON is explicitly listed in > the DEFINES qmake will not pick it up as it is only defined in a Qt header. > > A compromise would be not to disable the ENABLE_NOTIFICATIONS feature but only > guard the SysTray dependent code with SYSTEMTRAYICON. I think in the future we > should allow QtWebKit clients to render the notification themselves. I agree to guard the systemtrayicon code as we don't have a general solution and in this case, it's even a better solution as you have indicated for future enhancement. I am working on a patch if you guys don't mind. 214778 13 53847 cshu 2010-04-20 11:08:12 -0700 Created attachment 53847 fix patch 214786 14 53847 hausmann 2010-04-20 11:17:09 -0700 Comment on attachment 53847 fix patch Thanks Chang! 215269 15 53847 commit-queue 2010-04-21 06:08:22 -0700 Comment on attachment 53847 fix patch Clearing flags on attachment: 53847 Committed r57972: <http://trac.webkit.org/changeset/57972> 215270 16 commit-queue 2010-04-21 06:08:30 -0700 All reviewed patches have been landed. Closing bug. 216973 17 hausmann 2010-04-26 03:39:45 -0700 (In reply to comment #15) > (From update of attachment 53847 [details]) > Clearing flags on attachment: 53847 > > Committed r57972: <http://trac.webkit.org/changeset/57972> This patch is scheduled for integration into the 2.0 branch, but the earlier patches that implement this feature are not part of the branch. Do we really need to include another feature in the release branch? 217066 18 laszlo.gombos 2010-04-26 06:50:14 -0700 Simon, this is not needed for the 2.0 branch. If I read the history of the bug correctly, you added the 35784 blocker to this. 217128 19 hausmann 2010-04-26 09:07:36 -0700 (In reply to comment #18) > Simon, this is not needed for the 2.0 branch. If I read the history of the bug > correctly, you added the 35784 blocker to this. Hehe, thanks *gets the brown paper bag* 53158 2010-04-12 01:22:04 -0700 2010-04-12 01:36:05 -0700 Compile if QT_NO_SYSTEMTRAYICON is defined notification.patch text/plain 2619 ismail ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggMTgwYzdhZi4uMWY2YTRhMSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTQw Myw3ICs0MDMsNyBAQCBRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZShRV2ViUGFnZSAq cXEpCiAKICAgICBQYWdlR3JvdXA6OnNldFNob3VsZFRyYWNrVmlzaXRlZExpbmtzKHRydWUpOwog ICAgIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSAgICAKKyNpZiBFTkFCTEUoTk9USUZJQ0FU SU9OUykgJiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAgICAgbm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50ID0gbmV3IE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0KCk7CiAj ZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IDJkMWViYzEuLjI4NTBiNWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA0 LTEyICDEsHNtYWlsIETDtm5tZXogIDxpc21haWxAbmFtdHJhYy5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggY29tcGlsYXRpb24g d2l0aCBzeXN0ZW0gdHJheSBkaXNhYmxlZC4KKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6 CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwOgorICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5oOgorCiAyMDEwLTA0LTExICBT aGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByNTc0NjguCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudFF0LmNwcAppbmRleCA2Mjg2YzUxLi40ZWRjMzMxIDEwMDY0NAotLS0gYS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAgLTQ3NCw3ICs0NzQsNyBAQCB2b2lk IENocm9tZUNsaWVudFF0OjpyZWFjaGVkTWF4QXBwQ2FjaGVTaXplKGludDY0X3QpCiB9CiAjZW5k aWYKIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQorI2lmIEVOQUJMRShOT1RJRklDQVRJT05T KSAmJiAhZGVmaW5lZChRVF9OT19TWVNURU1UUkFZSUNPTikKIE5vdGlmaWNhdGlvblByZXNlbnRl ciogQ2hyb21lQ2xpZW50UXQ6Om5vdGlmaWNhdGlvblByZXNlbnRlcigpIGNvbnN0CiB7CiAgICAg cmV0dXJuIG1fd2ViUGFnZS0+ZC0+bm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50OwpkaWZmIC0t Z2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVu dFF0LmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJD bGllbnRRdC5jcHAKaW5kZXggMjZlOGZlNy4uMGE2MjdjMSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAorKysgYi9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3Bw CkBAIC00OCw3ICs0OCw3IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHVtcF9ub3RpZmljYXRp b24oYm9vbCBiKQogICAgIGR1bXBOb3RpZmljYXRpb24gPSBiOwogfQogCi0jaWYgRU5BQkxFKE5P VElGSUNBVElPTlMpCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpICYmICFkZWZpbmVkKFFUX05P X1NZU1RFTVRSQVlJQ09OKQogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApkaWZmIC0tZ2l0 IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0 LmggYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50 UXQuaAppbmRleCBjMzFiYTU3Li5iYjA5MzdmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29y ZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuaAorKysgYi9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuaApAQCAtMzQsNyAr MzQsNyBAQAogCiAjaW5jbHVkZSA8UVN5c3RlbVRyYXlJY29uPgogCi0jaWYgRU5BQkxFKE5PVElG SUNBVElPTlMpCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpICYmICFkZWZpbmVkKFFUX05PX1NZ U1RFTVRSQVlJQ09OKQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBEb2N1bWVudDsK 53159 2010-04-12 01:36:05 -0700 2010-04-12 01:38:58 -0700 Implement WebCore::ChromeClient::notificationPresenter() in all cases notification.patch text/plain 3323 ismail ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggMTgwYzdhZi4uMWY2YTRhMSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTQw Myw3ICs0MDMsNyBAQCBRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZShRV2ViUGFnZSAq cXEpCiAKICAgICBQYWdlR3JvdXA6OnNldFNob3VsZFRyYWNrVmlzaXRlZExpbmtzKHRydWUpOwog ICAgIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSAgICAKKyNpZiBFTkFCTEUoTk9USUZJQ0FU SU9OUykgJiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAgICAgbm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50ID0gbmV3IE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0KCk7CiAj ZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IDJkMWViYzEuLjVmMzQ4M2YgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA0 LTEyICDEsHNtYWlsIETDtm5tZXogIDxpc21haWxAaW50ZWxsaWdlbnRwYXBlcnMuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGNv bXBpbGF0aW9uIHdpdGggc3lzdGVtIHRyYXkgZGlzYWJsZWQuCisKKyAgICAgICAgKiBBcGkvcXdl YnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUpOgor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5oOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5oOgorCiAyMDEwLTA0LTExICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNTc0NjguCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudFF0LmNwcAppbmRleCA2Mjg2YzUxLi4zMWVkMTIwIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAgLTQ3NCwxMiArNDc0LDE0IEBAIHZvaWQg Q2hyb21lQ2xpZW50UXQ6OnJlYWNoZWRNYXhBcHBDYWNoZVNpemUoaW50NjRfdCkKIH0KICNlbmRp ZgogCi0jaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCiBOb3RpZmljYXRpb25QcmVzZW50ZXIqIENo cm9tZUNsaWVudFF0Ojpub3RpZmljYXRpb25QcmVzZW50ZXIoKSBjb25zdAogeworI2lmIEVOQUJM RShOT1RJRklDQVRJT05TKSAmJiAhZGVmaW5lZChRVF9OT19TWVNURU1UUkFZSUNPTikKICAgICBy ZXR1cm4gbV93ZWJQYWdlLT5kLT5ub3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnQ7Ci19CisjZWxz ZQorICAgIHJldHVybiBOVUxMOwogI2VuZGlmCit9CiAKIHZvaWQgQ2hyb21lQ2xpZW50UXQ6OnJ1 bk9wZW5QYW5lbChGcmFtZSogZnJhbWUsIFBhc3NSZWZQdHI8RmlsZUNob29zZXI+IHBycEZpbGVD aG9vc2VyKQogewpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudFF0LmggYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuaAppbmRl eCA4NWViODU0Li5mNmMxNmE4IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv Q2hyb21lQ2xpZW50UXQuaAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50UXQuaApAQCAtMTI4LDkgKzEyOCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg dmlydHVhbCB2b2lkIHJlYWNoZWRNYXhBcHBDYWNoZVNpemUoaW50NjRfdCBzcGFjZU5lZWRlZCk7 CiAjZW5kaWYKIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQogICAgICAgICB2aXJ0dWFsIE5v dGlmaWNhdGlvblByZXNlbnRlciogbm90aWZpY2F0aW9uUHJlc2VudGVyKCkgY29uc3Q7Ci0jZW5k aWYKIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAgICAgLy8gc2VlIENo cm9tZUNsaWVudC5oCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZp Y2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05v dGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAppbmRleCAyNmU4ZmU3Li4wYTYyN2MxIDEw MDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVy Q2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25Q cmVzZW50ZXJDbGllbnRRdC5jcHAKQEAgLTQ4LDcgKzQ4LDcgQEAgdm9pZCBRV0VCS0lUX0VYUE9S VCBxdF9kdW1wX25vdGlmaWNhdGlvbihib29sIGIpCiAgICAgZHVtcE5vdGlmaWNhdGlvbiA9IGI7 CiB9CiAKLSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9O UykgJiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAKIHVzaW5nIG5hbWVzcGFjZSBX ZWJDb3JlOwogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0 aW9uUHJlc2VudGVyQ2xpZW50UXQuaCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmlj YXRpb25QcmVzZW50ZXJDbGllbnRRdC5oCmluZGV4IGMzMWJhNTcuLmJiMDkzN2YgMTAwNjQ0Ci0t LSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRR dC5oCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJD bGllbnRRdC5oCkBAIC0zNCw3ICszNCw3IEBACiAKICNpbmNsdWRlIDxRU3lzdGVtVHJheUljb24+ CiAKLSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykg JiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IGNsYXNzIERvY3VtZW50Owo= 53160 2010-04-12 01:38:58 -0700 2010-04-20 11:08:12 -0700 Fix style error notification.patch text/plain 3320 ismail ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggMTgwYzdhZi4uMWY2YTRhMSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTQw Myw3ICs0MDMsNyBAQCBRV2ViUGFnZVByaXZhdGU6OlFXZWJQYWdlUHJpdmF0ZShRV2ViUGFnZSAq cXEpCiAKICAgICBQYWdlR3JvdXA6OnNldFNob3VsZFRyYWNrVmlzaXRlZExpbmtzKHRydWUpOwog ICAgIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSAgICAKKyNpZiBFTkFCTEUoTk9USUZJQ0FU SU9OUykgJiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAgICAgbm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50ID0gbmV3IE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0KCk7CiAj ZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IDJkMWViYzEuLjVmMzQ4M2YgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA0 LTEyICDEsHNtYWlsIETDtm5tZXogIDxpc21haWxAaW50ZWxsaWdlbnRwYXBlcnMuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRml4IGNv bXBpbGF0aW9uIHdpdGggc3lzdGVtIHRyYXkgZGlzYWJsZWQuCisKKyAgICAgICAgKiBBcGkvcXdl YnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUpOgor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5oOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0 L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5oOgorCiAyMDEwLTA0LTExICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByNTc0NjguCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudFF0LmNwcAppbmRleCA2Mjg2YzUxLi4zMWVkMTIwIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAKQEAgLTQ3NCwxMiArNDc0LDE0IEBAIHZvaWQg Q2hyb21lQ2xpZW50UXQ6OnJlYWNoZWRNYXhBcHBDYWNoZVNpemUoaW50NjRfdCkKIH0KICNlbmRp ZgogCi0jaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCiBOb3RpZmljYXRpb25QcmVzZW50ZXIqIENo cm9tZUNsaWVudFF0Ojpub3RpZmljYXRpb25QcmVzZW50ZXIoKSBjb25zdAogeworI2lmIEVOQUJM RShOT1RJRklDQVRJT05TKSAmJiAhZGVmaW5lZChRVF9OT19TWVNURU1UUkFZSUNPTikKICAgICBy ZXR1cm4gbV93ZWJQYWdlLT5kLT5ub3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnQ7Ci19CisjZWxz ZQorICAgIHJldHVybiAwOwogI2VuZGlmCit9CiAKIHZvaWQgQ2hyb21lQ2xpZW50UXQ6OnJ1bk9w ZW5QYW5lbChGcmFtZSogZnJhbWUsIFBhc3NSZWZQdHI8RmlsZUNob29zZXI+IHBycEZpbGVDaG9v c2VyKQogewpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVu dFF0LmggYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50UXQuaAppbmRleCA4 NWViODU0Li5mNmMxNmE4IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50UXQuaAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 UXQuaApAQCAtMTI4LDkgKzEyOCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmly dHVhbCB2b2lkIHJlYWNoZWRNYXhBcHBDYWNoZVNpemUoaW50NjRfdCBzcGFjZU5lZWRlZCk7CiAj ZW5kaWYKIAotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQogICAgICAgICB2aXJ0dWFsIE5vdGlm aWNhdGlvblByZXNlbnRlciogbm90aWZpY2F0aW9uUHJlc2VudGVyKCkgY29uc3Q7Ci0jZW5kaWYK IAogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAgICAgLy8gc2VlIENocm9t ZUNsaWVudC5oCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0 aW9uUHJlc2VudGVyQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlm aWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAppbmRleCAyNmU4ZmU3Li4wYTYyN2MxIDEwMDY0 NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xp ZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVz ZW50ZXJDbGllbnRRdC5jcHAKQEAgLTQ4LDcgKzQ4LDcgQEAgdm9pZCBRV0VCS0lUX0VYUE9SVCBx dF9kdW1wX25vdGlmaWNhdGlvbihib29sIGIpCiAgICAgZHVtcE5vdGlmaWNhdGlvbiA9IGI7CiB9 CiAKLSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykg JiYgIWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJD b3JlOwogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9u UHJlc2VudGVyQ2xpZW50UXQuaCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRp b25QcmVzZW50ZXJDbGllbnRRdC5oCmluZGV4IGMzMWJhNTcuLmJiMDkzN2YgMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdC5o CisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGll bnRRdC5oCkBAIC0zNCw3ICszNCw3IEBACiAKICNpbmNsdWRlIDxRU3lzdGVtVHJheUljb24+CiAK LSNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykgJiYg IWRlZmluZWQoUVRfTk9fU1lTVEVNVFJBWUlDT04pCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNs YXNzIERvY3VtZW50Owo= 53847 2010-04-20 11:08:12 -0700 2010-04-21 06:08:22 -0700 fix patch bug37442_1.patch text/plain 1827 cshu SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTc4OTcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjAgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBGaXggU3ltYmlhbiBidWlsZCB3aGVyZSBRVF9OT19TWVNURU1UUkFZSUNPTiBpcyBk ZWZpbmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mzc0NDIKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNs aWVudFF0LmNwcDoKKyAgICAgICAgKE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpzaG93 KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRR dC5oOgorCiAyMDEwLTA0LTE5ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVz ZW50ZXJDbGllbnRRdC5jcHAJKHJldmlzaW9uIDU3Nzk0KQorKysgV2ViS2l0L3F0L1dlYkNvcmVT dXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjcsMTAgKzY3LDExIEBAIGJvb2wgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQ6OnNo b3cKICAgICAgICAgICAgICAgICBRU3RyaW5nKG5vdGlmaWNhdGlvbi0+Y29udGVudHMoKS5ib2R5 KCkpLnRvVXRmOCgpLmNvbnN0RGF0YSgpKTsKICAgICAgICAgfQogICAgIH0KLSAgICAgICAgICAg IAorCisjaWZuZGVmIFFUX05PX1NZU1RFTVRSQVlJQ09OCiAgICAgbV90cmF5LnNob3coKTsKICAg ICBtX3RyYXkuc2hvd01lc3NhZ2Uobm90aWZpY2F0aW9uLT5jb250ZW50cygpLnRpdGxlKCksIG5v dGlmaWNhdGlvbi0+Y29udGVudHMoKS5ib2R5KCksIFFTeXN0ZW1UcmF5SWNvbjo6SW5mb3JtYXRp b24pOwotCisjZW5kaWYKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApJbmRleDogV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0 LmgJKHJldmlzaW9uIDU3Nzk0KQorKysgV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNh dGlvblByZXNlbnRlckNsaWVudFF0LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDkgQEAg cHVibGljOgogICAgIHZpcnR1YWwgTm90aWZpY2F0aW9uUHJlc2VudGVyOjpQZXJtaXNzaW9uIGNo ZWNrUGVybWlzc2lvbihjb25zdCBLVVJMJik7CiAKIHByaXZhdGU6IAorI2lmbmRlZiBRVF9OT19T WVNURU1UUkFZSUNPTgogICAgIFFTeXN0ZW1UcmF5SWNvbiBtX3RyYXk7CisjZW5kaWYKIH07CiB9 CiAK