37434 2010-04-11 21:58:05 -0700 [WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1 2010-05-04 02:03:40 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 38511 0 skyul webkit-unassigned commit-queue joybro201 laszlo.gombos paroga oldest_to_newest 211538 0 skyul 2010-04-11 21:58:05 -0700 Windows CE supports little-endian format only, so don't define WTF_CPU_MIDDLE_ENDIAN=1. Otherwise, it causes a crash in dtoa. 211539 1 53145 skyul 2010-04-11 22:04:44 -0700 Created attachment 53145 Patch MSDN mentions that Windows CE supports little-endian format only. http://msdn.microsoft.com/en-us/library/ms905093.aspx 212252 2 laszlo.gombos 2010-04-13 23:14:27 -0700 Should we define __ARM_EABI__ for WinCE instead ? 212735 3 skyul 2010-04-14 21:14:14 -0700 (In reply to comment #2) > Should we define __ARM_EABI__ for WinCE instead ? We can add __ARM_EABI__ to the preprocessor definition in MSVC project or vsprops. However, as we don't have a build system for WinCE, I think it is better to keep the guard here. It seems Android does the same thing. Who defines __ARM_EABI__ in other platforms? 213243 4 paroga 2010-04-16 03:54:19 -0700 I did the same patch in my working copy too, but didn't find the MSDN entry about the little-endian format ;-). I think this patch is ok since ANDROID does the same "hack" and we don't have a WinCE buildsystem in the moment. 213907 5 53145 laszlo.gombos 2010-04-18 21:51:26 -0700 Comment on attachment 53145 Patch r=me. 213908 6 53145 commit-queue 2010-04-18 22:13:36 -0700 Comment on attachment 53145 Patch Clearing flags on attachment: 53145 Committed r57804: <http://trac.webkit.org/changeset/57804> 213909 7 commit-queue 2010-04-18 22:13:41 -0700 All reviewed patches have been landed. Closing bug. 53145 2010-04-11 22:04:44 -0700 2010-04-18 22:13:36 -0700 Patch endian.patch text/plain 1033 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3NDY5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMTEgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIERvbid0IGRlZmluZSBXVEZfQ1BVX01JRERM RV9FTkRJQU49MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mzc0MzQKKworICAgICAgICBXaW5kb3dzIENFIHN1cHBvcnRzIGxpdHRsZS1lbmRpYW4gZm9y bWF0IG9ubHksIHNvIGRvbid0IGRlZmluZQorICAgICAgICBXVEZfQ1BVX01JRERMRV9FTkRJQU49 MS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEwLTA0LTExICBNYXJrIFJvd2Ug IDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5k ZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA1NzQ2OCkKKysrIEphdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMDIsNiArMjAyLDcgQEAKICNlbGlm ICFkZWZpbmVkKF9fQVJNX0VBQklfXykgXAogICAgICYmICFkZWZpbmVkKF9fRUFCSV9fKSBcCiAg ICAgJiYgIWRlZmluZWQoX19WRlBfRlBfXykgXAorICAgICYmICFkZWZpbmVkKF9XSU4zMl9XQ0Up IFwKICAgICAmJiAhZGVmaW5lZChBTkRST0lEKQogI2RlZmluZSBXVEZfQ1BVX01JRERMRV9FTkRJ QU4gMQogCg==