37415 2010-04-11 11:20:13 -0700 Minor Updates and Cleanup to the Contributing Page 2010-04-11 11:52:12 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue eric oldest_to_newest 211379 0 joepeck 2010-04-11 11:20:13 -0700 While trying to bring someone up to speed with contributing I noticed some minor issues on the page. 211381 1 53094 joepeck 2010-04-11 11:24:38 -0700 Created attachment 53094 [PATCH] Minor Cleanup The cleanup includes: - update the test warning line to the new format that prepare-ChangeLog produces - <code> wrap a prepare-ChangeLog reference - use the more popular ":" instead of "--" before an example 211382 2 53094 eric 2010-04-11 11:28:46 -0700 Comment on attachment 53094 [PATCH] Minor Cleanup Thanks. These got out of sync a while ago. 211383 3 eric 2010-04-11 11:29:42 -0700 I think our current "OOPS" behavior is very confusing to contributers, but we should at least document it. When I changed it before to what you see on the contributing.html page, the consensus was there was too much "yelling" in the template, so it was changed back to the OOPS behavior. 211395 4 53094 commit-queue 2010-04-11 11:52:06 -0700 Comment on attachment 53094 [PATCH] Minor Cleanup Clearing flags on attachment: 53094 Committed r57452: <http://trac.webkit.org/changeset/57452> 211396 5 commit-queue 2010-04-11 11:52:12 -0700 All reviewed patches have been landed. Closing bug. 53094 2010-04-11 11:24:38 -0700 2010-04-11 11:52:06 -0700 [PATCH] Minor Cleanup contrib-cleanup.patch text/plain 2473 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggYTdmZDgyOC4uZTZiNjM5MCAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNC0xMSAg Sm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pbm9yIFVwZGF0ZXMgYW5kIENsZWFudXAg dG8gdGhlIENvbnRyaWJ1dGluZyBQYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNzQxNQorCisgICAgICAgICogY29kaW5nL2NvbnRyaWJ1dGluZy5o dG1sOgorCiAyMDEwLTA0LTA3ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAK ICAgICAgICAgKE5vdCByZXZpZXdlZC4pCmRpZmYgLS1naXQgYS9XZWJLaXRTaXRlL2NvZGluZy9j b250cmlidXRpbmcuaHRtbCBiL1dlYktpdFNpdGUvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sCmlu ZGV4IDI3ZTc1MDMuLjkzOGJlZTcgMTAwNjQ0Ci0tLSBhL1dlYktpdFNpdGUvY29kaW5nL2NvbnRy aWJ1dGluZy5odG1sCisrKyBiL1dlYktpdFNpdGUvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sCkBA IC0xMjAsNyArMTIwLDcgQEAgY29tbWFuZC48L3A+CiAKIDxwPlRoZXJlIGlzIG9uZSBDaGFuZ2VM b2cgcGVyIHRvcC1sZXZlbCBkaXJlY3RvcnksIGlmIHlvdSBjaGFuZ2VkIGNvZGUgYW5kIHRlc3Rz IHlvdSB3aWxsIG5lZWQgdG8gZWRpdCBhdCBsZWFzdCB0d28gQ2hhbmdlTG9ncy4gVGhlIDxjb2Rl PnByZXBhcmUtQ2hhbmdlTG9nPC9jb2RlPiBzY3JpcHQgd2lsbCBjcmVhdGUgYSBzdHViIGVudHJp ZXMgZm9yIHlvdS4gIFlvdSBzaG91bGQgZWRpdCB0aGVzZSBzdHVicyB0byBkZXNjcmliZSB5b3Vy IGNoYW5nZSwgaW5jbHVkaW5nIHRoZSBmdWxsIHVybCB0byB0aGUgYnVnICg8YSBocmVmPSJodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC80MzI1OSI+ZXhhbXBsZSBlbnRyeTwvYT4sIG5v dGUgdGhhdCB5b3UgY2FuIHVzZSA8Y29kZT4tLWJ1ZzwvY29kZT4gZmxhZykuICAoWW91IHNob3Vs ZCBzZXQgRU1BSUxfQUREUkVTUyBhbmQgQ0hBTkdFX0xPR19OQU1FIGluIHlvdXIgZW52aXJvbm1l bnQgaWYgeW91IHdpbGwgYmUgcnVubmluZyB0aGlzIHNjcmlwdCBmcmVxdWVudGx5Lik8L3A+CiAK LTxwPlRoZSBsaW5lIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRCBhcHBl YXJzIGlmIHByZXBhcmUtQ2hhbmdlTG9nIGRpZCBub3QgZGV0ZWN0IHRoZSBhZGRpdGlvbiBvZiB0 ZXN0IGNhc2VzLiAgSWYgeW91ciBwYXRjaCBkb2VzIG5vdCByZXF1aXJlIHRlc3QgY2FzZXMgKG9y IHRlc3QgY2FzZXMgYXJlIG5vdCBwb3NzaWJsZSksIHlvdSBzaG91bGQgaW5jbHVkZSBhIGxpbmUg c3RhdGluZyBzdWNoLiAgT3RoZXJ3aXNlIGFsbCBjaGFuZ2VzIHJlcXVpcmUgdGVzdCBjYXNlcyB3 aGljaCBzaG91bGQgYmUgbWVudGlvbmVkIGluIHRoZSBDaGFuZ2VMb2cuPC9wPgorPHA+VGhlICJO byBuZXcgdGVzdHMuIChPT1BTISkiIGxpbmUgYXBwZWFycyBpZiA8Y29kZT5wcmVwYXJlLUNoYW5n ZUxvZzwvY29kZT4gZGlkIG5vdCBkZXRlY3QgdGhlIGFkZGl0aW9uIG9mIHRlc3QgY2FzZXMuICBJ ZiB5b3VyIHBhdGNoIGRvZXMgbm90IHJlcXVpcmUgdGVzdCBjYXNlcyAob3IgdGVzdCBjYXNlcyBh cmUgbm90IHBvc3NpYmxlKSwgeW91IHNob3VsZCBpbmNsdWRlIGEgbGluZSBzdGF0aW5nIHN1Y2gu ICBPdGhlcndpc2UgYWxsIGNoYW5nZXMgcmVxdWlyZSB0ZXN0IGNhc2VzIHdoaWNoIHNob3VsZCBi ZSBtZW50aW9uZWQgaW4gdGhlIENoYW5nZUxvZy48L3A+CiAKIDxoMz5DcmVhdGUgdGhlIHBhdGNo PC9oMz4KIDxwPldlYktpdCB1c2VzIDxjb2RlPnN2bi1jcmVhdGUtcGF0Y2g8L2NvZGU+IHRvIGNy ZWF0ZSBwYXRjaGVzLiBUaGUKQEAgLTEzMSw3ICsxMzEsNyBAQCB0byBtYWtlIHN1cmUgbm8gY2hh bmdlcyBhcmUgbGVmdCBvdXQgb2YgeW91ciBwYXRjaC4gSXQgaXMgbm90IG5lY2Vzc2FyeSB0bwog YnJlYWsgYSBwYXRjaCBpbnRvIG11bHRpcGxlIGZpbGVzLjwvcD4KIAogPHA+VGhlIDxjb2RlPnN2 bi1jcmVhdGUtcGF0Y2g8L2NvZGU+IHNjcmlwdCBkb2VzIG5vdCBjcmVhdGUgYSBmaWxlIGF1dG9t YXRpY2FsbHkuCi1Zb3UgbmVlZCB0byByZWRpcmVjdCB0aGUgb3V0cHV0IHlvdXJzZWxmIHVzaW5n IHNvbWV0aGluZyBsaWtlLS08L3A+CitZb3UgbmVlZCB0byByZWRpcmVjdCB0aGUgb3V0cHV0IHlv dXJzZWxmIHVzaW5nIHNvbWV0aGluZyBsaWtlOjwvcD4KIDxwIGNsYXNzPSJjb2RlIj5zdm4tY3Jl YXRlLXBhdGNoID4gTXlFeGNlbGxlbnRQYXRjaC50eHQ8L3A+CiAKIDxoMyBpZD0ic3VibWl0Ij5T dWJtaXQgeW91ciBwYXRjaDwvaDM+Cg==