37411 2010-04-11 07:53:43 -0700 [Haiku] Improve SimpleFontDataHaiku implementation 2010-04-22 00:30:15 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 superstippi webkit-unassigned commit-queue oldest_to_newest 211358 0 superstippi 2010-04-11 07:53:43 -0700 * Removed a hack and replaced it with existing UTF8 encoding infrastructure. * Fixed a memory leak. 211359 1 53089 superstippi 2010-04-11 07:55:37 -0700 Created attachment 53089 [Haiku] Improve SimpleFontDataHaiku.cpp 212221 2 53089 commit-queue 2010-04-13 22:15:00 -0700 Comment on attachment 53089 [Haiku] Improve SimpleFontDataHaiku.cpp Rejecting patch 53089 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12673 test cases. fast/events/platform-wheelevent-in-scrolling-div.html -> failed Exiting early after 1 failures. 6453 tests run. 117.11s total testing time 6452 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 2 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1601449 215624 3 53089 eric 2010-04-21 18:26:10 -0700 Comment on attachment 53089 [Haiku] Improve SimpleFontDataHaiku.cpp Flaky test. 215752 4 53089 commit-queue 2010-04-22 00:30:09 -0700 Comment on attachment 53089 [Haiku] Improve SimpleFontDataHaiku.cpp Clearing flags on attachment: 53089 Committed r58068: <http://trac.webkit.org/changeset/58068> 215753 5 commit-queue 2010-04-22 00:30:15 -0700 All reviewed patches have been landed. Closing bug. 53089 2010-04-11 07:55:37 -0700 2010-04-22 00:30:08 -0700 [Haiku] Improve SimpleFontDataHaiku.cpp SimpleFontDataHaiku.diff text/plain 3283 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzQ0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMDQtMTEgIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlA Z214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtIYWlrdV0gSW1wcm92ZSBTaW1wbGVGb250RGF0YUhhaWt1CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzQxMQorCisgICAgICAgIENvdmVyZWQgYnkg ZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYWlrdS9TaW1w bGVGb250RGF0YUhhaWt1LmNwcDoKKyAgICAgICAgICAgIC0gQ2xlYW5lZCB1cCBpbmNsdWRlcwor ICAgICAgICAgICAgLSBSZW1vdmVkIHByb3RvdHlwZSAiY2hhclVuaWNvZGVUb1VURjhIQUNLIgor ICAgICAgICAoV2ViQ29yZTo6U2ltcGxlRm9udERhdGE6OnBsYXRmb3JtSW5pdCk6CisgICAgICAg ICAgICAtIFVzZSBjb25zdCBCRm9udCBwb2ludGVyCisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVG b250RGF0YTo6c21hbGxDYXBzRm9udERhdGEpOgorICAgICAgICAgICAgLSAiZm9udFBsYXRmb3Jt RGF0YSIgd2FzIGxlYWtlZC4gSXQgaXMgb25seQorICAgICAgICAgICAgICB1c2VkIGFzIHRoZSBr ZXkgZm9yIHRoZSBmb250IGNhY2hlIGxvb2t1cC4KKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUZv bnREYXRhOjpwbGF0Zm9ybU1ldHJpY3NGb3JHbHlwaCk6CisgICAgICAgICAgICAtIFVzZSBleGlz dGluZyBXZWJDb3JlIGVuY29kaW5nIGluZnJhc3RydWN0dXJlCisgICAgICAgICAgICAgIGluc3Rl YWQgb2YgYWRkaW5nIGEgaGFjayBmb3IgSGFpa3UuIAorCiAyMDEwLTA0LTEwICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJlbmFtZSBtX2Zv cmNlU2FuZGJveEZsYWdzIHRvIG1fZm9yY2VkU2FuZG94RmxhZ3MsIGFzCkluZGV4OiBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L1NpbXBsZUZvbnREYXRhSGFpa3UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3UvU2ltcGxlRm9udERhdGFIYWlr dS5jcHAJKHJldmlzaW9uIDU3Mjc0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYWlr dS9TaW1wbGVGb250RGF0YUhhaWt1LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQsMTggKzM0LDE1 IEBACiAjaW5jbHVkZSAiRm9udENhY2hlLmgiCiAjaW5jbHVkZSAiRm9udERlc2NyaXB0aW9uLmgi CiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKLSNpbmNsdWRlIDxSZWN0Lmg+Ci0jaW5jbHVk ZSA8dW5pY29kZS91Y2hhci5oPgotI2luY2x1ZGUgPHVuaWNvZGUvdW5vcm0uaD4KKyNpbmNsdWRl ICJUZXh0RW5jb2RpbmcuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIAotZXh0 ZXJuIGludCBjaGFyVW5pY29kZVRvVVRGOEhBQ0sodW5zaWduZWQgc2hvcnQsIGNoYXIqKTsKLQog bmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lkIFNpbXBsZUZvbnREYXRhOjpwbGF0Zm9ybUluaXQo KQogewotICAgIEJGb250KiBmb250ID0gbV9wbGF0Zm9ybURhdGEuZm9udCgpOworICAgIGNvbnN0 IEJGb250KiBmb250ID0gbV9wbGF0Zm9ybURhdGEuZm9udCgpOwogICAgIGlmICghZm9udCkKICAg ICAgICAgcmV0dXJuOwogCkBAIC03Niw4ICs3Myw4IEBAIFNpbXBsZUZvbnREYXRhKiBTaW1wbGVG b250RGF0YTo6c21hbGxDYXAKICAgICBpZiAoIW1fc21hbGxDYXBzRm9udERhdGEpIHsKICAgICAg ICAgRm9udERlc2NyaXB0aW9uIGRlc2MgPSBGb250RGVzY3JpcHRpb24oZm9udERlc2NyaXB0aW9u KTsKICAgICAgICAgZGVzYy5zZXRTcGVjaWZpZWRTaXplKDAuNzBmICogZm9udERlc2NyaXB0aW9u LmNvbXB1dGVkU2l6ZSgpKTsKLSAgICAgICAgY29uc3QgRm9udFBsYXRmb3JtRGF0YSogZm9udFBs YXRmb3JtRGF0YSA9IG5ldyBGb250UGxhdGZvcm1EYXRhKGRlc2MsIGRlc2MuZmFtaWx5KCkuZmFt aWx5KCkpOwotICAgICAgICBtX3NtYWxsQ2Fwc0ZvbnREYXRhID0gbmV3IFNpbXBsZUZvbnREYXRh KCpmb250UGxhdGZvcm1EYXRhKTsKKyAgICAgICAgRm9udFBsYXRmb3JtRGF0YSBmb250UGxhdGZv cm1EYXRhKGRlc2MsIGRlc2MuZmFtaWx5KCkuZmFtaWx5KCkpOworICAgICAgICBtX3NtYWxsQ2Fw c0ZvbnREYXRhID0gbmV3IFNpbXBsZUZvbnREYXRhKGZvbnRQbGF0Zm9ybURhdGEpOwogICAgIH0K ICAgICByZXR1cm4gbV9zbWFsbENhcHNGb250RGF0YTsKIH0KQEAgLTk1LDE1ICs5MiwxNCBAQCB2 b2lkIFNpbXBsZUZvbnREYXRhOjpkZXRlcm1pbmVQaXRjaCgpCiAKIEdseXBoTWV0cmljcyBTaW1w bGVGb250RGF0YTo6cGxhdGZvcm1NZXRyaWNzRm9yR2x5cGgoR2x5cGggZ2x5cGgsIEdseXBoTWV0 cmljc01vZGUpIGNvbnN0CiB7CisgICAgR2x5cGhNZXRyaWNzIG1ldHJpY3M7CiAgICAgaWYgKCFt X3BsYXRmb3JtRGF0YS5mb250KCkpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4g bWV0cmljczsKIAotICAgIGNoYXIgY2hhckFycmF5WzRdOworICAgIENTdHJpbmcgZW5jb2RlZCA9 IFVURjhFbmNvZGluZygpLmVuY29kZShzdGF0aWNfY2FzdDxVQ2hhcio+KCZnbHlwaCksIDEsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFVSTEVuY29kZWRFbnRp dGllc0ZvclVuZW5jb2RhYmxlcyk7CiAgICAgZmxvYXQgZXNjYXBlbWVudHNbMV07Ci0KLSAgICBj aGFyVW5pY29kZVRvVVRGOEhBQ0soZ2x5cGgsIGNoYXJBcnJheSk7Ci0gICAgbV9wbGF0Zm9ybURh dGEuZm9udCgpLT5HZXRFc2NhcGVtZW50cyhjaGFyQXJyYXksIDEsIGVzY2FwZW1lbnRzKTsKLSAg ICBHbHlwaE1ldHJpY3MgbWV0cmljczsKKyAgICBtX3BsYXRmb3JtRGF0YS5mb250KCktPkdldEVz Y2FwZW1lbnRzKGVuY29kZWQuZGF0YSgpLCAxLCBlc2NhcGVtZW50cyk7CiAgICAgbWV0cmljcy5o b3Jpem9udGFsQWR2YW5jZSA9IGVzY2FwZW1lbnRzWzBdICogbV9wbGF0Zm9ybURhdGEuZm9udCgp LT5TaXplKCk7CiAgICAgcmV0dXJuIG1ldHJpY3M7CiB9Cg==