37407 2010-04-11 00:34:15 -0700 Make commit-log-editor Rubber-stamp aware. And other minor cleanups. 2010-04-11 00:47:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned joepeck oldest_to_newest 211329 0 joepeck 2010-04-11 00:34:15 -0700 commit-log-editor doesn't treat a "Rubber-stamp by" like a "Reviewed by". This causes ugly output. 211331 1 53080 joepeck 2010-04-11 00:37:07 -0700 Created attachment 53080 [PATCH] Rubber Stamp support and Cleanup Handles the top 3 Rubber-stamp variants: "Rubber-stamped by" "Rubber stamped by" "Rubberstamped by" Also removes some old code, fixes style issues, and provides better error messages. 211332 2 53080 mrowe 2010-04-11 00:38:17 -0700 Comment on attachment 53080 [PATCH] Rubber Stamp support and Cleanup Sure, why not. 211335 3 joepeck 2010-04-11 00:47:22 -0700 Committed r57447 M WebKitTools/ChangeLog M WebKitTools/Scripts/commit-log-editor r57447 = 3242d4a0dd22da53cd7f7fd35de11fd0272a3489 (trunk) http://trac.webkit.org/changeset/57447 53080 2010-04-11 00:37:07 -0700 2010-04-11 00:38:16 -0700 [PATCH] Rubber Stamp support and Cleanup cleanup.patch text/plain 2172 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3YTNlYmJkLi43YmY2OGYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQt MTEgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGNvbW1pdC1sb2ctZWRpdG9y IFJ1YmJlci1zdGFtcCBhd2FyZS4gQW5kIG90aGVyIG1pbm9yIGNsZWFudXBzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc0MDcKKworICAgICAgICAq IFNjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3I6CisKIDIwMTAtMDQtMTAgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGF0dGVtcHQgdG8gZml4IHRo ZSBDaHJvbWl1bSBNYWMgY2FuYXJ5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9j b21taXQtbG9nLWVkaXRvciBiL1dlYktpdFRvb2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3IK aW5kZXggYTI2ZWJkNi4uZTAzMTFjNSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9j b21taXQtbG9nLWVkaXRvcgorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRp dG9yCkBAIC04OCw3ICs4OCw3IEBAIG15ICRpbkNoYW5nZXNUb0JlQ29tbWl0dGVkID0gIWlzR2l0 KCk7CiBteSBAY2hhbmdlTG9ncyA9ICgpOwogbXkgJGxvZ0NvbnRlbnRzID0gIiI7CiBteSAkZXhp c3RpbmdMb2cgPSAwOwotb3BlbiBMT0csICRsb2cgb3IgZGllOworb3BlbiBMT0csICRsb2cgb3Ig ZGllICJDb3VsZCBub3Qgb3BlbiB0aGUgbG9nIGZpbGUuIjsKIHdoaWxlICg8TE9HPikgewogICAg IGlmIChpc0dpdCgpKSB7CiAgICAgICAgIGlmICgvXiMgQ2hhbmdlcyB0byBiZSBjb21taXR0ZWQ6 JC8pIHsKQEAgLTE1NSw4ICsxNTUsOCBAQCBmb3IgbXkgJGNoYW5nZUxvZyAoQGNoYW5nZUxvZ3Mp IHsKICAgICAgICAgICAgICMgUmVtb3ZlIGluZGVudGF0aW9uIHNwYWNlcwogICAgICAgICAgICAg JGxpbmUgPX4gcy9eIHs4fS8vOwogCi0gICAgICAgICAgICAjIFNhdmUgdGhlIHJldmlld2VkIGJ5 IGxpbmUKLSAgICAgICAgICAgIGlmICgkbGluZSA9fiBtL15SZXZpZXdlZCBieSAuKi8pIHsKKyAg ICAgICAgICAgICMgU2F2ZSB0aGUgcmV2aWV3ZWQgLyBydWJiZXIgc3RhbXBlZCBieSBsaW5lLgor ICAgICAgICAgICAgaWYgKCRsaW5lID1+IG0vXlJldmlld2VkIGJ5IC4qLyB8fCAkbGluZSA9fiBt L15SdWJiZXJbIFwtXT9zdGFtcGVkIGJ5IC4qLykgewogICAgICAgICAgICAgICAgICRyZXZpZXdl ZEJ5TGluZSA9ICRsaW5lOwogICAgICAgICAgICAgICAgIG5leHQ7CiAgICAgICAgICAgICB9CkBA IC0xODgsNyArMTg4LDYgQEAgZm9yIG15ICRjaGFuZ2VMb2cgKEBjaGFuZ2VMb2dzKSB7CiAgICAg ICAgICAgICAgICAgJHJldmlld2VkQnlMaW5lID0gIiI7CiAgICAgICAgICAgICB9CiAKLQogICAg ICAgICAgICAgJGxpbmVDb3VudCsrOwogICAgICAgICAgICAgJGNvbnRlbnRzIC49ICRsaW5lOwog ICAgICAgICB9IGVsc2UgewpAQCAtMjA4LDEyICsyMDcsNiBAQCBmb3IgbXkgJGNoYW5nZUxvZyAo QGNoYW5nZUxvZ3MpIHsKICAgICBteSAkc29ydEtleSA9IGxjICRsYWJlbDsKICAgICBpZiAoJGxh YmVsIGVxICJ0b3AgbGV2ZWwiKSB7CiAgICAgICAgICRzb3J0S2V5ID0gIiI7Ci0gICAgfSBlbHNp ZiAoJGxhYmVsIGVxICJUb29scyIpIHsKLSAgICAgICAgJHNvcnRLZXkgPSAiLSwganVzdCBhZnRl ciB0b3AgbGV2ZWwiOwotICAgIH0gZWxzaWYgKCRsYWJlbCBlcSAiV2ViQnJvd3NlciIpIHsKLSAg ICAgICAgJHNvcnRLZXkgPSBsYyAiV2ViS2l0LCBXZWJCcm93c2VyIGFmdGVyIjsKLSAgICB9IGVs c2lmICgkbGFiZWwgZXEgIldlYkNvcmUiKSB7Ci0gICAgICAgICRzb3J0S2V5ID0gbGMgIldlYkZv dW5kYXRpb24sIFdlYkNvcmUgYWZ0ZXIiOwogICAgIH0gZWxzaWYgKCRsYWJlbCBlcSAiTGF5b3V0 VGVzdHMiKSB7CiAgICAgICAgICRzb3J0S2V5ID0gbGMgIn4sIExheW91dFRlc3RzIGxhc3QiOwog ICAgIH0K