37398 2010-04-10 17:43:23 -0700 Missing CONTEXT_MENUS Guards 2010-04-10 17:54:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned ddkilzer joepeck oldest_to_newest 211244 0 joepeck 2010-04-10 17:43:23 -0700 There are some missing ENABLE checks in WebCore. 211245 1 53064 joepeck 2010-04-10 17:45:43 -0700 Created attachment 53064 [PATCH] Add Missing Guards 211246 2 53064 ddkilzer 2010-04-10 17:49:36 -0700 Comment on attachment 53064 [PATCH] Add Missing Guards r=me 211247 3 joepeck 2010-04-10 17:53:06 -0700 Committed r57429 M WebCore/ChangeLog M WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp M WebCore/inspector/InspectorFrontendHost.cpp M WebCore/inspector/InspectorFrontendHost.h r57429 = 873870f3ac2b7b5e5570c6274668a630f5c7ca1c (trunk) http://trac.webkit.org/changeset/57429 53064 2010-04-10 17:45:43 -0700 2010-04-10 17:49:36 -0700 [PATCH] Add Missing Guards missing-guards.patch text/plain 3967 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmY1NmIxNS4uM2JiYzdiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0xMCAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE1pc3NpbmcgQ09OVEVYVF9NRU5VUyBHdWFyZHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3Mzk4CisKKyAgICAgICAg QWRkZWQgbWlzc2luZyBFTkFCTEUoQ09OVEVYVF9NRU5VUykgZ3VhcmRzLgorCisgICAgICAgICog YmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnNob3dDb250ZXh0TWVudSk6CisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JGcm9udGVuZEhvc3Q6Okluc3BlY3RvckZyb250ZW5kSG9zdCk6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmRpc2Nvbm5lY3RDbGllbnQpOgor ICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaDoKKwogMjAxMC0wNC0x MCAgU3RlcGhhbiBBw59tdXMgIDxzdXBlcnN0aXBwaUBnbXguZGU+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5z cGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNw ZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwCmluZGV4IDM0MGVmNDQuLjY5NGRjMjUgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20u Y3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0 b20uY3BwCkBAIC04MSw3ICs4MSw3IEBAIEpTVmFsdWUgSlNJbnNwZWN0b3JGcm9udGVuZEhvc3Q6 OnNob3dDb250ZXh0TWVudShFeGVjU3RhdGUqIGV4ZWNTdGF0ZSwgY29uc3QgQXJnCiB7CiAgICAg aWYgKGFyZ3Muc2l6ZSgpIDwgMikKICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0KKyNp ZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKICAgICBFdmVudCogZXZlbnQgPSB0b0V2ZW50KGFyZ3Mu YXQoMCkpOwogCiAgICAgSlNBcnJheSogYXJyYXkgPSBhc0FycmF5KGFyZ3MuYXQoMSkpOwpAQCAt MTAwLDYgKzEwMCw5IEBAIEpTVmFsdWUgSlNJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnNob3dDb250 ZXh0TWVudShFeGVjU3RhdGUqIGV4ZWNTdGF0ZSwgY29uc3QgQXJnCiAgICAgfQogCiAgICAgaW1w bCgpLT5zaG93Q29udGV4dE1lbnUoZXZlbnQsIGl0ZW1zKTsKKyNlbHNlCisgICAgVU5VU0VEX1BB UkFNKGV4ZWNTdGF0ZSk7CisjZW5kaWYKICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIH0KIApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcCBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKaW5kZXggZWI1Zjcy Zi4uNzBmYzNhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRl bmRIb3N0LmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3Qu Y3BwCkBAIC01NCw2ICs1NCw3IEBAIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAorI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQogY2xhc3MgRnJvbnRlbmRNZW51 UHJvdmlkZXIgOiBwdWJsaWMgQ29udGV4dE1lbnVQcm92aWRlciB7CiBwdWJsaWM6CiAgICAgc3Rh dGljIFBhc3NSZWZQdHI8RnJvbnRlbmRNZW51UHJvdmlkZXI+IGNyZWF0ZShJbnNwZWN0b3JGcm9u dGVuZEhvc3QqIGZyb250ZW5kSG9zdCwgU2NyaXB0T2JqZWN0IHdlYkluc3BlY3RvciwgY29uc3Qg VmVjdG9yPENvbnRleHRNZW51SXRlbSo+JiBpdGVtcykKQEAgLTExNSwxMSArMTE2LDE0IEBAIHBy aXZhdGU6CiAgICAgU2NyaXB0T2JqZWN0IG1fd2ViSW5zcGVjdG9yOwogICAgIFZlY3RvcjxDb250 ZXh0TWVudUl0ZW0qPiBtX2l0ZW1zOwogfTsKKyNlbmRpZgogCiBJbnNwZWN0b3JGcm9udGVuZEhv c3Q6Okluc3BlY3RvckZyb250ZW5kSG9zdChJbnNwZWN0b3JGcm9udGVuZENsaWVudCogY2xpZW50 LCBQYWdlKiBmcm9udGVuZFBhZ2UpCiAgICAgOiBtX2NsaWVudChjbGllbnQpCiAgICAgLCBtX2Zy b250ZW5kUGFnZShmcm9udGVuZFBhZ2UpCisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAgICAg LCBtX21lbnVQcm92aWRlcigwKQorI2VuZGlmCiB7CiB9CiAKQEAgLTEzMSw4ICsxMzUsMTAgQEAg SW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojp+SW5zcGVjdG9yRnJvbnRlbmRIb3N0KCkKIHZvaWQgSW5z cGVjdG9yRnJvbnRlbmRIb3N0OjpkaXNjb25uZWN0Q2xpZW50KCkKIHsKICAgICBtX2NsaWVudCA9 IDA7CisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAgICAgaWYgKG1fbWVudVByb3ZpZGVyKQog ICAgICAgICBtX21lbnVQcm92aWRlci0+ZGlzY29ubmVjdCgpOworI2VuZGlmCiAgICAgbV9mcm9u dGVuZFBhZ2UgPSAwOwogfQogCkBAIC0yMDEsNiArMjA3LDcgQEAgdm9pZCBJbnNwZWN0b3JGcm9u dGVuZEhvc3Q6OmNvcHlUZXh0KGNvbnN0IFN0cmluZyYgdGV4dCkKICAgICBQYXN0ZWJvYXJkOjpn ZW5lcmFsUGFzdGVib2FyZCgpLT53cml0ZVBsYWluVGV4dCh0ZXh0KTsKIH0KIAorI2lmIEVOQUJM RShDT05URVhUX01FTlVTKQogdm9pZCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnNob3dDb250ZXh0 TWVudShFdmVudCogZXZlbnQsIGNvbnN0IFZlY3RvcjxDb250ZXh0TWVudUl0ZW0qPiYgaXRlbXMp CiB7CiAgICAgQVNTRVJUKG1fZnJvbnRlbmRQYWdlKTsKQEAgLTIxNSw2ICsyMjIsNyBAQCB2b2lk IEluc3BlY3RvckZyb250ZW5kSG9zdDo6c2hvd0NvbnRleHRNZW51KEV2ZW50KiBldmVudCwgY29u c3QgVmVjdG9yPENvbnRleHRNZQogICAgIG1lbnVDb250cm9sbGVyLT5zaG93Q29udGV4dE1lbnUo ZXZlbnQsIG1lbnVQcm92aWRlcik7CiAgICAgbV9tZW51UHJvdmlkZXIgPSBtZW51UHJvdmlkZXIu Z2V0KCk7CiB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaCBiL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oCmluZGV4IGZlYjZmNzYuLjRkM2UwZDEgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5oCkBAIC03NywxMiArNzcs MTYgQEAgcHVibGljOgogICAgIHZvaWQgc2hvd0NvbnRleHRNZW51KEV2ZW50KiwgY29uc3QgVmVj dG9yPENvbnRleHRNZW51SXRlbSo+JiBpdGVtcyk7CiAKIHByaXZhdGU6CisjaWYgRU5BQkxFKENP TlRFWFRfTUVOVVMpCiAgICAgZnJpZW5kIGNsYXNzIEZyb250ZW5kTWVudVByb3ZpZGVyOworI2Vu ZGlmCiAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0KEluc3BlY3RvckZyb250ZW5kQ2xpZW50KiBj bGllbnQsIFBhZ2UqIGZyb250ZW5kUGFnZSk7CiAKICAgICBJbnNwZWN0b3JGcm9udGVuZENsaWVu dCogbV9jbGllbnQ7CiAgICAgUGFnZSogbV9mcm9udGVuZFBhZ2U7CisjaWYgRU5BQkxFKENPTlRF WFRfTUVOVVMpCiAgICAgRnJvbnRlbmRNZW51UHJvdmlkZXIqIG1fbWVudVByb3ZpZGVyOworI2Vu ZGlmCiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==