37390 2010-04-10 12:07:46 -0700 [GStreamer] Apple trailers not playing 2010-05-26 00:19:11 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 bugzilla webkit-unassigned chpe pnormand xan.lopez oldest_to_newest 211169 0 bugzilla 2010-04-10 12:07:46 -0700 1. Go to any Apple trailers page like: http://trailers.apple.com/trailers/paramount/dinnerforschmucks/ 2. Click on "Watch now" 3. Gray area pops up, and no movie Do the same thing in Firefox, with Totem's QuickTime-compatible NarrowSpace plugin, and it will work as expected. The builtin video support should only kick in when: - Playing in "full-screen" (when mode is NP_FULL) or - When a plug-in handling the mime-type is already available or (obviously) - When a video or audio tag is used 223373 1 pnormand 2010-05-10 10:07:45 -0700 It seems r56650 introduced this "bug". It enables proxying to a MediaElement. It actually works but the User-Agent is not set "apple-friendly" by the FrameLoader in this case and that's why you see nothing. Apple webserver sents a 302 response because of that ... user-agent filter they have. 223914 2 55701 pnormand 2010-05-11 07:18:26 -0700 Created attachment 55701 proposed patch 224205 3 bugzilla 2010-05-11 15:49:32 -0700 I don't agree with that patch one bit. The patch still doesn't allow for the controls to be used in the display, because the web page expects a plugin compatible with QuickTime, not builtin HTML5 video support. If I wanted that sort of patches to get into WebKit, I would have mentioned what the work-around was. I want WebKitGTK to stop taking over <embed> and <object> mime-types that are handled by plugins. 224655 4 pnormand 2010-05-12 08:50:36 -0700 See http://trailers.apple.com/trailers/global/scripts/lib/ac_media.js // added a check for Google Chrome; until they fix their .mov wrapper bug we can't serve the <video> element 135 if (shouldBuildMediaSpecVideo && Media._isHTML5VideoAvailable() && 136 !Media.Detection.Firefox() && !Media.Detection.Mobile() && 137 !Media.Detection.Chrome()) { 138 // Create <video> player 139 return build(Media.Spec.Video); 140 } 141 142 if (shouldBuildMediaSpecQuickTime && 143 Media._isQuickTimeAvailable(Media.MIN_QUICKTIME_VERSION) || 144 Media.Detection.Mobile()) { 145 // Create QuickTime player 146 return build(Media.Spec.QuickTime); 147 } So the logic is to check if the browser supports HTML5 video and video/mp4. If so a video element is created instead of an <object>... So, not sure what I can actually do. I won't blacklist video/mp4 from our player. Have you tried the patch? 225331 5 bugzilla 2010-05-13 08:56:43 -0700 (In reply to comment #4) > See http://trailers.apple.com/trailers/global/scripts/lib/ac_media.js > > // added a check for Google Chrome; until they fix their .mov wrapper bug we can't serve the <video> element <snip> > So the logic is to check if the browser supports HTML5 video and video/mp4. If so a video element is created instead of an <object>... So, not sure what I can actually do. I won't blacklist video/mp4 from our player. Have you tried the patch? Right, it's my mistake for thinking that WebKitGTK was taking over from the <embed> property. Are you sure that's what it's doing? I still don't understand why a User-agent matching *QuickTime* (as opposed to one matching the Safari version) would make a difference to the website, if you were using a <video> tag. 225336 6 pnormand 2010-05-13 09:15:26 -0700 (In reply to comment #5) > Right, it's my mistake for thinking that WebKitGTK was taking over from the <embed> property. Are you sure that's what it's doing? > Well yeah that's what I conclude. I could see in gdb that the video element is created from Javascript. I also tested with Chromium, no <video> element is created, likely because of the checks in that js script. I could be wrong but I didn't see any place in WebKit code where we replace an <object> with a <video> element. > I still don't understand why a User-agent matching *QuickTime* (as opposed to one matching the Safari version) would make a difference to the website, if you were using a <video> tag. That confused me too. I think we never correctly sent the "Quicktime" UA. I don't see how it could work in the current call order, there was no change in the frameloader changing the behavior. You currently only see a gray rectangle because our player get a 302 error from apple webserver, because we don't send the correct user-agent (I checked with wireshark). 225350 7 bugzilla 2010-05-13 09:50:34 -0700 Right. So the last problem is whether you want to hard-code a user-agent for a website into the webkit code. 230573 8 55701 gustavo 2010-05-25 21:21:13 -0700 Comment on attachment 55701 proposed patch Can I suggest renaming this bug report before committing, and making sure the changed name is reflected in the ChangeLog, since your investigation concluded it has nothing to do with WebKitGTK+ taking over from plugins? =) 230602 9 pnormand 2010-05-26 00:19:11 -0700 Thanks for the review Gustavo. Landed the patch in http://trac.webkit.org/changeset/60219 55701 2010-05-11 07:18:26 -0700 2010-05-25 21:21:12 -0700 proposed patch proposed-patch.patch text/plain 2455 pnormand RnJvbSA0MWQ0OTI4ODE2YzA2MGE0MWIxZmM2OTY4NGViNGJiNDEwYWVmZTI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDExIE1heSAyMDEwIDE2OjE3OjU0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHAgICAgICAgICB8ICAgMTAgKysrKysrLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRiNzdiYS4uNmRh YzRmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNS0xMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW0dUS10gU2hvdWxkbid0IHRha2Ugb3ZlciBRdWlja1RpbWUgcGx1Z2luCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzM5MAorCisgICAg ICAgIFNldCB0aGUgQXBwbGVUcmFpbGVyIFVzZXItQWdlbnQgd29ya2Fyb3VuZCBhZnRlcgorICAg ICAgICBGcmFtZUxvYWRlcjo6YWRkRXh0cmFGaWVsZHNUb1N1YnJlc291cmNlUmVxdWVzdCBoYXMg YmVlbiBjYWxsZWQKKyAgICAgICAgYmVjYXVzZSB0aGF0IG1ldGhvZCBzZXRzIHRoZSBnbG9iYWwg VXNlci1BZ2VudC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJL aXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAod2ViS2l0V2ViU3JjU3RhcnQpOgor CiAyMDEwLTA1LTEwICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBOb3QgcmV2aWV3ZWQ6IHJvbGxiYWNrIHRoZSBjb21taXQgcjU5MDYyCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VH U3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0 V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBkYWVlNTA2Li4xMjQ3NTA0IDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3Ry ZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTM4OCwxMCArMzg4LDYgQEAgc3RhdGljIGJvb2wg d2ViS2l0V2ViU3JjU3RhcnQoV2ViS2l0V2ViU3JjKiBzcmMpCiAgICAgcmVxdWVzdC5zZXRUYXJn ZXRUeXBlKFJlc291cmNlUmVxdWVzdEJhc2U6OlRhcmdldElzTWVkaWEpOwogICAgIHJlcXVlc3Qu c2V0QWxsb3dDb29raWVzKHRydWUpOwogCi0gICAgLy8gTGV0IEFwcGxlIHdlYiBzZXJ2ZXJzIGtu b3cgd2Ugd2FudCB0byBhY2Nlc3MgdGhlaXIgbmljZSBtb3ZpZSB0cmFpbGVycy4KLSAgICBpZiAo IWdfYXNjaWlfc3RyY2FzZWNtcCgibW92aWVzLmFwcGxlLmNvbSIsIHVybC5ob3N0KCkudXRmOCgp LmRhdGEoKSkpCi0gICAgICAgIHJlcXVlc3Quc2V0SFRUUFVzZXJBZ2VudCgiUXVpY2t0aW1lLzcu Mi4wIik7Ci0KICAgICBpZiAocHJpdi0+ZnJhbWUpIHsKICAgICAgICAgRG9jdW1lbnQqIGRvY3Vt ZW50ID0gcHJpdi0+ZnJhbWUtPmRvY3VtZW50KCk7CiAgICAgICAgIGlmIChkb2N1bWVudCkKQEAg LTQwMiw2ICszOTgsMTIgQEAgc3RhdGljIGJvb2wgd2ViS2l0V2ViU3JjU3RhcnQoV2ViS2l0V2Vi U3JjKiBzcmMpCiAgICAgICAgICAgICBsb2FkZXItPmFkZEV4dHJhRmllbGRzVG9TdWJyZXNvdXJj ZVJlcXVlc3QocmVxdWVzdCk7CiAgICAgfQogCisgICAgLy8gTGV0IEFwcGxlIHdlYiBzZXJ2ZXJz IGtub3cgd2Ugd2FudCB0byBhY2Nlc3MgdGhlaXIgbmljZSBtb3ZpZSB0cmFpbGVycy4KKyAgICBp ZiAoIWdfYXNjaWlfc3RyY2FzZWNtcCgibW92aWVzLmFwcGxlLmNvbSIsIHVybC5ob3N0KCkudXRm OCgpLmRhdGEoKSkKKyAgICAgICAgfHwgIWdfYXNjaWlfc3RyY2FzZWNtcCgidHJhaWxlcnMuYXBw bGUuY29tIiwgdXJsLmhvc3QoKS51dGY4KCkuZGF0YSgpKSkgeworICAgICAgICByZXF1ZXN0LnNl dEhUVFBVc2VyQWdlbnQoIlF1aWNrdGltZS83LjIuMCIpOworICAgIH0KKwogICAgIGlmIChwcml2 LT5yZXF1ZXN0ZWRPZmZzZXQpIHsKICAgICAgICAgR093blB0cjxnY2hhcj4gdmFsOwogCi0tIAox LjcuMQ==