37384 2010-04-10 04:55:13 -0700 [Haiku] Fix build of ImageHaiku.cpp 2010-04-10 14:31:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 superstippi webkit-unassigned commit-queue oldest_to_newest 211131 0 53035 superstippi 2010-04-10 04:55:13 -0700 Created attachment 53035 Fix build of HaikuImage.cpp ImageHaiku.cpp needs to include SharedBuffer.h Due to a mix up caused by resolving merge conflicts, I accidentally landed a patch that used the wrong parameter name for the "phase". 211132 1 53035 commit-queue 2010-04-10 04:58:28 -0700 Comment on attachment 53035 Fix build of HaikuImage.cpp Rejecting patch 53035 from commit-queue. superstippi@gmx.de does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 211133 2 53036 superstippi 2010-04-10 05:00:25 -0700 Created attachment 53036 Fix build of ImageHaiku.cpp Forgot to replace the bug ID in the ChangeLog URL. 211181 3 53036 eric 2010-04-10 14:15:41 -0700 Comment on attachment 53036 Fix build of ImageHaiku.cpp OK. 211186 4 53036 commit-queue 2010-04-10 14:31:03 -0700 Comment on attachment 53036 Fix build of ImageHaiku.cpp Clearing flags on attachment: 53036 Committed r57419: <http://trac.webkit.org/changeset/57419> 211187 5 commit-queue 2010-04-10 14:31:08 -0700 All reviewed patches have been landed. Closing bug. 53035 2010-04-10 04:55:13 -0700 2010-04-10 05:00:25 -0700 Fix build of HaikuImage.cpp HaikuImage.diff text/plain 1912 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMTAgIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlA Z214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtIYWlrdV0gRml4IGJ1aWxkIG9mIEltYWdlSGFpa3UuY3BwCisgICAgICAgIDxodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9WFhYWFg+CisKKyAgICAgICAgTm8gbmV3IHRl c3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L0ltYWdlSGFp a3UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToKKyAgICAgICAg ICAgIC0gaW5jbHVkZSBTaGFyZWRCdWZmZXIuaAorICAgICAgICAgICAgLSBjaGFuZ2VkIHBhcmFt ZXRlciBuYW1lIHRvIGJlIGluIGxpbmUgd2l0aCBvdGhlciBwb3J0cywKKyAgICAgICAgICAgICAg dGhlIGNvZGUgSSBsYW5kZWQgaW4gYW4gZWFybGllciBjb21taXQgd2FzIGFscmVhZHkgdXNpbmcK KyAgICAgICAgICAgICAgdGhpcyBuYW1lLgorCiAyMDEwLTA0LTA4ICBLZW50IFRhbXVyYSAgPHRr ZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3UvSW1hZ2VIYWlrdS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYWlrdS9JbWFnZUhhaWt1LmNwcAko cmV2aXNpb24gNTcyNzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L0ltYWdl SGFpa3UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBACiAjaW5jbHVkZSAiSW1h Z2VPYnNlcnZlci5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGxh dGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKICNpbmNsdWRlICJUcmFu c2Zvcm1hdGlvbk1hdHJpeC5oIgogI2luY2x1ZGUgPEFwcGxpY2F0aW9uLmg+CiAjaW5jbHVkZSA8 Qml0bWFwLmg+CkBAIC0xMjAsNyArMTIxLDcgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFw aGljc0NvbnRleHQqIAogICAgICAgICBpbWFnZU9ic2VydmVyKCktPmRpZERyYXcodGhpcyk7CiB9 CiAKLXZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29u c3QgRmxvYXRSZWN0JiB0aWxlUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJh bnNmb3JtLCBjb25zdCBGbG9hdFBvaW50JiBzcmNQb2ludCwgQ29sb3JTcGFjZSwgQ29tcG9zaXRl T3BlcmF0b3Igb3AsIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVjdCkKK3ZvaWQgSW1hZ2U6OmRyYXdQ YXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVj dCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmb3JtLCBjb25zdCBGbG9hdFBv aW50JiBwaGFzZSwgQ29sb3JTcGFjZSwgQ29tcG9zaXRlT3BlcmF0b3Igb3AsIGNvbnN0IEZsb2F0 UmVjdCYgZHN0UmVjdCkKIHsKICAgICBCQml0bWFwKiBpbWFnZSA9IG5hdGl2ZUltYWdlRm9yQ3Vy cmVudEZyYW1lKCk7CiAgICAgaWYgKCFpbWFnZSB8fCAhaW1hZ2UtPklzVmFsaWQoKSkgLy8gSWYg dGhlIGltYWdlIGhhc24ndCBmdWxseSBsb2FkZWQuCg== 53036 2010-04-10 05:00:25 -0700 2010-04-10 14:31:03 -0700 Fix build of ImageHaiku.cpp HaikuImage.diff text/plain 1912 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI3NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMTAgIFN0ZXBoYW4gQcOfbXVzICA8c3VwZXJzdGlwcGlA Z214LmRlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtIYWlrdV0gRml4IGJ1aWxkIG9mIEltYWdlSGFpa3UuY3BwCisgICAgICAgIDxodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzczODQ+CisKKyAgICAgICAgTm8gbmV3IHRl c3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L0ltYWdlSGFp a3UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2U6OmRyYXdQYXR0ZXJuKToKKyAgICAgICAg ICAgIC0gaW5jbHVkZSBTaGFyZWRCdWZmZXIuaAorICAgICAgICAgICAgLSBjaGFuZ2VkIHBhcmFt ZXRlciBuYW1lIHRvIGJlIGluIGxpbmUgd2l0aCBvdGhlciBwb3J0cywKKyAgICAgICAgICAgICAg dGhlIGNvZGUgSSBsYW5kZWQgaW4gYW4gZWFybGllciBjb21taXQgd2FzIGFscmVhZHkgdXNpbmcK KyAgICAgICAgICAgICAgdGhpcyBuYW1lLgorCiAyMDEwLTA0LTA4ICBLZW50IFRhbXVyYSAgPHRr ZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFpa3UvSW1hZ2VIYWlrdS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYWlrdS9JbWFnZUhhaWt1LmNwcAko cmV2aXNpb24gNTcyNzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhaWt1L0ltYWdl SGFpa3UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw2ICszOSw3IEBACiAjaW5jbHVkZSAiSW1h Z2VPYnNlcnZlci5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiUGxh dGZvcm1TdHJpbmcuaCIKKyNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKICNpbmNsdWRlICJUcmFu c2Zvcm1hdGlvbk1hdHJpeC5oIgogI2luY2x1ZGUgPEFwcGxpY2F0aW9uLmg+CiAjaW5jbHVkZSA8 Qml0bWFwLmg+CkBAIC0xMjAsNyArMTIxLDcgQEAgdm9pZCBCaXRtYXBJbWFnZTo6ZHJhdyhHcmFw aGljc0NvbnRleHQqIAogICAgICAgICBpbWFnZU9ic2VydmVyKCktPmRpZERyYXcodGhpcyk7CiB9 CiAKLXZvaWQgSW1hZ2U6OmRyYXdQYXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29u c3QgRmxvYXRSZWN0JiB0aWxlUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJh bnNmb3JtLCBjb25zdCBGbG9hdFBvaW50JiBzcmNQb2ludCwgQ29sb3JTcGFjZSwgQ29tcG9zaXRl T3BlcmF0b3Igb3AsIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVjdCkKK3ZvaWQgSW1hZ2U6OmRyYXdQ YXR0ZXJuKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiB0aWxlUmVj dCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmb3JtLCBjb25zdCBGbG9hdFBv aW50JiBwaGFzZSwgQ29sb3JTcGFjZSwgQ29tcG9zaXRlT3BlcmF0b3Igb3AsIGNvbnN0IEZsb2F0 UmVjdCYgZHN0UmVjdCkKIHsKICAgICBCQml0bWFwKiBpbWFnZSA9IG5hdGl2ZUltYWdlRm9yQ3Vy cmVudEZyYW1lKCk7CiAgICAgaWYgKCFpbWFnZSB8fCAhaW1hZ2UtPklzVmFsaWQoKSkgLy8gSWYg dGhlIGltYWdlIGhhc24ndCBmdWxseSBsb2FkZWQuCg==