37356 2010-04-09 13:33:56 -0700 StorageEvent destructor should be in StorageEvent.cpp 2010-04-09 18:56:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned commit-queue jorlow oldest_to_newest 210885 0 evan 2010-04-09 13:33:56 -0700 StorageEvent destructor should be in StorageEvent.cpp 210887 1 52985 evan 2010-04-09 13:36:35 -0700 Created attachment 52985 Patch 210888 2 52985 evan 2010-04-09 13:37:32 -0700 Comment on attachment 52985 Patch (This is needed to compile under Clang.) 210891 3 evan 2010-04-09 13:37:46 -0700 In file included from third_party/WebKit/WebCore/bindings/v8/custom/V8EventCustom.cpp:32: In file included from llvm/Debug/obj/gen/webkit/bindings/V8Event.h:25: In file included from third_party/WebKit/JavaScriptCore/wtf/HashMap.h:24: In file included from third_party/WebKit/JavaScriptCore/wtf/HashTable.h:26: In file included from third_party/WebKit/JavaScriptCore/wtf/HashTraits.h:24: In file included from third_party/WebKit/JavaScriptCore/wtf/HashFunctions.h:24: In file included from third_party/WebKit/JavaScriptCore/wtf/RefPtr.h:27: third_party/WebKit/JavaScriptCore/wtf/PassRefPtr.h:66:16: error: member access into incomplete type 'WebCore::Storage' ptr->deref(); ^ In file included from third_party/WebKit/WebCore/bindings/v8/custom/V8EventCustom.cpp:32: In file included from llvm/Debug/obj/gen/webkit/bindings/V8Event.h:25: In file included from third_party/WebKit/JavaScriptCore/wtf/HashMap.h:24: In file included from third_party/WebKit/JavaScriptCore/wtf/HashTable.h:26: In file included from third_party/WebKit/JavaScriptCore/wtf/HashTraits.h:24: In file included from third_party/WebKit/JavaScriptCore/wtf/HashFunctions.h:24: third_party/WebKit/JavaScriptCore/wtf/RefPtr.h:54:21: note: in instantiation of function template specialization 'WTF::derefIfNotNull<WebCore::Storage>' requested here ~RefPtr() { derefIfNotNull(m_ptr); } ^ In file included from third_party/WebKit/WebCore/bindings/v8/custom/V8EventCustom.cpp:53: In file included from llvm/Debug/obj/gen/webkit/bindings/V8StorageEvent.h:31: third_party/WebKit/WebCore/storage/StorageEvent.h:38:11: note: in instantiation of member function 'WTF::RefPtr<WebCore::Storage>::~RefPtr' requested here class StorageEvent : public Event { ^ In file included from third_party/WebKit/WebCore/bindings/v8/custom/V8EventCustom.cpp:41: In file included from llvm/Debug/obj/gen/webkit/bindings/V8CompositionEvent.h:28: In file included from third_party/WebKit/WebCore/dom/CompositionEvent.h:30: In file included from third_party/WebKit/WebCore/dom/UIEvent.h:27: third_party/WebKit/WebCore/page/DOMWindow.h:70:11: note: forward declaration of 'WebCore::Storage' class Storage; ^ 1 error generated. 211080 4 52985 commit-queue 2010-04-09 18:56:25 -0700 Comment on attachment 52985 Patch Clearing flags on attachment: 52985 Committed r57394: <http://trac.webkit.org/changeset/57394> 211081 5 commit-queue 2010-04-09 18:56:30 -0700 All reviewed patches have been landed. Closing bug. 52985 2010-04-09 13:36:35 -0700 2010-04-09 18:56:25 -0700 Patch bug-37356-20100409133651.patch text/plain 1961 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDliOGQxZi4uNjY2Njg1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0wOSAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTdG9yYWdlRXZlbnQgZGVzdHJ1Y3RvciBzaG91bGQgYmUgaW4gU3RvcmFn ZUV2ZW50LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzczNTYKKworICAgICAgICBCZWNhdXNlIFN0b3JhZ2UgaXMgZm9yd2FyZC1kZWNsYXJlZCBp biBTdG9yYWdlRXZlbnQuaCwgd2UgbmVlZCB0byBkZWZpbmUKKyAgICAgICAgdGhlIFN0b3JhZ2VF dmVudCBkZXN0cnVjdG9yIGluIHRoZSAuY3BwIGZpbGUgc28gdGhhdCB0aGUgUmVmUHRyPFN0b3Jh Z2U+CisgICAgICAgIGRlc3RydWN0b3IgaGFzIGEgY29tcGxldGUgdHlwZSBmb3IgU3RvcmFnZS4K KworICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZUV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlN0b3JhZ2VFdmVudDo6flN0b3JhZ2VFdmVudCk6CisgICAgICAgICogc3RvcmFnZS9TdG9yYWdl RXZlbnQuaDoKKwogMjAxMC0wMy0zMCAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlRXZlbnQuY3BwIGIvV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2VFdmVudC5jcHAKaW5kZXggMTI2YWNhMC4uZjJiMTMzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9z dG9yYWdlL1N0b3JhZ2VFdmVudC5jcHAKKysrIGIvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VFdmVu dC5jcHAKQEAgLTQxLDYgKzQxLDEwIEBAIFN0b3JhZ2VFdmVudDo6U3RvcmFnZUV2ZW50KCkKIHsK IH0KIAorU3RvcmFnZUV2ZW50Ojp+U3RvcmFnZUV2ZW50KCkKK3sKK30KKwogUGFzc1JlZlB0cjxT dG9yYWdlRXZlbnQ+IFN0b3JhZ2VFdmVudDo6Y3JlYXRlKGNvbnN0IEF0b21pY1N0cmluZyYgdHlw ZSwgY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgb2xkVmFsdWUsIGNvbnN0IFN0cmlu ZyYgbmV3VmFsdWUsIGNvbnN0IFN0cmluZyYgdXJpLCBTdG9yYWdlKiBzdG9yYWdlQXJlYSkKIHsK ICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0b3JhZ2VFdmVudCh0eXBlLCBrZXksIG9sZFZhbHVl LCBuZXdWYWx1ZSwgdXJpLCBzdG9yYWdlQXJlYSkpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdG9y YWdlL1N0b3JhZ2VFdmVudC5oIGIvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VFdmVudC5oCmluZGV4 IGZhNzUzNWIuLjkxODUxNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlRXZl bnQuaAorKysgYi9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUV2ZW50LmgKQEAgLTM5LDYgKzM5LDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGljIFBhc3NS ZWZQdHI8U3RvcmFnZUV2ZW50PiBjcmVhdGUoKTsKICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8 U3RvcmFnZUV2ZW50PiBjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBjb25zdCBTdHJp bmcmIGtleSwgY29uc3QgU3RyaW5nJiBvbGRWYWx1ZSwgY29uc3QgU3RyaW5nJiBuZXdWYWx1ZSwg Y29uc3QgU3RyaW5nJiB1cmksIFN0b3JhZ2UqIHN0b3JhZ2VBcmVhKTsKKyAgICAgICAgdmlydHVh bCB+U3RvcmFnZUV2ZW50KCk7CiAKICAgICAgICAgY29uc3QgU3RyaW5nJiBrZXkoKSBjb25zdCB7 IHJldHVybiBtX2tleTsgfQogICAgICAgICBjb25zdCBTdHJpbmcmIG9sZFZhbHVlKCkgY29uc3Qg eyByZXR1cm4gbV9vbGRWYWx1ZTsgfQo=