37325 2010-04-09 03:33:20 -0700 SVG Padding stops mouse events 2011-11-15 07:38:28 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 peterjosling webkit-unassigned krit pdr webkit.review.bot oldest_to_newest 210664 0 peterjosling 2010-04-09 03:33:20 -0700 Creating an SVG image with padding (ie <svg style = "padding:10px" etc.) causes onclick/onmousedown/onmouseover etc events to stop working. The image still displays properly, but mouse events do not register. 223160 1 krit 2010-05-09 23:19:57 -0700 Peter, can you add a simple test case to this bug please? 232790 2 57555 peterjosling 2010-06-01 09:58:21 -0700 Created attachment 57555 A simple SVG image with a rectangle - alert box appears on click. Works as expected 232792 3 57556 peterjosling 2010-06-01 09:59:15 -0700 Created attachment 57556 Same image as before - but style="padding:100px;" added to the SVG element. Rectangle no longer responds to click. 232793 4 peterjosling 2010-06-01 09:59:40 -0700 Added test case 502591 5 115086 pdr 2011-11-14 19:13:36 -0800 Created attachment 115086 Fix SVG hit testing when padding is present and add associated test 502854 6 115086 zimmermann 2011-11-15 06:20:13 -0800 Comment on attachment 115086 Fix SVG hit testing when padding is present and add associated test View in context: https://bugs.webkit.org/attachment.cgi?id=115086&action=review Looks great to me, please update the comment and land manually, or reuploaded it and I'll set the flags again. > Source/WebCore/rendering/svg/RenderSVGRoot.cpp:431 > // Note: For now, we're ignoring hits to border and padding for <svg> This comment is invalid now, no? 502856 7 pdr 2011-11-15 06:23:39 -0800 (In reply to comment #6) > (From update of attachment 115086 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115086&action=review > > Looks great to me, please update the comment and land manually, or reuploaded it and I'll set the flags again. > > > Source/WebCore/rendering/svg/RenderSVGRoot.cpp:431 > > // Note: For now, we're ignoring hits to border and padding for <svg> > > This comment is invalid now, no? I think it's still valid, it was just implemented wrong. We still do ignore mouse movements on the padding and borders of a SVG element, but now the positioning is correct so we don't account for the padding twice. 502859 8 115086 zimmermann 2011-11-15 06:29:25 -0800 Comment on attachment 115086 Fix SVG hit testing when padding is present and add associated test Fair enough, cq+ then. 502897 9 115086 webkit.review.bot 2011-11-15 07:38:24 -0800 Comment on attachment 115086 Fix SVG hit testing when padding is present and add associated test Clearing flags on attachment: 115086 Committed r100280: <http://trac.webkit.org/changeset/100280> 502898 10 webkit.review.bot 2011-11-15 07:38:28 -0800 All reviewed patches have been landed. Closing bug. 57555 2010-06-01 09:58:21 -0700 2010-06-01 09:58:21 -0700 A simple SVG image with a rectangle - alert box appears on click. Works as expected nopadding.svg image/svg+xml 303 peterjosling PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/Pgo8IURPQ1RZUEUgc3ZnIFBVQkxJ QyAiLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9T VkcvMS4xL0RURC9zdmcxMS5kdGQiPgo8c3ZnIHdpZHRoPSI1MDAiIGhlaWdodD0iNTAwIiB2ZXJz aW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CjxyZWN0IHdpZHRo PSIzMDAiIGhlaWdodD0iMTAwIiBmaWxsLWNvbG9yID0gIiMwMDAiIG9uY2xpY2sgPSAiYWxlcnQo J3Rlc3QnKTsiLz4KPC9zdmc+ 57556 2010-06-01 09:59:15 -0700 2010-06-01 09:59:15 -0700 Same image as before - but style="padding:100px;" added to the SVG element. Rectangle no longer responds to click. padding.svg image/svg+xml 327 peterjosling PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/Pgo8IURPQ1RZUEUgc3ZnIFBVQkxJ QyAiLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9T VkcvMS4xL0RURC9zdmcxMS5kdGQiPgo8c3ZnIHdpZHRoPSI1MDAiIGhlaWdodD0iNTAwIiB2ZXJz aW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgIHN0eWxlPSJwYWRk aW5nOjEwMHB4OyI+CjxyZWN0IHdpZHRoPSIzMDAiIGhlaWdodD0iMTAwIiBmaWxsLWNvbG9yID0g IiMwMDAiIG9uY2xpY2sgPSAiYWxlcnQoJ3Rlc3QnKTsiLz4KPC9zdmc+ 115086 2011-11-14 19:13:36 -0800 2011-11-15 07:38:24 -0800 Fix SVG hit testing when padding is present and add associated test 37325.1.patch text/plain 3609 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDIzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE0ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IFNWRyBoaXQgdGVzdGluZyB3 aGVuIHBhZGRpbmcgaXMgcHJlc2VudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzczMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiBzdmcvaGl0dGVzdC9zdmctcGFkZGluZy54aHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSb290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclNWR1Jvb3Q6Om5vZGVBdFBvaW50KToKKwogMjAxMS0xMS0xNCAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlByb2Nlc3MgY3Jhc2hlcyB3 aGVuIHRyeWluZyB0byBkaXNwbGF5IHlvdXIgInVwbG9hZGVkIHZpZGVvcyIgcGFnZSBvbiBGYWNl Ym9vawpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSb290LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jv b3QuY3BwCShyZXZpc2lvbiA5OTkxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHUm9vdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyOSw4ICs0MjksNyBAQCBib29s IFJlbmRlclNWR1Jvb3Q6Om5vZGVBdFBvaW50KGNvbnN0IEhpCiAgICAgTGF5b3V0UG9pbnQgcG9p bnRJbkJvcmRlckJveCA9IHBvaW50SW5QYXJlbnQgLSBwYXJlbnRPcmlnaW5Ub0JvcmRlckJveCgp OwogCiAgICAgLy8gTm90ZTogRm9yIG5vdywgd2UncmUgaWdub3JpbmcgaGl0cyB0byBib3JkZXIg YW5kIHBhZGRpbmcgZm9yIDxzdmc+Ci0gICAgTGF5b3V0UG9pbnQgcG9pbnRJbkNvbnRlbnRCb3gg PSBwb2ludEluQm9yZGVyQm94IC0gYm9yZGVyT3JpZ2luVG9Db250ZW50Qm94KCk7Ci0gICAgaWYg KCFjb250ZW50Qm94UmVjdCgpLmNvbnRhaW5zKHBvaW50SW5Db250ZW50Qm94KSkKKyAgICBpZiAo IWNvbnRlbnRCb3hSZWN0KCkuY29udGFpbnMocG9pbnRJbkJvcmRlckJveCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAogICAgIExheW91dFBvaW50IGxvY2FsUG9pbnQgPSBsb2NhbFRvUGFyZW50 VHJhbnNmb3JtKCkuaW52ZXJzZSgpLm1hcFBvaW50KHBvaW50SW5QYXJlbnQpOwpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMTAwMjMzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMTQgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xl LmNvbT4KKworICAgICAgICBGaXggU1ZHIGhpdCB0ZXN0aW5nIHdoZW4gcGFkZGluZyBpcyBwcmVz ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMy NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3Zn L2hpdHRlc3Qvc3ZnLXBhZGRpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdmcv aGl0dGVzdC9zdmctcGFkZGluZy54aHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMTQgIE5vZWwgR29y ZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgogCiAgICAgICAgIFRlc3QgSlBFRyBpbWFnZSBk ZWNvZGluZyBSR0IgcGl4ZWwgZW5kaWFuZXNzCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvaGl0dGVz dC9zdmctcGFkZGluZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3Zn L2hpdHRlc3Qvc3ZnLXBhZGRpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvc3ZnL2hpdHRlc3Qvc3ZnLXBhZGRpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxIEBACitQQVNTRUQKSW5kZXg6IExheW91dFRlc3RzL3N2Zy9oaXR0ZXN0L3N2Zy1w YWRkaW5nLnhodG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9oaXR0ZXN0L3N2Zy1w YWRkaW5nLnhodG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL2hpdHRlc3Qvc3Zn LXBhZGRpbmcueGh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzQgQEAKKzxodG1sIHhtbG5z PSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sJz4KKyAgPGhlYWQ+CisgICAgPHN0eWxlPgor ICAgICAgYm9keSB7CisgICAgICAgICAgbWFyZ2luOiAwcHg7CisgICAgICAgICAgcGFkZGluZzog MHB4OworICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOworICAgICAgfQorICAgICAg I3NxdWFyZSB7CisgICAgICAgIGZpbGw6IGJsdWU7CisgICAgICB9CisgICAgICAjc3F1YXJlOmhv dmVyIHsKKyAgICAgICAgZmlsbDogZ3JlZW47CisgICAgICB9CisgICAgPC9zdHlsZT4KKyAgPC9o ZWFkPgorICA8Ym9keT4KKyAgICA8dGFibGU+PHRyPjx0ZD4KKyAgICAgIDxzdmcgd2lkdGg9JzEw MHB4JyBoZWlnaHQ9JzEwMHB4JyBzdHlsZT0ncGFkZGluZzogNTBweCcgeG1sbnM9J2h0dHA6Ly93 d3cudzMub3JnLzIwMDAvc3ZnJz4KKyAgICAgICAgPHN2Zz4KKyAgICAgICAgICA8cmVjdCBpZD0n c3F1YXJlJyB3aWR0aD0nMTAwJyBoZWlnaHQ9JzEwMCcgb25jbGljaz0nYWxlcnQoIllvdSBjbGlj a2VkIHRoZSBzcXVhcmUhIEl0IHdvcmtlZCEiKScvPgorICAgICAgICA8L3N2Zz4KKyAgICAgIDwv c3ZnPgorICAgIDwvdGQ+PC90cj48L3RhYmxlPgorICAgIDxzY3JpcHQ+PCFbQ0RBVEFbCisgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuZHVtcEFzVGV4dCgpOworICAgIH0KKyAgICB2YXIgaGl0RWxlbWVudCA9IGRvY3VtZW50 LmVsZW1lbnRGcm9tUG9pbnQoNzUsIDc1KTsKKyAgICB2YXIgaGl0U3VjY2VzcyA9IGhpdEVsZW1l bnQgJiYgaGl0RWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3F1YXJlIik7Cisg ICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSBoaXRTdWNjZXNzID8gIlBBU1NFRCIgOiAiRkFJ TCwgaGl0ICIgKyBoaXRFbGVtZW50ICsgIiBAIDUwLCA1MCI7CisgICAgXV0+PC9zY3JpcHQ+Cisg IDwvYm9keT4KKzwvaHRtbD4K