<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37323</bug_id>
          
          <creation_ts>2010-04-09 03:00:47 -0700</creation_ts>
          <short_desc>[Qt] tst_QWebHistoryInterface::visitedLinks() fails</short_desc>
          <delta_ts>2010-05-07 07:58:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>38654</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Hausmann">hausmann</reporter>
          <assigned_to name="Yi Shen">max.hong.shen</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>cshu</cc>
    
    <cc>jesus</cc>
    
    <cc>jwieczorek</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>210655</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-09 03:00:47 -0700</bug_when>
    <thetext>FAIL!  : tst_QWebHistoryInterface::visitedLinks() Compared values are not the same
   Actual (m_page-&gt;mainFrame()-&gt;evaluateJavaScript(&quot;document.querySelectorAll(&apos;:visited&apos;).length;&quot;).toString()): 0
   Expected (QString::fromLatin1(&quot;1&quot;)): 1
   Loc: [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp(90)]

Reproducible on Linux/X11.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210704</commentid>
    <comment_count>1</comment_count>
    <who name="Jakub Wieczorek">jwieczorek</who>
    <bug_when>2010-04-09 06:57:35 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; FAIL!  : tst_QWebHistoryInterface::visitedLinks() Compared values are not the
&gt; same
&gt;    Actual
&gt; (m_page-&gt;mainFrame()-&gt;evaluateJavaScript(&quot;document.querySelectorAll(&apos;:visited&apos;).length;&quot;).toString()):
&gt; 0
&gt;    Expected (QString::fromLatin1(&quot;1&quot;)): 1
&gt;    Loc:
&gt; [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp(90)]
&gt; 
&gt; Reproducible on Linux/X11.

That would be the new :visited patch that has just landed: https://bugs.webkit.org/show_bug.cgi?id=24300.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>215890</commentid>
    <comment_count>2</comment_count>
      <attachid>54060</attachid>
    <who name="Yi Shen">max.hong.shen</who>
    <bug_when>2010-04-22 08:43:37 -0700</bug_when>
    <thetext>Created attachment 54060
proposed patch

Fix the tst_QWebHistoryInterface::visitedLinks by using DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo to get the correct info.
I have run the test on my local many many times and I am sure DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo won&apos;t cause any crash.
Please take a look at the comments of https://bugs.webkit.org/show_bug.cgi?id=37759. Thanks a lot!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>217918</commentid>
    <comment_count>3</comment_count>
      <attachid>54060</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-27 14:01:04 -0700</bug_when>
    <thetext>Comment on attachment 54060
proposed patch

Thanks a lot Yi! :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218162</commentid>
    <comment_count>4</comment_count>
      <attachid>54060</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-27 19:38:38 -0700</bug_when>
    <thetext>Comment on attachment 54060
proposed patch

Rejecting patch 54060 from commit-queue.

Failed to run &quot;[u&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Simon Hausmann&apos;, u&apos;--force&apos;]&quot; exit_code: 1
Last 500 characters of output:
g file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Hunk #2 succeeded at 416 with fuzz 2 (offset 45 lines).
patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
Hunk #1 FAILED at 24.
Hunk #2 succeeded at 86 (offset 3 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h.rej
patching file WebKit/qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp

Full output: http://webkit-commit-queue.appspot.com/results/1905083</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218168</commentid>
    <comment_count>5</comment_count>
    <who name="Yi Shen">max.hong.shen</who>
    <bug_when>2010-04-27 20:00:45 -0700</bug_when>
    <thetext>Is it because my patch is out of date? I will create a new one then.

(In reply to comment #4)
&gt; (From update of attachment 54060 [details])
&gt; Rejecting patch 54060 from commit-queue.
&gt; 
&gt; Failed to run
&gt; &quot;[u&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;,
&gt; u&apos;--reviewer&apos;, u&apos;Simon Hausmann&apos;, u&apos;--force&apos;]&quot; exit_code: 1
&gt; Last 500 characters of output:
&gt; g file WebKit/qt/ChangeLog
&gt; Hunk #1 succeeded at 1 with fuzz 3.
&gt; patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
&gt; Hunk #2 succeeded at 416 with fuzz 2 (offset 45 lines).
&gt; patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h
&gt; Hunk #1 FAILED at 24.
&gt; Hunk #2 succeeded at 86 (offset 3 lines).
&gt; 1 out of 2 hunks FAILED -- saving rejects to file
&gt; WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h.rej
&gt; patching file WebKit/qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp
&gt; 
&gt; Full output: http://webkit-commit-queue.appspot.com/results/1905083</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218171</commentid>
    <comment_count>6</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-27 20:31:32 -0700</bug_when>
    <thetext>hum, patch works, but doing this include from WebKit/qt/tests looks a bit strange to me =(

+#include &quot;../WebCoreSupport/DumpRenderTreeSupportQt.h&quot;
 #include &lt;QtTest/QtTest&gt;
 
+    QString linkColor = DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo(m_page-&gt;mainFrame(), &quot;vlink&quot;)[&quot;color&quot;].toString();


and this looks a bit intrusive ...

simon, any idea to make it work differently? if no, just ignore me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218254</commentid>
    <comment_count>7</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-28 01:02:54 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; hum, patch works, but doing this include from WebKit/qt/tests looks a bit
&gt; strange to me =(
&gt; 
&gt; +#include &quot;../WebCoreSupport/DumpRenderTreeSupportQt.h&quot;
&gt;  #include &lt;QtTest/QtTest&gt;
&gt; 
&gt; +    QString linkColor =
&gt; DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo(m_page-&gt;mainFrame(),
&gt; &quot;vlink&quot;)[&quot;color&quot;].toString();
&gt; 
&gt; 
&gt; and this looks a bit intrusive ...
&gt; 
&gt; simon, any idea to make it work differently? if no, just ignore me

I don&apos;t see much of a choice at this point :( It&apos;s late in the game to add new APIs, so the DRT function for unit testing is fine with me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218383</commentid>
    <comment_count>8</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-28 07:14:05 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; hum, patch works, but doing this include from WebKit/qt/tests looks a bit
&gt; &gt; strange to me =(
&gt; &gt; 
&gt; &gt; +#include &quot;../WebCoreSupport/DumpRenderTreeSupportQt.h&quot;
&gt; &gt;  #include &lt;QtTest/QtTest&gt;
&gt; &gt; 
&gt; &gt; +    QString linkColor =
&gt; &gt; DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo(m_page-&gt;mainFrame(),
&gt; &gt; &quot;vlink&quot;)[&quot;color&quot;].toString();
&gt; &gt; 
&gt; &gt; 
&gt; &gt; and this looks a bit intrusive ...
&gt; &gt; 
&gt; &gt; simon, any idea to make it work differently? if no, just ignore me
&gt; 
&gt; I don&apos;t see much of a choice at this point :( It&apos;s late in the game to add new
&gt; APIs, so the DRT function for unit testing is fine with me.

Simon, I think we can use

QWebElement::styleProperty(const QString &amp;name, StyleResolveStrategy strategy)

i will upload a patch that shows what I have in mind.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218384</commentid>
    <comment_count>9</comment_count>
      <attachid>54562</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-28 07:16:02 -0700</bug_when>
    <thetext>Created attachment 54562
alternative approach

this patch makes QWebElement::styleProperty method instead of DumpRenderTreeQt additional method.

ps: Yi&apos;s authorship is kept in the ChangeLog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218401</commentid>
    <comment_count>10</comment_count>
      <attachid>54565</attachid>
    <who name="Yi Shen">max.hong.shen</who>
    <bug_when>2010-04-28 08:09:49 -0700</bug_when>
    <thetext>Created attachment 54565
fix the svn-apply issue

Thanks Antonio. Your patch looks nice for me but I am not familiar with QWebElement::styleProperty() changes. I also updated my patch and attached it for review. Let Simon decide which patch should be used :)

The reasons why I prefer to add DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo to handle this test case are
1) using DRT function for unit testing can also be found in tst_qwebpage.cpp.
2) we may need an implementation of LayoutTestController::computedStyleIncludingVisitedInfo for Qt, which can invoke DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo.
see https://bugs.webkit.org/show_bug.cgi?id=37759. I was fighting against the test script which causes the new interface crashes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218581</commentid>
    <comment_count>11</comment_count>
      <attachid>54562</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-28 13:08:17 -0700</bug_when>
    <thetext>Comment on attachment 54562
alternative approach

You&apos;re right Antonio, the reason for the change in behaviour of computedStyle() was to protect the user from malicious javascript.

There&apos;s little point in providing much security through our C++ API, given that it gives full control anyway.

Therefore your patch is much simpler :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218582</commentid>
    <comment_count>12</comment_count>
      <attachid>54565</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-28 13:08:46 -0700</bug_when>
    <thetext>Comment on attachment 54565
fix the svn-apply issue

Let&apos;s go for Antonio&apos;s solution :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218807</commentid>
    <comment_count>13</comment_count>
      <attachid>54562</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-28 21:37:23 -0700</bug_when>
    <thetext>Comment on attachment 54562
alternative approach

Clearing flags on attachment: 54562

Committed r58427: &lt;http://trac.webkit.org/changeset/58427&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218808</commentid>
    <comment_count>14</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-28 21:37:51 -0700</bug_when>
    <thetext>Thank you Simon Hausmann!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218810</commentid>
    <comment_count>15</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-28 21:39:34 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (From update of attachment 54562 [details])
&gt; Clearing flags on attachment: 54562
&gt; 
&gt; Committed r58427: &lt;http://trac.webkit.org/changeset/58427&gt;

Err, I had a typo in the commit message:

&quot;Reviewed by NOBODY Simon Hausmann.&quot;

hope it does not hurt much. sorry :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218843</commentid>
    <comment_count>16</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-28 22:45:43 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #13)
&gt; &gt; (From update of attachment 54562 [details] [details])
&gt; &gt; Clearing flags on attachment: 54562
&gt; &gt; 
&gt; &gt; Committed r58427: &lt;http://trac.webkit.org/changeset/58427&gt;
&gt; 
&gt; Err, I had a typo in the commit message:
&gt; 
&gt; &quot;Reviewed by NOBODY Simon Hausmann.&quot;
&gt; 
&gt; hope it does not hurt much. sorry :(

Not a problem at all, I had a good laugh :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218865</commentid>
    <comment_count>17</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-29 00:08:54 -0700</bug_when>
    <thetext>Revision r58427 cherry-picked into qtwebkit-2.0 with commit adc47622d204163a416403abd925d2eff1817f0b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218892</commentid>
    <comment_count>18</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-29 01:14:14 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; Revision r58427 cherry-picked into qtwebkit-2.0 with commit
&gt; adc47622d204163a416403abd925d2eff1817f0b

Rolled out with commit a3a6be07b35ace4738aab1f3b1dc2caa755175e9:


   ../../../WebCore/css/CSSComputedStyleDeclaration.h: In member function â&lt;U+0080&gt;&lt;U+0098&gt;QString QWebElement::styleProperty(const QString&amp;, QWebElement::StyleResolveStrategy) constâ&lt;U+0080&gt;&lt;U+0099&gt;:
    ../../../WebCore/css/CSSComputedStyleDeclaration.h:75: error: too many arguments to function â&lt;U+0080&gt;&lt;U+0098&gt;WTF::PassRefPtr WebCore::computedStyle(WTF::PassRefPtr)â&lt;U+0080&gt;&lt;U+0099&gt;
    ../../../WebKit/qt/Api/qwebelement.cpp:824: error: at this point in file



The private links patch is not part of the branch. Not sure if we should actually pick it, it&apos;s quite intrusive...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218938</commentid>
    <comment_count>19</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-29 03:51:20 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; (In reply to comment #17)
&gt; &gt; Revision r58427 cherry-picked into qtwebkit-2.0 with commit
&gt; &gt; adc47622d204163a416403abd925d2eff1817f0b
&gt; 
&gt; Rolled out with commit a3a6be07b35ace4738aab1f3b1dc2caa755175e9:
&gt; 
&gt; 
&gt;    ../../../WebCore/css/CSSComputedStyleDeclaration.h: In member function
&gt; â&lt;U+0080&gt;&lt;U+0098&gt;QString QWebElement::styleProperty(const QString&amp;,
&gt; QWebElement::StyleResolveStrategy) constâ&lt;U+0080&gt;&lt;U+0099&gt;:
&gt;     ../../../WebCore/css/CSSComputedStyleDeclaration.h:75: error: too many
&gt; arguments to function â&lt;U+0080&gt;&lt;U+0098&gt;WTF::PassRefPtr
&gt; WebCore::computedStyle(WTF::PassRefPtr)â&lt;U+0080&gt;&lt;U+0099&gt;
&gt;     ../../../WebKit/qt/Api/qwebelement.cpp:824: error: at this point in file
&gt; 
&gt; 
&gt; 
&gt; The private links patch is not part of the branch. Not sure if we should
&gt; actually pick it, it&apos;s quite intrusive...

Ahh! :( should we go with the other approach for the branch? I really did not realize it could happen ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218970</commentid>
    <comment_count>20</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-29 05:22:19 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; (In reply to comment #18)
&gt; &gt; (In reply to comment #17)
&gt; &gt; &gt; Revision r58427 cherry-picked into qtwebkit-2.0 with commit
&gt; &gt; &gt; adc47622d204163a416403abd925d2eff1817f0b
&gt; &gt; 
&gt; &gt; Rolled out with commit a3a6be07b35ace4738aab1f3b1dc2caa755175e9:
&gt; &gt; 
&gt; &gt; 
&gt; &gt;    ../../../WebCore/css/CSSComputedStyleDeclaration.h: In member function
&gt; &gt; â&lt;U+0080&gt;&lt;U+0098&gt;QString QWebElement::styleProperty(const QString&amp;,
&gt; &gt; QWebElement::StyleResolveStrategy) constâ&lt;U+0080&gt;&lt;U+0099&gt;:
&gt; &gt;     ../../../WebCore/css/CSSComputedStyleDeclaration.h:75: error: too many
&gt; &gt; arguments to function â&lt;U+0080&gt;&lt;U+0098&gt;WTF::PassRefPtr
&gt; &gt; WebCore::computedStyle(WTF::PassRefPtr)â&lt;U+0080&gt;&lt;U+0099&gt;
&gt; &gt;     ../../../WebKit/qt/Api/qwebelement.cpp:824: error: at this point in file
&gt; &gt; 

&gt; Ahh! :( should we go with the other approach for the branch? I really did not
&gt; realize it could happen ...

ahh (again) the &quot;other&quot; approach also makes use of this the new parameter introduced by hyatt :(

&gt; &gt; The private links patch is not part of the branch. Not sure if we should
&gt; &gt; actually pick it, it&apos;s quite intrusive...

humm, it is considered a security fix. Are you considering to cherry pick it at all, simon, or it is out of the question?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>221049</commentid>
    <comment_count>21</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-05-05 04:34:41 -0700</bug_when>
    <thetext>simon, ideas on what can be done here?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>221115</commentid>
    <comment_count>22</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-05-05 08:13:24 -0700</bug_when>
    <thetext>(In reply to comment #21)
&gt; simon, ideas on what can be done here?

I&apos;ve looked into cherry-picking the private links feature, but it turns out to be a big effort. There have been a _lot_ of follow-up patches after the initial landing, mostly performance related.

I don&apos;t feel comfortable to cherry-pick a huge series of patches and risk missing one, to be honest. If one of you wants to do it, I&apos;d be happy to review the picks.

My feeling is that it may be simpler to take this into the next 2.1 release. What do you think?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>221123</commentid>
    <comment_count>23</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-05-05 08:28:42 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; (In reply to comment #21)
&gt; &gt; simon, ideas on what can be done here?
&gt; 
&gt; I&apos;ve looked into cherry-picking the private links feature, but it turns out to
&gt; be a big effort. There have been a _lot_ of follow-up patches after the initial
&gt; landing, mostly performance related.
&gt; 
&gt; I don&apos;t feel comfortable to cherry-pick a huge series of patches and risk
&gt; missing one, to be honest. If one of you wants to do it, I&apos;d be happy to review
&gt; the picks.
&gt; 
&gt; My feeling is that it may be simpler to take this into the next 2.1 release.
&gt; What do you think?

I see. My concern is what to do with this test in the 2.0 branch? Maybe &quot;skip&quot; it, like a known test failure?

on trunk it is ok and will be in 2.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>222362</commentid>
    <comment_count>24</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-05-07 07:51:40 -0700</bug_when>
    <thetext>It seems that tronical reported this bug because auto tests was failing on trunk, not on the qtwebkit-2.0 release branch. Hence, since the release branch does not have hyatt&apos;s &quot;visited links fixes&apos; series of patches either, this autotest does not fail on release branch, and this fix does not need to be cherry-picked.

I just build qtwebkit-2.0 b4aa5e1ddc41edab895132aba3cc66d9d7129444 , and auto test passes fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>222367</commentid>
    <comment_count>25</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-05-07 07:58:55 -0700</bug_when>
    <thetext>Marking as closed, this is not meant for inclusion in the release branch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54060</attachid>
            <date>2010-04-22 08:43:37 -0700</date>
            <delta_ts>2010-04-28 21:40:29 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>bug37323.patch</filename>
            <type>text/plain</type>
            <size>4181</size>
            <attacher name="Yi Shen">max.hong.shen</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNTgwOTYpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjIgIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEZpeCB0aGUgUVdlYkhpc3RvcnlJbnRlcmZhY2UgdGVzdCBmYWlsdXJlIGJ5IHVzaW5nIGEgY29y
cmVjdCB3YXkgCisgICAgICAgIHRvIGdldCB0aGUgdmlzaXRlZCBsaW5rIGluZm8KKworICAgICAg
ICBbUXRdIHRzdF9RV2ViSGlzdG9yeUludGVyZmFjZTo6dmlzaXRlZExpbmtzKCkgZmFpbHMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MzIzCisKKyAg
ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisgICAg
ICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0
ZWRJbmZvKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR
dC5oOgorICAgICAgICAqIHRlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9y
eWludGVyZmFjZS5jcHA6CisgICAgICAgICh0c3RfUVdlYkhpc3RvcnlJbnRlcmZhY2U6OnZpc2l0
ZWRMaW5rcyk6CisKIDIwMTAtMDQtMjIgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNv
dHRlQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlz
dGlhbnNlbi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1
cHBvcnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBS
ZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAkocmV2aXNpb24gNTgwOTMpCisrKyBXZWJLaXQvcXQvV2Vi
Q29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0yMyw2ICsyMyw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRHVtcFJlbmRl
clRyZWVTdXBwb3J0UXQuaCIKIAorI2luY2x1ZGUgIkNTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlv
bi5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCiAjaW5jbHVkZSAiQ29udGV4dE1lbnVDbGll
bnRRdC5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51Q29udHJvbGxlci5oIgpAQCAtMzcwLDMgKzM3
MSwyNCBAQCBRU3RyaW5nIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjptYXJrZXJUCiB7CiAgICAg
cmV0dXJuIFdlYkNvcmU6Om1hcmtlclRleHRGb3JMaXN0SXRlbShsaXN0SXRlbS5tX2VsZW1lbnQp
OwogfQorCitRVmFyaWFudE1hcCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y29tcHV0ZWRTdHls
ZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvKFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJpbmcmIGlk
KQoreworICAgIFFWYXJpYW50TWFwIHJldDsKKyAgICBGcmFtZSogY29yZUZyYW1lID0gUVdlYkZy
YW1lUHJpdmF0ZTo6Y29yZShmcmFtZSk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJl
dHVybiByZXQ7CisKKyAgICBFbGVtZW50KiBlbGVtZW50ID0gY29yZUZyYW1lLT5kb2N1bWVudCgp
LT5nZXRFbGVtZW50QnlJZChBdG9taWNTdHJpbmcoaWQpKTsKKyAgICBpZiAoIWVsZW1lbnQpCisg
ICAgICAgIHJldHVybiByZXQ7CisKKyAgICBSZWZQdHI8Q1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0
aW9uPiBzdHlsZSA9IGNvbXB1dGVkU3R5bGUoZWxlbWVudCwgdHJ1ZSk7CisgICAgZm9yIChpbnQg
aSA9IDA7IGkgPCBzdHlsZS0+bGVuZ3RoKCk7IGkrKykgeworICAgICAgICBRU3RyaW5nIG5hbWUg
PSBzdHlsZS0+aXRlbShpKTsKKyAgICAgICAgUVN0cmluZyB2YWx1ZSA9IChzdGF0aWNfY2FzdDxD
U1NTdHlsZURlY2xhcmF0aW9uKj4oc3R5bGUuZ2V0KCkpKS0+Z2V0UHJvcGVydHlWYWx1ZShuYW1l
KTsKKyAgICAgICAgcmV0W25hbWVdID0gUVZhcmlhbnQodmFsdWUpOworICAgIH0KKyAgICByZXR1
cm4gcmV0OworfQorCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy
ZWVTdXBwb3J0UXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVt
cFJlbmRlclRyZWVTdXBwb3J0UXQuaAkocmV2aXNpb24gNTgwOTMpCisrKyBXZWJLaXQvcXQvV2Vi
Q29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaAkod29ya2luZyBjb3B5KQpAQCAt
MjQsNiArMjQsNyBAQAogI2RlZmluZSBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdF9oCiAKICNpbmNs
dWRlICJxd2Via2l0Z2xvYmFsLmgiCisjaW5jbHVkZSA8UVZhcmlhbnQ+CiAKICNpbmNsdWRlICJx
d2ViZWxlbWVudC5oIgogCkBAIC04Miw2ICs4Myw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgaW50
IHdvcmtlclRocmVhZENvdW50KCk7CiAKICAgICBzdGF0aWMgUVN0cmluZyBtYXJrZXJUZXh0Rm9y
TGlzdEl0ZW0oY29uc3QgUVdlYkVsZW1lbnQmIGxpc3RJdGVtKTsKKyAgICBzdGF0aWMgUVZhcmlh
bnRNYXAgY29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvKFFXZWJGcmFtZSogZnJhbWUs
IGNvbnN0IFFTdHJpbmcmIGlkKTsKIH07CiAKICNlbmRpZgpJbmRleDogV2ViS2l0L3F0L3Rlc3Rz
L3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9yeWludGVyZmFjZS5jcHAKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlz
dG9yeWludGVyZmFjZS5jcHAJKHJldmlzaW9uIDU4MDkzKQorKysgV2ViS2l0L3F0L3Rlc3RzL3F3
ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9yeWludGVyZmFjZS5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTE3LDcgKzE3LDcgQEAKICAgICBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4K
ICovCiAKLQorI2luY2x1ZGUgIi4uL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9y
dFF0LmgiCiAjaW5jbHVkZSA8UXRUZXN0L1F0VGVzdD4KIAogI2luY2x1ZGUgPHF3ZWJwYWdlLmg+
CkBAIC04NSw5ICs4NSw5IEBAIHB1YmxpYzoKIHZvaWQgdHN0X1FXZWJIaXN0b3J5SW50ZXJmYWNl
Ojp2aXNpdGVkTGlua3MoKQogewogICAgIFFXZWJIaXN0b3J5SW50ZXJmYWNlOjpzZXREZWZhdWx0
SW50ZXJmYWNlKG5ldyBGYWtlSGlzdG9yeUltcGxlbWVudGF0aW9uKTsKLSAgICBtX3ZpZXctPnNl
dEh0bWwoIjxodG1sPjxib2R5PjxhIGhyZWY9J2h0dHA6Ly93d3cudHJvbGx0ZWNoLmNvbSc+VHJv
bGx0ZWNoPC9hPjwvYm9keT48L2h0bWw+Iik7Ci0gICAgUUNPTVBBUkUobV9wYWdlLT5tYWluRnJh
bWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCc6dmlz
aXRlZCcpLmxlbmd0aDsiKS50b1N0cmluZygpLAotICAgICAgICAgICAgIFFTdHJpbmc6OmZyb21M
YXRpbjEoIjEiKSk7CisgICAgbV92aWV3LT5zZXRIdG1sKCI8aHRtbD48c3R5bGU+Omxpbmt7Y29s
b3I6Z3JlZW59OnZpc2l0ZWR7Y29sb3I6cmVkfTwvc3R5bGU+PGJvZHk+PGEgaHJlZj0naHR0cDov
L3d3dy50cm9sbHRlY2guY29tJyBpZD0ndmxpbmsnPlRyb2xsdGVjaDwvYT48L2JvZHk+PC9odG1s
PiIpOworICAgIFFTdHJpbmcgbGlua0NvbG9yID0gRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OmNv
bXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbyhtX3BhZ2UtPm1haW5GcmFtZSgpLCAidmxp
bmsiKVsiY29sb3IiXS50b1N0cmluZygpOworICAgIFFDT01QQVJFKGxpbmtDb2xvciwgUVN0cmlu
Zzo6ZnJvbUxhdGluMSgicmdiKDI1NSwgMCwgMCkiKSk7CiB9CiAKIFFURVNUX01BSU4odHN0X1FX
ZWJIaXN0b3J5SW50ZXJmYWNlKQo=
</data>
<flag name="commit-queue"
          id="37930"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54562</attachid>
            <date>2010-04-28 07:16:02 -0700</date>
            <delta_ts>2010-04-28 21:37:23 -0700</delta_ts>
            <desc>alternative approach</desc>
            <filename>0001--Qt-tst_QWebHistoryInterface-visitedLinks-fails.patch</filename>
            <type>text/plain</type>
            <size>4321</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSBiMGNhODhhYzIzNDAxZTZiNWQzZWJiNDE4ZWIzOTkyNmIzZjk4ZWQ4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogV2VkLCAyOCBBcHIgMjAxMCAxMDoxMzowOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gdHN0X1FXZWJIaXN0b3J5SW50ZXJmYWNlOjp2aXNpdGVkTGlua3MoKSBmYWlscwogaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MzIzCgpQYXRjaCBieSBBbnRvbmlv
IEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+LCBZaSBTaGVuIDx5aS40LnNoZW5Abm9raWEu
Y29tPiBvbiAyMDEwLTA0LTI4ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKUGF0Y2ggZml4
ZXMgc3R5bGVQcm9wZXJ0eSBtZXRob2Qgb2YgUVdlYkVsZW1lbnQgdG8gbWFrZSB1c2Ugb2YKQ1NT
Q29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpjb21wdXRlZFN0eWxlICdhbGxvd1Zpc2l0ZWRTdHls
ZScgcGFyYW1ldGVyCmFuZCB0aGUgY29ycmVzcG9uZGluZyBmYWlsaW5nIFFXZWJIaXN0b3J5SW50
ZXJmYWNlOjp2aXNpdGVkTGlua3MgbWV0aG9kLgoKKiBBcGkvcXdlYmVsZW1lbnQuY3BwOgooUVdl
YkVsZW1lbnQ6OnN0eWxlUHJvcGVydHkpOgoqIHRlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3Rz
dF9xd2ViaGlzdG9yeWludGVyZmFjZS5jcHA6Cih0c3RfUVdlYkhpc3RvcnlJbnRlcmZhY2U6OnZp
c2l0ZWRMaW5rcyk6CgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2ViZWxlbWVudC5jcHAg
Yi9XZWJLaXQvcXQvQXBpL3F3ZWJlbGVtZW50LmNwcAppbmRleCA4YWY3MjAzLi41NTEzNDZiIDEw
MDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJlbGVtZW50LmNwcAorKysgYi9XZWJLaXQvcXQv
QXBpL3F3ZWJlbGVtZW50LmNwcApAQCAtODE2LDE3ICs4MTYsMTcgQEAgUVN0cmluZyBRV2ViRWxl
bWVudDo6c3R5bGVQcm9wZXJ0eShjb25zdCBRU3RyaW5nICZuYW1lLCBTdHlsZVJlc29sdmVTdHJh
dGVneSBzdHIKICAgICB9CiAKICAgICBpZiAoc3RyYXRlZ3kgPT0gQ29tcHV0ZWRTdHlsZSkgewog
ICAgICAgICBpZiAoIW1fZWxlbWVudCB8fCAhbV9lbGVtZW50LT5pc1N0eWxlZEVsZW1lbnQoKSkK
ICAgICAgICAgICAgIHJldHVybiBRU3RyaW5nKCk7CiAKICAgICAgICAgaW50IHByb3BJRCA9IGNz
c1Byb3BlcnR5SUQobmFtZSk7CiAKLSAgICAgICAgUmVmUHRyPENTU0NvbXB1dGVkU3R5bGVEZWNs
YXJhdGlvbj4gc3R5bGUgPSBjb21wdXRlZFN0eWxlKG1fZWxlbWVudCk7CisgICAgICAgIFJlZlB0
cjxDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24+IHN0eWxlID0gY29tcHV0ZWRTdHlsZShtX2Vs
ZW1lbnQsIHRydWUpOwogICAgICAgICBpZiAoIXByb3BJRCB8fCAhc3R5bGUpCiAgICAgICAgICAg
ICByZXR1cm4gUVN0cmluZygpOwogCiAgICAgICAgIHJldHVybiBzdHlsZS0+Z2V0UHJvcGVydHlW
YWx1ZShwcm9wSUQpOwogICAgIH0KIAogICAgIHJldHVybiBRU3RyaW5nKCk7CiB9CmRpZmYgLS1n
aXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA5ZWYx
NmVmLi5jZmI4Y2M5IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktp
dC9xdC9DaGFuZ2VMb2cKQEAgLTEsOCArMSwyNCBAQAorMjAxMC0wNC0yOCAgQW50b25pbyBHb21l
cyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPiwgWWkgU2hlbiA8eWkuNC5zaGVuQG5va2lhLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIHRz
dF9RV2ViSGlzdG9yeUludGVyZmFjZTo6dmlzaXRlZExpbmtzKCkgZmFpbHMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MzIzCisKKyAgICAgICAgUGF0
Y2ggZml4ZXMgc3R5bGVQcm9wZXJ0eSBtZXRob2Qgb2YgUVdlYkVsZW1lbnQgdG8gbWFrZSB1c2Ug
b2YKKyAgICAgICAgQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uOjpjb21wdXRlZFN0eWxlICdh
bGxvd1Zpc2l0ZWRTdHlsZScgcGFyYW1ldGVyCisgICAgICAgIGFuZCB0aGUgY29ycmVzcG9uZGlu
ZyBmYWlsaW5nIFFXZWJIaXN0b3J5SW50ZXJmYWNlOjp2aXNpdGVkTGlua3MgbWV0aG9kLgorCisg
ICAgICAgICogQXBpL3F3ZWJlbGVtZW50LmNwcDoKKyAgICAgICAgKFFXZWJFbGVtZW50OjpzdHls
ZVByb3BlcnR5KToKKyAgICAgICAgKiB0ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS90c3RfcXdl
Ymhpc3RvcnlpbnRlcmZhY2UuY3BwOgorICAgICAgICAodHN0X1FXZWJIaXN0b3J5SW50ZXJmYWNl
Ojp2aXNpdGVkTGlua3MpOgorCiAyMDEwLTA0LTI1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v
cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCiAKICAgICAgICAg
Rml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwOTcKICAg
ICAgICAgRGlzZW50YW5nbGUgaW5pdGlhbGl6aW5nIHRoZSBtYWluIHRocmVhZCBmcm9tIGluaXRp
YWxpemluZyB0aHJlYWRpbmcKIAogICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CmRpZmYgLS1n
aXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYmhpc3RvcnlpbnRlcmZhY2UvdHN0X3F3ZWJoaXN0b3J5
aW50ZXJmYWNlLmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS90c3Rf
cXdlYmhpc3RvcnlpbnRlcmZhY2UuY3BwCmluZGV4IDQzNWNhZGEuLjg0YjEyZDIgMTAwNjQ0Ci0t
LSBhL1dlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS90c3RfcXdlYmhpc3Rvcnlp
bnRlcmZhY2UuY3BwCisrKyBiL1dlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeWludGVyZmFjZS90
c3RfcXdlYmhpc3RvcnlpbnRlcmZhY2UuY3BwCkBAIC0xOCwxNiArMTgsMTcgQEAKICovCiAKIAog
I2luY2x1ZGUgPFF0VGVzdC9RdFRlc3Q+CiAKICNpbmNsdWRlIDxxd2VicGFnZS5oPgogI2luY2x1
ZGUgPHF3ZWJ2aWV3Lmg+CiAjaW5jbHVkZSA8cXdlYmZyYW1lLmg+CisjaW5jbHVkZSA8cXdlYmVs
ZW1lbnQuaD4KICNpbmNsdWRlIDxxd2ViaGlzdG9yeWludGVyZmFjZS5oPgogI2luY2x1ZGUgPFFE
ZWJ1Zz4KIAogY2xhc3MgdHN0X1FXZWJIaXN0b3J5SW50ZXJmYWNlIDogcHVibGljIFFPYmplY3QK
IHsKICAgICBRX09CSkVDVAogCiBwdWJsaWM6CkBAIC04MCwxNSArODEsMTYgQEAgcHVibGljOgog
LyoKICAqIFRlc3QgdGhhdCB2aXNpdGVkIGxpbmtzIGFyZSBwcm9wZXJseSBjb2xvcmVkLiBodHRw
Oi8vd3d3LnRyb2xsdGVjaC5jb20gaXMgbWFya2VkCiAgKiBhcyB2aXNpdGVkLCBzbyB0aGUgYmVs
b3cgd2Vic2l0ZSBzaG91bGQgaGF2ZSBleGFjdGx5IG9uZSBlbGVtZW50IGluIHRoZSBhOnZpc2l0
ZWQKICAqIHN0YXRlLgogICovCiB2b2lkIHRzdF9RV2ViSGlzdG9yeUludGVyZmFjZTo6dmlzaXRl
ZExpbmtzKCkKIHsKICAgICBRV2ViSGlzdG9yeUludGVyZmFjZTo6c2V0RGVmYXVsdEludGVyZmFj
ZShuZXcgRmFrZUhpc3RvcnlJbXBsZW1lbnRhdGlvbik7Ci0gICAgbV92aWV3LT5zZXRIdG1sKCI8
aHRtbD48Ym9keT48YSBocmVmPSdodHRwOi8vd3d3LnRyb2xsdGVjaC5jb20nPlRyb2xsdGVjaDwv
YT48L2JvZHk+PC9odG1sPiIpOwotICAgIFFDT01QQVJFKG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2
YWx1YXRlSmF2YVNjcmlwdCgiZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnOnZpc2l0ZWQnKS5s
ZW5ndGg7IikudG9TdHJpbmcoKSwKLSAgICAgICAgICAgICBRU3RyaW5nOjpmcm9tTGF0aW4xKCIx
IikpOworICAgIG1fdmlldy0+c2V0SHRtbCgiPGh0bWw+PHN0eWxlPjpsaW5re2NvbG9yOmdyZWVu
fTp2aXNpdGVke2NvbG9yOnJlZH08L3N0eWxlPjxib2R5PjxhIGhyZWY9J2h0dHA6Ly93d3cudHJv
bGx0ZWNoLmNvbScgaWQ9J3ZsaW5rJz5Ucm9sbHRlY2g8L2E+PC9ib2R5PjwvaHRtbD4iKTsKKyAg
ICBRV2ViRWxlbWVudCBhbmNob3IgPSBtX3ZpZXctPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmZpbmRG
aXJzdEVsZW1lbnQoImFbaWQ9dmxpbmtdIik7CisgICAgUVN0cmluZyBsaW5rQ29sb3IgPSBhbmNo
b3Iuc3R5bGVQcm9wZXJ0eSgiY29sb3IiLCBRV2ViRWxlbWVudDo6Q29tcHV0ZWRTdHlsZSk7Cisg
ICAgUUNPTVBBUkUobGlua0NvbG9yLCBRU3RyaW5nOjpmcm9tTGF0aW4xKCJyZ2IoMjU1LCAwLCAw
KSIpKTsKIH0KIAogUVRFU1RfTUFJTih0c3RfUVdlYkhpc3RvcnlJbnRlcmZhY2UpCiAjaW5jbHVk
ZSAidHN0X3F3ZWJoaXN0b3J5aW50ZXJmYWNlLm1vYyIKLS0gCjEuNi4wLjQKCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54565</attachid>
            <date>2010-04-28 08:09:49 -0700</date>
            <delta_ts>2010-04-28 21:40:36 -0700</delta_ts>
            <desc>fix the svn-apply issue</desc>
            <filename>bug37323.patch</filename>
            <type>text/plain</type>
            <size>4088</size>
            <attacher name="Yi Shen">max.hong.shen</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n
ZUxvZwkocmV2aXNpb24gNTg0MDUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEZpeCB0aGUgUVdlYkhpc3RvcnlJbnRlcmZhY2UgdGVzdCBmYWlsdXJlIGJ5IHVzaW5nIGEgY29y
cmVjdCB3YXkgCisgICAgICAgIHRvIGdldCB0aGUgdmlzaXRlZCBsaW5rIGluZm8KKworICAgICAg
ICBbUXRdIHRzdF9RV2ViSGlzdG9yeUludGVyZmFjZTo6dmlzaXRlZExpbmtzKCkgZmFpbHMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MzIzCisKKyAg
ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisgICAg
ICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0
ZWRJbmZvKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR
dC5oOgorICAgICAgICAqIHRlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9y
eWludGVyZmFjZS5jcHA6CisgICAgICAgICh0c3RfUVdlYkhpc3RvcnlJbnRlcmZhY2U6OnZpc2l0
ZWRMaW5rcyk6CisKIDIwMTAtMDQtMjggIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0aW5pQG9w
ZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp
YW5zZW4uCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBw
b3J0UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVu
ZGVyVHJlZVN1cHBvcnRRdC5jcHAJKHJldmlzaW9uIDU4NDA1KQorKysgV2ViS2l0L3F0L1dlYkNv
cmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt
MjMsNiArMjMsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkR1bXBSZW5kZXJU
cmVlU3VwcG9ydFF0LmgiCiAKKyNpbmNsdWRlICJDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24u
aCIKICNpbmNsdWRlICJDb250ZXh0TWVudS5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51Q2xpZW50
UXQuaCIKICNpbmNsdWRlICJDb250ZXh0TWVudUNvbnRyb2xsZXIuaCIKQEAgLTQxNSwzICs0MTYs
MjQgQEAgUVZhcmlhbnRMaXN0IER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpmaQogICAgIHJlY3Qg
PDwgcmVzdWx0UmVjdC54KCkgPDwgcmVzdWx0UmVjdC55KCkgPDwgcmVzdWx0UmVjdC53aWR0aCgp
IDw8IHJlc3VsdFJlY3QuaGVpZ2h0KCk7CiAgICAgcmV0dXJuIHJlY3Q7CiB9CisKK1FWYXJpYW50
TWFwIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojpjb21wdXRlZFN0eWxlSW5jbHVkaW5nVmlzaXRl
ZEluZm8oUVdlYkZyYW1lKiBmcmFtZSwgY29uc3QgUVN0cmluZyYgaWQpCit7CisgICAgUVZhcmlh
bnRNYXAgcmV0OworICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpjb3Jl
KGZyYW1lKTsKKyAgICBpZiAoIWNvcmVGcmFtZSkKKyAgICAgICAgcmV0dXJuIHJldDsKKworICAg
IEVsZW1lbnQqIGVsZW1lbnQgPSBjb3JlRnJhbWUtPmRvY3VtZW50KCktPmdldEVsZW1lbnRCeUlk
KEF0b21pY1N0cmluZyhpZCkpOworICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgcmV0dXJuIHJl
dDsKKworICAgIFJlZlB0cjxDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24+IHN0eWxlID0gY29t
cHV0ZWRTdHlsZShlbGVtZW50LCB0cnVlKTsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IHN0eWxl
LT5sZW5ndGgoKTsgaSsrKSB7CisgICAgICAgIFFTdHJpbmcgbmFtZSA9IHN0eWxlLT5pdGVtKGkp
OworICAgICAgICBRU3RyaW5nIHZhbHVlID0gKHN0YXRpY19jYXN0PENTU1N0eWxlRGVjbGFyYXRp
b24qPihzdHlsZS5nZXQoKSkpLT5nZXRQcm9wZXJ0eVZhbHVlKG5hbWUpOworICAgICAgICByZXRb
bmFtZV0gPSBRVmFyaWFudCh2YWx1ZSk7CisgICAgfQorICAgIHJldHVybiByZXQ7Cit9CisKSW5k
ZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv
cnRRdC5oCShyZXZpc2lvbiA1ODQwNSkKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1w
UmVuZGVyVHJlZVN1cHBvcnRRdC5oCSh3b3JraW5nIGNvcHkpCkBAIC04NSw2ICs4NSw3IEBAIHB1
YmxpYzoKICAgICBzdGF0aWMgaW50IHdvcmtlclRocmVhZENvdW50KCk7CiAKICAgICBzdGF0aWMg
UVN0cmluZyBtYXJrZXJUZXh0Rm9yTGlzdEl0ZW0oY29uc3QgUVdlYkVsZW1lbnQmIGxpc3RJdGVt
KTsKKyAgICBzdGF0aWMgUVZhcmlhbnRNYXAgY29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJ
bmZvKFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJpbmcmIGlkKTsKIH07CiAKICNlbmRpZgpJ
bmRleDogV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9y
eWludGVyZmFjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5
aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9yeWludGVyZmFjZS5jcHAJKHJldmlzaW9uIDU4NDA1KQor
KysgV2ViS2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5aW50ZXJmYWNlL3RzdF9xd2ViaGlzdG9yeWlu
dGVyZmFjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3LDcgKzE3LDcgQEAKICAgICBCb3N0b24s
IE1BIDAyMTEwLTEzMDEsIFVTQS4KICovCiAKLQorI2luY2x1ZGUgIi4uL1dlYkNvcmVTdXBwb3J0
L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmgiCiAjaW5jbHVkZSA8UXRUZXN0L1F0VGVzdD4KIAog
I2luY2x1ZGUgPHF3ZWJwYWdlLmg+CkBAIC04NSw5ICs4NSw5IEBAIHB1YmxpYzoKIHZvaWQgdHN0
X1FXZWJIaXN0b3J5SW50ZXJmYWNlOjp2aXNpdGVkTGlua3MoKQogewogICAgIFFXZWJIaXN0b3J5
SW50ZXJmYWNlOjpzZXREZWZhdWx0SW50ZXJmYWNlKG5ldyBGYWtlSGlzdG9yeUltcGxlbWVudGF0
aW9uKTsKLSAgICBtX3ZpZXctPnNldEh0bWwoIjxodG1sPjxib2R5PjxhIGhyZWY9J2h0dHA6Ly93
d3cudHJvbGx0ZWNoLmNvbSc+VHJvbGx0ZWNoPC9hPjwvYm9keT48L2h0bWw+Iik7Ci0gICAgUUNP
TVBBUkUobV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJkb2N1bWVudC5x
dWVyeVNlbGVjdG9yQWxsKCc6dmlzaXRlZCcpLmxlbmd0aDsiKS50b1N0cmluZygpLAotICAgICAg
ICAgICAgIFFTdHJpbmc6OmZyb21MYXRpbjEoIjEiKSk7CisgICAgbV92aWV3LT5zZXRIdG1sKCI8
aHRtbD48c3R5bGU+Omxpbmt7Y29sb3I6Z3JlZW59OnZpc2l0ZWR7Y29sb3I6cmVkfTwvc3R5bGU+
PGJvZHk+PGEgaHJlZj0naHR0cDovL3d3dy50cm9sbHRlY2guY29tJyBpZD0ndmxpbmsnPlRyb2xs
dGVjaDwvYT48L2JvZHk+PC9odG1sPiIpOworICAgIFFTdHJpbmcgbGlua0NvbG9yID0gRHVtcFJl
bmRlclRyZWVTdXBwb3J0UXQ6OmNvbXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbyhtX3Bh
Z2UtPm1haW5GcmFtZSgpLCAidmxpbmsiKVsiY29sb3IiXS50b1N0cmluZygpOworICAgIFFDT01Q
QVJFKGxpbmtDb2xvciwgUVN0cmluZzo6ZnJvbUxhdGluMSgicmdiKDI1NSwgMCwgMCkiKSk7CiB9
CiAKIFFURVNUX01BSU4odHN0X1FXZWJIaXN0b3J5SW50ZXJmYWNlKQo=
</data>
<flag name="review"
          id="38581"
          type_id="1"
          status="-"
          setter="hausmann"
    />
    <flag name="commit-queue"
          id="38582"
          type_id="3"
          status="-"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>