37322 2010-04-09 02:59:40 -0700 [Qt] tst_QWebHistory::serialize_2() fails 2010-05-18 01:56:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux CLOSED FIXED Qt P1 Blocker --- 38654 1 hausmann jedrzej.nowacki abarth diegohcg eric jedrzej.nowacki jesus webkit.review.bot oldest_to_newest 210653 0 hausmann 2010-04-09 02:59:40 -0700 On Linux/X11: ASSERTION FAILED: item->documentSequenceNumber() == history()->currentItem()->documentSequenceNumber() (../../../WebCore/loader/FrameLoader.cpp:3771 void WebCore::FrameLoader::navigateWithinDocument(WebCore::HistoryItem*)) QFATAL : tst_QWebHistory::serialize_2() Received signal 11 FAIL! : tst_QWebHistory::serialize_2() Received a fatal error. Loc: [Unknown file(0)] 210684 1 jedrzej.nowacki 2010-04-09 04:27:39 -0700 I can reproduce it on debian(32) 210692 2 jedrzej.nowacki 2010-04-09 05:58:05 -0700 The crash is caused by https://bugs.webkit.org/show_bug.cgi?id=33224 210751 3 52958 jedrzej.nowacki 2010-04-09 09:08:25 -0700 Created attachment 52958 solution The diff solve the problem but is a bit strange that we have to set nullitem document sequence number. I'm posting the diff here as a backup, I will investigate. 214184 4 53708 jedrzej.nowacki 2010-04-19 12:59:24 -0700 Created attachment 53708 Fix v1 The solution shoiuld work, I want to do some manual testing before r? flag, but for now it pass all autotests. 214344 5 53740 jedrzej.nowacki 2010-04-19 16:58:25 -0700 Created attachment 53740 Fix v2 Ok, one line solution. Fixes symptoms. After the patch the serialization behave in the same manner as before 33224 bug. Autotests pass. I tried manual testing and it seems to work well. 214349 6 jedrzej.nowacki 2010-04-19 17:08:06 -0700 (In reply to comment #5) > Created an attachment (id=53740) [details] > Fix v2 > > Ok, one line solution. Fixes symptoms. After the patch the serialization behave > in the same manner as before 33224 bug. > > Autotests pass. I tried manual testing and it seems to work well. Patch assumes that if a HistoryItems are in the same group, we can separate them without any consequences. If the assumption is bad then we have to bump streaming protocol version and save on each serialization document sequence number. 220695 7 diegohcg 2010-05-04 11:50:05 -0700 I did no get this test failing anymore. Does anyone is getting this test still failing? 221028 8 jedrzej.nowacki 2010-05-05 02:18:10 -0700 (In reply to comment #7) > I did no get this test failing anymore. Does anyone is getting this test still > failing? Hi, yes problem is still valid. It is an assert so it is visible only in debug, do you use debug build? If you use debug build then provide us more information about your platform. Thank you :-) The bug was reproduced with trunk on Linux(Debian - testing 32). 221179 9 diegohcg 2010-05-05 10:32:50 -0700 (In reply to comment #8) > (In reply to comment #7) > > I did no get this test failing anymore. Does anyone is getting this test still > > failing? > Hi, yes problem is still valid. It is an assert so it is visible only in debug, > do you use debug build? If you use debug build then provide us more information > about your platform. Thank you :-) > > The bug was reproduced with trunk on Linux(Debian - testing 32). Yes sure, We did not test in debug mode. Got the fail now :) 221940 10 jesus 2010-05-06 13:42:54 -0700 *** Bug 38679 has been marked as a duplicate of this bug. *** 227184 11 hausmann 2010-05-18 01:43:05 -0700 Committed r59660: <http://trac.webkit.org/changeset/59660> 227185 12 hausmann 2010-05-18 01:46:40 -0700 Revision r59660 cherry-picked into qtwebkit-2.0 with commit 71e6346a3e2bf9d137d03be4d6dcff79ea0c8358 227193 13 webkit.review.bot 2010-05-18 01:56:36 -0700 http://trac.webkit.org/changeset/59660 might have broken Chromium Win Release The following changes are on the blame list: http://trac.webkit.org/changeset/59659 http://trac.webkit.org/changeset/59660 52958 2010-04-09 09:08:25 -0700 2010-04-19 12:59:24 -0700 solution qwebhistory.diff text/plain 842 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwIGIvV2ViS2l0L3F0L0Fw aS9xd2ViaGlzdG9yeS5jcHAKaW5kZXggZDg1MjAxMi4uYzljY2M2ZSAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0FwaS9xd2ViaGlzdG9yeS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViaGlzdG9y eS5jcHAKQEAgLTUzNyw5ICs1MzcsMTMgQEAgUURhdGFTdHJlYW0mIG9wZXJhdG9yPj4oUURhdGFT dHJlYW0mIHNvdXJjZSwgUVdlYkhpc3RvcnkmIGhpc3RvcnkpCiAgICAgICAgICAgICBmb3IgKGlu dCBpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKICAgICAgICAgICAgICAgICBXVEY6OlBhc3NSZWZQ dHI8V2ViQ29yZTo6SGlzdG9yeUl0ZW0+IGl0ZW0gPSBXZWJDb3JlOjpIaXN0b3J5SXRlbTo6Y3Jl YXRlKCk7CiAgICAgICAgICAgICAgICAgaXRlbS0+cmVzdG9yZVN0YXRlKHNvdXJjZSwgdmVyc2lv bik7CisgICAgICAgICAgICAgICAgaXRlbS0+c2V0RG9jdW1lbnRTZXF1ZW5jZU51bWJlcigxMjMp OwogICAgICAgICAgICAgICAgIGQtPmxzdC0+YWRkSXRlbShpdGVtKTsKICAgICAgICAgICAgIH0K LSAgICAgICAgICAgIGQtPmxzdC0+cmVtb3ZlSXRlbShudWxsSXRlbSk7CisgICAgICAgICAgICBp ZiAobnVsbEl0ZW0pIHsKKyAgICAgICAgICAgICAgICBudWxsSXRlbS0+c2V0RG9jdW1lbnRTZXF1 ZW5jZU51bWJlcigxMjMpOworICAgICAgICAgICAgICAgIGQtPmxzdC0+cmVtb3ZlSXRlbShudWxs SXRlbSk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBoaXN0b3J5LmdvVG9JdGVtKGhpc3Rv cnkuaXRlbUF0KGN1cnJlbnRJbmRleCkpOwogICAgICAgICB9CiAgICAgfQo= 53708 2010-04-19 12:59:24 -0700 2010-04-19 16:58:25 -0700 Fix v1 history.diff text/plain 1830 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwIGIvV2ViS2l0L3F0L0Fw aS9xd2ViaGlzdG9yeS5jcHAKaW5kZXggZDg1MjAxMi4uNzZiMDE5NiAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0FwaS9xd2ViaGlzdG9yeS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViaGlzdG9y eS5jcHAKQEAgLTUzNCwxNiArNTM0LDE4IEBAIFFEYXRhU3RyZWFtJiBvcGVyYXRvcj4+KFFEYXRh U3RyZWFtJiBzb3VyY2UsIFFXZWJIaXN0b3J5JiBoaXN0b3J5KQogICAgICAgICBpZiAoY291bnQp IHsKICAgICAgICAgICAgIC8vIGFmdGVyIGNsZWFyKCkgaXMgbmV3IGNsZWFyIEhpc3RvcnlJdGVt IChhdCB0aGUgZW5kIHdlIGhhZCB0byByZW1vdmUgaXQpCiAgICAgICAgICAgICBXZWJDb3JlOjpI aXN0b3J5SXRlbSogbnVsbEl0ZW0gPSBkLT5sc3QtPmN1cnJlbnRJdGVtKCk7CisgICAgICAgICAg ICAvLyBXZSBoYXZlIHRvIGtlZXAgY3VycmVudCBkb2N1bWVudFNlcXVlbmNlTnVtYmVyIHRvIGJl IGluIHN5bmMgd2l0aCB0aGUgSGlzdG9yeUNvbnRyb2xsZXI6OmN1cnJlbnRJdGVtLgorICAgICAg ICAgICAgbG9uZyBsb25nIGRzbiA9IG51bGxJdGVtID8gbnVsbEl0ZW0tPmRvY3VtZW50U2VxdWVu Y2VOdW1iZXIoKSA6IDEyMzQ1OwogICAgICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBjb3Vu dDsgaSsrKSB7CiAgICAgICAgICAgICAgICAgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6Okhpc3Rv cnlJdGVtPiBpdGVtID0gV2ViQ29yZTo6SGlzdG9yeUl0ZW06OmNyZWF0ZSgpOwogICAgICAgICAg ICAgICAgIGl0ZW0tPnJlc3RvcmVTdGF0ZShzb3VyY2UsIHZlcnNpb24pOworICAgICAgICAgICAg ICAgIGl0ZW0tPnNldERvY3VtZW50U2VxdWVuY2VOdW1iZXIoZHNuKTsKICAgICAgICAgICAgICAg ICBkLT5sc3QtPmFkZEl0ZW0oaXRlbSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBkLT5s c3QtPnJlbW92ZUl0ZW0obnVsbEl0ZW0pOwogICAgICAgICAgICAgaGlzdG9yeS5nb1RvSXRlbSho aXN0b3J5Lml0ZW1BdChjdXJyZW50SW5kZXgpKTsKICAgICAgICAgfQogICAgIH0KLQogICAgIGQt PnBhZ2UoKS0+dXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoKTsKIAogICAgIHJldHVybiBzb3VyY2U7 CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpp bmRleCA5YTM2ZTRhLi5hOTBjYWExIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0xOSAgSmVk cnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggUVdlYkhpc3Rvcnkgc2VyaWFs aXphdGlvbi4KKworICAgICAgICBSZWdyZXNzaW9uIHdhcyBjYXVzZWQgYnkgYnVnIDMzMjI0LiBU aGUgc3RyZWFtaW5nIGZ1bmN0aW9uCisgICAgICAgIHNob3VsZCBnZW5lcmF0ZSBhIGRvY3VtZW50 U2VxdWVuY2VOdW1iZXIgZm9yIGFsbCBsb2FkZWQgdmFsdWVzLgorCisgICAgICAgIFtRdF0gdHN0 X1FXZWJIaXN0b3J5OjpzZXJpYWxpemVfMigpIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMyMgorCisgICAgICAgICogQXBpL3F3ZWJoaXN0 b3J5LmNwcDoKKyAgICAgICAgKG9wZXJhdG9yPj4pOgorCiAyMDEwLTA0LTE4ICBSb2JlcnQgSG9n YW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVz bWFubi4K 53740 2010-04-19 16:58:25 -0700 2010-05-18 01:41:56 -0700 Fix v2 history.diff text/plain 1380 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwIGIvV2ViS2l0L3F0L0Fw aS9xd2ViaGlzdG9yeS5jcHAKaW5kZXggZDg1MjAxMi4uMDdkMzcwOSAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0FwaS9xd2ViaGlzdG9yeS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViaGlzdG9y eS5jcHAKQEAgLTU0MCwxMCArNTQwLDExIEBAIFFEYXRhU3RyZWFtJiBvcGVyYXRvcj4+KFFEYXRh U3RyZWFtJiBzb3VyY2UsIFFXZWJIaXN0b3J5JiBoaXN0b3J5KQogICAgICAgICAgICAgICAgIGQt PmxzdC0+YWRkSXRlbShpdGVtKTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGQtPmxzdC0+ cmVtb3ZlSXRlbShudWxsSXRlbSk7CisgICAgICAgICAgICAvLyBVcGRhdGUgdGhlIEhpc3RvcnlD b250cm9sbGVyLgorICAgICAgICAgICAgaGlzdG9yeS5kLT5wYWdlKCktPnBhZ2UtPm1haW5GcmFt ZSgpLT5sb2FkZXIoKS0+aGlzdG9yeSgpLT5zZXRDdXJyZW50SXRlbShoaXN0b3J5LmQtPmxzdC0+ ZW50cmllcygpW2N1cnJlbnRJbmRleF0uZ2V0KCkpOwogICAgICAgICAgICAgaGlzdG9yeS5nb1Rv SXRlbShoaXN0b3J5Lml0ZW1BdChjdXJyZW50SW5kZXgpKTsKICAgICAgICAgfQogICAgIH0KLQog ICAgIGQtPnBhZ2UoKS0+dXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoKTsKIAogICAgIHJldHVybiBz b3VyY2U7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5n ZUxvZwppbmRleCA5YTM2ZTRhLi5hOTBjYWExIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0x OSAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggUVdlYkhpc3Rvcnkg c2VyaWFsaXphdGlvbi4KKworICAgICAgICBSZWdyZXNzaW9uIHdhcyBjYXVzZWQgYnkgYnVnIDMz MjI0LiBUaGUgc3RyZWFtaW5nIGZ1bmN0aW9uCisgICAgICAgIHNob3VsZCBnZW5lcmF0ZSBhIGRv Y3VtZW50U2VxdWVuY2VOdW1iZXIgZm9yIGFsbCBsb2FkZWQgdmFsdWVzLgorCisgICAgICAgIFtR dF0gdHN0X1FXZWJIaXN0b3J5OjpzZXJpYWxpemVfMigpIGZhaWxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzMyMgorCisgICAgICAgICogQXBpL3F3 ZWJoaXN0b3J5LmNwcDoKKyAgICAgICAgKG9wZXJhdG9yPj4pOgorCiAyMDEwLTA0LTE4ICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1v biBIYXVzbWFubi4K