<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37303</bug_id>
          
          <creation_ts>2010-04-08 18:31:40 -0700</creation_ts>
          <short_desc>[Qt] Application crash on exit if NPPlugin is loaded</short_desc>
          <delta_ts>2010-07-01 00:55:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>S60 Hardware</rep_platform>
          <op_sys>S60 3rd edition</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P1</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35784</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="David Leong">david.leong</reporter>
          <assigned_to name="Abhinav Mithal">abhinav.mithal</assigned_to>
          <cc>abhinav.mithal</cc>
    
    <cc>commit-queue</cc>
    
    <cc>hausmann</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>maheshk</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>210527</commentid>
    <comment_count>0</comment_count>
      <attachid>52930</attachid>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-08 18:31:40 -0700</bug_when>
    <thetext>Created attachment 52930
fix to check for null pointer

Qt-Symbian applications which use Qtwebkit and load Netscape plugins currently crashes on exit.

The crash has been narrowed down to:

void PluginView::platformDestroy()
{
    QWebPageClient* client = m_parentFrame-&gt;view()-&gt;hostWindow()-&gt;platformPageClient();
    if (qobject_cast&lt;QGraphicsWebView*&gt;(client-&gt;pluginParent()))   // Crashes here
        delete static_cast&lt;PluginContainerSymbian*&gt;(platformPluginWidget())-&gt;proxy();
    else
        delete platformPluginWidget();
}

The crash is caused by a NULL client*. qobject_cast causes an exception as it requires a valid QObject pointer to access underlying Qtmetadata.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210544</commentid>
    <comment_count>1</comment_count>
      <attachid>52932</attachid>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-08 19:38:24 -0700</bug_when>
    <thetext>Created attachment 52932
Alternative patch

The plugin view in symbian can only be of a type PluginContainerSymbian. The proxy object is initialized to NULL or a QGraphicsProxyWidget*. There is no harm deleting NULLs, so there is no need to do the qobject_cast. If the platform widget pointer is not null, it should be safe to delete both the proxy and the widget itself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210546</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-04-08 19:39:23 -0700</bug_when>
    <thetext>Attachment 52932 did not pass style-queue:

Failed to run &quot;WebKitTools/Scripts/check-webkit-style&quot; exit_code: 1
WebCore/plugins/symbian/PluginViewSymbian.cpp:417:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210687</commentid>
    <comment_count>3</comment_count>
      <attachid>52932</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-09 05:07:41 -0700</bug_when>
    <thetext>Comment on attachment 52932
Alternative patch


&gt; +    if( PlatformPluginWidget() ) {

This is not going to compile because of the uppercase P.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210688</commentid>
    <comment_count>4</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-09 05:13:14 -0700</bug_when>
    <thetext>Committed r57333: &lt;http://trac.webkit.org/changeset/57333&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210689</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-09 05:18:36 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; Created an attachment (id=52930) [details]
&gt; fix to check for null pointer

Cherry-picked r51006 into qtwebkit-4.6 with commit
14feb62c96ffe2c37e3e2fdac4e370fdbc76ef62</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210711</commentid>
    <comment_count>6</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-09 07:16:37 -0700</bug_when>
    <thetext>Revision r57333 cherry-picked into qtwebkit-2.0 with commit e3b79791d73b624eceebbfbbfd6d6752a532b390</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210826</commentid>
    <comment_count>7</comment_count>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-09 11:40:22 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 52932 [details])
&gt; 
&gt; &gt; +    if( PlatformPluginWidget() ) {
&gt; 
&gt; This is not going to compile because of the uppercase P.

Thanks! Good catch. Funny enough RVCT still compiles and works on the device. 

I think we are leaking the container now with the landed patch. Both the proxy and the container are new&apos;ed but the if fix will only delete the proxy. This leaks the container. Will submit an updated fix once i test out a window&apos;ed plugin to make sure it is working.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210985</commentid>
    <comment_count>8</comment_count>
      <attachid>53005</attachid>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-09 15:46:20 -0700</bug_when>
    <thetext>Created attachment 53005
Patch

Updated alternative patch. It will now properly delete the proxy and the container objects.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211678</commentid>
    <comment_count>9</comment_count>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-12 11:28:28 -0700</bug_when>
    <thetext>Tested the code with window&apos;ed and windowless plugins. For window&apos;ed plugins the current fix will leak the container. Updated the patch with Simon&apos;s comment for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211679</commentid>
    <comment_count>10</comment_count>
      <attachid>53005</attachid>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-12 11:29:52 -0700</bug_when>
    <thetext>Comment on attachment 53005
Patch

Fixes memory leak.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211684</commentid>
    <comment_count>11</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2010-04-12 11:35:54 -0700</bug_when>
    <thetext>changing on behalf of David</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211752</commentid>
    <comment_count>12</comment_count>
      <attachid>53191</attachid>
    <who name="David Leong">david.leong</who>
    <bug_when>2010-04-12 16:26:48 -0700</bug_when>
    <thetext>Created attachment 53191
SVN up&apos;ed to latest webkit to fix auto check errors</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211924</commentid>
    <comment_count>13</comment_count>
      <attachid>52930</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-13 06:50:17 -0700</bug_when>
    <thetext>Comment on attachment 52930
fix to check for null pointer

Clearing review as this attachment has been landed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>211926</commentid>
    <comment_count>14</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-13 06:53:15 -0700</bug_when>
    <thetext>As a side note: Due to the use of QGraphicsProxyWidget this is going to be horribly slow on Symbian and generally mobile platforms. Hopefully the flash plugin on the other side will default to windowless painting, otherwise this isn&apos;t going to be actually usable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>215272</commentid>
    <comment_count>15</comment_count>
      <attachid>53191</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-04-21 06:11:48 -0700</bug_when>
    <thetext>Comment on attachment 53191
SVN up&apos;ed to latest webkit to fix auto check errors

Marking it to cq+ for landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>215631</commentid>
    <comment_count>16</comment_count>
      <attachid>53191</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-21 18:30:10 -0700</bug_when>
    <thetext>Comment on attachment 53191
SVN up&apos;ed to latest webkit to fix auto check errors

Clearing flags on attachment: 53191

Committed r58035: &lt;http://trac.webkit.org/changeset/58035&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>215633</commentid>
    <comment_count>17</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-21 18:30:17 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>216959</commentid>
    <comment_count>18</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-26 03:17:10 -0700</bug_when>
    <thetext>Revision r58035 cherry-picked into qtwebkit-2.0 with commit 7513c8718ac700b5fa7f58cb459f76fadd526df3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244430</commentid>
    <comment_count>19</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-06-29 12:36:11 -0700</bug_when>
    <thetext>Reopening for a potential double-deallocation case when a page is destroyed which had a plugin loaded.

It seems that the container is deleted twice, once with delete container-&gt;proxy(); and then by calling delete container.

Abhinav promised to have a patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244612</commentid>
    <comment_count>20</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2010-06-29 20:47:34 -0700</bug_when>
    <thetext>Fix committed to trunk as http://trac.webkit.org/changeset/62159.

We should seriously consider this patch for the 4.6 and 2.0 branches as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245085</commentid>
    <comment_count>21</comment_count>
    <who name="Mahesh Kulkarni">maheshk</who>
    <bug_when>2010-06-30 21:35:21 -0700</bug_when>
    <thetext>*** Bug 41366 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245167</commentid>
    <comment_count>22</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-07-01 00:48:12 -0700</bug_when>
    <thetext>&lt;cherry-pick-for-backport: r62159&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245172</commentid>
    <comment_count>23</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-07-01 00:55:02 -0700</bug_when>
    <thetext>Revision r62159 cherry-picked into qtwebkit-2.0 with commit 5bddb0b27458a4ac655ca9527393b41a729d3717</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52930</attachid>
            <date>2010-04-08 18:31:40 -0700</date>
            <delta_ts>2010-06-29 12:38:12 -0700</delta_ts>
            <desc>fix to check for null pointer</desc>
            <filename>crash.patch</filename>
            <type>text/plain</type>
            <size>1358</size>
            <attacher name="David Leong">david.leong</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1NzMxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIERhdmlkIExlb25nICA8ZGF2aWQubGVvbmdAbm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFN5bWJpYW4gYXBwcyBjcmFzaCBvbiBleGl0IGR1ZSB0byBhIGJhZCBxT2JqZWN0X2Nhc3QuCisg
ICAgICAgIAorICAgICAgICBBZGRlZCBjaGVjayBmb3IgTlVMTCB0byBhdm9pZCB0aGUgY3Jhc2gu
CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAKKworICAgICAgICAqIHBsdWdpbnMvc3ltYmlhbi9Q
bHVnaW5WaWV3U3ltYmlhbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpwbGF0
Zm9ybURlc3Ryb3kpOgorCiAyMDEwLTAzLTI5ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogV2Vi
Q29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5bWJpYW4uY3BwCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFdlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNwcAkocmV2aXNpb24g
NTczMTEpCisrKyBXZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTQxNSw3ICs0MTUsNyBAQCBib29sIFBsdWdpblZpZXc6OnBsYXRm
b3JtU3RhcnQoKQogdm9pZCBQbHVnaW5WaWV3OjpwbGF0Zm9ybURlc3Ryb3koKQogewogICAgIFFX
ZWJQYWdlQ2xpZW50KiBjbGllbnQgPSBtX3BhcmVudEZyYW1lLT52aWV3KCktPmhvc3RXaW5kb3co
KS0+cGxhdGZvcm1QYWdlQ2xpZW50KCk7Ci0gICAgaWYgKFFHcmFwaGljc1dlYlZpZXcgKndlYlZp
ZXcgPSBxb2JqZWN0X2Nhc3Q8UUdyYXBoaWNzV2ViVmlldyo+KGNsaWVudC0+cGx1Z2luUGFyZW50
KCkpKQorICAgIGlmIChjbGllbnQgJiYgcW9iamVjdF9jYXN0PFFHcmFwaGljc1dlYlZpZXcqPihj
bGllbnQtPnBsdWdpblBhcmVudCgpKSkKICAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PFBsdWdp
bkNvbnRhaW5lclN5bWJpYW4qPihwbGF0Zm9ybVBsdWdpbldpZGdldCgpKS0+cHJveHkoKTsKICAg
ICBlbHNlCiAgICAgICAgIGRlbGV0ZSBwbGF0Zm9ybVBsdWdpbldpZGdldCgpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52932</attachid>
            <date>2010-04-08 19:38:24 -0700</date>
            <delta_ts>2010-04-12 16:26:48 -0700</delta_ts>
            <desc>Alternative patch</desc>
            <filename>crashv2.patch</filename>
            <type>text/plain</type>
            <size>1529</size>
            <attacher name="David Leong">david.leong</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1NzMxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIERhdmlkIExlb25nICA8ZGF2aWQubGVvbmdAbm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFN5bWJpYW4gYXBwcyBjcmFzaCBvbiBleGl0IGR1ZSB0byBhIGJhZCBxT2JqZWN0X2Nhc3QuCisg
ICAgICAgIAorICAgICAgICBBZGRlZCBjaGVjayBmb3IgTlVMTCB0byBhdm9pZCB0aGUgY3Jhc2gu
CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAKKworICAgICAgICAqIHBsdWdpbnMvc3ltYmlhbi9Q
bHVnaW5WaWV3U3ltYmlhbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpwbGF0
Zm9ybURlc3Ryb3kpOgorCiAyMDEwLTAzLTI5ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpJbmRleDogV2Vi
Q29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5bWJpYW4uY3BwCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFdlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNwcAkocmV2aXNpb24g
NTczMTEpCisrKyBXZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTQxNCwxMSArNDE0LDExIEBAIGJvb2wgUGx1Z2luVmlldzo6cGxh
dGZvcm1TdGFydCgpCiAKIHZvaWQgUGx1Z2luVmlldzo6cGxhdGZvcm1EZXN0cm95KCkKIHsKLSAg
ICBRV2ViUGFnZUNsaWVudCogY2xpZW50ID0gbV9wYXJlbnRGcmFtZS0+dmlldygpLT5ob3N0V2lu
ZG93KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOwotICAgIGlmIChRR3JhcGhpY3NXZWJWaWV3ICp3
ZWJWaWV3ID0gcW9iamVjdF9jYXN0PFFHcmFwaGljc1dlYlZpZXcqPihjbGllbnQtPnBsdWdpblBh
cmVudCgpKSkKLSAgICAgICAgZGVsZXRlIHN0YXRpY19jYXN0PFBsdWdpbkNvbnRhaW5lclN5bWJp
YW4qPihwbGF0Zm9ybVBsdWdpbldpZGdldCgpKS0+cHJveHkoKTsKLSAgICBlbHNlCi0gICAgICAg
IGRlbGV0ZSBwbGF0Zm9ybVBsdWdpbldpZGdldCgpOworICAgIGlmKCBQbGF0Zm9ybVBsdWdpbldp
ZGdldCgpICkgeworICAgICAgICBQbHVnaW5Db250YWluZXJTeW1iaWFuKiBjb250YWluZXIgPSBz
dGF0aWNfY2FzdDxQbHVnaW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZvcm1QbHVnaW5XaWRnZXQo
KSk7CisgICAgICAgIGRlbGV0ZSBjb250YWluZXItPnByb3h5KCk7CisgICAgICAgIGRlbGV0ZSBj
b250YWluZXI7CisgICAgfQogfQogCiB2b2lkIFBsdWdpblZpZXc6OmhhbHQoKQo=
</data>
<flag name="review"
          id="36549"
          type_id="1"
          status="-"
          setter="hausmann"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>53005</attachid>
            <date>2010-04-09 15:46:20 -0700</date>
            <delta_ts>2010-04-12 16:26:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>crashv3.patch</filename>
            <type>text/plain</type>
            <size>1601</size>
            <attacher name="David Leong">david.leong</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1NzM3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMDkgIERhdmlkIExlb25nICA8ZGF2aWQubGVvbmdAbm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFtRdF0gU3ltYmlhbiBhcHBzIGNyYXNoIG9uIGV4aXQgZHVlIHRvIGEgYmFkIHFPYmplY3RfY2Fz
dC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzcz
MDMKKworICAgICAgICBBZGRlZCBjaGVjayBmb3IgTlVMTCB0byBhdm9pZCB0aGUgY3Jhc2ggYW5k
IGRlbGV0ZWQgYWxsIGRhdGEKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAg
ICAgICAqIHBsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjpwbGF0Zm9ybURlc3Ryb3kpOgorCiAyMDEwLTA0LTA5ICBEYXZp
ZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIg
SHVudC4KSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlh
bi5jcHAJKHJldmlzaW9uIDU3MzExKQorKysgV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2lu
Vmlld1N5bWJpYW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTQsMTEgKzQxNCwxMSBAQCBib29s
IFBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQoKQogCiB2b2lkIFBsdWdpblZpZXc6OnBsYXRmb3Jt
RGVzdHJveSgpCiB7Ci0gICAgUVdlYlBhZ2VDbGllbnQqIGNsaWVudCA9IG1fcGFyZW50RnJhbWUt
PnZpZXcoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVBhZ2VDbGllbnQoKTsKLSAgICBpZiAoUUdy
YXBoaWNzV2ViVmlldyAqd2ViVmlldyA9IHFvYmplY3RfY2FzdDxRR3JhcGhpY3NXZWJWaWV3Kj4o
Y2xpZW50LT5wbHVnaW5QYXJlbnQoKSkpCi0gICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxQbHVn
aW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSktPnByb3h5KCk7Ci0g
ICAgZWxzZQotICAgICAgICBkZWxldGUgcGxhdGZvcm1QbHVnaW5XaWRnZXQoKTsKKyAgICBpZiAo
cGxhdGZvcm1QbHVnaW5XaWRnZXQoKSkgeworICAgICAgICBQbHVnaW5Db250YWluZXJTeW1iaWFu
KiBjb250YWluZXIgPSBzdGF0aWNfY2FzdDxQbHVnaW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZv
cm1QbHVnaW5XaWRnZXQoKSk7CisgICAgICAgIGRlbGV0ZSBjb250YWluZXItPnByb3h5KCk7Cisg
ICAgICAgIGRlbGV0ZSBjb250YWluZXI7CisgICAgfQogfQogCiB2b2lkIFBsdWdpblZpZXc6Omhh
bHQoKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>53191</attachid>
            <date>2010-04-12 16:26:48 -0700</date>
            <delta_ts>2010-04-21 18:30:10 -0700</delta_ts>
            <desc>SVN up&apos;ed to latest webkit to fix auto check errors</desc>
            <filename>crashv4.patch</filename>
            <type>text/plain</type>
            <size>1571</size>
            <attacher name="David Leong">david.leong</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1NzQ4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMTIgIERhdmlkIExlb25nICA8ZGF2aWQubGVvbmdAbm9r
aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFtRdF0gU3ltYmlhbiBhcHBzIGNyYXNoIG9uIGV4aXQgZHVlIHRvIGEgYmFkIHFPYmplY3RfY2Fz
dC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzcz
MDMKKworICAgICAgICBBZGRlZCBjaGVjayBmb3IgTlVMTCB0byBhdm9pZCB0aGUgY3Jhc2guIFJl
d29ya2VkIHRvIGZpeCBtZW1vcnkgbGVhaworICAgICAgICAgICAKKyAgICAgICAgKiBwbHVnaW5z
L3N5bWJpYW4vUGx1Z2luVmlld1N5bWJpYW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu
Vmlldzo6cGxhdGZvcm1EZXN0cm95KToKKwogMjAxMC0wNC0xMiAgRGF2aWQgSHlhdHQgIDxoeWF0
dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6
IFdlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblZpZXdTeW1iaWFuLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5WaWV3U3ltYmlhbi5jcHAJKHJldmlz
aW9uIDU3NDg0KQorKysgV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luVmlld1N5bWJpYW4u
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTQsMTEgKzQxNCwxMSBAQCBib29sIFBsdWdpblZpZXc6
OnBsYXRmb3JtU3RhcnQoKQogCiB2b2lkIFBsdWdpblZpZXc6OnBsYXRmb3JtRGVzdHJveSgpCiB7
Ci0gICAgUVdlYlBhZ2VDbGllbnQqIGNsaWVudCA9IG1fcGFyZW50RnJhbWUtPnZpZXcoKS0+aG9z
dFdpbmRvdygpLT5wbGF0Zm9ybVBhZ2VDbGllbnQoKTsKLSAgICBpZiAoY2xpZW50ICYmIHFvYmpl
Y3RfY2FzdDxRR3JhcGhpY3NXZWJWaWV3Kj4oY2xpZW50LT5wbHVnaW5QYXJlbnQoKSkpCi0gICAg
ICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxQbHVnaW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZvcm1Q
bHVnaW5XaWRnZXQoKSktPnByb3h5KCk7Ci0gICAgZWxzZQotICAgICAgICBkZWxldGUgcGxhdGZv
cm1QbHVnaW5XaWRnZXQoKTsKKyAgICBpZiAocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSkgeworICAg
ICAgICBQbHVnaW5Db250YWluZXJTeW1iaWFuKiBjb250YWluZXIgPSBzdGF0aWNfY2FzdDxQbHVn
aW5Db250YWluZXJTeW1iaWFuKj4ocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSk7CisgICAgICAgIGRl
bGV0ZSBjb250YWluZXItPnByb3h5KCk7CisgICAgICAgIGRlbGV0ZSBjb250YWluZXI7CisgICAg
fQogfQogCiB2b2lkIFBsdWdpblZpZXc6OmhhbHQoKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>