37294 2010-04-08 15:35:28 -0700 WebView::isLoading should null check m_mainFrame 2010-04-08 17:21:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken abarth eric webkit.review.bot oldest_to_newest 210438 0 sfalken 2010-04-08 15:35:28 -0700 WebView::isLoading should null check m_mainFrame 210444 1 52904 sfalken 2010-04-08 15:46:35 -0700 Created attachment 52904 Patch 210450 2 52904 darin 2010-04-08 15:56:04 -0700 Comment on attachment 52904 Patch Can this just return FALSE without failing, though? Why is it a failure to ask this question of a WebView without a main frame? 210457 3 sfalken 2010-04-08 16:01:15 -0700 http://trac.webkit.org/changeset/57302 210488 4 webkit.review.bot 2010-04-08 17:13:07 -0700 http://trac.webkit.org/changeset/57302 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57304 http://trac.webkit.org/changeset/57301 http://trac.webkit.org/changeset/57302 http://trac.webkit.org/changeset/57303 210493 5 abarth 2010-04-08 17:21:12 -0700 Sorry for the sheriffbot spam. We're fighting through storage/open-database-creation-callback.html. 52904 2010-04-08 15:46:35 -0700 2010-04-08 15:56:04 -0700 Patch diff.txt text/plain 975 sfalken SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1NzI5OCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDggIFN0ZXZlIEZhbGtlbmJ1cmcgIDxz ZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZWJWaWV3Ojppc0xvYWRpbmcgc2hvdWxkIG51bGwgY2hlY2sgbV9tYWluRnJh bWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3Mjk0 CisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OmlzTG9hZGluZyk6 CisKIDIwMTAtMDQtMDcgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFN0ZXZlIEZhbGtlbmJ1cmcuCkluZGV4OiBXZWJLaXQvd2luL1dlYlZp ZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDU3 MjM2KQorKysgV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQyOCw2 ICszNDI4LDkgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3Ojppc0xvYQogCiAg ICAgKmlzTG9hZGluZyA9IEZBTFNFOwogCisgICAgaWYgKCFtX21haW5GcmFtZSkKKyAgICAgICAg cmV0dXJuIEVfRkFJTDsKKwogICAgIGlmIChTVUNDRUVERUQobV9tYWluRnJhbWUtPmRhdGFTb3Vy Y2UoJmRhdGFTb3VyY2UpKSkKICAgICAgICAgZGF0YVNvdXJjZS0+aXNMb2FkaW5nKGlzTG9hZGlu Zyk7CiAK