37290 2010-04-08 14:02:05 -0700 REGRESSION (r55823): database callbacks happen in an isolated world 2010-04-09 00:36:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren dumi abarth dumi eric webkit.review.bot oldest_to_newest 210370 0 ggaren 2010-04-08 14:02:05 -0700 http://trac.webkit.org/changeset/55823 changed database callbacks in JSC, creating a new isolated world for each callback. This seems clearly wrong. A callback should just reuse the world it was created with. This: , m_isolatedWorld(DOMWrapperWorld::create(globalObject->globalData(), true)) should be this: , m_isolatedWorld(globalObject->world()) 210384 1 dumi 2010-04-08 14:25:20 -0700 On it. 210413 2 52899 dumi 2010-04-08 15:09:03 -0700 Created attachment 52899 patch 210420 3 52899 abarth 2010-04-08 15:13:19 -0700 Comment on attachment 52899 patch Test? Or does this fix the open-database test that's failing? 210425 4 ggaren 2010-04-08 15:19:34 -0700 No, it needs a new test. 210426 5 52899 abarth 2010-04-08 15:20:20 -0700 Comment on attachment 52899 patch You heard the man. 210431 6 52901 dumi 2010-04-08 15:23:48 -0700 Created attachment 52901 patch (In reply to comment #5) > (From update of attachment 52899 [details]) > You heard the man. Yessir! 210433 7 52901 ggaren 2010-04-08 15:27:24 -0700 Comment on attachment 52901 patch r=me 210449 8 dumi 2010-04-08 15:55:47 -0700 Landed as r57301. 210487 9 webkit.review.bot 2010-04-08 17:12:56 -0700 http://trac.webkit.org/changeset/57301 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/57304 http://trac.webkit.org/changeset/57301 http://trac.webkit.org/changeset/57302 http://trac.webkit.org/changeset/57303 210491 10 dumi 2010-04-08 17:15:20 -0700 (In reply to comment #9) > http://trac.webkit.org/changeset/57301 might have broken Tiger Intel Release > The following changes are on the blame list: > http://trac.webkit.org/changeset/57304 > http://trac.webkit.org/changeset/57301 > http://trac.webkit.org/changeset/57302 > http://trac.webkit.org/changeset/57303 None of these changes are to blame. The bots just happened to like open-database-creation-callback-isolated-world.html in the previous run, but it failed again when these 4 patches were pulled in. 210610 11 eric 2010-04-09 00:36:26 -0700 The bots have been failing for 12 hours, ever since bug 31482 went in. As far as I can tell, this depends on bug 31482, so I think I'll need to roll both out since Dumi is not around. 52899 2010-04-08 15:09:03 -0700 2010-04-08 15:23:48 -0700 patch patch text/plain 1351 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDggIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXggdGhlIGlzb2xhdGVkIHdvcmxkIGNvZGUgaW4gSlNEYXRhYmFzZUNhbGxiYWNrLmNwcC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjkwCisK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RhdGFiYXNlQ2FsbGJhY2suY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNEYXRhYmFzZUNhbGxiYWNrOjpKU0RhdGFiYXNlQ2FsbGJhY2spOgorCiAyMDEw LTA0LTA3ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNEYXRhYmFzZUNh bGxiYWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGF0YWJhc2VD YWxsYmFjay5jcHAJKHJldmlzaW9uIDU3MjkyKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Rh dGFiYXNlQ2FsbGJhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw2IEBACiAKICNp bmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkpTRGF0YWJhc2UuaCIKLSNpbmNsdWRlICJTY3Jp cHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgogI2lu Y2x1ZGUgPHJ1bnRpbWUvSlNMb2NrLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KQEAg LTQ2LDcgKzQ1LDcgQEAgdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogSlNEYXRhYmFzZUNhbGxiYWNr OjpKU0RhdGFiYXNlQ2FsbGJhY2soSlNPYmplY3QqIGNhbGxiYWNrLCBKU0RPTUdsb2JhbE9iamVj dCogZ2xvYmFsT2JqZWN0KQogICAgIDogbV9kYXRhKG5ldyBKU0NhbGxiYWNrRGF0YShjYWxsYmFj aywgZ2xvYmFsT2JqZWN0KSkKLSAgICAsIG1faXNvbGF0ZWRXb3JsZChET01XcmFwcGVyV29ybGQ6 OmNyZWF0ZShnbG9iYWxPYmplY3QtPmdsb2JhbERhdGEoKSwgdHJ1ZSkpCisgICAgLCBtX2lzb2xh dGVkV29ybGQoZ2xvYmFsT2JqZWN0LT53b3JsZCgpKQogewogfQogCg== 52901 2010-04-08 15:23:48 -0700 2010-04-08 15:27:24 -0700 patch patch text/plain 4503 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDggIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDcmVhdGUgdGhlIGNyZWF0aW9uIGNhbGxiYWNrIGlzIHRoZSBjdXJyZW50IHdvcmxkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyOTAKKworICAg ICAgICAqIGJpbmRpbmdzL2pzL0pTRGF0YWJhc2VDYWxsYmFjay5jcHA6CisgICAgICAgIChXZWJD b3JlOjpKU0RhdGFiYXNlQ2FsbGJhY2s6OkpTRGF0YWJhc2VDYWxsYmFjayk6CisKIDIwMTAtMDQt MDggIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE9saXZlciBIdW50LgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RhdGFiYXNlQ2FsbGJh Y2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvSlNEYXRhYmFzZUNhbGxi YWNrLmNwcAkocmV2aXNpb24gNTcyOTIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGF0YWJh c2VDYWxsYmFjay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDcgKzM1LDYgQEAKIAogI2luY2x1 ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiSlNEYXRhYmFzZS5oIgotI2luY2x1ZGUgIlNjcmlwdENv bnRyb2xsZXIuaCIKICNpbmNsdWRlICJTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgiCiAjaW5jbHVk ZSA8cnVudGltZS9KU0xvY2suaD4KICNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgpAQCAtNDYs NyArNDUsNyBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBKU0RhdGFiYXNlQ2FsbGJhY2s6OkpT RGF0YWJhc2VDYWxsYmFjayhKU09iamVjdCogY2FsbGJhY2ssIEpTRE9NR2xvYmFsT2JqZWN0KiBn bG9iYWxPYmplY3QpCiAgICAgOiBtX2RhdGEobmV3IEpTQ2FsbGJhY2tEYXRhKGNhbGxiYWNrLCBn bG9iYWxPYmplY3QpKQotICAgICwgbV9pc29sYXRlZFdvcmxkKERPTVdyYXBwZXJXb3JsZDo6Y3Jl YXRlKGdsb2JhbE9iamVjdC0+Z2xvYmFsRGF0YSgpLCB0cnVlKSkKKyAgICAsIG1faXNvbGF0ZWRX b3JsZChnbG9iYWxPYmplY3QtPndvcmxkKCkpCiB7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3 Mjk4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTAtMDQtMDggIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRo YXQgdGhlIGNyZWF0aW9uIGNhbGxiYWNrIGlzIGV4ZWN1dGVkIGluIHRoZSB3b3JsZCB3aGVyZSBp dAorICAgICAgICB3YXMgY3JlYXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3MjkwCisKKyAgICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Ut Y3JlYXRpb24tY2FsbGJhY2staXNvbGF0ZWQtd29ybGQtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHN0b3JhZ2Uvb3Blbi1kYXRhYmFzZS1jcmVhdGlvbi1jYWxsYmFjay1pc29sYXRlZC13b3JsZC5o dG1sOgorCiAyMDEwLTA0LTA4ICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3N0b3Jh Z2Uvb3Blbi1kYXRhYmFzZS1jcmVhdGlvbi1jYWxsYmFjay1pc29sYXRlZC13b3JsZC1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNlLWNy ZWF0aW9uLWNhbGxiYWNrLWlzb2xhdGVkLXdvcmxkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTcy OTIpCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL29wZW4tZGF0YWJhc2UtY3JlYXRpb24tY2FsbGJh Y2staXNvbGF0ZWQtd29ybGQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs NCBAQAogQUxFUlQ6IHVuZGVmaW5lZAorQUxFUlQ6IFBBU1M6IGRvY3VtZW50LmJvZHkuYmFyIHZp c2libGUgaW4gYSBjYWxsYmFjayBjcmVhdGVkIGluIHRoaXMgd29ybGQuCiBUaGlzIHRlc3QgdGVz dHMgdGhhdCB0aGUgb3BlbkRhdGFiYXNlKCkgY3JlYXRpb24gY2FsbGJhY2sgaXMgY2FsbGVkIGlu IHRoZSByaWdodCB3b3JsZC4KIApJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFi YXNlLWNyZWF0aW9uLWNhbGxiYWNrLWlzb2xhdGVkLXdvcmxkLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNlLWNyZWF0aW9uLWNhbGxiYWNrLWlzb2xh dGVkLXdvcmxkLmh0bWwJKHJldmlzaW9uIDU3MjkyKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9v cGVuLWRhdGFiYXNlLWNyZWF0aW9uLWNhbGxiYWNrLWlzb2xhdGVkLXdvcmxkLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTQsMTkgKzQsMjcgQEAKIFRoaXMgdGVzdCB0ZXN0cyB0aGF0IHRoZSBvcGVu RGF0YWJhc2UoKSBjcmVhdGlvbiBjYWxsYmFjayBpcyBjYWxsZWQgaW4gdGhlIHJpZ2h0IHdvcmxk LgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiA8c2NyaXB0PgordmFyIGNyZWF0aW9uQ2FsbGJh Y2tzRXhlY3V0ZWQgPSAwOwogZnVuY3Rpb24gZG9uZSgpCiB7Ci0gICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICBpZiAoKCsrY3JlYXRpb25DYWxsYmFja3NFeGVjdXRlZCA9 PSAyKSAmJiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSkKICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogfQogCi1mdW5jdGlvbiBjcmVhdGlvbkNhbGxiYWNr KGRiKQorZnVuY3Rpb24gY3JlYXRpb25DYWxsYmFjazEoZGIpCiB7CiAgICAgYWxlcnQoIkZBSUw6 IFZpc2libGUgaW4gaXNvbGF0ZWQgd29ybGQuIik7CiAgICAgZG9uZSgpOwogfQogCitmdW5jdGlv biBjcmVhdGlvbkNhbGxiYWNrMihkYikKK3sKKyAgICBhbGVydChkb2N1bWVudC5ib2R5LmJhcik7 CisgICAgZG9uZSgpOworfQorCiBkb2N1bWVudC5ib2R5LmZvbyA9ICJGQUlMOiBkb2N1bWVudC5i b2R5LmZvbyB2aXNpYmxlIGluIGlzb2xhdGVkIHdvcmxkLiI7Citkb2N1bWVudC5ib2R5LmJhciA9 ICJQQVNTOiBkb2N1bWVudC5ib2R5LmJhciB2aXNpYmxlIGluIGEgY2FsbGJhY2sgY3JlYXRlZCBp biB0aGlzIHdvcmxkLiI7CiAKIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5jbGVhckFsbERhdGFiYXNlcygpOwpAQCAtMjQsMTIgKzMy LDE0IEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXZh bHVhdGVTY3JpcHRJbklzb2xhdGVkV29ybGQoCiAgICAgICAgIDAsCi0gICAgICAgICJmdW5jdGlv biBjcmVhdGlvbkNhbGxiYWNrKGRiKVxuIiArCisgICAgICAgICJmdW5jdGlvbiBjcmVhdGlvbkNh bGxiYWNrMShkYilcbiIgKwogICAgICAgICAie1xuIiArCiAgICAgICAgICIgICAgYWxlcnQoZG9j dW1lbnQuYm9keS5mb28pO1xuIiArCiAgICAgICAgICIgICAgd2luZG93LmxvY2F0aW9uPSdqYXZh c2NyaXB0OmRvbmUoKSc7XG4iICsKICAgICAgICAgIn1cbiIgKwotICAgICAgICAidmFyIGRiID0g b3BlbkRhdGFiYXNlKCdPcGVuRGF0YWJhc2VDcmVhdGlvbkNhbGxiYWNrSXNvbGF0ZWRXb3JsZCcs ICcxLjAnLCAnJywgMSwgY3JlYXRpb25DYWxsYmFjayk7Iik7CisgICAgICAgICJ2YXIgZGIxID0g b3BlbkRhdGFiYXNlKCdPcGVuRGF0YWJhc2VDcmVhdGlvbkNhbGxiYWNrSXNvbGF0ZWRXb3JsZCcs ICcxLjAnLCAnJywgMSwgY3JlYXRpb25DYWxsYmFjazEpOyIpOworCisgICAgdmFyIGRiMiA9IG9w ZW5EYXRhYmFzZSgnT3BlbkRhdGFiYXNlQ3JlYXRpb25DYWxsYmFja0lzb2xhdGVkV29ybGQyJywg JzEuMCcsICcnLCAxLCBjcmVhdGlvbkNhbGxiYWNrMik7CiB9CiA8L3NjcmlwdD4KIDwvYm9keT4K