37277 2010-04-08 08:45:29 -0700 Move the IDB::open ExceptionCode parameter to be last 2010-04-09 12:50:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow webkit-unassigned commit-queue darin fishd japhet oldest_to_newest 210225 0 jorlow 2010-04-08 08:45:29 -0700 Move the IDB::open ExceptionCode paramter to be last 210228 1 52873 jorlow 2010-04-08 08:50:09 -0700 Created attachment 52873 Patch 210762 2 darin 2010-04-09 09:27:41 -0700 Normally we use the typedef ExceptionCode so we don't have to name exception code arguments. Please do that whenever practical. 210763 3 jorlow 2010-04-09 09:30:52 -0700 (In reply to comment #2) > Normally we use the typedef ExceptionCode so we don't have to name exception > code arguments. Please do that whenever practical. All the uses of int are in the Chromium WebKit API. I suppose maybe we should add a WebExceptionCode class there, but I also don't see a huge advantage to doing so. + fishd in case we think it's a good idea to do so. 210770 4 darin 2010-04-09 09:39:35 -0700 (In reply to comment #3) > All the uses of int are in the Chromium WebKit API. I suppose maybe we should > add a WebExceptionCode class there, but I also don't see a huge advantage to > doing so. I'm surprised that ExceptionCode is part of the Chromium WebKit API. It's an implementation detail we've often changed around in the past and not something particularly stable, so not great for API. But anyway, not on point for this patch. 210772 5 jorlow 2010-04-09 09:43:35 -0700 (In reply to comment #4) > (In reply to comment #3) > > All the uses of int are in the Chromium WebKit API. I suppose maybe we should > > add a WebExceptionCode class there, but I also don't see a huge advantage to > > doing so. > > I'm surprised that ExceptionCode is part of the Chromium WebKit API. It's an > implementation detail we've often changed around in the past and not something > particularly stable, so not great for API. But anyway, not on point for this > patch. Did you mean you're surprised it's not? Anyway, I guess you're right that it is an implementation detail that should probably be abstracted away by an API. I'll look into changing this, unless you have an objection, fishd. 210774 6 darin 2010-04-09 09:45:14 -0700 (In reply to comment #5) > > I'm surprised that ExceptionCode is part of the Chromium WebKit API. It's an > > implementation detail we've often changed around in the past and not something > > particularly stable, so not great for API. But anyway, not on point for this > > patch. > > Did you mean you're surprised it's not? I am surprised that WebCore's internal representation of DOM exceptions is a part of the API. Not the ExceptionCode typedef, which, as you say, is not. 210857 7 52873 commit-queue 2010-04-09 12:50:47 -0700 Comment on attachment 52873 Patch Clearing flags on attachment: 52873 Committed r57350: <http://trac.webkit.org/changeset/57350> 210858 8 commit-queue 2010-04-09 12:50:53 -0700 All reviewed patches have been landed. Closing bug. 52873 2010-04-08 08:50:09 -0700 2010-04-09 12:50:47 -0700 Patch bug-37277-20100408165007.patch text/plain 10886 jorlow ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTE1YmM0Ny4uYmE3ZjU4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzMiBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIE1vdmUgdGhlIElEQjo6b3BlbiBFeGNlcHRpb25Db2Rl IHBhcmFtdGVyIHRvIGJlIGxhc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3Mjc3CisKKyAgICAgICAgTW92ZSB0aGUgRXhjZXB0aW9uQ29kZSBwYXJh bXRlciB0byB0aGUgbGFzdCBwb3NpdGlvbiBpbgorICAgICAgICBJbmRleGVkRGF0YWJhc2VSZXF1 ZXN0OjpvcGVuIGFuZCBmcmllbmRzLiAgSXQgc2hvdWxkIGRlZmluaXRlbHkKKyAgICAgICAgZ28g YWZ0ZXIgdGhlIGNhbGxiYWNrcyB0byBrZWVwIHRoZSBwYXJhbWV0ZXJzIHRoYXQgY29tZSBkaXJl Y3RseQorICAgICAgICBmcm9tIGphdmFzY3JpcHQgdG9nZXRoZXIuICBBbmQgaGF2aW5nIG91dHB1 dCBwYXJhbWV0ZXJzIGFwcGVhcgorICAgICAgICBsYXN0IGlzIGRvbmUgb2Z0ZW4gaW4gdGhlIGNv ZGUgYmFzZSwgc28gaXQgbWFrZXMgc2Vuc2UgdG8gcHVzaAorICAgICAgICBpdCBwYXN0IHRoZSBG cmFtZSogcGFyYW0gYXMgd2VsbC4KKworICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5nZS4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEluZGV4ZWREYXRhYmFzZVJlcXVlc3RDdXN0 b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhJbmRleGVkRGF0YWJhc2VSZXF1ZXN0OjpvcGVu Q2FsbGJhY2spOgorICAgICAgICAqIHN0b3JhZ2UvSW5kZXhlZERhdGFiYXNlLmg6CisgICAgICAg ICogc3RvcmFnZS9JbmRleGVkRGF0YWJhc2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oklu ZGV4ZWREYXRhYmFzZUltcGw6Om9wZW4pOgorICAgICAgICAqIHN0b3JhZ2UvSW5kZXhlZERhdGFi YXNlSW1wbC5oOgorICAgICAgICAqIHN0b3JhZ2UvSW5kZXhlZERhdGFiYXNlUmVxdWVzdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJbmRleGVkRGF0YWJhc2VSZXF1ZXN0OjpvcGVuKToKKyAgICAg ICAgKiBzdG9yYWdlL0luZGV4ZWREYXRhYmFzZVJlcXVlc3QuaDoKKworMjAxMC0wNC0wOCAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBJREIgY2FsbGJhY2tzIHNob3VsZCBmaXJlIGFzeW5j aHJvbm91c2x5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNzI2NQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluZGV4 ZWREYXRhYmFzZVJlcXVlc3RDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhJbmRleGVkRGF0YWJhc2VSZXF1ZXN0Q3VzdG9tLmNwcAppbmRleCBhZmFjNzAzLi5lOGMyYjY4 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluZGV4ZWREYXRhYmFz ZVJlcXVlc3RDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5k ZXhlZERhdGFiYXNlUmVxdWVzdEN1c3RvbS5jcHAKQEAgLTc1LDcgKzc1LDcgQEAgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IFY4SW5kZXhlZERhdGFiYXNlUmVxdWVzdDo6b3BlbkNhbGxiYWNrKGNvbnN0 IHY4OjpBcmd1bWVudHMKICAgICAgICAgVjhDdXN0b21JREJDYWxsYmFja3M8SURCRGF0YWJhc2Us IElEQkRhdGFiYXNlUmVxdWVzdD46OmNyZWF0ZShvblN1Y2Nlc3MsIG9uRXJyb3IsIGZyYW1lLT5k b2N1bWVudCgpKTsKIAogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIGltcC0+b3Blbihu YW1lLCBkZXNjcmlwdGlvbiwgbW9kaWZ5RGF0YWJhc2UsIGVjLCBjYWxsYmFja3MpOworICAgIGlt cC0+b3BlbihuYW1lLCBkZXNjcmlwdGlvbiwgbW9kaWZ5RGF0YWJhc2UsIGNhbGxiYWNrcywgZWMp OwogICAgIGlmIChlYykKICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoZWMpOwogICAgIHJldHVy biB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9J bmRleGVkRGF0YWJhc2UuaCBiL1dlYkNvcmUvc3RvcmFnZS9JbmRleGVkRGF0YWJhc2UuaAppbmRl eCA1OTBjM2VlLi4xMDI3ZmI3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvSW5kZXhlZERh dGFiYXNlLmgKKysrIGIvV2ViQ29yZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZS5oCkBAIC01MSw3 ICs1MSw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJbmRleGVkRGF0YWJhc2U+ IGNyZWF0ZSgpOwogICAgIHZpcnR1YWwgfkluZGV4ZWREYXRhYmFzZSgpIHsgfQogCi0gICAgdmly dHVhbCB2b2lkIG9wZW4oY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGRlc2NyaXB0 aW9uLCBib29sIG1vZGlmeURhdGFiYXNlLCBFeGNlcHRpb25Db2RlJiwgUGFzc1JlZlB0cjxJREJE YXRhYmFzZUNhbGxiYWNrcz4sIEZyYW1lKikgPSAwOworICAgIHZpcnR1YWwgdm9pZCBvcGVuKGNv bnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBkZXNjcmlwdGlvbiwgYm9vbCBtb2RpZnlE YXRhYmFzZSwgUGFzc1JlZlB0cjxJREJEYXRhYmFzZUNhbGxiYWNrcz4sIEZyYW1lKiwgRXhjZXB0 aW9uQ29kZSYpID0gMDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1dlYkNvcmUvc3RvcmFnZS9JbmRleGVkRGF0YWJhc2VJbXBsLmNwcCBiL1dlYkNvcmUvc3RvcmFn ZS9JbmRleGVkRGF0YWJhc2VJbXBsLmNwcAppbmRleCBiMmYwNjYwLi5iODJkZWU4IDEwMDY0NAot LS0gYS9XZWJDb3JlL3N0b3JhZ2UvSW5kZXhlZERhdGFiYXNlSW1wbC5jcHAKKysrIGIvV2ViQ29y ZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZUltcGwuY3BwCkBAIC00OSw3ICs0OSw3IEBAIEluZGV4 ZWREYXRhYmFzZUltcGw6On5JbmRleGVkRGF0YWJhc2VJbXBsKCkKIHsKIH0KIAotdm9pZCBJbmRl eGVkRGF0YWJhc2VJbXBsOjpvcGVuKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBk ZXNjcmlwdGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwgRXhjZXB0aW9uQ29kZSYsIFBhc3NSZWZQ dHI8SURCRGF0YWJhc2VDYWxsYmFja3M+LCBGcmFtZSogZnJhbWUpCit2b2lkIEluZGV4ZWREYXRh YmFzZUltcGw6Om9wZW4oY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGRlc2NyaXB0 aW9uLCBib29sIG1vZGlmeURhdGFiYXNlLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tz PiwgRnJhbWUqLCBFeGNlcHRpb25Db2RlJikKIHsKICAgICAvLyBGSVhNRTogV3JpdGUuCiAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3N0b3JhZ2UvSW5kZXhl ZERhdGFiYXNlSW1wbC5oIGIvV2ViQ29yZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZUltcGwuaApp bmRleCAwYTgxYzEwLi41NDEzYjliIDEwMDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvSW5kZXhl ZERhdGFiYXNlSW1wbC5oCisrKyBiL1dlYkNvcmUvc3RvcmFnZS9JbmRleGVkRGF0YWJhc2VJbXBs LmgKQEAgLTM5LDcgKzM5LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEluZGV4 ZWREYXRhYmFzZUltcGw+IGNyZWF0ZSgpOwogICAgIHZpcnR1YWwgfkluZGV4ZWREYXRhYmFzZUlt cGwoKTsKIAotICAgIHZpcnR1YWwgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3Qg U3RyaW5nJiBkZXNjcmlwdGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwgRXhjZXB0aW9uQ29kZSYs IFBhc3NSZWZQdHI8SURCQ2FsbGJhY2tzPElEQkRhdGFiYXNlPiA+LCBGcmFtZSopOworICAgIHZp cnR1YWwgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBkZXNjcmlw dGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwgUGFzc1JlZlB0cjxJREJDYWxsYmFja3M8SURCRGF0 YWJhc2U+ID4sIEZyYW1lKiwgRXhjZXB0aW9uQ29kZSYpOwogCiBwcml2YXRlOgogICAgIEluZGV4 ZWREYXRhYmFzZUltcGwoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9JbmRleGVkRGF0 YWJhc2VSZXF1ZXN0LmNwcCBiL1dlYkNvcmUvc3RvcmFnZS9JbmRleGVkRGF0YWJhc2VSZXF1ZXN0 LmNwcAppbmRleCA0ZWQ3YjkyLi40NDMwMTE1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2Uv SW5kZXhlZERhdGFiYXNlUmVxdWVzdC5jcHAKKysrIGIvV2ViQ29yZS9zdG9yYWdlL0luZGV4ZWRE YXRhYmFzZVJlcXVlc3QuY3BwCkBAIC00Nyw5ICs0Nyw5IEBAIEluZGV4ZWREYXRhYmFzZVJlcXVl c3Q6On5JbmRleGVkRGF0YWJhc2VSZXF1ZXN0KCkKIHsKIH0KIAotdm9pZCBJbmRleGVkRGF0YWJh c2VSZXF1ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBkZXNjcmlw dGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwgRXhjZXB0aW9uQ29kZSYgZXhjZXB0aW9uLCBQYXNz UmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBjYWxsYmFja3MpCit2b2lkIEluZGV4ZWREYXRh YmFzZVJlcXVlc3Q6Om9wZW4oY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGRlc2Ny aXB0aW9uLCBib29sIG1vZGlmeURhdGFiYXNlLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJh Y2tzPiBjYWxsYmFja3MsIEV4Y2VwdGlvbkNvZGUmIGV4Y2VwdGlvbikKIHsKLSAgICBtX2luZGV4 ZWREYXRhYmFzZS0+b3BlbihuYW1lLCBkZXNjcmlwdGlvbiwgbW9kaWZ5RGF0YWJhc2UsIGV4Y2Vw dGlvbiwgY2FsbGJhY2tzLCBtX2ZyYW1lKTsKKyAgICBtX2luZGV4ZWREYXRhYmFzZS0+b3Blbihu YW1lLCBkZXNjcmlwdGlvbiwgbW9kaWZ5RGF0YWJhc2UsIGNhbGxiYWNrcywgbV9mcmFtZSwgZXhj ZXB0aW9uKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZVJlcXVlc3QuaCBiL1dlYkNvcmUvc3RvcmFnZS9JbmRl eGVkRGF0YWJhc2VSZXF1ZXN0LmgKaW5kZXggOTZlZDg1YS4uODMyMzViNiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZVJlcXVlc3QuaAorKysgYi9XZWJDb3JlL3N0 b3JhZ2UvSW5kZXhlZERhdGFiYXNlUmVxdWVzdC5oCkBAIC01MCw3ICs1MCw3IEBAIHB1YmxpYzoK ICAgICB9CiAgICAgfkluZGV4ZWREYXRhYmFzZVJlcXVlc3QoKTsKIAotICAgIHZvaWQgb3Blbihj b25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIGJvb2wgbW9kaWZ5 RGF0YWJhc2UsIEV4Y2VwdGlvbkNvZGUmLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tz Pik7CisgICAgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiBkZXNj cmlwdGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwgUGFzc1JlZlB0cjxJREJEYXRhYmFzZUNhbGxi YWNrcz4sIEV4Y2VwdGlvbkNvZGUmKTsKIAogICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCkgeyBt X2ZyYW1lID0gMDsgfQogCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBlMzg3ZjcyLi43ZmVhZmQ2IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNC0wOCAgSmVyZW15IE9ybG93ICA8am9ybG93 QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNb3ZlIHRoZSBJREI6Om9wZW4gRXhjZXB0aW9uQ29kZSBwYXJhbXRlciB0byBiZSBs YXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI3 NworCisgICAgICAgIE1vdmUgdGhlIEV4Y2VwdGlvbkNvZGUgcGFyYW10ZXIgdG8gdGhlIGxhc3Qg cG9zaXRpb24gaW4gCisgICAgICAgIEluZGV4ZWREYXRhYmFzZVJlcXVlc3Q6Om9wZW4gYW5kIGZy aWVuZHMuICBJdCBzaG91bGQgZGVmaW5pdGVseQorICAgICAgICBnbyBhZnRlciB0aGUgY2FsbGJh Y2tzIHRvIGtlZXAgdGhlIHBhcmFtZXRlcnMgdGhhdCBjb21lIGRpcmVjdGx5CisgICAgICAgIGZy b20gamF2YXNjcmlwdCB0b2dldGhlci4gIEFuZCBoYXZpbmcgb3V0cHV0IHBhcmFtZXRlcnMgYXBw ZWFyCisgICAgICAgIGxhc3QgaXMgZG9uZSBvZnRlbiBpbiB0aGUgY29kZSBiYXNlLCBzbyBpdCBt YWtlcyBzZW5zZSB0byBwdXNoCisgICAgICAgIGl0IHBhc3QgdGhlIEZyYW1lKiBwYXJhbSBhcyB3 ZWxsLgorCisgICAgICAgICogcHVibGljL1dlYkluZGV4ZWREYXRhYmFzZS5oOgorICAgICAgICAq IHNyYy9JbmRleGVkRGF0YWJhc2VQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmRleGVk RGF0YWJhc2VQcm94eTo6b3Blbik6CisgICAgICAgICogc3JjL0luZGV4ZWREYXRhYmFzZVByb3h5 Lmg6CisgICAgICAgICogc3JjL1dlYkluZGV4ZWREYXRhYmFzZUltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJJbmRleGVkRGF0YWJhc2VJbXBsOjpvcGVuKToKKyAgICAgICAgKiBzcmMvV2Vi SW5kZXhlZERhdGFiYXNlSW1wbC5oOgorCiAyMDEwLTA0LTA3ICBQYXZlbCBGZWxkbWFuICA8cGZl bGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRz a3kuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkluZGV4ZWREYXRhYmFz ZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbmRleGVkRGF0YWJhc2UuaAppbmRleCBm ZDc2YzY0Li5iYjc1MTcwIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklu ZGV4ZWREYXRhYmFzZS5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5kZXhlZERh dGFiYXNlLmgKQEAgLTQ3LDcgKzQ3LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB+V2ViSW5k ZXhlZERhdGFiYXNlKCkgeyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgb3Blbihjb25zdCBXZWJTdHJp bmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgZGVzY3JpcHRpb24sIGJvb2wgbW9kaWZ5RGF0YWJh c2UsIGludCYgZXhjZXB0aW9uQ29kZSwgV2ViSURCQ2FsbGJhY2tzPFdlYklEQkRhdGFiYXNlPios IFdlYkZyYW1lKikgPSAwOworICAgIHZpcnR1YWwgdm9pZCBvcGVuKGNvbnN0IFdlYlN0cmluZyYg bmFtZSwgY29uc3QgV2ViU3RyaW5nJiBkZXNjcmlwdGlvbiwgYm9vbCBtb2RpZnlEYXRhYmFzZSwg V2ViSURCQ2FsbGJhY2tzPFdlYklEQkRhdGFiYXNlPiosIFdlYkZyYW1lKiwgaW50JiBleGNlcHRp b25Db2RlKSA9IDA7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1dl YktpdC9jaHJvbWl1bS9zcmMvSW5kZXhlZERhdGFiYXNlUHJveHkuY3BwIGIvV2ViS2l0L2Nocm9t aXVtL3NyYy9JbmRleGVkRGF0YWJhc2VQcm94eS5jcHAKaW5kZXggM2FkNmRlZi4uOTA2OWI0NiAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9JbmRleGVkRGF0YWJhc2VQcm94eS5jcHAK KysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9JbmRleGVkRGF0YWJhc2VQcm94eS5jcHAKQEAgLTU3 LDExICs1NywxMSBAQCBJbmRleGVkRGF0YWJhc2VQcm94eTo6fkluZGV4ZWREYXRhYmFzZVByb3h5 KCkKIHsKIH0KIAotdm9pZCBJbmRleGVkRGF0YWJhc2VQcm94eTo6b3Blbihjb25zdCBTdHJpbmcm IG5hbWUsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIGJvb2wgbW9kaWZ5RGF0YWJhc2UsIEV4 Y2VwdGlvbkNvZGUmIGVjLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBjYWxsYmFj a3MsIEZyYW1lKiBmcmFtZSkKK3ZvaWQgSW5kZXhlZERhdGFiYXNlUHJveHk6Om9wZW4oY29uc3Qg U3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGRlc2NyaXB0aW9uLCBib29sIG1vZGlmeURhdGFi YXNlLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBjYWxsYmFja3MsIEZyYW1lKiBm cmFtZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgV2ViS2l0OjpXZWJGcmFtZSogd2ViRnJh bWUgPSBXZWJLaXQ6OldlYkZyYW1lSW1wbDo6ZnJvbUZyYW1lKGZyYW1lKTsKLSAgICBtX3dlYklu ZGV4ZWREYXRhYmFzZS0+b3BlbihuYW1lLCBkZXNjcmlwdGlvbiwgbW9kaWZ5RGF0YWJhc2UsIGVj LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5ldyBJREJDYWxsYmFja3NQcm94eTxX ZWJLaXQ6OldlYklEQkRhdGFiYXNlLCBJREJEYXRhYmFzZSwgSURCRGF0YWJhc2VQcm94eT4oY2Fs bGJhY2tzKSwgd2ViRnJhbWUpOworICAgIHR5cGVkZWYgSURCQ2FsbGJhY2tzUHJveHk8V2ViS2l0 OjpXZWJJREJEYXRhYmFzZSwgSURCRGF0YWJhc2UsIElEQkRhdGFiYXNlUHJveHk+IENhbGxiYWNr c1Byb3h5OworICAgIG1fd2ViSW5kZXhlZERhdGFiYXNlLT5vcGVuKG5hbWUsIGRlc2NyaXB0aW9u LCBtb2RpZnlEYXRhYmFzZSwgbmV3IENhbGxiYWNrc1Byb3h5KGNhbGxiYWNrcyksIHdlYkZyYW1l LCBlYyk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvSW5kZXhlZERhdGFiYXNlUHJveHkuaCBiL1dlYktpdC9jaHJvbWl1bS9zcmMv SW5kZXhlZERhdGFiYXNlUHJveHkuaAppbmRleCA5OTdlNWM4Li5kMGY1NWI2IDEwMDY0NAotLS0g YS9XZWJLaXQvY2hyb21pdW0vc3JjL0luZGV4ZWREYXRhYmFzZVByb3h5LmgKKysrIGIvV2ViS2l0 L2Nocm9taXVtL3NyYy9JbmRleGVkRGF0YWJhc2VQcm94eS5oCkBAIC00Miw3ICs0Miw3IEBAIHB1 YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJbmRleGVkRGF0YWJhc2U+IGNyZWF0ZSgpOwog ICAgIHZpcnR1YWwgfkluZGV4ZWREYXRhYmFzZVByb3h5KCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQg b3Blbihjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIGJvb2wg bW9kaWZ5RGF0YWJhc2UsIEV4Y2VwdGlvbkNvZGUmLCBQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2Fs bGJhY2tzPiwgRnJhbWUqKTsKKyAgICB2aXJ0dWFsIHZvaWQgb3Blbihjb25zdCBTdHJpbmcmIG5h bWUsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24sIGJvb2wgbW9kaWZ5RGF0YWJhc2UsIFBhc3NS ZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3M+LCBGcmFtZSosIEV4Y2VwdGlvbkNvZGUmKTsKIAog cHJpdmF0ZToKICAgICBJbmRleGVkRGF0YWJhc2VQcm94eSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJJbmRleGVkRGF0YWJhc2VJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViSW5kZXhlZERhdGFiYXNlSW1wbC5jcHAKaW5kZXggOGE5OThhZi4uNmE2MzI3YiAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbmRleGVkRGF0YWJhc2VJbXBsLmNw cAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkluZGV4ZWREYXRhYmFzZUltcGwuY3BwCkBA IC00Nyw3ICs0Nyw3IEBAIFdlYkluZGV4ZWREYXRhYmFzZUltcGw6On5XZWJJbmRleGVkRGF0YWJh c2VJbXBsKCkKIHsKIH0KIAotdm9pZCBXZWJJbmRleGVkRGF0YWJhc2VJbXBsOjpvcGVuKGNvbnN0 IFdlYlN0cmluZyYgbmFtZSwgY29uc3QgV2ViU3RyaW5nJiBkZXNjcmlwdGlvbiwgYm9vbCBtb2Rp ZnlEYXRhYmFzZSwgaW50JiBleGNlcHRpb25Db2RlLCBXZWJJREJDYWxsYmFja3M8V2ViSURCRGF0 YWJhc2U+KiBjYWxsYmFja3NQdHIsIFdlYkZyYW1lKikKK3ZvaWQgV2ViSW5kZXhlZERhdGFiYXNl SW1wbDo6b3Blbihjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgZGVzY3Jp cHRpb24sIGJvb2wgbW9kaWZ5RGF0YWJhc2UsIFdlYklEQkNhbGxiYWNrczxXZWJJREJEYXRhYmFz ZT4qIGNhbGxiYWNrc1B0ciwgV2ViRnJhbWUqLCBpbnQmIGV4Y2VwdGlvbkNvZGUpCiB7CiAgICAg T3duUHRyPFdlYklEQkNhbGxiYWNrczxXZWJJREJEYXRhYmFzZT4qPiBjYWxsYmFja3MoY2FsbGJh Y2tzUHRyKTsKICAgICBjYWxsYmFja3MtPm9uRXJyb3IoV2ViSURCRGF0YWJhc2VFcnJvcigwLCAi Tm90IGltcGxlbWVudGVkIikpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJ bmRleGVkRGF0YWJhc2VJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkluZGV4ZWREYXRh YmFzZUltcGwuaAppbmRleCBlNzM0NzMyLi5iNGI4Yzk5IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkluZGV4ZWREYXRhYmFzZUltcGwuaAorKysgYi9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYkluZGV4ZWREYXRhYmFzZUltcGwuaApAQCAtMzcsNyArMzcsNyBAQCBjbGFzcyBXZWJJ bmRleGVkRGF0YWJhc2VJbXBsIDogcHVibGljIFdlYkluZGV4ZWREYXRhYmFzZSB7CiBwdWJsaWM6 CiAgICAgdmlydHVhbCB+V2ViSW5kZXhlZERhdGFiYXNlSW1wbCgpOwogCi0gICAgdmlydHVhbCB2 b2lkIG9wZW4oY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBjb25zdCBXZWJTdHJpbmcmIGRlc2NyaXB0 aW9uLCBib29sIG1vZGlmeURhdGFiYXNlLCBpbnQmIGV4Y2VwdGlvbkNvZGUsIFdlYklEQkNhbGxi YWNrczxXZWJJREJEYXRhYmFzZT4qLCBXZWJGcmFtZSopOworICAgIHZpcnR1YWwgdm9pZCBvcGVu KGNvbnN0IFdlYlN0cmluZyYgbmFtZSwgY29uc3QgV2ViU3RyaW5nJiBkZXNjcmlwdGlvbiwgYm9v bCBtb2RpZnlEYXRhYmFzZSwgV2ViSURCQ2FsbGJhY2tzPFdlYklEQkRhdGFiYXNlPiosIFdlYkZy YW1lKiwgaW50JiBleGNlcHRpb25Db2RlKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=