37274 2010-04-08 08:01:05 -0700 Report resource URL and error details in resource events 2010-04-09 15:43:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P4 Minor --- 0 caseq webkit-unassigned ap commit-queue oldest_to_newest 210192 0 caseq 2010-04-08 08:01:05 -0700 When resource loader reports resource events, the following methods return unexpected values: - ResourceError::failingURL() is always empty - ResourceResponse::httpStatusText() is always "OK" 210196 1 52866 caseq 2010-04-08 08:05:58 -0700 Created attachment 52866 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values 210201 2 52866 caseq 2010-04-08 08:11:31 -0700 Comment on attachment 52866 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values One of changed test expectations was accidently missing from patch, about to commit another one in a few minutes. 210204 3 52868 caseq 2010-04-08 08:18:45 -0700 Created attachment 52868 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values 210302 4 52868 darin 2010-04-08 11:57:02 -0700 Comment on attachment 52868 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values > + m_failingURL = failingURLString; Good fix. Where's the test case for this, though? It's separate from the other fix. We don't take bug fixes without test cases. > - // FIXME: it would be nice to have a way to get the real status text eventually. > - m_httpStatusText = "OK"; > + // we used to return "OK" for everything, so be compatible and return "OK" for 200. > + m_httpStatusText = m_httpStatusCode == 200 ? String("OK") > + : String([NSHTTPURLResponse localizedStringForStatusCode: m_httpStatusCode]); Does the localizedStringForStatusCode method exist on all platforms we build on? Tiger? Formatting here is wrong -- we normally don't indent the second line of a conditional expression like this. We just indent by a single tab stop. What does [NSHTTPURLResponse localizedStringForStatusCode:] return for 200? Do we really need the hard-coded string? 210793 5 caseq 2010-04-09 10:31:29 -0700 (In reply to comment #4) > (From update of attachment 52868 [details]) > > + m_failingURL = failingURLString; > > Good fix. Where's the test case for this, though? It's separate from the other > fix. We don't take bug fixes without test cases. There's a bit of a problem with testing for this -- currently, resource notification related code in DumpRenderTree is platform-specific (DumpRenderTree/mac/ResourceLoadDelegate.mm) and uses native platform classes (NSError & co) only -- the classes that I changed are not used at all. Adding tests for them at this level would require implementing tests explicitly for different platforms, plus passing additional flags via LayoutTestsController. A much cheaper and practical solution would be to test it on a higher level -- e.g. in inspector tests, as my initial motivation for fixing this was to enable logging of messages to inspector console in case of resource loading problems. This will also cover all platforms at once. This requires, however, that the patch for logging resource errors to inspector is landed (http://webkit.org/b/37215), so I added the test there. In will only pass once both this and 37215 are landed, though. > > - // FIXME: it would be nice to have a way to get the real status text eventually. > > - m_httpStatusText = "OK"; > > + // we used to return "OK" for everything, so be compatible and return "OK" for 200. > > + m_httpStatusText = m_httpStatusCode == 200 ? String("OK") > > + : String([NSHTTPURLResponse localizedStringForStatusCode: m_httpStatusCode]); > > Does the localizedStringForStatusCode method exist on all platforms we build > on? Tiger? At least the manual says so (http://developer.apple.com/mac/library/documentation/Cocoa/Reference/Foundation/Classes/NSHTTPURLResponse_Class/Reference/Reference.html): Return Value A localized string suitable for displaying to users that describes the specified status code. Availability Available in Mac OS X v10.2 with Safari 1.0 installed. Available in Mac OS X v10.2.7 and later. > > Formatting here is wrong -- we normally don't indent the second line of a > conditional expression like this. We just indent by a single tab stop. Fixed! > What does [NSHTTPURLResponse localizedStringForStatusCode:] return for 200? Do > we really need the hard-coded string? localizedStringForStatusCode returns "no error". I don't have an evidence that we really need this hack (except for a handful of tests that would need to be re-baselined as a result of this), but considering this value is made available to JS via XMLHttpRequest.statusText, I'd rather be on a safe side and leave it as it used to be in cases where it doesn't contradict numeric value (especially given that OK is what HTTP/1.1 suggests for 200). 210798 6 52967 caseq 2010-04-09 10:36:37 -0700 Created attachment 52967 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values (style fixed) 210861 7 52967 commit-queue 2010-04-09 13:01:27 -0700 Comment on attachment 52967 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values (style fixed) Clearing flags on attachment: 52967 Committed r57351: <http://trac.webkit.org/changeset/57351> 210862 8 commit-queue 2010-04-09 13:01:31 -0700 All reviewed patches have been landed. Closing bug. 210979 9 ap 2010-04-09 15:43:33 -0700 I don't think it's a good idea to synthesize status text - if someone actually needs to look at it, they won't appreciate us lying. Fortunately, there was a way to fix this long-standing issue, see bug 24572. 52866 2010-04-08 08:05:58 -0700 2010-04-08 08:11:30 -0700 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values resource-info.patch text/plain 3709 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBSZXNvdXJjZUVycm9yOjpmYWlsaW5nVVJMKCkgYW5kIFJlc291cmNlUmVzcG9uc2U6 Omh0dHBTdGF0dXNUZXh0KCkKKyAgICAgICAgdG8gcmV0dXJuIG1lYW5pbmdmdWwgdmFsdWVzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyNzQKKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW06CisgICAg ICAgIChXZWJDb3JlOjpSZXNvdXJjZUVycm9yOjpwbGF0Zm9ybUxhenlJbml0KToKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdCk6CisKIDIwMTAtMDQt MDEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXZpZCBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMv UmVzb3VyY2VFcnJvck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW0JKHJldmlzaW9uIDU3MjE0KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUVycm9yTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBA IC00Nyw5ICs0Nyw5IEBAIHZvaWQgUmVzb3VyY2VFcnJvcjo6cGxhdGZvcm1MYXp5SW5pdCgpCiAg ICAgTlNTdHJpbmcqIGZhaWxpbmdVUkxTdHJpbmcgPSBbW21fcGxhdGZvcm1FcnJvci5nZXQoKSB1 c2VySW5mb10gdmFsdWVGb3JLZXk6QCJOU0Vycm9yRmFpbGluZ1VSTFN0cmluZ0tleSJdOwogICAg IGlmICghZmFpbGluZ1VSTFN0cmluZykKICAgICAgICAgZmFpbGluZ1VSTFN0cmluZyA9IFtbW21f cGxhdGZvcm1FcnJvci5nZXQoKSB1c2VySW5mb10gdmFsdWVGb3JLZXk6QCJOU0Vycm9yRmFpbGlu Z1VSTEtleSJdIGFic29sdXRlU3RyaW5nXTsKLSAgICAKKyAgICBtX2ZhaWxpbmdVUkwgPSBmYWls aW5nVVJMU3RyaW5nOyAKICAgICAvLyBXb3JrYXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vNjU1 NDA2Nz4KLSAgICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gZmFpbGluZ1VSTFN0cmluZzsKKyAg ICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gbV9mYWlsaW5nVVJMOwogICAgIEJFR0lOX0JMT0NL X09CSkNfRVhDRVBUSU9OUzsKICAgICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gW21fcGxhdGZv cm1FcnJvci5nZXQoKSBfd2ViX2xvY2FsaXplZERlc2NyaXB0aW9uXTsKICAgICBFTkRfQkxPQ0tf T0JKQ19FWENFUFRJT05TOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNv dXJjZVJlc3BvbnNlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQkocmV2aXNpb24gNTcyMTQpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTc5LDggKzc5LDkgQEAgdm9pZCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJ bml0KAogICAgICAgICAKICAgICAgICAgbV9odHRwU3RhdHVzQ29kZSA9IFtodHRwUmVzcG9uc2Ug c3RhdHVzQ29kZV07CiAgICAgICAgIAotICAgICAgICAvLyBGSVhNRTogaXQgd291bGQgYmUgbmlj ZSB0byBoYXZlIGEgd2F5IHRvIGdldCB0aGUgcmVhbCBzdGF0dXMgdGV4dCBldmVudHVhbGx5Lgot ICAgICAgICBtX2h0dHBTdGF0dXNUZXh0ID0gIk9LIjsKKyAgICAgICAgLy8gd2UgdXNlZCB0byBy ZXR1cm4gIk9LIiBmb3IgZXZlcnl0aGluZywgc28gYmUgY29tcGF0aWJsZSBhbmQgcmV0dXJuICJP SyIgZm9yIDIwMC4KKyAgICAgICAgbV9odHRwU3RhdHVzVGV4dCA9IG1faHR0cFN0YXR1c0NvZGUg PT0gMjAwID8gU3RyaW5nKCJPSyIpIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOiBTdHJpbmcoW05TSFRUUFVSTFJlc3BvbnNlIGxvY2FsaXplZFN0 cmluZ0ZvclN0YXR1c0NvZGU6IG1faHR0cFN0YXR1c0NvZGVdKTsKICAgICAgICAgCiAgICAgICAg IE5TRGljdGlvbmFyeSAqaGVhZGVycyA9IFtodHRwUmVzcG9uc2UgYWxsSGVhZGVyRmllbGRzXTsK ICAgICAgICAgTlNFbnVtZXJhdG9yICplID0gW2hlYWRlcnMga2V5RW51bWVyYXRvcl07CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA1NzI3OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0LTA4ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNl cUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hhbmdlZCBleHBlY3RhdGlvbiBmb3IgdGV4dCBzdGF0dXMgZm9yIEhUVFAgc3Rh dHVzIG9mIDQwMCBmb2xsb3dpbmcKKyAgICAgICAgZml4IGZvciBsb2NhbGl6ZXIgc3RhdHVzIG1l c3NhZ2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzcyNzQKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3dlYi1hcHBzLzAxMy1leHBlY3RlZC50eHQ6CisKIDIwMTAtMDQtMDEgIEFudG9uaW8gR29tZXMg IDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0 dC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3dlYi1hcHBzLzAxMy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd2ViLWFwcHMvMDEzLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gNTcyMTQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC93ZWItYXBwcy8wMTMtZXhwZWN0ZWQudHh0CSh3b3JraW5n IGNvcHkpCkBAIC0xICsxIEBACi1GQUlMOiBTdGF0dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAw LCAiT0siCitGQUlMOiBTdGF0dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAwLCAiYmFkIHJlcXVl c3QiCg== 52868 2010-04-08 08:18:45 -0700 2010-04-09 10:36:37 -0700 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values resource-info.patch text/plain 4390 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBSZXNvdXJjZUVycm9yOjpmYWlsaW5nVVJMKCkgYW5kIFJlc291cmNlUmVzcG9uc2U6 Omh0dHBTdGF0dXNUZXh0KCkKKyAgICAgICAgdG8gcmV0dXJuIG1lYW5pbmdmdWwgdmFsdWVzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyNzQKKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW06CisgICAg ICAgIChXZWJDb3JlOjpSZXNvdXJjZUVycm9yOjpwbGF0Zm9ybUxhenlJbml0KToKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdCk6CisKIDIwMTAtMDQt MDEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXZpZCBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMv UmVzb3VyY2VFcnJvck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW0JKHJldmlzaW9uIDU3MjE0KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUVycm9yTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBA IC00Nyw5ICs0Nyw5IEBAIHZvaWQgUmVzb3VyY2VFcnJvcjo6cGxhdGZvcm1MYXp5SW5pdCgpCiAg ICAgTlNTdHJpbmcqIGZhaWxpbmdVUkxTdHJpbmcgPSBbW21fcGxhdGZvcm1FcnJvci5nZXQoKSB1 c2VySW5mb10gdmFsdWVGb3JLZXk6QCJOU0Vycm9yRmFpbGluZ1VSTFN0cmluZ0tleSJdOwogICAg IGlmICghZmFpbGluZ1VSTFN0cmluZykKICAgICAgICAgZmFpbGluZ1VSTFN0cmluZyA9IFtbW21f cGxhdGZvcm1FcnJvci5nZXQoKSB1c2VySW5mb10gdmFsdWVGb3JLZXk6QCJOU0Vycm9yRmFpbGlu Z1VSTEtleSJdIGFic29sdXRlU3RyaW5nXTsKLSAgICAKKyAgICBtX2ZhaWxpbmdVUkwgPSBmYWls aW5nVVJMU3RyaW5nOyAKICAgICAvLyBXb3JrYXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vNjU1 NDA2Nz4KLSAgICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gZmFpbGluZ1VSTFN0cmluZzsKKyAg ICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gbV9mYWlsaW5nVVJMOwogICAgIEJFR0lOX0JMT0NL X09CSkNfRVhDRVBUSU9OUzsKICAgICBtX2xvY2FsaXplZERlc2NyaXB0aW9uID0gW21fcGxhdGZv cm1FcnJvci5nZXQoKSBfd2ViX2xvY2FsaXplZERlc2NyaXB0aW9uXTsKICAgICBFTkRfQkxPQ0tf T0JKQ19FWENFUFRJT05TOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNv dXJjZVJlc3BvbnNlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQkocmV2aXNpb24gNTcyMTQpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVzcG9uc2VNYWMubW0JKHdvcmtpbmcgY29w eSkKQEAgLTc5LDggKzc5LDkgQEAgdm9pZCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUxhenlJ bml0KAogICAgICAgICAKICAgICAgICAgbV9odHRwU3RhdHVzQ29kZSA9IFtodHRwUmVzcG9uc2Ug c3RhdHVzQ29kZV07CiAgICAgICAgIAotICAgICAgICAvLyBGSVhNRTogaXQgd291bGQgYmUgbmlj ZSB0byBoYXZlIGEgd2F5IHRvIGdldCB0aGUgcmVhbCBzdGF0dXMgdGV4dCBldmVudHVhbGx5Lgot ICAgICAgICBtX2h0dHBTdGF0dXNUZXh0ID0gIk9LIjsKKyAgICAgICAgLy8gd2UgdXNlZCB0byBy ZXR1cm4gIk9LIiBmb3IgZXZlcnl0aGluZywgc28gYmUgY29tcGF0aWJsZSBhbmQgcmV0dXJuICJP SyIgZm9yIDIwMC4KKyAgICAgICAgbV9odHRwU3RhdHVzVGV4dCA9IG1faHR0cFN0YXR1c0NvZGUg PT0gMjAwID8gU3RyaW5nKCJPSyIpIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgOiBTdHJpbmcoW05TSFRUUFVSTFJlc3BvbnNlIGxvY2FsaXplZFN0 cmluZ0ZvclN0YXR1c0NvZGU6IG1faHR0cFN0YXR1c0NvZGVdKTsKICAgICAgICAgCiAgICAgICAg IE5TRGljdGlvbmFyeSAqaGVhZGVycyA9IFtodHRwUmVzcG9uc2UgYWxsSGVhZGVyRmllbGRzXTsK ICAgICAgICAgTlNFbnVtZXJhdG9yICplID0gW2hlYWRlcnMga2V5RW51bWVyYXRvcl07CkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA1NzI3OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0LTA4ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNl cUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hhbmdlZCBleHBlY3RhdGlvbiBmb3IgdGV4dCBzdGF0dXMgZm9yIEhUVFAgc3Rh dHVzIG9mIDR4eCBmb2xsb3dpbmcKKyAgICAgICAgYSBmaXggZm9yIGxvY2FsaXplZCBzdGF0dXMg bWVzc2FnZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC93ZWItYXBwcy8wMTMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL21hYy9o dHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1leGNl cHRpb24tZXhwZWN0ZWQudHh0OgorCiAyMDEwLTA0LTA4ICBLZW50IFRhbXVyYSAgPHRrZW50QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggYSB0ZXN0IGZvciB0aGUgYmVo YXZpb3IgY2hhbmdlIGJ5IHI1NzI3NC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9o dHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1leGNl cHRpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1l eGNlcHRpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1NzIxNCkKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3Np bmctZmlsZS1leGNlcHRpb24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01LDUgKzUs NSBAQCByZWFkeVN0YXRlOiA0IChudW1iZXIpCiByZXNwb25zZVRleHQ6IE5vbi1lbXB0eSAoc3Ry aW5nKQogcmVzcG9uc2VYTUw6IG51bGwgKG9iamVjdCkKIHN0YXR1czogNDA0IChudW1iZXIpCi1z dGF0dXNUZXh0OiBPSyAoc3RyaW5nKQorc3RhdHVzVGV4dDogbm90IGZvdW5kIChzdHJpbmcpCiAK SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0 L3dlYi1hcHBzLzAxMy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd2ViLWFwcHMvMDEzLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gNTcyMTQpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC93ZWItYXBwcy8wMTMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xICsxIEBACi1GQUlMOiBTdGF0dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAwLCAi T0siCitGQUlMOiBTdGF0dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAwLCAiYmFkIHJlcXVlc3Qi Cg== 52967 2010-04-09 10:36:37 -0700 2010-04-09 13:01:26 -0700 Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText() to return meaningful values (style fixed) resource-info.patch text/plain 4375 caseq SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDkgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBSZXNvdXJjZUVycm9yOjpmYWlsaW5nVVJMKCkgYW5kIFJlc291cmNlUmVzcG9uc2U6 Omh0dHBTdGF0dXNUZXh0KCkKKyAgICAgICAgdG8gcmV0dXJuIG1lYW5pbmdmdWwgdmFsdWVzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyNzQKKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW06CisgICAg ICAgIChXZWJDb3JlOjpSZXNvdXJjZUVycm9yOjpwbGF0Zm9ybUxhenlJbml0KToKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZVJlc3BvbnNlTWFjLm1tOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdCk6CisKIDIwMTAtMDQt MDkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggdGhlIG1hYyBX ZWJLaXQyIGJ1aWxkLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJj ZUVycm9yTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMv UmVzb3VyY2VFcnJvck1hYy5tbQkocmV2aXNpb24gNTczMzkpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvbWFjL1Jlc291cmNlRXJyb3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ3LDkg KzQ3LDkgQEAgdm9pZCBSZXNvdXJjZUVycm9yOjpwbGF0Zm9ybUxhenlJbml0KCkKICAgICBOU1N0 cmluZyogZmFpbGluZ1VSTFN0cmluZyA9IFtbbV9wbGF0Zm9ybUVycm9yLmdldCgpIHVzZXJJbmZv XSB2YWx1ZUZvcktleTpAIk5TRXJyb3JGYWlsaW5nVVJMU3RyaW5nS2V5Il07CiAgICAgaWYgKCFm YWlsaW5nVVJMU3RyaW5nKQogICAgICAgICBmYWlsaW5nVVJMU3RyaW5nID0gW1tbbV9wbGF0Zm9y bUVycm9yLmdldCgpIHVzZXJJbmZvXSB2YWx1ZUZvcktleTpAIk5TRXJyb3JGYWlsaW5nVVJMS2V5 Il0gYWJzb2x1dGVTdHJpbmddOwotICAgIAorICAgIG1fZmFpbGluZ1VSTCA9IGZhaWxpbmdVUkxT dHJpbmc7IAogICAgIC8vIFdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS82NTU0MDY3Pgot ICAgIG1fbG9jYWxpemVkRGVzY3JpcHRpb24gPSBmYWlsaW5nVVJMU3RyaW5nOworICAgIG1fbG9j YWxpemVkRGVzY3JpcHRpb24gPSBtX2ZhaWxpbmdVUkw7CiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19F WENFUFRJT05TOwogICAgIG1fbG9jYWxpemVkRGVzY3JpcHRpb24gPSBbbV9wbGF0Zm9ybUVycm9y LmdldCgpIF93ZWJfbG9jYWxpemVkRGVzY3JpcHRpb25dOwogICAgIEVORF9CTE9DS19PQkpDX0VY Q0VQVElPTlM7CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlUmVz cG9uc2VNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9S ZXNvdXJjZVJlc3BvbnNlTWFjLm1tCShyZXZpc2lvbiA1NzMzOSkKKysrIFdlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9tYWMvUmVzb3VyY2VSZXNwb25zZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAt NzksOCArNzksOSBAQCB2b2lkIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtTGF6eUluaXQoCiAg ICAgICAgIAogICAgICAgICBtX2h0dHBTdGF0dXNDb2RlID0gW2h0dHBSZXNwb25zZSBzdGF0dXND b2RlXTsKICAgICAgICAgCi0gICAgICAgIC8vIEZJWE1FOiBpdCB3b3VsZCBiZSBuaWNlIHRvIGhh dmUgYSB3YXkgdG8gZ2V0IHRoZSByZWFsIHN0YXR1cyB0ZXh0IGV2ZW50dWFsbHkuCi0gICAgICAg IG1faHR0cFN0YXR1c1RleHQgPSAiT0siOworICAgICAgICAvLyB3ZSB1c2VkIHRvIHJldHVybiAi T0siIGZvciBldmVyeXRoaW5nLCBzbyBiZSBjb21wYXRpYmxlIGFuZCByZXR1cm4gIk9LIiBmb3Ig MjAwLgorICAgICAgICBtX2h0dHBTdGF0dXNUZXh0ID0gbV9odHRwU3RhdHVzQ29kZSA9PSAyMDAg PyBTdHJpbmcoIk9LIikgCisgICAgICAgICAgICA6IFN0cmluZyhbTlNIVFRQVVJMUmVzcG9uc2Ug bG9jYWxpemVkU3RyaW5nRm9yU3RhdHVzQ29kZTogbV9odHRwU3RhdHVzQ29kZV0pOwogICAgICAg ICAKICAgICAgICAgTlNEaWN0aW9uYXJ5ICpoZWFkZXJzID0gW2h0dHBSZXNwb25zZSBhbGxIZWFk ZXJGaWVsZHNdOwogICAgICAgICBOU0VudW1lcmF0b3IgKmUgPSBbaGVhZGVycyBrZXlFbnVtZXJh dG9yXTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDU3MzQ0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDkgIEFuZHJleSBLb3N5 YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIGV4cGVjdGF0aW9uIGZvciB0ZXh0IHN0YXR1cyBm b3IgSFRUUCBzdGF0dXMgb2YgNHh4IGZvbGxvd2luZworICAgICAgICBhIGZpeCBmb3IgbG9jYWxp emVkIHN0YXR1cyBtZXNzYWdlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3Mjc0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvaHR0cC90ZXN0cy94 bWxodHRwcmVxdWVzdC93ZWItYXBwcy8wMTMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRm b3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3Npbmct ZmlsZS1leGNlcHRpb24tZXhwZWN0ZWQudHh0OgorCiAyMDEwLTA0LTA5ICBBbmRyYXMgQmVjc2kg IDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBTaW1vbiBI YXVzbWFubi4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0 dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1leGNlcHRpb24tZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1leGNlcHRpb24tZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiA1NzMzOSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9odHRw L3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW1pc3NpbmctZmlsZS1leGNlcHRp b24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01LDUgKzUsNSBAQCByZWFkeVN0YXRl OiA0IChudW1iZXIpCiByZXNwb25zZVRleHQ6IE5vbi1lbXB0eSAoc3RyaW5nKQogcmVzcG9uc2VY TUw6IG51bGwgKG9iamVjdCkKIHN0YXR1czogNDA0IChudW1iZXIpCi1zdGF0dXNUZXh0OiBPSyAo c3RyaW5nKQorc3RhdHVzVGV4dDogbm90IGZvdW5kIChzdHJpbmcpCiAKSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dlYi1hcHBzLzAxMy1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2h0dHAv dGVzdHMveG1saHR0cHJlcXVlc3Qvd2ViLWFwcHMvMDEzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g NTczMzkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC93ZWItYXBwcy8wMTMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xICsxIEBA Ci1GQUlMOiBTdGF0dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAwLCAiT0siCitGQUlMOiBTdGF0 dXMgYXQgcmVhZHlTdGF0ZSAzIHdhczogNDAwLCAiYmFkIHJlcXVlc3QiCg==