37271 2010-04-08 07:43:46 -0700 [chromium] Expose SecurityOrigin::canRequest in WebSecurityOrigin. 2010-04-09 03:46:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jochen webkit-unassigned abarth commit-queue fishd oldest_to_newest 210176 0 jochen 2010-04-08 07:43:46 -0700 Expose SecurityOrigin::canRequest in WebSecurityOrigin. 210178 1 52864 jochen 2010-04-08 07:44:53 -0700 Created attachment 52864 Patch 210234 2 abarth 2010-04-08 09:02:57 -0700 LGTM, but you need fishd's review for WebKit API changes. 210271 3 52864 fishd 2010-04-08 11:00:34 -0700 Comment on attachment 52864 Patch > + // Returns true if this WebSecurityOrigin can read content retrieved from > + // the given URL. For example, call this function before issuing > + // XMLHttpRequests. > + WEBKIT_API bool canRequest(const WebURL&) const; nit: The XMLHttpRequest example doesn't really apply to WebKit API consumers. Otherwise, this change is fine. Please post a revised patch for the commit queue. 210582 4 52938 jochen 2010-04-08 23:35:31 -0700 Created attachment 52938 Patch 210583 5 52938 abarth 2010-04-08 23:37:26 -0700 Comment on attachment 52938 Patch Picture perfect 210670 6 52938 commit-queue 2010-04-09 03:46:26 -0700 Comment on attachment 52938 Patch Clearing flags on attachment: 52938 Committed r57325: <http://trac.webkit.org/changeset/57325> 210671 7 commit-queue 2010-04-09 03:46:32 -0700 All reviewed patches have been landed. Closing bug. 52864 2010-04-08 07:44:53 -0700 2010-04-08 23:35:25 -0700 Patch bug-37271-20100408164451.patch text/plain 2407 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA2OTUyYjguLjg5MjVmMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA0LTA4ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9z ZSBTZWN1cml0eU9yaWdpbjo6Y2FuUmVxdWVzdCBpbiBXZWJTZWN1cml0eU9yaWdpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjcxCisKKyAgICAg ICAgKiBwdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaDoKKyAgICAgICAgKiBzcmMvV2ViU2VjdXJp dHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6Y2FuUmVx dWVzdCk6CisKIDIwMTAtMDQtMDYgIEphbWVzIEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaCBiL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAppbmRleCBiNWY2YTBiLi5mMjhhYTYwIDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCkBAIC03MywxMiArNzMsMTcg QEAgcHVibGljOgogICAgIC8vIFRoZSBlbXB0eSBXZWJTZWN1cml0eU9yaWdpbiBpcyB0aGUgbGVh c3QgcHJpdmlsZWdlZCBXZWJTZWN1cml0eU9yaWdpbi4KICAgICBXRUJLSVRfQVBJIGJvb2wgaXNF bXB0eSgpIGNvbnN0OwogCi0gICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoaXMgU2VjdXJpdHlPcmln aW4gY2FuIHNjcmlwdCBvYmplY3RzIGluIHRoZSBnaXZlbgorICAgIC8vIFJldHVybnMgdHJ1ZSBp ZiB0aGlzIFdlYlNlY3VyaXR5T3JpZ2luIGNhbiBzY3JpcHQgb2JqZWN0cyBpbiB0aGUgZ2l2ZW4K ICAgICAvLyBTZWN1cml0eU9yaWdpbi4gRm9yIGV4YW1wbGUsIGNhbGwgdGhpcyBmdW5jdGlvbiBi ZWZvcmUgYWxsb3dpbmcKICAgICAvLyBzY3JpcHQgZnJvbSBvbmUgc2VjdXJpdHkgb3JpZ2luIHRv IHJlYWQgb3Igd3JpdGUgb2JqZWN0cyBmcm9tCiAgICAgLy8gYW5vdGhlciBTZWN1cml0eU9yaWdp bi4KICAgICBXRUJLSVRfQVBJIGJvb2wgY2FuQWNjZXNzKGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2lu JikgY29uc3Q7CiAKKyAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhpcyBXZWJTZWN1cml0eU9yaWdp biBjYW4gcmVhZCBjb250ZW50IHJldHJpZXZlZCBmcm9tCisgICAgLy8gdGhlIGdpdmVuIFVSTC4g Rm9yIGV4YW1wbGUsIGNhbGwgdGhpcyBmdW5jdGlvbiBiZWZvcmUgaXNzdWluZworICAgIC8vIFhN TEh0dHBSZXF1ZXN0cy4KKyAgICBXRUJLSVRfQVBJIGJvb2wgY2FuUmVxdWVzdChjb25zdCBXZWJV UkwmKSBjb25zdDsKKwogICAgIC8vIFJldHVybnMgYSBzdHJpbmcgcmVwcmVzZW50YXRpb24gb2Yg dGhlIFdlYlNlY3VyaXR5T3JpZ2luLiAgVGhlIGVtcHR5CiAgICAgLy8gV2ViU2VjdXJpdHlPcmln aW4gaXMgcmVwcmVzZW50ZWQgYnkgIm51bGwiLiAgVGhlIHJlcHJlc2VudGF0aW9uIG9mIGEKICAg ICAvLyBub24tZW1wdHkgV2ViU2VjdXJpdHlPcmlnaW4gcmVzZW1ibGVzIGEgc3RhbmRhcmQgVVJM LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAppbmRleCAzYzgzNWVl Li5jMmJkZjgyIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3Jp Z2luLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcApA QCAtMTAzLDYgKzEwMywxMiBAQCBib29sIFdlYlNlY3VyaXR5T3JpZ2luOjpjYW5BY2Nlc3MoY29u c3QgV2ViU2VjdXJpdHlPcmlnaW4mIG90aGVyKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGUt PmNhbkFjY2VzcyhvdGhlci5tX3ByaXZhdGUpOwogfQogCitib29sIFdlYlNlY3VyaXR5T3JpZ2lu OjpjYW5SZXF1ZXN0KGNvbnN0IFdlYlVSTCYgdXJsKSBjb25zdAoreworICAgIEFTU0VSVChtX3By aXZhdGUpOworICAgIHJldHVybiBtX3ByaXZhdGUtPmNhblJlcXVlc3QodXJsKTsKK30KKwogV2Vi U3RyaW5nIFdlYlNlY3VyaXR5T3JpZ2luOjp0b1N0cmluZygpIGNvbnN0CiB7CiAgICAgQVNTRVJU KG1fcHJpdmF0ZSk7Cg== 52938 2010-04-08 23:35:31 -0700 2010-04-09 03:46:26 -0700 Patch bug-37271-20100409083529.patch text/plain 2465 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA2OTUyYjguLjg5MjVmMDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTA0LTA4ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9z ZSBTZWN1cml0eU9yaWdpbjo6Y2FuUmVxdWVzdCBpbiBXZWJTZWN1cml0eU9yaWdpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjcxCisKKyAgICAg ICAgKiBwdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaDoKKyAgICAgICAgKiBzcmMvV2ViU2VjdXJp dHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6Y2FuUmVx dWVzdCk6CisKIDIwMTAtMDQtMDYgIEphbWVzIEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaCBiL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAppbmRleCBiNWY2YTBiLi5hNDY1MTM5IDEwMDY0NAot LS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCkBAIC03MywxMiArNzMsMTcg QEAgcHVibGljOgogICAgIC8vIFRoZSBlbXB0eSBXZWJTZWN1cml0eU9yaWdpbiBpcyB0aGUgbGVh c3QgcHJpdmlsZWdlZCBXZWJTZWN1cml0eU9yaWdpbi4KICAgICBXRUJLSVRfQVBJIGJvb2wgaXNF bXB0eSgpIGNvbnN0OwogCi0gICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoaXMgU2VjdXJpdHlPcmln aW4gY2FuIHNjcmlwdCBvYmplY3RzIGluIHRoZSBnaXZlbgorICAgIC8vIFJldHVybnMgdHJ1ZSBp ZiB0aGlzIFdlYlNlY3VyaXR5T3JpZ2luIGNhbiBzY3JpcHQgb2JqZWN0cyBpbiB0aGUgZ2l2ZW4K ICAgICAvLyBTZWN1cml0eU9yaWdpbi4gRm9yIGV4YW1wbGUsIGNhbGwgdGhpcyBmdW5jdGlvbiBi ZWZvcmUgYWxsb3dpbmcKICAgICAvLyBzY3JpcHQgZnJvbSBvbmUgc2VjdXJpdHkgb3JpZ2luIHRv IHJlYWQgb3Igd3JpdGUgb2JqZWN0cyBmcm9tCiAgICAgLy8gYW5vdGhlciBTZWN1cml0eU9yaWdp bi4KICAgICBXRUJLSVRfQVBJIGJvb2wgY2FuQWNjZXNzKGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2lu JikgY29uc3Q7CiAKKyAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhpcyBXZWJTZWN1cml0eU9yaWdp biBjYW4gcmVhZCBjb250ZW50IHJldHJpZXZlZCBmcm9tCisgICAgLy8gdGhlIGdpdmVuIFVSTC4g Rm9yIGV4YW1wbGUsIGNhbGwgdGhpcyBmdW5jdGlvbiBiZWZvcmUgYWxsb3dpbmcgc2NyaXB0Cisg ICAgLy8gZnJvbSBhIGdpdmVuIHNlY3VyaXR5IG9yaWdpbiB0byByZWNlaXZlIGNvbnRlbnRzIGZy b20gYSBnaXZlbiBVUkwuCisgICAgV0VCS0lUX0FQSSBib29sIGNhblJlcXVlc3QoY29uc3QgV2Vi VVJMJikgY29uc3Q7CisKICAgICAvLyBSZXR1cm5zIGEgc3RyaW5nIHJlcHJlc2VudGF0aW9uIG9m IHRoZSBXZWJTZWN1cml0eU9yaWdpbi4gIFRoZSBlbXB0eQogICAgIC8vIFdlYlNlY3VyaXR5T3Jp Z2luIGlzIHJlcHJlc2VudGVkIGJ5ICJudWxsIi4gIFRoZSByZXByZXNlbnRhdGlvbiBvZiBhCiAg ICAgLy8gbm9uLWVtcHR5IFdlYlNlY3VyaXR5T3JpZ2luIHJlc2VtYmxlcyBhIHN0YW5kYXJkIFVS TC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3Bw IGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAKaW5kZXggM2M4MzVl ZS4uYzJiZGY4MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9y aWdpbi5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAK QEAgLTEwMyw2ICsxMDMsMTIgQEAgYm9vbCBXZWJTZWN1cml0eU9yaWdpbjo6Y2FuQWNjZXNzKGNv bnN0IFdlYlNlY3VyaXR5T3JpZ2luJiBvdGhlcikgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRl LT5jYW5BY2Nlc3Mob3RoZXIubV9wcml2YXRlKTsKIH0KIAorYm9vbCBXZWJTZWN1cml0eU9yaWdp bjo6Y2FuUmVxdWVzdChjb25zdCBXZWJVUkwmIHVybCkgY29uc3QKK3sKKyAgICBBU1NFUlQobV9w cml2YXRlKTsKKyAgICByZXR1cm4gbV9wcml2YXRlLT5jYW5SZXF1ZXN0KHVybCk7Cit9CisKIFdl YlN0cmluZyBXZWJTZWN1cml0eU9yaWdpbjo6dG9TdHJpbmcoKSBjb25zdAogewogICAgIEFTU0VS VChtX3ByaXZhdGUpOwo=