37265 2010-04-08 06:24:41 -0700 IDB callbacks should fire asynchronously 2010-04-08 07:56:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow abarth eric gustavo japhet pfeldman webkit-ews webkit.review.bot xan.lopez yurys oldest_to_newest 210130 0 jorlow 2010-04-08 06:24:41 -0700 IDB callbacks should fire asynchronously 210133 1 52856 jorlow 2010-04-08 06:37:57 -0700 Created attachment 52856 Patch 210137 2 jorlow 2010-04-08 06:39:44 -0700 In addition to being the right thing to do, this exposes the bug we've been working on in --single-process mode within Chromium. 210138 3 eric 2010-04-08 06:40:05 -0700 Attachment 52856 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1674139 210145 4 webkit-ews 2010-04-08 06:45:48 -0700 Attachment 52856 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1660252 210146 5 webkit.review.bot 2010-04-08 06:48:48 -0700 Attachment 52856 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1612322 210147 6 jorlow 2010-04-08 06:49:05 -0700 Oops...will upload a new version that doesn't break everything in a sec. Pavel/Yury: Note that this patch also makes the inspector bug I was seeing show up in single process mode. Still don't know if the bug is related to my code (or why it's not working correctly) or whether it's a bug in inspector. 210151 7 yurys 2010-04-08 06:59:13 -0700 Please fix linux and mac bot failures, otherwise r+. 210158 8 jorlow 2010-04-08 07:14:57 -0700 Committed r57275: <http://trac.webkit.org/changeset/57275> 210186 9 webkit.review.bot 2010-04-08 07:53:48 -0700 http://trac.webkit.org/changeset/57275 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57273 http://trac.webkit.org/changeset/57275 210189 10 abarth 2010-04-08 07:56:44 -0700 The real failure is http://trac.webkit.org/changeset/57274. tkent is on it. 52856 2010-04-08 06:37:57 -0700 2010-04-08 07:00:06 -0700 Patch bug-37265-20100408143755.patch text/plain 4922 jorlow ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWU1OTlmNS4uOTE1YmM0NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wNC0wOCAgSmVyZW15IE9ybG93 ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJREIgY2FsbGJhY2tzIHNob3VsZCBmaXJlIGFzeW5jaHJvbm91c2x5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI2NQor CisgICAgICAgIEZpeCB0aGUgZmlyaW5nIGJlaGF2aW9yIG9mIHRoZSBjYWxsYmFja3MgdG8gbm90 IGJlIHN5bmNocm9ub3VzLgorCisgICAgICAgIFRoZXJlJ3Mgc3RpbGwgYSBtYWpvciBidWcgdGhh dCBJJ20gdHJ5aW5nIHRvIHRyYWNrIGRvd24gdGhhdCBpcyBrZWVwaW5nCisgICAgICAgIHVzIGZy b20gdGVzdGluZyB0aGlzIHN0dWZmLiAgUHJvbWlzZSBsb3RzIG9mIHRlc3RzIEFTQVAuCisKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21JREJDYWxsYmFja3MuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlY4Q3VzdG9tSURCQ2FsbGJhY2tzOjpvblN1Y2Nlc3NBc3luYyk6CisgICAg ICAgIChXZWJDb3JlOjpWOEN1c3RvbUlEQkNhbGxiYWNrczo6b25FcnJvckFzeW5jKToKKyAgICAg ICAgKiBzdG9yYWdlL0lEQkNhbGxiYWNrcy5oOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2FsbGJh Y2tzOjpJREJDYWxsYmFja3MpOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2FsbGJhY2tzOjpvblN1 Y2Nlc3MpOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2FsbGJhY2tzOjpvbkVycm9yKToKKyAgICAg ICAgKFdlYkNvcmU6OklEQkNhbGxiYWNrczo6dGltZXJGaXJlZCk6CisgICAgICAgICogc3RvcmFn ZS9JbmRleGVkRGF0YWJhc2VSZXF1ZXN0LmNwcDoKKwogMjAxMC0wNC0wOCAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRy aSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0 b21JREJDYWxsYmFja3MuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tSURC Q2FsbGJhY2tzLmgKaW5kZXggODA2ZmE3Ni4uMTUxN2YxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21JREJDYWxsYmFja3MuaAorKysgYi9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbUlEQkNhbGxiYWNrcy5oCkBAIC02MSwxNiArNjEsNiBA QCBwdWJsaWM6CiAgICAgICAgIG1fb25FcnJvci5EaXNwb3NlKCk7CiAgICAgfQogCi0gICAgdmly dHVhbCB2b2lkIG9uU3VjY2VzcyhQYXNzUmVmUHRyPFJlc3VsdFR5cGU+IHJlc3VsdCkKLSAgICB7 Ci0gICAgICAgIG9uRXZlbnQobV9vblN1Y2Nlc3MsIFJlc3VsdFdyYXBwZXJUeXBlOjpjcmVhdGUo cmVzdWx0KSk7Ci0gICAgfQotCi0gICAgdmlydHVhbCB2b2lkIG9uRXJyb3IoUGFzc1JlZlB0cjxJ REJEYXRhYmFzZUVycm9yPiBlcnJvcikKLSAgICB7Ci0gICAgICAgIG9uRXZlbnQobV9vbkVycm9y LCBlcnJvcik7Ci0gICAgfQotCiAgICAgLy8gRklYTUU6IEhhbmRsZSBzdXNwZW5kL3Jlc3VtZSBj b3JyZWN0bHkuCiAKIHByaXZhdGU6CkBAIC0xMDksNiArOTksMTYgQEAgcHJpdmF0ZToKICAgICAg ICAgaW52b2tlQ2FsbGJhY2soY2FsbGJhY2ssIDEsIGFyZ3YsIGNhbGxiYWNrUmV0dXJuVmFsdWUp OwogICAgIH0KIAorICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3NBc3luYyhQYXNzUmVmUHRyPFJl c3VsdFR5cGU+IHJlc3VsdCkKKyAgICB7CisgICAgICAgIG9uRXZlbnQobV9vblN1Y2Nlc3MsIFJl c3VsdFdyYXBwZXJUeXBlOjpjcmVhdGUocmVzdWx0KSk7CisgICAgfQorCisgICAgdmlydHVhbCB2 b2lkIG9uRXJyb3JBc3luYyhQYXNzUmVmUHRyPElEQkRhdGFiYXNlRXJyb3I+IGVycm9yKQorICAg IHsKKyAgICAgICAgb25FdmVudChtX29uRXJyb3IsIGVycm9yKTsKKyAgICB9CisKICAgICAvLyBG SVhNRTogVXNlIE93bkhhbmRsZXMuCiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gbV9v blN1Y2Nlc3M7CiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gbV9vbkVycm9yOwpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9zdG9yYWdlL0lEQkNhbGxiYWNrcy5oIGIvV2ViQ29yZS9zdG9yYWdl L0lEQkNhbGxiYWNrcy5oCmluZGV4IGE3ZDM1MmUuLjkwMmI0ODEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvc3RvcmFnZS9JREJDYWxsYmFja3MuaAorKysgYi9XZWJDb3JlL3N0b3JhZ2UvSURCQ2FsbGJh Y2tzLmgKQEAgLTMwLDIyICszMCw3MSBAQAogI2RlZmluZSBJREJDYWxsYmFja3NfaAogCiAjaW5j bHVkZSAiQWN0aXZlRE9NT2JqZWN0LmgiCisjaW5jbHVkZSAiSURCRGF0YWJhc2VFcnJvci5oIgor I2luY2x1ZGUgIlRpbWVyLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRl IDx3dGYvUmVmQ291bnRlZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIElEQkRh dGFiYXNlRXJyb3I7Ci0KKy8vIEFsbCBJbmRleGVkREIgY2FsbGJhY2tzIG11c3QgaW1wbGVtZW50 IHRoaXMgY2xhc3MuICBJdCBoYW5kbGVzIHRoZSBhc3luY2hyb25vdXMgZmlyaW5nIG9mCisvLyB0 aGUgY2FsbGJhY2tzLgogdGVtcGxhdGUgPHR5cGVuYW1lIFJlc3VsdFR5cGU+CiBjbGFzcyBJREJD YWxsYmFja3MgOiBwdWJsaWMgUmVmQ291bnRlZDxJREJDYWxsYmFja3M8UmVzdWx0VHlwZT4gPiwg cHVibGljIEFjdGl2ZURPTU9iamVjdCB7CiBwdWJsaWM6CiAgICAgSURCQ2FsbGJhY2tzKFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIHZvaWQqIHVwY2FzdFBv aW50ZXIpCi0gICAgICAgIDogQWN0aXZlRE9NT2JqZWN0KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQs IHVwY2FzdFBvaW50ZXIpIHsgfQorICAgICAgICA6IEFjdGl2ZURPTU9iamVjdChzY3JpcHRFeGVj dXRpb25Db250ZXh0LCB1cGNhc3RQb2ludGVyKQorICAgICAgICAsIG1fdGltZXIodGhpcywgJklE QkNhbGxiYWNrczo6dGltZXJGaXJlZCkKKyAgICB7CisgICAgfQorCiAgICAgdmlydHVhbCB+SURC Q2FsbGJhY2tzKCkgeyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgb25TdWNjZXNzKFBhc3NSZWZQdHI8 UmVzdWx0VHlwZT4pID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgb25FcnJvcihQYXNzUmVmUHRyPElE QkRhdGFiYXNlRXJyb3I+KSA9IDA7CisgICAgdm9pZCBvblN1Y2Nlc3MoUGFzc1JlZlB0cjxSZXN1 bHRUeXBlPiByZXN1bHQpCisgICAgeworICAgICAgICBBU1NFUlQoIW1fcmVzdWx0KTsKKyAgICAg ICAgQVNTRVJUKCFtX2Vycm9yKTsKKyAgICAgICAgbV9yZXN1bHQgPSByZXN1bHQ7CisgICAgICAg IEFTU0VSVChtX3Jlc3VsdCk7CisKKyAgICAgICAgQVNTRVJUKCFtX3RpbWVyLmlzQWN0aXZlKCkp OworICAgICAgICBtX3NlbGZSZWYgPSB0aGlzOworICAgICAgICBtX3RpbWVyLnN0YXJ0T25lU2hv dCgwKTsKKyAgICB9CisKKyAgICB2b2lkIG9uRXJyb3IoUGFzc1JlZlB0cjxJREJEYXRhYmFzZUVy cm9yPiBlcnJvcikKKyAgICB7CisgICAgICAgIEFTU0VSVCghbV9yZXN1bHQpOworICAgICAgICBB U1NFUlQoIW1fZXJyb3IpOworICAgICAgICBtX2Vycm9yID0gZXJyb3I7CisgICAgICAgIEFTU0VS VChtX2Vycm9yKTsKKworICAgICAgICBBU1NFUlQoIW1fdGltZXIuaXNBY3RpdmUoKSk7CisgICAg ICAgIG1fc2VsZlJlZiA9IHRoaXM7CisgICAgICAgIG1fdGltZXIuc3RhcnRPbmVTaG90KDApOwor ICAgIH0KKworcHJvdGVjdGVkOgorICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3NBc3luYyhQYXNz UmVmUHRyPFJlc3VsdFR5cGU+KSA9IDA7CisgICAgdmlydHVhbCB2b2lkIG9uRXJyb3JBc3luYyhQ YXNzUmVmUHRyPElEQkRhdGFiYXNlRXJyb3I+KSA9IDA7CisKKyAgICB2b2lkIHRpbWVyRmlyZWQo VGltZXI8SURCQ2FsbGJhY2tzPiopCisgICAgeworICAgICAgICBpZiAobV9yZXN1bHQpIHsKKyAg ICAgICAgICAgIG9uU3VjY2Vzc0FzeW5jKG1fcmVzdWx0KTsKKyAgICAgICAgICAgIG1fcmVzdWx0 ID0gMDsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIG9uRXJyb3JBc3luYyhtX2Vycm9y KTsKKyAgICAgICAgICAgIG1fZXJyb3IgPSAwOworICAgICAgICB9CisgICAgICAgIG1fc2VsZlJl ZiA9IDA7IC8vIE1heSB0cmlnZ2VyIGEgZGVsZXRlIGltbWVkaWF0ZWx5LgorICAgIH0KKworcHJp dmF0ZToKKyAgICBUaW1lcjxJREJDYWxsYmFja3M+IG1fdGltZXI7CisgICAgUmVmUHRyPElEQkNh bGxiYWNrcz4gbV9zZWxmUmVmOworICAgIFBhc3NSZWZQdHI8UmVzdWx0VHlwZT4gbV9yZXN1bHQ7 CisgICAgUGFzc1JlZlB0cjxJREJEYXRhYmFzZUVycm9yPiBtX2Vycm9yOwogfTsKIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdG9yYWdlL0luZGV4ZWREYXRh YmFzZVJlcXVlc3QuY3BwIGIvV2ViQ29yZS9zdG9yYWdlL0luZGV4ZWREYXRhYmFzZVJlcXVlc3Qu Y3BwCmluZGV4IGZhNDAwZmYuLjRlZDdiOTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9J bmRleGVkRGF0YWJhc2VSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3N0b3JhZ2UvSW5kZXhlZERh dGFiYXNlUmVxdWVzdC5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJJbmRleGVkRGF0 YWJhc2VSZXF1ZXN0LmgiCiAKICNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCisjaW5jbHVkZSAi SURCRGF0YWJhc2UuaCIKICNpbmNsdWRlICJJbmRleGVkRGF0YWJhc2UuaCIKIAogI2lmIEVOQUJM RShJTkRFWEVEX0RBVEFCQVNFKQo=