<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37253</bug_id>
          
          <creation_ts>2010-04-08 00:57:39 -0700</creation_ts>
          <short_desc>[Qt]r57240 broke Qt build (gcc bug)</short_desc>
          <delta_ts>2013-09-06 19:35:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abecsi</cc>
    
    <cc>benjamin</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>hausmann</cc>
    
    <cc>kling</cc>
    
    <cc>lauro.neto</cc>
    
    <cc>menard</cc>
    
    <cc>oliver</cc>
    
    <cc>ossy</cc>
    
    <cc>rafael.lobo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>210065</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-08 00:57:39 -0700</bug_when>
    <thetext>After http://trac.webkit.org/changeset/57240 Qt build broke,
exactly gcc stucked in an infinite loop (with 100% CPU load)
when building WebCore/platform/graphics/FontFamily.cpp

original command:
g++ -c -m32 -pipe -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self -ffunction-sections -fdata-sections -O2 -fvisibility=hidden -fvisibility-inlines-hidden -D_REENTRANT -fPIC -DBUILDING_QT__=1 -DWTF_USE_ACCELERATED_COMPOSITING -DNDEBUG -DQT_MAKEDLL -DHAVE_STDINT_H -DBUILD_WEBKIT -DBUILDING_QT__ -DBUILDING_JavaScriptCore -DBUILDING_WTF -DENABLE_VIDEO=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_DATABASE=1 -DENABLE_EVENTSOURCE=1 -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_DOM_STORAGE=1 -DENABLE_ICONDATABASE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_SQLITE=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_FILTERS=1 -DENABLE_XPATH=1 -DENABLE_WCSS=0 -DENABLE_WML=0 -DENABLE_SHARED_WORKERS=1 -DENABLE_WORKERS=1 -DENABLE_XHTMLMP=0 -DENABLE_DATAGRID=0 -DENABLE_RUBY=1 -DENABLE_SANDBOX=1 -DENABLE_PROGRESS_TAG=1 -DENABLE_BLOB_SLICE=0 -DENABLE_3D_RENDERING=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_USE=1 -DENABLE_DATALIST=1 -DENABLE_TILED_BACKING_STORE=1 -DENABLE_NETSCAPE_PLUGIN_API=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_XSLT=1 -DENABLE_TOUCH_EVENTS=1 -DXP_UNIX -DQT_NO_DEBUG -DQT_XMLPATTERNS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/Trolltech/Qt-4.6.0/mkspecs/linux-g++-32 -I../../../WebCore -I/usr/local/Trolltech/Qt-4.6.0/include/QtCore -I/usr/local/Trolltech/Qt-4.6.0/include/QtNetwork -I/usr/local/Trolltech/Qt-4.6.0/include/QtGui -I/usr/local/Trolltech/Qt-4.6.0/include/QtXmlPatterns -I/usr/local/Trolltech/Qt-4.6.0/include -I../../../WebCore/bridge/qt -I../../../WebCore/page/qt -I../../../WebCore/platform/graphics/qt -I../../../WebCore/platform/network/qt -I../../../WebCore/platform/qt -I../../../WebKit/qt/Api -I../../../WebKit/qt/WebCoreSupport -I../../../WebCore -I../../../WebCore/accessibility -I../../../WebCore/bindings/js -I../../../WebCore/bridge -I../../../WebCore/bridge/c -I../../../WebCore/bridge/jsc -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/dom/default -I../../../WebCore/editing -I../../../WebCore/history -I../../../WebCore/html -I../../../WebCore/html/canvas -I../../../WebCore/inspector -I../../../WebCore/loader -I../../../WebCore/loader/appcache -I../../../WebCore/loader/archive -I../../../WebCore/loader/icon -I../../../WebCore/notifications -I../../../WebCore/page -I../../../WebCore/page/animation -I../../../WebCore/platform -I../../../WebCore/platform/animation -I../../../WebCore/platform/graphics -I../../../WebCore/platform/graphics/filters -I../../../WebCore/platform/graphics/transforms -I../../../WebCore/platform/image-decoders -I../../../WebCore/platform/mock -I../../../WebCore/platform/network -I../../../WebCore/platform/sql -I../../../WebCore/platform/text -I../../../WebCore/plugins -I../../../WebCore/rendering -I../../../WebCore/rendering/style -I../../../WebCore/storage -I../../../WebCore/svg -I../../../WebCore/svg/animation -I../../../WebCore/svg/graphics -I../../../WebCore/svg/graphics/filters -I../../../WebCore/websockets -I../../../WebCore/wml -I../../../WebCore/workers -I../../../WebCore/xml -Igenerated -I../../../JavaScriptCore -I../../../../build -I../../../JavaScriptCore/assembler -I../../../JavaScriptCore/bytecode -I../../../JavaScriptCore/bytecompiler -I../../../JavaScriptCore/debugger -I../../../JavaScriptCore/interpreter -I../../../JavaScriptCore/jit -I../../../JavaScriptCore/parser -I../../../JavaScriptCore/pcre -I../../../JavaScriptCore/profiler -I../../../JavaScriptCore/runtime -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/wtf/symbian -I../../../JavaScriptCore/wtf/unicode -I../../../JavaScriptCore/yarr -I../../../JavaScriptCore/API -I../../../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/generated -I../include/QtWebKit -I/usr/local/Trolltech/Qt-4.6.0/src/3rdparty/sqlite/ -I/usr/local/Trolltech/Qt-4.6.0/include/phonon -I/usr/X11R6/include -I. -I../../../WebCore -I. -o obj/release/FontFamily.o ../../../WebCore/platform/graphics/FontFamily.cpp

I tried to preprocess and compile in two steps manually, it works:

preprocess:
g++ -E -m32 -pipe -Wall -Wextra -Wreturn-type -fno-strict-aliasing -Wcast-align -Wchar-subscripts -Wformat-security -Wreturn-type -Wno-unused-parameter -Wno-sign-compare -Wno-switch -Wno-switch-enum -Wundef -Wmissing-noreturn -Winit-self -ffunction-sections -fdata-sections -O2 -fvisibility=hidden -fvisibility-inlines-hidden -D_REENTRANT -fPIC -DBUILDING_QT__=1 -DWTF_USE_ACCELERATED_COMPOSITING -DNDEBUG -DQT_MAKEDLL -DHAVE_STDINT_H -DBUILD_WEBKIT -DBUILDING_QT__ -DBUILDING_JavaScriptCore -DBUILDING_WTF -DENABLE_VIDEO=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_DATABASE=1 -DENABLE_EVENTSOURCE=1 -DENABLE_OFFLINE_WEB_APPLICATIONS=1 -DENABLE_DOM_STORAGE=1 -DENABLE_ICONDATABASE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_SQLITE=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_FILTERS=1 -DENABLE_XPATH=1 -DENABLE_WCSS=0 -DENABLE_WML=0 -DENABLE_SHARED_WORKERS=1 -DENABLE_WORKERS=1 -DENABLE_XHTMLMP=0 -DENABLE_DATAGRID=0 -DENABLE_RUBY=1 -DENABLE_SANDBOX=1 -DENABLE_PROGRESS_TAG=1 -DENABLE_BLOB_SLICE=0 -DENABLE_3D_RENDERING=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_SVG_FOREIGN_OBJECT=1 -DENABLE_SVG_ANIMATION=1 -DENABLE_SVG_AS_IMAGE=1 -DENABLE_SVG_USE=1 -DENABLE_DATALIST=1 -DENABLE_TILED_BACKING_STORE=1 -DENABLE_NETSCAPE_PLUGIN_API=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_XSLT=1 -DENABLE_TOUCH_EVENTS=1 -DXP_UNIX -DQT_NO_DEBUG -DQT_XMLPATTERNS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/local/Trolltech/Qt-4.6.0/mkspecs/linux-g++-32 -I../../../WebCore -I/usr/local/Trolltech/Qt-4.6.0/include/QtCore -I/usr/local/Trolltech/Qt-4.6.0/include/QtNetwork -I/usr/local/Trolltech/Qt-4.6.0/include/QtGui -I/usr/local/Trolltech/Qt-4.6.0/include/QtXmlPatterns -I/usr/local/Trolltech/Qt-4.6.0/include -I../../../WebCore/bridge/qt -I../../../WebCore/page/qt -I../../../WebCore/platform/graphics/qt -I../../../WebCore/platform/network/qt -I../../../WebCore/platform/qt -I../../../WebKit/qt/Api -I../../../WebKit/qt/WebCoreSupport -I../../../WebCore -I../../../WebCore/accessibility -I../../../WebCore/bindings/js -I../../../WebCore/bridge -I../../../WebCore/bridge/c -I../../../WebCore/bridge/jsc -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/dom/default -I../../../WebCore/editing -I../../../WebCore/history -I../../../WebCore/html -I../../../WebCore/html/canvas -I../../../WebCore/inspector -I../../../WebCore/loader -I../../../WebCore/loader/appcache -I../../../WebCore/loader/archive -I../../../WebCore/loader/icon -I../../../WebCore/notifications -I../../../WebCore/page -I../../../WebCore/page/animation -I../../../WebCore/platform -I../../../WebCore/platform/animation -I../../../WebCore/platform/graphics -I../../../WebCore/platform/graphics/filters -I../../../WebCore/platform/graphics/transforms -I../../../WebCore/platform/image-decoders -I../../../WebCore/platform/mock -I../../../WebCore/platform/network -I../../../WebCore/platform/sql -I../../../WebCore/platform/text -I../../../WebCore/plugins -I../../../WebCore/rendering -I../../../WebCore/rendering/style -I../../../WebCore/storage -I../../../WebCore/svg -I../../../WebCore/svg/animation -I../../../WebCore/svg/graphics -I../../../WebCore/svg/graphics/filters -I../../../WebCore/websockets -I../../../WebCore/wml -I../../../WebCore/workers -I../../../WebCore/xml -Igenerated -I../../../JavaScriptCore -I../../../../build -I../../../JavaScriptCore/assembler -I../../../JavaScriptCore/bytecode -I../../../JavaScriptCore/bytecompiler -I../../../JavaScriptCore/debugger -I../../../JavaScriptCore/interpreter -I../../../JavaScriptCore/jit -I../../../JavaScriptCore/parser -I../../../JavaScriptCore/pcre -I../../../JavaScriptCore/profiler -I../../../JavaScriptCore/runtime -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/wtf/symbian -I../../../JavaScriptCore/wtf/unicode -I../../../JavaScriptCore/yarr -I../../../JavaScriptCore/API -I../../../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/generated -I../include/QtWebKit -I/usr/local/Trolltech/Qt-4.6.0/src/3rdparty/sqlite/ -I/usr/local/Trolltech/Qt-4.6.0/include/phonon -I/usr/X11R6/include -I. -I../../../WebCore -I. -o obj/release/FontFamily.i ../../../WebCore/platform/graphics/FontFamily.cpp

compile:
g++ -c -o obj/release/FontFamily.o obj/release/FontFamily.i</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210072</commentid>
    <comment_count>1</comment_count>
      <attachid>52848</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-08 01:11:30 -0700</bug_when>
    <thetext>Created attachment 52848
proposed workaround until fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210074</commentid>
    <comment_count>2</comment_count>
      <attachid>52848</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-04-08 01:13:43 -0700</bug_when>
    <thetext>Comment on attachment 52848
proposed workaround until fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210076</commentid>
    <comment_count>3</comment_count>
      <attachid>52848</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-08 01:23:34 -0700</bug_when>
    <thetext>Comment on attachment 52848
proposed workaround until fix

Workaround landed in http://trac.webkit.org/changeset/57262
We shouldn&apos;t close this bug until find what the problem is.

I forgot to mention, I use gcc (Debian 4.3.2-1.1) 4.3.2,
which can be found in stable Debian (5.0.4 - Lenny)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210162</commentid>
    <comment_count>4</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-08 07:26:14 -0700</bug_when>
    <thetext>It works with gcc (Ubuntu 4.4.1-4ubuntu9) 4.4.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218933</commentid>
    <comment_count>5</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-29 03:32:23 -0700</bug_when>
    <thetext>Any chance to close the bug now?
Or reduce the priority to P5 if it is only about understanding where the problem was.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>219516</commentid>
    <comment_count>6</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-30 10:06:41 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Any chance to close the bug now?
&gt; Or reduce the priority to P5 if it is only about understanding where the
&gt; problem was.

I don&apos;t think if we should close the bug, because it is a real bug,
and we should use ALWAYS_INLINE macro carefully.

But I agree, it isn&apos;t blocker and P1 priority bug after workaround landed,
so I modified it to P3 and normal. I played with a little bit this bug again,
I can reproduce it with preprocessed source, so I&apos;m going to file a bug about it
into gcc bugzilla.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244522</commentid>
    <comment_count>7</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-06-29 15:20:59 -0700</bug_when>
    <thetext>If this is a GCC bug, then we should file a GCC bug report. I don&apos;t see any reason to keep a WebKit bug report open about this indefinitely.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>397256</commentid>
    <comment_count>8</comment_count>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-05-03 12:20:57 -0700</bug_when>
    <thetext>GCC bug and seems outdated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>612454</commentid>
    <comment_count>9</comment_count>
      <attachid>139406</attachid>
    <who name="Adenilson Cavalcanti Silva">savagobr</who>
    <bug_when>2012-04-29 14:34:00 -0700</bug_when>
    <thetext>Created attachment 139406
Remove the inline hack

Current gcc (tested with 4.6.1) and Qt5 doesn&apos;t need this macro workaround.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>612614</commentid>
    <comment_count>10</comment_count>
      <attachid>139406</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2012-04-30 07:24:50 -0700</bug_when>
    <thetext>Comment on attachment 139406
Remove the inline hack

but what about Qt 4.8?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614079</commentid>
    <comment_count>11</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 01:16:52 -0700</bug_when>
    <thetext>Reopen, because CQ won&apos;t land patch from RESOLVED/WONTFIX bug. :)

I tested it with Debian Squeeze (latest Debian stable), it works fine with its default 4.4.5 GCC. Ubuntu 10.04 LTS has 4.4.3, it should work too. (Additionally 12.04 LTS is out now.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614083</commentid>
    <comment_count>12</comment_count>
      <attachid>139406</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 01:19:22 -0700</bug_when>
    <thetext>Comment on attachment 139406
Remove the inline hack

Clearing flags on attachment: 139406

Committed r115802: &lt;http://trac.webkit.org/changeset/115802&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614084</commentid>
    <comment_count>13</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 01:19:30 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614302</commentid>
    <comment_count>14</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 08:11:39 -0700</bug_when>
    <thetext>Reopen, because it broke the N9 build inside scratchbox with the following error:
In file included from /home/lauro/webkit/webkit-deb/Source/WebCore/html/shadow/HTMLContentSelector.cpp:28:
/home/lauro/webkit/webkit-deb/Source/WTF/wtf/RefPtr.h: In destructor &apos;WebCore::HTMLContentSelectionList::~HTMLContentSelectionList()&apos;:
/home/lauro/webkit/webkit-deb/Source/WTF/wtf/RefPtr.h:56: sorry, unimplemented: inlining failed in call to &apos;WTF::RefPtr&lt;T&gt;::~RefPtr() [with T = WebCore::HTMLContentSelection]&apos;: recursive inlining
/home/lauro/webkit/webkit-deb/Source/WebCore/html/shadow/HTMLContentSelector.h:47: sorry, unimplemented: called from here
...

What if we add back an ifdef guard again for it: #if !(PLATFORM(QT) &amp;&amp; CPU(ARM)) ?

Any better idea?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614633</commentid>
    <comment_count>15</comment_count>
      <attachid>139878</attachid>
    <who name="Lauro Moura Maranhao Neto">lauro.neto</who>
    <bug_when>2012-05-02 13:56:31 -0700</bug_when>
    <thetext>Created attachment 139878
Patch with guard for Qt &amp;&amp; Arm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>614994</commentid>
    <comment_count>16</comment_count>
      <attachid>139878</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 22:19:23 -0700</bug_when>
    <thetext>Comment on attachment 139878
Patch with guard for Qt &amp;&amp; Arm

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>615029</commentid>
    <comment_count>17</comment_count>
      <attachid>139878</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-02 23:10:04 -0700</bug_when>
    <thetext>Comment on attachment 139878
Patch with guard for Qt &amp;&amp; Arm

Clearing flags on attachment: 139878

Committed r115940: &lt;http://trac.webkit.org/changeset/115940&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>615030</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-02 23:10:10 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>615035</commentid>
    <comment_count>19</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-05-02 23:19:45 -0700</bug_when>
    <thetext>Reopen not to forget removing this workaround after updating GCC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>615344</commentid>
    <comment_count>20</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2012-05-03 09:34:55 -0700</bug_when>
    <thetext>If this is a compiler issue, then it should really be an #if COMPILER, not an #if PLATFORM &amp;&amp; CPU. Obviously we can live with the way it was landed, but it’s not quite right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>670198</commentid>
    <comment_count>21</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-07-16 02:05:19 -0700</bug_when>
    <thetext>I wonder if this issue is still present with Harmattan PR 1.3?

It also appears that this happens when building inside Scratchbox. What about builds outside of scratchbox box? Does the latest cross-compiling toolchain delivered with the Qt SDK suffer from the same bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925954</commentid>
    <comment_count>22</comment_count>
      <attachid>210828</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-09-06 18:35:27 -0700</bug_when>
    <thetext>Created attachment 210828
Remove hack

I think it should be okay to remove this now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925971</commentid>
    <comment_count>23</comment_count>
      <attachid>210828</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-09-06 19:34:58 -0700</bug_when>
    <thetext>Comment on attachment 210828
Remove hack

Clearing flags on attachment: 210828

Committed r155232: &lt;http://trac.webkit.org/changeset/155232&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925972</commentid>
    <comment_count>24</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2013-09-06 19:35:06 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52848</attachid>
            <date>2010-04-08 01:11:30 -0700</date>
            <delta_ts>2010-06-11 11:48:02 -0700</delta_ts>
            <desc>proposed workaround until fix</desc>
            <filename>buildfix.patch</filename>
            <type>text/plain</type>
            <size>1717</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBmNWJmZTFlLi5kZmI1YmI5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg
QEAKKzIwMTAtMDQtMDggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdcjU3MjQw
IGJyb2tlIFF0IGJ1aWxkIChtaWdodCBiZSBhIGdjYyBidWcpCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI1MworCisgICAgICAgIFdvcmthcm91bmQg
dW50aWwgZml4LiBPbiBQTEFURk9STShRVCkgdXNlIGlubGluZSBpbnN0ZWFkIG9mIEFMV0FZU19J
TkxJTkUuCisKKyAgICAgICAgKiB3dGYvUGFzc1JlZlB0ci5oOiBRdCBndWFyZHMgYWRkZWQuCisK
IDIwMTAtMDQtMDcgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93
dGYvUGFzc1JlZlB0ci5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1Bhc3NSZWZQdHIuaAppbmRleCAy
NGQ4Y2FiLi42MDhkMjE3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvUGFzc1JlZlB0
ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVmUHRyLmgKQEAgLTMzLDkgKzMzLDE2
IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIC8vIFJlbW92ZSBpbmxpbmUgZm9yIFdJTlNDVyBjb21w
aWxlciB0byBwcmV2ZW50IHRoZSBjb21waWxlciBhZ3Jlc3NpdmVseSByZXNvbHZpbmcKICAgICAv
LyBUOjpyZWYoKSBhbmQgVDo6ZGVyZWYoKSwgd2hpY2ggd2lsbCBmYWlsIGNvbXBpbGluZyB3aGVu
IFBhc3NSZWZQdHI8VD4gaXMgdXNlZCBhcwogICAgIC8vIGEgY2xhc3MgbWVtYmVyIG9yIGZ1bmN0
aW9uIGFyZ3VtZW50cyBiZWZvcmUgVCBpcyBkZWZpbmVkLgorCisgICAgLy8gW1F0XXI1NzI0MCBi
cm9rZSBRdCBidWlsZCAobWlnaHQgYmUgYSBnY2MgYnVnKQorICAgIC8vIEZJWE1FISBTZWU6IGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI1MwogICAgIHRlbXBsYXRl
PHR5cGVuYW1lIFQ+CiAjaWYgIUNPTVBJTEVSKFdJTlNDVykKKyNpZiAhUExBVEZPUk0oUVQpCiAg
ICAgQUxXQVlTX0lOTElORQorI2Vsc2UKKyAgICBpbmxpbmUKKyNlbmRpZgogI2VuZGlmCiAgICAg
dm9pZCByZWZJZk5vdE51bGwoVCogcHRyKQogICAgIHsKQEAgLTQzLDkgKzUwLDE1IEBAIG5hbWVz
cGFjZSBXVEYgewogICAgICAgICAgICAgcHRyLT5yZWYoKTsKICAgICB9CiAKKyAgICAvLyBbUXRd
cjU3MjQwIGJyb2tlIFF0IGJ1aWxkIChtaWdodCBiZSBhIGdjYyBidWcpCisgICAgLy8gRklYTUUh
IFNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjUzCiAgICAg
dGVtcGxhdGU8dHlwZW5hbWUgVD4gCiAjaWYgIUNPTVBJTEVSKFdJTlNDVykKLSAgICBBTFdBWVNf
SU5MSU5FIAorI2lmICFQTEFURk9STShRVCkKKyAgICBBTFdBWVNfSU5MSU5FCisjZWxzZQorICAg
IGlubGluZQorI2VuZGlmCiAjZW5kaWYKICAgICB2b2lkIGRlcmVmSWZOb3ROdWxsKFQqIHB0cikK
ICAgICB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>139406</attachid>
            <date>2012-04-29 14:34:00 -0700</date>
            <delta_ts>2012-05-02 01:19:21 -0700</delta_ts>
            <desc>Remove the inline hack</desc>
            <filename>cleanup_macro_guard.patch</filename>
            <type>text/plain</type>
            <size>1680</size>
            <attacher name="Adenilson Cavalcanti Silva">savagobr</attacher>
            
              <data encoding="base64">RnJvbSAyNTQxMDUxMTc3OTMxZDIyODU3OTE3YTNmNTJhY2VkZjYwM2RjODk0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h
aWwuY29tPgpEYXRlOiBTdW4sIDI5IEFwciAyMDEyIDE3OjMxOjE4IC0wNDAwClN1YmplY3Q6IFtQ
QVRDSF0gQ2xlYW51cCBvbGQgbWFjcm8gZ3VhcmQuIEN1cnJlbnQgUXQ1ICsgZ2NjIHNpbXBseSB3
b3JrcyBmaW5lCiB3aXRob3V0IGl0LgoKU2lnbmVkLW9mZi1ieTogQWRlbmlsc29uIENhdmFsY2Fu
dGkgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAg
ICAgfCAgIDEyICsrKysrKysrKysrKwogU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oIHwgICAg
NiAtLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMo
LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdl
TG9nCmluZGV4IGYwZjM0NWMuLmY1YzJiZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQt
MjkgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8Y2F2YWxjYW50aWlAZ21haWwuY29tPgorCisgICAg
ICAgIFtRdF1yNTcyNDAgYnJva2UgUXQgYnVpbGQgKGdjYyBidWcpCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI1MworCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92aW5nIHdvcmthcm91bmQgbWFjcm8g
c2luY2UgY3VycmVudCBnY2MvUXQgZG9lc24ndCByZXF1aXJlIGl0IHRvIGNvbXBpbGUuCisKKyAg
ICAgICAgKiB3dGYvUGFzc1JlZlB0ci5oOgorICAgICAgICAoV1RGKToKKwogMjAxMi0wNC0yNiAg
Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1NP
VVBdIEFkZCBhIHdheSB0byByZWdpc3RlciBjdXN0b20gdXJpIHNjaGVtZXMgaW4gV2ViS2l0Mgpk
aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oIGIvU291cmNlL1dURi93dGYv
UGFzc1JlZlB0ci5oCmluZGV4IDkyZGNiMzMuLjlkOGMzNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
VEYvd3RmL1Bhc3NSZWZQdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QYXNzUmVmUHRyLmgKQEAg
LTMyLDEzICszMiw3IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgaW5saW5lIHZvaWQgYWRvcHRl
ZChjb25zdCB2b2lkKikgeyB9CiAKLSNpZiAhUExBVEZPUk0oUVQpCiAgICAgI2RlZmluZSBSRUZf
REVSRUZfSU5MSU5FIEFMV0FZU19JTkxJTkUKLSNlbHNlCi0gICAgLy8gVXNpbmcgQUxXQVlTX0lO
TElORSBicm9rZSB0aGUgUXQgYnVpbGQuIFRoaXMgbWF5IGJlIGEgR0NDIGJ1Zy4KLSAgICAvLyBT
ZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjUzIGZvciBkZXRh
aWxzLgotICAgICNkZWZpbmUgUkVGX0RFUkVGX0lOTElORSBpbmxpbmUKLSNlbmRpZgogCiAgICAg
dGVtcGxhdGU8dHlwZW5hbWUgVD4gUkVGX0RFUkVGX0lOTElORSB2b2lkIHJlZklmTm90TnVsbChU
KiBwdHIpCiAgICAgewotLSAKMS43LjUuNAoK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>139878</attachid>
            <date>2012-05-02 13:56:31 -0700</date>
            <delta_ts>2012-05-02 23:10:04 -0700</delta_ts>
            <desc>Patch with guard for Qt &amp;&amp; Arm</desc>
            <filename>bug-37253-20120502175628.patch</filename>
            <type>text/plain</type>
            <size>1441</size>
            <attacher name="Lauro Moura Maranhao Neto">lauro.neto</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVjMjdiOTgxODMyMGRhYjQ4YTdhY2Y3
OTYxNGRjNTMxNDQ2ZDc0MGEuLjFkM2EyNDMyY2MzY2FjMDdkOWJmYTc4ZWYxMTk4NDg2NDI5NWY3
NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMDIgIExhdXJvIE5ldG8gIDxsYXVyby5u
ZXRvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XXI1NzI0MCBicm9rZSBRdCBidWlsZCAo
Z2NjIGJ1ZykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTM3MjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
QWRkIGJhY2sgdGhlIGlubGluZSBoYWNrIGp1c3QgZm9yIEFSTSBkdWUgdG8gb2xkIHZlcnNpb24g
b2YKKyAgICAgICAgZ2NjIHN0aWxsIGJlaW5nIHVzZWQgb24gSGFybWF0dGFuIFNESy4gVGhhbmtz
IHRvIE9zc3kgZm9yIHRoZQorICAgICAgICBzdWdnZXN0aW9uLgorICAgICAgICAqIHd0Zi9QYXNz
UmVmUHRyLmg6CisgICAgICAgIChXVEYpOgorCiAyMDEyLTA1LTAyICBBZGVuaWxzb24gQ2F2YWxj
YW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KIAogICAgICAgICBbUXRdcjU3MjQwIGJyb2tl
IFF0IGJ1aWxkIChnY2MgYnVnKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFzc1JlZlB0
ci5oIGIvU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oCmluZGV4IDlkOGMzNjFkNmRkMjEzMmYy
Yzk1NjFlMTBiZTljM2JmYTU2NmE1NWEuLmI4NTgwNjA4MzZjMmE0M2EyN2E1ZDc1YjkwYTI3NzJi
ZTEwZDQ5MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaAorKysgYi9T
b3VyY2UvV1RGL3d0Zi9QYXNzUmVmUHRyLmgKQEAgLTMyLDcgKzMyLDEzIEBAIG5hbWVzcGFjZSBX
VEYgewogCiAgICAgaW5saW5lIHZvaWQgYWRvcHRlZChjb25zdCB2b2lkKikgeyB9CiAKKyNpZiAh
KFBMQVRGT1JNKFFUKSAmJiBDUFUoQVJNKSkKICAgICAjZGVmaW5lIFJFRl9ERVJFRl9JTkxJTkUg
QUxXQVlTX0lOTElORQorI2Vsc2UKKyAgICAvLyBPbGRlciB2ZXJzaW9uIG9mIGdjYyB1c2VkIGJ5
IEhhcm1hdHRhbiBTREsgZmFpbHMgdG8gYnVpbGQgd2l0aCBBTFdBWVNfSU5MSU5FLgorICAgIC8v
IFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyNTMgZm9yIGRl
dGFpbHMuCisgICAgI2RlZmluZSBSRUZfREVSRUZfSU5MSU5FIGlubGluZQorI2VuZGlmCiAKICAg
ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBSRUZfREVSRUZfSU5MSU5FIHZvaWQgcmVmSWZOb3ROdWxs
KFQqIHB0cikKICAgICB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>210828</attachid>
            <date>2013-09-06 18:35:27 -0700</date>
            <delta_ts>2013-09-06 19:34:57 -0700</delta_ts>
            <desc>Remove hack</desc>
            <filename>bug-37253.diff</filename>
            <type>text/plain</type>
            <size>2006</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK
aW5kZXggOWZmMmNlOS4uOWEzYjRhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMy0wOS0wNiAg
QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIG9sZCB3
b3JrYXJvdW5kIGZvciBOb2tpYSdzIEhhcm1hdHRhbiBHQ0Mgb24gUXQvQVJNLgorICAgICAgICA8
aHR0cHM6Ly93ZWJraXQub3JnL2IvMzcyNTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQXBwYXJlbnRseSB0aGlzIHdhcyBhIHdvcmthcm91bmQgZm9y
IEdDQyBnZXR0aW5nIHN0dWNrIGluIGFuIGluZmluaXRlIGxvb3AKKyAgICAgICAgd2hlbiBidWls
ZGluZyBmb3IgQVJNIGluIGEgTm9raWEgU0RLIG92ZXIgMiB5ZWFycyBhZ28uCisKKyAgICAgICAg
SSB0aGluayBpdCdzIHNhZmUgdG8gcmVtb3ZlIHRoaXMgbm93LCBidXQgaWYgSSdtIHdyb25nLCBh
bmQgeW91J3JlIHJlYWRpbmcKKyAgICAgICAgdGhpcyBDaGFuZ2VMb2cgd29uZGVyaW5nIHdoeSBJ
IGRpZCB0aGlzIHRvIHlvdSwgZmVlbCBmcmVlIHRvIHB1dCBpdCBiYWNrIGluLgorCisgICAgICAg
ICogd3RmL1Bhc3NSZWZQdHIuaDoKKyAgICAgICAgKFdURjo6cmVmSWZOb3ROdWxsKToKKyAgICAg
ICAgKFdURjo6ZGVyZWZJZk5vdE51bGwpOgorCisyMDEzLTA5LTA2ICBBbmRyZWFzIEtsaW5nICA8
YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW1vdmUgdW51c2VkIFJlZlB0cihQbGFjZW1l
bnROZXdBZG9wdCkgY29uc3RydWN0b3IuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8x
MjA5MTQ+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaCBiL1NvdXJj
ZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaAppbmRleCAxZTFjNzc3Li44NDhmYzVmIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV1RGL3d0Zi9QYXNzUmVmUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFzc1Jl
ZlB0ci5oCkBAIC0zMiwyOCArMzIsMTggQEAgbmFtZXNwYWNlIFdURiB7CiAKICAgICBpbmxpbmUg
dm9pZCBhZG9wdGVkKGNvbnN0IHZvaWQqKSB7IH0KIAotI2lmICEoUExBVEZPUk0oUVQpICYmIENQ
VShBUk0pKQotICAgICNkZWZpbmUgUkVGX0RFUkVGX0lOTElORSBBTFdBWVNfSU5MSU5FCi0jZWxz
ZQotICAgIC8vIE9sZGVyIHZlcnNpb24gb2YgZ2NjIHVzZWQgYnkgSGFybWF0dGFuIFNESyBmYWls
cyB0byBidWlsZCB3aXRoIEFMV0FZU19JTkxJTkUuCi0gICAgLy8gU2VlIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzI1MyBmb3IgZGV0YWlscy4KLSAgICAjZGVmaW5l
IFJFRl9ERVJFRl9JTkxJTkUgaW5saW5lCi0jZW5kaWYKLQotICAgIHRlbXBsYXRlPHR5cGVuYW1l
IFQ+IFJFRl9ERVJFRl9JTkxJTkUgdm9pZCByZWZJZk5vdE51bGwoVCogcHRyKQorICAgIHRlbXBs
YXRlPHR5cGVuYW1lIFQ+IEFMV0FZU19JTkxJTkUgdm9pZCByZWZJZk5vdE51bGwoVCogcHRyKQog
ICAgIHsKICAgICAgICAgaWYgKExJS0VMWShwdHIgIT0gMCkpCiAgICAgICAgICAgICBwdHItPnJl
ZigpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IFJFRl9ERVJFRl9JTkxJTkUg
dm9pZCBkZXJlZklmTm90TnVsbChUKiBwdHIpCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gQUxX
QVlTX0lOTElORSB2b2lkIGRlcmVmSWZOb3ROdWxsKFQqIHB0cikKICAgICB7CiAgICAgICAgIGlm
IChMSUtFTFkocHRyICE9IDApKQogICAgICAgICAgICAgcHRyLT5kZXJlZigpOwogICAgIH0KIAot
ICAgICN1bmRlZiBSRUZfREVSRUZfSU5MSU5FCi0KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBj
bGFzcyBQYXNzUmVmUHRyIHsKICAgICBwdWJsaWM6CiAgICAgICAgIFBhc3NSZWZQdHIoKSA6IG1f
cHRyKDApIHsgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>