37247 2010-04-07 22:53:16 -0700 Limit XML node depth 2010-05-18 09:34:52 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 18282 1 scarybeasts webkit-unassigned abarth ap cevans commit-queue eric ojan vestbo oldest_to_newest 210002 0 scarybeasts 2010-04-07 22:53:16 -0700 Patch forthcoming. 210014 1 52833 scarybeasts 2010-04-07 23:20:31 -0700 Created attachment 52833 Limit excessive XML recursion, which can cause stack overflows in various paths. 210018 2 52833 abarth 2010-04-07 23:31:28 -0700 Comment on attachment 52833 Limit excessive XML recursion, which can cause stack overflows in various paths. ok 210064 3 52833 commit-queue 2010-04-08 00:56:58 -0700 Comment on attachment 52833 Limit excessive XML recursion, which can cause stack overflows in various paths. Rejecting patch 52833 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: comparison between signed and unsigned integer expressions distcc[50702] ERROR: compile /Users/eseidel/Projects/CommitQueue/WebCore/dom/XMLTokenizer.cpp on localhost failed ** BUILD FAILED ** The following build commands failed: WebCore: Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/XMLTokenizer.o /Users/eseidel/Projects/CommitQueue/WebCore/dom/XMLTokenizer.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/1688051 210069 4 52846 scarybeasts 2010-04-08 01:02:59 -0700 Created attachment 52846 Fix type mismatch. 210070 5 52846 abarth 2010-04-08 01:04:06 -0700 Comment on attachment 52846 Fix type mismatch. k 210075 6 52846 commit-queue 2010-04-08 01:19:31 -0700 Comment on attachment 52846 Fix type mismatch. Clearing flags on attachment: 52846 Committed r57263: <http://trac.webkit.org/changeset/57263> 210101 7 eric 2010-04-08 02:36:49 -0700 I am concerned this test runs too slowly. Chromium will need to mark it as SLOW if nothing else. 210102 8 scarybeasts 2010-04-08 02:40:24 -0700 How long do you see it taking? At what timing do things be a concern? 210339 9 ap 2010-04-08 12:48:13 -0700 *** Bug 35746 has been marked as a duplicate of this bug. *** 210342 10 ap 2010-04-08 12:50:15 -0700 The test takes about a second for me on a debug build (on Mac Book Pro). This doesn't seem to be excessively slow. 215751 11 52846 commit-queue 2010-04-22 00:19:35 -0700 Comment on attachment 52846 Fix type mismatch. Rejecting patch 52846 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 patching file WebCore/dom/XMLTokenizer.cpp Hunk #1 FAILED at 67. Hunk #2 FAILED at 87. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/dom/XMLTokenizer.cpp.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/images/svg-nested.html patching file LayoutTests/fast/images/svg-nested-expected.txt patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Full output: http://webkit-commit-queue.appspot.com/results/1853042 226183 12 52846 abarth 2010-05-15 00:12:21 -0700 Comment on attachment 52846 Fix type mismatch. Clearing Eric's r+ from this patch so that it doesn't show up in pending-commit. Please upload an updated version of this patch that applies cleanly to top of tree. BTW, the tools say that you're not a committer, but I thought your paperwork when through. If you're not listed in committers.py, please add yourself and feel free to land an updated version of this patch with Eric's review. 227293 13 cevans 2010-05-18 07:25:56 -0700 Hi Adam, This was already landed as per c6. Looks like the patch was added to the commit-queue twice and the second one obviously failed. So nothing to do here. I'll add myself to committers.py shortly. Cheers Chris 227343 14 abarth 2010-05-18 09:34:52 -0700 If this patch as been landed, we should close the bug. 52833 2010-04-07 23:20:31 -0700 2010-04-21 18:25:01 -0700 Limit excessive XML recursion, which can cause stack overflows in various paths. xml.diff text/plain 3132 scarybeasts SW5kZXg6IFdlYkNvcmUvZG9tL1hNTFRva2VuaXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9kb20vWE1MVG9rZW5pemVyLmNwcAkocmV2aXNpb24gNTcxNjApCisrKyBXZWJDb3JlL2RvbS9Y TUxUb2tlbml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw3IEBACiB1c2luZyBu YW1lc3BhY2UgSFRNTE5hbWVzOwogCiBjb25zdCBpbnQgbWF4RXJyb3JzID0gMjU7Citjb25zdCBp bnQgbWF4TmVzdGluZ0RlcHRoID0gNDA5NjsKIAogI2lmIEVOQUJMRShXTUwpCiBib29sIFhNTFRv a2VuaXplcjo6aXNXTUxEb2N1bWVudCgpIGNvbnN0CkBAIC04Niw2ICs4Nyw4IEBACiAgICAgICAg IG4tPnJlZigpOwogICAgIG1fY3VycmVudE5vZGVTdGFjay5hcHBlbmQobV9jdXJyZW50Tm9kZSk7 CiAgICAgbV9jdXJyZW50Tm9kZSA9IG47CisgICAgaWYgKG1fY3VycmVudE5vZGVTdGFjay5zaXpl KCkgPiBtYXhOZXN0aW5nRGVwdGgpCisgICAgICAgIGhhbmRsZUVycm9yKGZhdGFsLCAiRXhjZXNz aXZlIG5vZGUgbmVzdGluZy4iLCBsaW5lTnVtYmVyKCksIGNvbHVtbk51bWJlcigpKTsKIH0KIAog dm9pZCBYTUxUb2tlbml6ZXI6OnBvcEN1cnJlbnROb2RlKCkKSW5kZXg6IFdlYkNvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NzE2MCkKKysr IFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAt MDQtMDcgIENocmlzIEV2YW5zICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYW5pdHk6IGFwcGx5IGEgbWF4IG5v ZGUgZGVwdGggdG8gWE1MIHBhcnNpbmcuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM3MjQ3CisKKyAgICAgICAgVGVzdDogZmFzdC9pbWFnZXMvc3Zn LW5lc3RlZC5odG1sCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlhNTFRva2VuaXplcjo6cHVzaEN1cnJlbnROb2RlKToKKyAgICAgICAgICBFcnJv ciBvdXQgdGhlIHBhcnNlIHVwb24gYSByZWFsbHkgbGFyZ2Ugbm9kZSBkZXB0aC4KKwogMjAxMC0w NC0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3N2 Zy1uZXN0ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9zdmct bmVzdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9zdmct bmVzdGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEgQEAKKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRV bnRpbERvbmUoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CitTdWNjZXNzIC0gYSBo dWdlbHkgbmVzdGVkIFNWRyBkaWQgbm90IGNyYXNoIHVzLgorPHNjcmlwdD4KK2Z1bmN0aW9uIGRv bmUoKSB7CisgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICBlbHNlCisgICAgYWxlcnQoJ2RvbmUhJyk7Cit9 CisKK3ZhciB4ID0gJyc7Citmb3IgKGk9MDsgaTw1MDAwMDsgKytpKQorICB4ICs9ICc8YT4nOwor Zm9yIChpPTA7IGk8NTAwMDA7ICsraSkKKyAgeCArPSAnPC9hPic7Cit2YXIgdXJpID0gJ2RhdGE6 aW1hZ2Uvc3ZnK3htbCwnICsgeDsKK3ZhciBpID0gbmV3IEltYWdlKCk7CitpLm9uZXJyb3IgPSBk b25lOworaS5zcmMgPSB1cmk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3N2Zy1uZXN0ZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3N2Zy1uZXN0ZWQtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvc3ZnLW5lc3RlZC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1N1Y2Nlc3MgLSBhIGh1Z2VseSBuZXN0ZWQg U1ZHIGRpZCBub3QgY3Jhc2ggdXMuCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NzE2MCkKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0 LTA3ICBDaHJpcyBFdmFucyAgPGNldmFuc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yIFNWRyBpbWFnZSB3 aXRoIGV4Y2Vzc2l2ZSBuZXN0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzcyNDcKKworICAgICAgICAqIGZhc3QvaW1hZ2VzL3N2Zy1uZXN0ZWQu aHRtbDogYWRkZWQKKyAgICAgICAgKiBmYXN0L2ltYWdlcy9zdmctbmVzdGVkLWV4cGVjdGVkLnR4 dDogYWRkZWQKKwogMjAxMC0wNC0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjU3MTA5KTogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctaW1h Z2UtdG8tY29udGVudGVkaXRhYmxlLWluLWlmcmFtZS5odG1sIGZhaWxzIG9uIFdpbmRvd3MK 52846 2010-04-08 01:02:59 -0700 2010-05-15 00:12:21 -0700 Fix type mismatch. xml2.diff text/plain 3135 scarybeasts SW5kZXg6IFdlYkNvcmUvZG9tL1hNTFRva2VuaXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9kb20vWE1MVG9rZW5pemVyLmNwcAkocmV2aXNpb24gNTcxNjApCisrKyBXZWJDb3JlL2RvbS9Y TUxUb2tlbml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw3IEBACiB1c2luZyBu YW1lc3BhY2UgSFRNTE5hbWVzOwogCiBjb25zdCBpbnQgbWF4RXJyb3JzID0gMjU7Citjb25zdCBz aXplX3QgbWF4TmVzdGluZ0RlcHRoID0gNDA5NjsKIAogI2lmIEVOQUJMRShXTUwpCiBib29sIFhN TFRva2VuaXplcjo6aXNXTUxEb2N1bWVudCgpIGNvbnN0CkBAIC04Niw2ICs4Nyw4IEBACiAgICAg ICAgIG4tPnJlZigpOwogICAgIG1fY3VycmVudE5vZGVTdGFjay5hcHBlbmQobV9jdXJyZW50Tm9k ZSk7CiAgICAgbV9jdXJyZW50Tm9kZSA9IG47CisgICAgaWYgKG1fY3VycmVudE5vZGVTdGFjay5z aXplKCkgPiBtYXhOZXN0aW5nRGVwdGgpCisgICAgICAgIGhhbmRsZUVycm9yKGZhdGFsLCAiRXhj ZXNzaXZlIG5vZGUgbmVzdGluZy4iLCBsaW5lTnVtYmVyKCksIGNvbHVtbk51bWJlcigpKTsKIH0K IAogdm9pZCBYTUxUb2tlbml6ZXI6OnBvcEN1cnJlbnROb2RlKCkKSW5kZXg6IFdlYkNvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NzE2MCkK KysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTAtMDQtMDcgIENocmlzIEV2YW5zICA8Y2V2YW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYW5pdHk6IGFwcGx5IGEgbWF4 IG5vZGUgZGVwdGggdG8gWE1MIHBhcnNpbmcuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjQ3CisKKyAgICAgICAgVGVzdDogZmFzdC9pbWFnZXMv c3ZnLW5lc3RlZC5odG1sCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlhNTFRva2VuaXplcjo6cHVzaEN1cnJlbnROb2RlKToKKyAgICAgICAgICBF cnJvciBvdXQgdGhlIHBhcnNlIHVwb24gYSByZWFsbHkgbGFyZ2Ugbm9kZSBkZXB0aC4KKwogMjAx MC0wNC0wNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVy LXN0YW1wZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaW1hZ2Vz L3N2Zy1uZXN0ZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9z dmctbmVzdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9z dmctbmVzdGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzEgQEAKKzxodG1sPgorPGhl YWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgIGxheW91dFRlc3RDb250cm9sbGVyLndh aXRVbnRpbERvbmUoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CitTdWNjZXNzIC0g YSBodWdlbHkgbmVzdGVkIFNWRyBkaWQgbm90IGNyYXNoIHVzLgorPHNjcmlwdD4KK2Z1bmN0aW9u IGRvbmUoKSB7CisgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICBlbHNlCisgICAgYWxlcnQoJ2RvbmUhJyk7 Cit9CisKK3ZhciB4ID0gJyc7Citmb3IgKGk9MDsgaTw1MDAwMDsgKytpKQorICB4ICs9ICc8YT4n OworZm9yIChpPTA7IGk8NTAwMDA7ICsraSkKKyAgeCArPSAnPC9hPic7Cit2YXIgdXJpID0gJ2Rh dGE6aW1hZ2Uvc3ZnK3htbCwnICsgeDsKK3ZhciBpID0gbmV3IEltYWdlKCk7CitpLm9uZXJyb3Ig PSBkb25lOworaS5zcmMgPSB1cmk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3N2Zy1uZXN0ZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3N2Zy1uZXN0ZWQtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvc3ZnLW5lc3RlZC1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1N1Y2Nlc3MgLSBhIGh1Z2VseSBuZXN0 ZWQgU1ZHIGRpZCBub3QgY3Jhc2ggdXMuCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NzE2MCkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEw LTA0LTA3ICBDaHJpcyBFdmFucyAgPGNldmFuc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3QgZm9yIFNWRyBpbWFn ZSB3aXRoIGV4Y2Vzc2l2ZSBuZXN0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzcyNDcKKworICAgICAgICAqIGZhc3QvaW1hZ2VzL3N2Zy1uZXN0 ZWQuaHRtbDogYWRkZWQKKyAgICAgICAgKiBmYXN0L2ltYWdlcy9zdmctbmVzdGVkLWV4cGVjdGVk LnR4dDogYWRkZWQKKwogMjAxMC0wNC0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjU3MTA5KTogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWct aW1hZ2UtdG8tY29udGVudGVkaXRhYmxlLWluLWlmcmFtZS5odG1sIGZhaWxzIG9uIFdpbmRvd3MK