37243 2010-04-07 17:49:25 -0700 [chromium] <select> dropdowns don't die when an item is selected 2010-04-09 14:18:06 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P1 Critical --- 1 estade webkit-unassigned eric jcivelli oldest_to_newest 209944 0 estade 2010-04-07 17:49:25 -0700 see http://code.google.com/p/chromium/issues/detail?id=40749 and http://code.google.com/p/chromium/issues/detail?id=40556 209946 1 52813 estade 2010-04-07 17:52:23 -0700 Created attachment 52813 try1 209949 2 estade 2010-04-07 17:55:53 -0700 this is p1 in the chromium tracker, so I'm marking importance as P1/critical. Hopefully that's the right thing to do. 209950 3 52815 estade 2010-04-07 17:57:35 -0700 Created attachment 52815 stylefix 210337 4 52815 dglazkov 2010-04-08 12:47:39 -0700 Comment on attachment 52815 stylefix r=me. Can we please add more testing around popups? We're in bad place here. 210644 5 52815 commit-queue 2010-04-09 02:48:08 -0700 Comment on attachment 52815 stylefix Clearing flags on attachment: 52815 Committed r57321: <http://trac.webkit.org/changeset/57321> 210649 6 52815 commit-queue 2010-04-09 02:56:45 -0700 Comment on attachment 52815 stylefix Rejecting patch 52815 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/chromium/PopupMenuChromium.cpp Hunk #1 FAILED at 412. Hunk #2 FAILED at 1127. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/chromium/PopupMenuChromium.cpp.rej patching file WebCore/platform/chromium/PopupMenuChromium.h Hunk #1 succeeded at 154 with fuzz 2 (offset 3 lines). Full output: http://webkit-commit-queue.appspot.com/results/1580336 52813 2010-04-07 17:52:23 -0700 2010-04-07 17:57:35 -0700 try1 percolate.diff text/plain 2108 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDcgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gPHNlbGVjdD4gZHJvcGRvd25zIGRvbid0IGRpZSB3aGVuIGFuIGl0ZW0gaXMgc2Vs ZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 MjQzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENvbnRhaW5lcjo6aGlkZVBvcHVwKToKKyAgICAgICAg KFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyOjpub3RpZnlQb3B1cEhpZGRlbik6CisgICAgICAgIChX ZWJDb3JlOjpQb3B1cExpc3RCb3g6OmhpZGVQb3B1cCk6IGluZm9ybSBjb250YWluZXIgdGhhdCBw b3B1cCBpcyBjbG9zaW5nCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uaDoKKwogMjAxMC0wNC0wNyAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgRmFsa2VuYnVyZy4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA1 NzI0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00MTIsNyArNDEyLDEwIEBAIHZvaWQgUG9wdXBDb250YWluZXI6 OnNob3dFeHRlcm5hbChjb25zdCAKIHZvaWQgUG9wdXBDb250YWluZXI6OmhpZGVQb3B1cCgpCiB7 CiAgICAgbGlzdEJveCgpLT5oaWRlUG9wdXAoKTsKLSAgICBjaHJvbWVDbGllbnRDaHJvbWl1bSgp LT5wb3B1cENsb3NlZCh0aGlzKTsKK30KKwordm9pZCBQb3B1cENvbnRhaW5lcjo6bm90aWZ5UG9w dXBIaWRkZW4oKSB7CisgICAgIGNocm9tZUNsaWVudENocm9taXVtKCktPnBvcHVwQ2xvc2VkKHRo aXMpOwogfQogCiB2b2lkIFBvcHVwQ29udGFpbmVyOjpsYXlvdXQoKQpAQCAtMTEyMyw2ICsxMTI2 LDcgQEAgdm9pZCBQb3B1cExpc3RCb3g6OmhpZGVQb3B1cCgpCiAgICAgICAgIFBvcHVwQ29udGFp bmVyKiBjb250YWluZXIgPSBzdGF0aWNfY2FzdDxQb3B1cENvbnRhaW5lcio+KHBhcmVudCgpKTsK ICAgICAgICAgaWYgKGNvbnRhaW5lci0+Y2xpZW50KCkpCiAgICAgICAgICAgICBjb250YWluZXIt PmNsaWVudCgpLT5wb3B1cENsb3NlZChjb250YWluZXIpOworICAgICAgICBjb250YWluZXItPm5v dGlmeVBvcHVwSGlkZGVuKCk7CiAgICAgfQogCiAgICAgaWYgKG1fcG9wdXBDbGllbnQpCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCShyZXZp c2lvbiA1NzI0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21p dW0uaAkod29ya2luZyBjb3B5KQpAQCAtMTUxLDYgKzE1MSw5IEBAIHB1YmxpYzoKICAgICAvLyBI aWRlIHRoZSBwb3B1cC4KICAgICB2b2lkIGhpZGVQb3B1cCgpOwogCisgICAgLy8gVGhlIHBvcHVw IHdhcyBoaWRkZW4uCisgICAgdm9pZCBub3RpZnlQb3B1cEhpZGRlbigpOworCiAgICAgLy8gQ29t cHV0ZSBzaXplIG9mIHdpZGdldCBhbmQgY2hpbGRyZW4uCiAgICAgdm9pZCBsYXlvdXQoKTsKIAo= 52815 2010-04-07 17:57:35 -0700 2010-04-09 02:56:45 -0700 stylefix percolate.diff text/plain 2109 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDcgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gPHNlbGVjdD4gZHJvcGRvd25zIGRvbid0IGRpZSB3aGVuIGFuIGl0ZW0gaXMgc2Vs ZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 MjQzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQb3B1cENvbnRhaW5lcjo6aGlkZVBvcHVwKToKKyAgICAgICAg KFdlYkNvcmU6OlBvcHVwQ29udGFpbmVyOjpub3RpZnlQb3B1cEhpZGRlbik6CisgICAgICAgIChX ZWJDb3JlOjpQb3B1cExpc3RCb3g6OmhpZGVQb3B1cCk6IGluZm9ybSBjb250YWluZXIgdGhhdCBw b3B1cCBpcyBjbG9zaW5nCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hy b21pdW0uaDoKKwogMjAxMC0wNC0wNyAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgRmFsa2VuYnVyZy4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCShyZXZpc2lvbiA1 NzI0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00MTIsNyArNDEyLDExIEBAIHZvaWQgUG9wdXBDb250YWluZXI6 OnNob3dFeHRlcm5hbChjb25zdCAKIHZvaWQgUG9wdXBDb250YWluZXI6OmhpZGVQb3B1cCgpCiB7 CiAgICAgbGlzdEJveCgpLT5oaWRlUG9wdXAoKTsKLSAgICBjaHJvbWVDbGllbnRDaHJvbWl1bSgp LT5wb3B1cENsb3NlZCh0aGlzKTsKK30KKwordm9pZCBQb3B1cENvbnRhaW5lcjo6bm90aWZ5UG9w dXBIaWRkZW4oKQoreworICAgICBjaHJvbWVDbGllbnRDaHJvbWl1bSgpLT5wb3B1cENsb3NlZCh0 aGlzKTsKIH0KIAogdm9pZCBQb3B1cENvbnRhaW5lcjo6bGF5b3V0KCkKQEAgLTExMjMsNiArMTEy Nyw3IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpoaWRlUG9wdXAoKQogICAgICAgICBQb3B1cENvbnRh aW5lciogY29udGFpbmVyID0gc3RhdGljX2Nhc3Q8UG9wdXBDb250YWluZXIqPihwYXJlbnQoKSk7 CiAgICAgICAgIGlmIChjb250YWluZXItPmNsaWVudCgpKQogICAgICAgICAgICAgY29udGFpbmVy LT5jbGllbnQoKS0+cG9wdXBDbG9zZWQoY29udGFpbmVyKTsKKyAgICAgICAgY29udGFpbmVyLT5u b3RpZnlQb3B1cEhpZGRlbigpOwogICAgIH0KIAogICAgIGlmIChtX3BvcHVwQ2xpZW50KQpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaAkocmV2 aXNpb24gNTcyNDQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9t aXVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTE1MSw2ICsxNTEsOSBAQCBwdWJsaWM6CiAgICAgLy8g SGlkZSB0aGUgcG9wdXAuCiAgICAgdm9pZCBoaWRlUG9wdXAoKTsKIAorICAgIC8vIFRoZSBwb3B1 cCB3YXMgaGlkZGVuLgorICAgIHZvaWQgbm90aWZ5UG9wdXBIaWRkZW4oKTsKKwogICAgIC8vIENv bXB1dGUgc2l6ZSBvZiB3aWRnZXQgYW5kIGNoaWxkcmVuLgogICAgIHZvaWQgbGF5b3V0KCk7CiAK