37233 2010-04-07 14:37:55 -0700 add slightly better logging to the python websocket_server wrapper script 2010-04-19 14:59:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke ap cjerdonek eric ukai oldest_to_newest 209852 0 dpranke 2010-04-07 14:37:55 -0700 It can be hard to debug what's going on with the python websocket server; I recently spent a few misdirected hours debugging issues because I didn't realize that there was an old websocket server already running on my machine. This change adds a --verbose flag for debug output and fixes a couple other minor nits. 209853 1 52784 dpranke 2010-04-07 14:43:54 -0700 Created attachment 52784 patch to add --verbose to websocket_server, slightly improve logging 209959 2 ukai 2010-04-07 18:17:05 -0700 (In reply to comment #1) > Created an attachment (id=52784) [details] > patch to add --verbose to websocket_server, slightly improve logging LGTM 209978 3 ap 2010-04-07 20:58:42 -0700 How does one pass this flag? I only know run-webkit-websocketserver, which doesn't seem to forward any flags. 210311 4 dpranke 2010-04-08 12:17:36 -0700 (In reply to comment #3) > How does one pass this flag? I only know run-webkit-websocketserver, which > doesn't seem to forward any flags. There isn't a generic new-run-webkit-websocketserver wrapper that would invoke this python code. We should probably add one. Otherwise, you would only pass this flag if you were running the script directly by hand. 210922 5 52784 eric 2010-04-09 14:11:50 -0700 Comment on attachment 52784 patch to add --verbose to websocket_server, slightly improve logging 241 pid = None looks unrelated. 210968 6 dpranke 2010-04-09 15:28:06 -0700 (In reply to comment #5) > (From update of attachment 52784 [details]) > 241 pid = None > looks unrelated. Yes, it is unrelated, but it is one of the "other minor nits" referred to in my first comment. 213930 7 52784 eric 2010-04-19 00:11:40 -0700 Comment on attachment 52784 patch to add --verbose to websocket_server, slightly improve logging OK. 214249 8 53722 dpranke 2010-04-19 14:36:47 -0700 Created attachment 53722 Patch 214263 9 53722 eric 2010-04-19 14:56:40 -0700 Comment on attachment 53722 Patch OK. 214266 10 53722 dpranke 2010-04-19 14:59:50 -0700 Comment on attachment 53722 Patch Clearing flags on attachment: 53722 Committed r57845: <http://trac.webkit.org/changeset/57845> 214267 11 dpranke 2010-04-19 14:59:55 -0700 All reviewed patches have been landed. Closing bug. 52784 2010-04-07 14:43:54 -0700 2010-04-19 14:36:42 -0700 patch to add --verbose to websocket_server, slightly improve logging wk37233_websocket_debugging.diff text/plain 2002 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxMWNiNDdkLi41MjQ4MTEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MDcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNsaWdodGx5IGJldHRlciBsb2dn aW5nIHRvIHRoZSB3ZWJzb2NrZXQgcHl0aG9uIHdyYXBwZXIgc2NyaXB0LAorICAgICAgICBpbmNs dWRpbmcgYSAtLXZlcmJvc2UgZmxhZyBmb3IgZGVidWcgb3V0cHV0LgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzIzMworCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5OgorCiAy MDEwLTA0LTA2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5IGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVy LnB5CmluZGV4IGIyODM1ZjcuLjY4N2RlOTggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNvY2tldF9z ZXJ2ZXIucHkKQEAgLTIzOCw2ICsyMzgsNyBAQCBjbGFzcyBQeVdlYlNvY2tldChodHRwX3NlcnZl ci5MaWdodHRwZCk6CiAgICAgICAgIGlmIG5vdCBmb3JjZSBhbmQgbm90IHNlbGYuaXNfcnVubmlu ZygpOgogICAgICAgICAgICAgcmV0dXJuCiAKKyAgICAgICAgcGlkID0gTm9uZQogICAgICAgICBp ZiBzZWxmLl9wcm9jZXNzOgogICAgICAgICAgICAgcGlkID0gc2VsZi5fcHJvY2Vzcy5waWQKICAg ICAgICAgZWxpZiBzZWxmLl9waWRmaWxlOgpAQCAtMjg0LDYgKzI4NSw4IEBAIGlmICdfX21haW5f XycgPT0gX19uYW1lX186CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlc3Q9InJlZ2lz dGVyX2N5Z3dpbiIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhlbHA9J1JlZ2lzdGVy IEN5Z3dpbiBwYXRocyAob24gV2luIHRyeSBib3RzKScpCiAgICAgb3B0aW9uX3BhcnNlci5hZGRf b3B0aW9uKCctLXBpZGZpbGUnLCBoZWxwPSdwYXRoIHRvIHBpZCBmaWxlLicpCisgICAgb3B0aW9u X3BhcnNlci5hZGRfb3B0aW9uKCItdiIsICItLXZlcmJvc2UiLCBhY3Rpb249InN0b3JlX3RydWUi LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLCBoZWxwPSJpbmNs dWRlIGRlYnVnLWxldmVsIGxvZ2dpbmciKQogICAgIG9wdGlvbnMsIGFyZ3MgPSBvcHRpb25fcGFy c2VyLnBhcnNlX2FyZ3MoKQogCiAgICAgaWYgbm90IG9wdGlvbnMucG9ydDoKQEAgLTMwNiw2ICsz MDksMTEgQEAgaWYgJ19fbWFpbl9fJyA9PSBfX25hbWVfXzoKICAgICBwb3J0X29iaiA9IGZhY3Rv cnkuZ2V0KCkKICAgICBweXdlYnNvY2tldCA9IFB5V2ViU29ja2V0KHBvcnRfb2JqLCB0ZW1wZmls ZS5nZXR0ZW1wZGlyKCksICoqa3dkcykKIAorICAgIGxvZ19sZXZlbCA9IGxvZ2dpbmcuV0FSTgor ICAgIGlmIG9wdGlvbnMudmVyYm9zZToKKyAgICAgICAgbG9nX2xldmVsID0gbG9nZ2luZy5ERUJV RworICAgIGxvZ2dpbmcuYmFzaWNDb25maWcobGV2ZWw9bG9nX2xldmVsKQorCiAgICAgaWYgJ3N0 YXJ0JyA9PSBvcHRpb25zLnNlcnZlcjoKICAgICAgICAgcHl3ZWJzb2NrZXQuc3RhcnQoKQogICAg IGVsc2U6Cg== 53722 2010-04-19 14:36:47 -0700 2010-04-19 14:59:49 -0700 Patch bug-37233-20100419143646.patch text/plain 2540 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOGExZTEyLi5lNzU3MmE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MTkgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgQWRkIHNsaWdodGx5IGJldHRlciBsb2dnaW5n IHRvIHRoZSB3ZWJzb2NrZXQgcHl0aG9uIHdyYXBwZXIgc2NyaXB0LAorICAgICAgICBpbmNsdWRp bmcgYSAtLXZlcmJvc2UgZmxhZyBmb3IgZGVidWcgb3V0cHV0LgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzIzMworCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5OgorICAgICAg ICAqIFNjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyOgorCiAyMDEwLTA0LTE5 ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9uZXctcnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXIKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBt b2RlIDEwMDc1NQppbmRleCAxMTlmNmUzLi44ZTRhZWFhCi0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyCisrKyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyCkBAIC0zMCw2ICszMCw3IEBACiAiIiJB IHV0aWxpdHkgc2NyaXB0IGZvciBzdGFydGluZyBhbmQgc3RvcHBpbmcgdGhlIHdlYiBzb2NrZXQg c2VydmVyIHdpdGggdGhlCiAgICBzYW1lIGNvbmZpZ3VyYXRpb24gYXMgdXNlZCBpbiB0aGUgbGF5 b3V0IHRlc3RzLiIiIgogCitpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9wdHBhcnNlCiBpbXBvcnQg dGVtcGZpbGUKIApAQCAtNTgsNiArNTksOCBAQCBkZWYgbWFpbigpOgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBkZXN0PSJyZWdpc3Rlcl9jeWd3aW4iLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBoZWxwPSdSZWdpc3RlciBDeWd3aW4gcGF0aHMgKG9uIFdpbiB0cnkgYm90cykn KQogICAgIG9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbignLS1waWRmaWxlJywgaGVscD0ncGF0aCB0 byBwaWQgZmlsZS4nKQorICAgIG9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbignLXYnLCAnLS12ZXJi b3NlJywgYWN0aW9uPSdzdG9yZV90cnVlJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGVmYXVsdD1GYWxzZSwgaGVscD0naW5jbHVkZSBkZWJ1Zy1sZXZlbCBsb2dnaW5nJykKICAgICBv cHRpb25zLCBhcmdzID0gb3B0aW9uX3BhcnNlci5wYXJzZV9hcmdzKCkKIAogICAgIGlmIG5vdCBv cHRpb25zLnBvcnQ6CkBAIC04Miw2ICs4NSwxMSBAQCBkZWYgbWFpbigpOgogICAgIHBvcnRfb2Jq ID0gZmFjdG9yeS5nZXQoKQogICAgIHB5d2Vic29ja2V0ID0gd2Vic29ja2V0X3NlcnZlci5QeVdl YlNvY2tldChwb3J0X29iaiwgdGVtcGZpbGUuZ2V0dGVtcGRpcigpLCAqKmt3ZHMpCiAKKyAgICBs b2dfbGV2ZWwgPSBsb2dnaW5nLldBUk4KKyAgICBpZiBvcHRpb25zLnZlcmJvc2U6CisgICAgICAg IGxvZ19sZXZlbCA9IGxvZ2dpbmcuREVCVUcKKyAgICBsb2dnaW5nLmJhc2ljQ29uZmlnKGxldmVs PWxvZ19sZXZlbCkKKwogICAgIGlmICdzdGFydCcgPT0gb3B0aW9ucy5zZXJ2ZXI6CiAgICAgICAg IHB5d2Vic29ja2V0LnN0YXJ0KCkKICAgICBlbHNlOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRfc2VydmVyLnB5IGIv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJzb2NrZXRf c2VydmVyLnB5CmluZGV4IDczOTkwM2YuLjAzYjQ5NDggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Vic29ja2V0X3NlcnZlci5weQor KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYnNv Y2tldF9zZXJ2ZXIucHkKQEAgLTI0MSw2ICsyNDEsNyBAQCBjbGFzcyBQeVdlYlNvY2tldChodHRw X3NlcnZlci5MaWdodHRwZCk6CiAgICAgICAgIGlmIG5vdCBmb3JjZSBhbmQgbm90IHNlbGYuaXNf cnVubmluZygpOgogICAgICAgICAgICAgcmV0dXJuCiAKKyAgICAgICAgcGlkID0gTm9uZQogICAg ICAgICBpZiBzZWxmLl9wcm9jZXNzOgogICAgICAgICAgICAgcGlkID0gc2VsZi5fcHJvY2Vzcy5w aWQKICAgICAgICAgZWxpZiBzZWxmLl9waWRmaWxlOgo=