37230 2010-04-07 14:08:36 -0700 REGRESSION (4.0.5): Safari asks for credentials all the time when authenticating to Windows IIS Server 2010-04-07 14:31:26 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap oldest_to_newest 209824 0 ap 2010-04-07 14:08:36 -0700 Safari asks for credentials for each resource from a server using NTLM auth. 209826 1 ap 2010-04-07 14:10:49 -0700 <rdar://problem/7813115> 209832 2 52781 ap 2010-04-07 14:17:28 -0700 Created attachment 52781 proposed fix 209833 3 52781 darin 2010-04-07 14:18:41 -0700 Comment on attachment 52781 proposed fix > +#if defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) > +// There is no contsnt in headers, but NTLM is supported. > +NSString * const NSURLAuthenticationMethodNTLM = @"NSURLAuthenticationMethodNTLM"; > +#endif Typo: "contsnt" How does ProtectionSpaceAuthenticationSchemeUnknown help us? Does it affect behavior? r=me 209842 4 ap 2010-04-07 14:26:39 -0700 Committed r57232. We don't fall into the default case in if (scheme == ProtectionSpaceAuthenticationSchemeHTTPBasic || scheme == ProtectionSpaceAuthenticationSchemeDefault) { // The map can contain both a path and its subpath - while redundant, this makes lookups faster. pathToDefaultProtectionSpaceMap().set(protectionSpaceMapKeyFromURL(url), protectionSpace); } 209847 5 ap 2010-04-07 14:31:26 -0700 We were hitting this with "NSURLAuthenticationMethodNTLM" on 10.5, or with "NSURLAuthenticationMethodNegotiate" on 10.6. 52781 2010-04-07 14:17:28 -0700 2010-04-07 14:18:41 -0700 proposed fix NTLMAuth.txt text/plain 5015 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzIyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDQtMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjMwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83ODEzMTE1PiBSRUdSRVNTSU9OICg0LjAuNSk6IFNhZmFyaSBhc2tzIGZv ciBjcmVkZW50aWFscyBhbGwgdGhlIHRpbWUgd2hlbgorICAgICAgICBhdXRoZW50aWNhdGluZyB0 byBXaW5kb3dzIElJUyBTZXJ2ZXIKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUHJvdGVj dGlvblNwYWNlLmg6IChXZWJDb3JlOjpQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVt ZSk6IEFkZGVkCisgICAgICAgIGEgY29uc3RhbnQgZm9yIFByb3RlY3Rpb25TcGFjZUF1dGhlbnRp Y2F0aW9uU2NoZW1lVW5rbm93bi4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvQXV0 aGVudGljYXRpb25DRi5jcHA6IChXZWJDb3JlOjpjb3JlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcDogKFdlYkNvcmU6OmF1dGhlbnRp Y2F0aW9uU2NoZW1lRnJvbUF1dGhlbnRpY2F0aW9uTWV0aG9kKToKKyAgICAgICAgUmV0dXJuIFBy b3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lVW5rbm93biBmb3IgdW5rbm93biBzY2hl bWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9BdXRoZW50aWNhdGlvbk1hYy5t bToKKyAgICAgICAgKFdlYkNvcmU6Om1hYyk6IFN1cHBvcnQgTlRMTSBvbiBzeXN0ZW1zIG9sZGVy IHRoYW4gMTAuNi4gV2UgYWN0dWFsbHkgZ2V0IHRoaXMgc3RyaW5nIGZyb20KKyAgICAgICAgTlNV UkxDb25uZWN0aW9uLCBldmVuIHRob3VnaCB0aGVyZSB3YXMgbm8gcHVibGljIGNvbnN0YW50Lgor ICAgICAgICAoV2ViQ29yZTo6Y29yZSk6IFJldHVybiBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNh dGlvblNjaGVtZVVua25vd24gZm9yIHVua25vd24gc2NoZW1lLgorCiAyMDEwLTA0LTA3ICBLaW51 a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBK aWFuIExpLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Qcm90ZWN0aW9uU3BhY2Uu aAkocmV2aXNpb24gNTcxNTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlv blNwYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYgKzQ3LDcgQEAgZW51bSBQcm90ZWN0aW9u U3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZQogICBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlv blNjaGVtZUhUTUxGb3JtID0gNCwKICAgUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hl bWVOVExNID0gNSwKICAgUHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVOZWdvdGlh dGUgPSA2LAorICBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZVVua25vd24gPSAx MDAsCiB9OwogCiBjbGFzcyBQcm90ZWN0aW9uU3BhY2UgewpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2NmL0F1dGhlbnRpY2F0aW9uQ0YuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jZi9BdXRoZW50aWNhdGlvbkNGLmNwcAkocmV2aXNpb24gNTcxNTMp CisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQXV0aGVudGljYXRpb25DRi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTI1Myw2ICsyNTMsNyBAQCBQcm90ZWN0aW9uU3BhY2UgY29yZShDRlVS TFByb3RlY3Rpb25TcGFjCiAgICAgICAgIHNjaGVtZSA9IFByb3RlY3Rpb25TcGFjZUF1dGhlbnRp Y2F0aW9uU2NoZW1lTmVnb3RpYXRlOwogICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgorICAg ICAgICBzY2hlbWUgPSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZVVua25vd247 CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KICAgICAgICAgCkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvU29ja2V0U3RyZWFtSGFuZGxlQ0ZOZXQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9Tb2NrZXRTdHJlYW1IYW5k bGVDRk5ldC5jcHAJKHJldmlzaW9uIDU3MTUzKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1NvY2tldFN0cmVhbUhhbmRsZUNGTmV0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc3LDcg KzM3Nyw3IEBAIHN0YXRpYyBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGUKICAgICAg ICAgcmV0dXJuIFByb3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lTmVnb3RpYXRlOwog I2VuZGlmCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIFByb3RlY3Rpb25T cGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lRGVmYXVsdDsKKyAgICByZXR1cm4gUHJvdGVjdGlvblNw YWNlQXV0aGVudGljYXRpb25TY2hlbWVVbmtub3duOwogfQogCiB2b2lkIFNvY2tldFN0cmVhbUhh bmRsZTo6YWRkQ09OTkVDVENyZWRlbnRpYWxzKENGSFRUUE1lc3NhZ2VSZWYgcHJveHlSZXNwb25z ZSkKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQXV0aGVudGljYXRpb25NYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9BdXRoZW50aWNh dGlvbk1hYy5tbQkocmV2aXNpb24gNTcxNTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv bWFjL0F1dGhlbnRpY2F0aW9uTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC04Miw2ICs4MiwxMiBA QCAtICh2b2lkKWNhbmNlbEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOihOCiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAorI2lmIGRlZmluZWQoQlVJTERJTkdfT05fVElHRVIpIHx8IGRlZmluZWQoQlVJ TERJTkdfT05fTEVPUEFSRCkKKy8vIFRoZXJlIGlzIG5vIGNvbnRzbnQgaW4gaGVhZGVycywgYnV0 IE5UTE0gaXMgc3VwcG9ydGVkLgorTlNTdHJpbmcgKiBjb25zdCBOU1VSTEF1dGhlbnRpY2F0aW9u TWV0aG9kTlRMTSA9IEAiTlNVUkxBdXRoZW50aWNhdGlvbk1ldGhvZE5UTE0iOworI2VuZGlmCisK KwogQXV0aGVudGljYXRpb25DaGFsbGVuZ2U6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0 IFByb3RlY3Rpb25TcGFjZSYgcHJvdGVjdGlvblNwYWNlLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IENyZWRlbnRpYWwmIHByb3Bvc2VkQ3Jl ZGVudGlhbCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBwcmV2aW91c0ZhaWx1cmVDb3VudCwKQEAgLTE4OCwxMSArMTk0LDkgQEAgTlNV UkxQcm90ZWN0aW9uU3BhY2UgKm1hYyhjb25zdCBQcm90ZWN0aQogICAgICAgICBjYXNlIFByb3Rl Y3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lSFRNTEZvcm06CiAgICAgICAgICAgICBtZXRo b2QgPSBOU1VSTEF1dGhlbnRpY2F0aW9uTWV0aG9kSFRNTEZvcm07CiAgICAgICAgICAgICBicmVh azsKLSNpZiAhZGVmaW5lZChCVUlMRElOR19PTl9USUdFUikgJiYgIWRlZmluZWQoQlVJTERJTkdf T05fTEVPUEFSRCkKICAgICAgICAgY2FzZSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNj aGVtZU5UTE06CiAgICAgICAgICAgICBtZXRob2QgPSBOU1VSTEF1dGhlbnRpY2F0aW9uTWV0aG9k TlRMTTsKICAgICAgICAgICAgIGJyZWFrOwotI2VuZGlmCiAgICAgICAgIGRlZmF1bHQ6CiAgICAg ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9CkBAIC0yODksMTIgKzI5MywxMiBA QCBQcm90ZWN0aW9uU3BhY2UgY29yZShOU1VSTFByb3RlY3Rpb25TcGFjCiAgICAgICAgIHNjaGVt ZSA9IFByb3RlY3Rpb25TcGFjZUF1dGhlbnRpY2F0aW9uU2NoZW1lSFRUUERpZ2VzdDsKICAgICBl bHNlIGlmIChbbWV0aG9kIGlzRXF1YWxUb1N0cmluZzpOU1VSTEF1dGhlbnRpY2F0aW9uTWV0aG9k SFRNTEZvcm1dKQogICAgICAgICBzY2hlbWUgPSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlv blNjaGVtZUhUTUxGb3JtOwotI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKSAmJiAhZGVm aW5lZChCVUlMRElOR19PTl9MRU9QQVJEKQogICAgIGVsc2UgaWYgKFttZXRob2QgaXNFcXVhbFRv U3RyaW5nOk5TVVJMQXV0aGVudGljYXRpb25NZXRob2ROVExNXSkKICAgICAgICAgc2NoZW1lID0g UHJvdGVjdGlvblNwYWNlQXV0aGVudGljYXRpb25TY2hlbWVOVExNOwotI2VuZGlmCi0gICAgZWxz ZQorICAgIGVsc2UgeworICAgICAgICBzY2hlbWUgPSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNh dGlvblNjaGVtZVVua25vd247CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIH0K ICAgICAgICAgCiAgICAgcmV0dXJuIFByb3RlY3Rpb25TcGFjZShbbWFjU3BhY2UgaG9zdF0sIFtt YWNTcGFjZSBwb3J0XSwgc2VydmVyVHlwZSwgW21hY1NwYWNlIHJlYWxtXSwgc2NoZW1lKTsKIAo=