37226 2010-04-07 11:57:14 -0700 [Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp 2010-04-08 03:40:23 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 35784 0 jarkko.j.sakkinen webkit-unassigned commit-queue hausmann oldest_to_newest 209763 0 jarkko.j.sakkinen 2010-04-07 11:57:14 -0700 Remove ugly hack from GraphicsContext3D::shadeSource implementation that appends #version to shaderSource. This is all wrong and mistake by me when I first did it and it breaks lot of WebGL pages. Making sure that shader source meets WebGL specification must be handled in platform independent WebGL code. 209784 1 52771 jarkko.j.sakkinen 2010-04-07 12:45:09 -0700 Created attachment 52771 Removes appending of precision and version from shaderSource 210097 2 52771 commit-queue 2010-04-08 02:23:07 -0700 Comment on attachment 52771 Removes appending of precision and version from shaderSource Clearing flags on attachment: 52771 Committed r57267: <http://trac.webkit.org/changeset/57267> 210098 3 commit-queue 2010-04-08 02:23:11 -0700 All reviewed patches have been landed. Closing bug. 210112 4 hausmann 2010-04-08 03:40:15 -0700 Revision r57267 cherry-picked into qtwebkit-2.0 with commit 26ec2a2b5376ffc5810a52d5476d51ca9b860a36 52771 2010-04-07 12:45:09 -0700 2010-04-08 02:23:07 -0700 Removes appending of precision and version from shaderSource shadersource.diff text/plain 1957 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTYxMmMxYi4uN2Y0MzZmMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0wNyAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLnNha2tpbmVuQHRpZXRvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAgW1F0XSBSZW1vdmUgc2hhZGVyU291cmNlIG1hbmlw dWxhdGlvbiBmcm9tIEdyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisgICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcyMjYKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6OnNoYWRlclNvdXJjZSk6CisKIDIwMTAtMDQtMDcgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3ND b250ZXh0M0RRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29u dGV4dDNEUXQuY3BwCmluZGV4IGQ4ZGE0N2MuLmNhYTgwNWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApAQCAtMTAzMCwy NyArMTAzMCwxNSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpzY2lzc29yKGxvbmcgeCwgbG9u ZyB5LCB1bnNpZ25lZCBsb25nIHdpZHRoLCB1bnNpZ25lZCBsbwogICAgIGdsU2Npc3Nvcih4LCB5 LCB3aWR0aCwgaGVpZ2h0KTsKIH0KIAotdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6c2hhZGVyU291 cmNlKFdlYkdMU2hhZGVyKiBzaGFkZXIsIGNvbnN0IFN0cmluZyYgc3RyaW5nKQordm9pZCBHcmFw aGljc0NvbnRleHQzRDo6c2hhZGVyU291cmNlKFdlYkdMU2hhZGVyKiBzaGFkZXIsIGNvbnN0IFN0 cmluZyYgc291cmNlKQogewogICAgIEFTU0VSVChzaGFkZXIpOwogICAgIAogICAgIG1faW50ZXJu YWwtPm1fZ2xXaWRnZXQtPm1ha2VDdXJyZW50KCk7CiAKLSAgICAvLyBGb3JjZSB0aGUgdXNlIG9m IEdMU0wgMS4wOgotICAgIC8vIGh0dHBzOi8vY3ZzLmtocm9ub3Mub3JnL3N2bi9yZXBvcy9yZWdp c3RyeS90cnVuay9wdWJsaWMvd2ViZ2wvZG9jL3NwZWMvV2ViR0wtc3BlYy5odG1sIzQuNAotICAg IC8vIEZJWE1FOiBMaW5lcyBiZWdpbm5pbmcgd2l0aCAiI3ZlcnNpb24iIHNob3VsZCBiZSBzdHJp cHBlZCBvdXQuCi0KLSAgICBTdHJpbmcgcHJlcGFyZWQ7Ci0gICAKLSAgICBwcmVwYXJlZC5hcHBl bmQoIiN2ZXJzaW9uIDEwMFxuIik7Ci0jaWYgZGVmaW5lZChRVF9PUEVOR0xfRVNfMikKLSAgICBw cmVwYXJlZC5hcHBlbmQoInByZWNpc2lvbiBtZWRpdW1wIGZsb2F0O1xuIik7Ci0jZW5kaWYKLSAg ICBwcmVwYXJlZC5hcHBlbmQoc3RyaW5nKTsKLQotICAgIENTdHJpbmcgcHJlcGFyZWRDUyA9IHBy ZXBhcmVkLnV0ZjgoKTsKLSAgICBjb25zdCBjaGFyKiBkYXRhID0gcHJlcGFyZWRDUy5kYXRhKCk7 Ci0gICAgaW50IGxlbmd0aCA9IHByZXBhcmVkLmxlbmd0aCgpOworICAgIENTdHJpbmcgc291cmNl Q1MgPSBzb3VyY2UudXRmOCgpOworICAgIGNvbnN0IGNoYXIqIGRhdGEgPSBzb3VyY2VDUy5kYXRh KCk7CisgICAgaW50IGxlbmd0aCA9IHNvdXJjZS5sZW5ndGgoKTsKICAgICBtX2ludGVybmFsLT5z aGFkZXJTb3VyY2UoKEdMdWludCkgc2hhZGVyLT5vYmplY3QoKSwgLyogY291bnQgKi8gMSwgJmRh dGEsICZsZW5ndGgpOwogfQogCg==