37220 2010-04-07 11:05:17 -0700 Adding static method zero() to classes IntPoint and FloatPoint. 2010-04-07 14:53:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 luiz webkit-unassigned commit-queue darin oldest_to_newest 209737 0 luiz 2010-04-07 11:05:17 -0700 Adding static method zeroPoint to class IntPoint. 209741 1 52757 luiz 2010-04-07 11:09:57 -0700 Created attachment 52757 Patch 209783 2 52757 darin 2010-04-07 12:41:48 -0700 Comment on attachment 52757 Patch If it's a class member, then it's IntPoint::zeroPoint(), which is worse than IntPoint(). I think we either need it to be: inline IntPoint zeroIntPoint() { return IntPoint(); } Or: static IntPoint zero() { return IntPoint(); } So we don't repeat the word point twice. I also think we should do this for FloatPoint too. 209790 3 darin 2010-04-07 12:54:46 -0700 (In reply to comment #2) > inline IntPoint zeroIntPoint() { return IntPoint(); } Outside the class, so it would be "zeroIntPoint()" at the call site. > static IntPoint zero() { return IntPoint(); } Inside the class, so it would be "IntPoint::zero()" at the call site. 209799 4 52776 luiz 2010-04-07 13:17:37 -0700 Created attachment 52776 Patch 209825 5 52776 darin 2010-04-07 14:10:01 -0700 Comment on attachment 52776 Patch Thanks for implementing my suggestion. I think using this at various call sites instead of IntPoint() or IntPoint(0, 0) will make things a little more readable. 209858 6 52776 commit-queue 2010-04-07 14:53:34 -0700 Comment on attachment 52776 Patch Clearing flags on attachment: 52776 Committed r57236: <http://trac.webkit.org/changeset/57236> 209859 7 commit-queue 2010-04-07 14:53:41 -0700 All reviewed patches have been landed. Closing bug. 52757 2010-04-07 11:09:57 -0700 2010-04-07 13:17:28 -0700 Patch bug-37220-20100407150954.patch text/plain 1148 luiz ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzJlOTIxMy4uNDkxNGE4MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0wNyAgTHVpeiBBZ29zdGlu aSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgc3RhdGljIG1ldGhvZCB6ZXJvUG9pbnQg dG8gY2xhc3MgSW50UG9pbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNzIyMAorCisgICAgICAgIEFkZGluZyBzdGF0aWMgbWV0aG9kIHplcm9Qb2lu dCB0byBjbGFzcyBJbnRQb2ludCBhcyBzdWdnZXN0ZWQgYnkgRGFyaW4gQWRsZXIgaW4gY29tbWVu dCA0MyBvZiBidWcgMzcxNjQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2lu dC5oOgorICAgICAgICAoV2ViQ29yZTo6SW50UG9pbnQ6Onplcm9Qb2ludCk6CisKIDIwMTAtMDQt MDcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9J bnRQb2ludC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCmluZGV4IDZk NWQ0MGIuLjQ5N2FjNGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50 UG9pbnQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmgKQEAgLTgx LDYgKzgxLDggQEAgcHVibGljOgogICAgIEludFBvaW50KGludCB4LCBpbnQgeSkgOiBtX3goeCks IG1feSh5KSB7IH0KICAgICBleHBsaWNpdCBJbnRQb2ludChjb25zdCBJbnRTaXplJiBzaXplKSA6 IG1feChzaXplLndpZHRoKCkpLCBtX3koc2l6ZS5oZWlnaHQoKSkgeyB9CiAKKyAgICBzdGF0aWMg SW50UG9pbnQgemVyb1BvaW50KCkgeyByZXR1cm4gSW50UG9pbnQoMCwgMCk7IH0KKwogICAgIGlu dCB4KCkgY29uc3QgeyByZXR1cm4gbV94OyB9CiAgICAgaW50IHkoKSBjb25zdCB7IHJldHVybiBt X3k7IH0KIAo= 52776 2010-04-07 13:17:37 -0700 2010-04-07 14:53:34 -0700 Patch bug-37220-20100407171734.patch text/plain 1929 luiz ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzJlOTIxMy4uMTY4OGM0ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0wNyAgTHVpeiBBZ29zdGlu aSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgc3RhdGljIG1ldGhvZCB6ZXJvKCkgdG8g Y2xhc3NlcyBJbnRQb2ludCBhbmQgRmxvYXRQb2ludC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MjIwCisKKyAgICAgICAgQWRkaW5nIHN0YXRpYyBt ZXRob2QgemVybygpIHRvIGNsYXNzZXMgSW50UG9pbnQgYW5kIEZsb2F0UG9pbnQgYXMgc3VnZ2Vz dGVkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQ b2ludC5oOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDo6emVybyk6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkludFBvaW50 Ojp6ZXJvKToKKyAgICAgICAgKFdlYkNvcmU6OkludFBvaW50OjpjbGFtcE5lZ2F0aXZlVG9aZXJv KToKKwogMjAxMC0wNC0wNyAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0Zsb2F0UG9pbnQuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxv YXRQb2ludC5oCmluZGV4IDI0ZTBmY2YuLjc0NDNlOTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludC5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRmxvYXRQb2ludC5oCkBAIC03MCw2ICs3MCw5IEBAIHB1YmxpYzoKICAgICBGbG9hdFBvaW50 KGZsb2F0IHgsIGZsb2F0IHkpIDogbV94KHgpLCBtX3koeSkgeyB9CiAgICAgRmxvYXRQb2ludChj b25zdCBJbnRQb2ludCYpOwogCisKKyAgICBzdGF0aWMgRmxvYXRQb2ludCB6ZXJvKCkgeyByZXR1 cm4gRmxvYXRQb2ludCgpOyB9CisKICAgICBzdGF0aWMgRmxvYXRQb2ludCBuYXJyb3dQcmVjaXNp b24oZG91YmxlIHgsIGRvdWJsZSB5KTsKIAogICAgIGZsb2F0IHgoKSBjb25zdCB7IHJldHVybiBt X3g7IH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaCBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW50UG9pbnQuaAppbmRleCA2ZDVkNDBiLi5kNGVh MmYyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ludFBvaW50LmgKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbnRQb2ludC5oCkBAIC04MSw2ICs4MSw4IEBA IHB1YmxpYzoKICAgICBJbnRQb2ludChpbnQgeCwgaW50IHkpIDogbV94KHgpLCBtX3koeSkgeyB9 CiAgICAgZXhwbGljaXQgSW50UG9pbnQoY29uc3QgSW50U2l6ZSYgc2l6ZSkgOiBtX3goc2l6ZS53 aWR0aCgpKSwgbV95KHNpemUuaGVpZ2h0KCkpIHsgfQogCisgICAgc3RhdGljIEludFBvaW50IHpl cm8oKSB7IHJldHVybiBJbnRQb2ludCgpOyB9CisKICAgICBpbnQgeCgpIGNvbnN0IHsgcmV0dXJu IG1feDsgfQogICAgIGludCB5KCkgY29uc3QgeyByZXR1cm4gbV95OyB9CiAKQEAgLTEwNCw3ICsx MDYsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGNsYW1wTmVnYXRpdmVUb1plcm8oKQogICAgIHsK LSAgICAgICAgKnRoaXMgPSBleHBhbmRlZFRvKEludFBvaW50KCkpOworICAgICAgICAqdGhpcyA9 IGV4cGFuZGVkVG8oemVybygpKTsKICAgICB9CiAKICNpZiBQTEFURk9STShDRykK