37195 2010-04-07 01:53:07 -0700 JSC's currentThreadStackBase is not reentrant on some platforms 2010-04-29 00:15:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All CLOSED FIXED Qt P2 Major --- 35784 1 hausmann hausmann abarth ap eric kent.hansen koshuin laszlo.gombos norbert.leser ogoffart s.mathur webkit.review.bot oldest_to_newest 209536 0 hausmann 2010-04-07 01:53:07 -0700 On some platforms the implementation of currentThreadStackBase() in runtime/Collector.cpp uses global variables, either to store the stack base itself and/or the last thread handle. The latter case is used as an optimization to avoid expensive operating system calls to determine the stack base. However if the function is called simultaenously from multiple threads, access to the global variables needs to be protected. There are two consequences of the current code: 1) Either it crashes because of concurrent access to the global variables, causing memory corruption. 2) Or the thread stack base of a thread different than the current thread is returned, causing the garbage collector to miss out objects to free. 209537 1 52715 hausmann 2010-04-07 01:55:14 -0700 Created attachment 52715 Patch 209541 2 kent.hansen 2010-04-07 02:12:32 -0700 (In reply to comment #1) > Created an attachment (id=52715) [details] > Patch Yep, this fixes the crash on Linux. 209549 3 eric 2010-04-07 03:02:41 -0700 Attachment 52715 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1552337 209588 4 kent.hansen 2010-04-07 05:44:09 -0700 (In reply to comment #3) > Attachment 52715 [details] did not build on mac: > Build output: http://webkit-commit-queue.appspot.com/results/1552337 Patch needs a guard for the currentThreadStackBaseMutex() definition, so it's not defined on platforms that don't use it (the Mac buildbot treats warnings as errors, and really, we don't want this warning). As we discussed already, we just need to be careful with the #if OS(UNIX) part... :) Something like #if (OS(UNIX) && !(OS(DARWIN) || OS(QNX) || OS(SOLARIS) || OS(OPENBSD) || OS(HAIKU) || OS(SYMBIAN)) For QNX, I'd also consider moving the MutexLocker into currentThreadStackBaseQNX() (even though the function is not called from anywhere else currently). 209591 5 ogoffart 2010-04-07 05:55:10 -0700 The patch is not correct on symbian. As the stackBase will be assigned the value of the first thread, and will not be changed again if this function is called from a different thread. (I am wondering if it is worth to cache those value at all. And if it is, maybe a thread local storage would work better?) 209599 6 kent.hansen 2010-04-07 06:10:40 -0700 (In reply to comment #4) > #if (OS(UNIX) && !(OS(DARWIN) || OS(QNX) || OS(SOLARIS) || OS(OPENBSD) || > OS(HAIKU) || OS(SYMBIAN)) Hehe, we don't want the OS(QNX) and OS(SYMBIAN) above of course... This builds on Mac: #if (OS(UNIX) && !(OS(DARWIN) || OS(HAIKU) || OS(OPENBSD) || OS(SOLARIS))) || OS(WINCE) static Mutex& currentThreadStackBaseMutex() { AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex); return mutex; } #endif 209600 7 hausmann 2010-04-07 06:11:34 -0700 (In reply to comment #5) > The patch is not correct on symbian. As the stackBase will be assigned the > value of the first thread, and will not be changed again if this function is > called from a different thread. > > (I am wondering if it is worth to cache those value at all. And if it is, > maybe a thread local storage would work better?) Right, the patch only addresses the concurrency issue 1). With that patch there's a chance of getting less crashes, but we'll continue to collect less objects than we could. 209602 8 kent.hansen 2010-04-07 06:16:49 -0700 (In reply to comment #5) > The patch is not correct on symbian. As the stackBase will be assigned the > value of the first thread, and will not be changed again if this function is > called from a different thread. That's a problem with the original patch for Symbian, not this patch. > (I am wondering if it is worth to cache those value at all. And if it is, > maybe a thread local storage would work better?) Yeah, Simon and I were also wondering whether the caching is needed on Symbian. Is it just a case of the Symbian implementation following the pattern of the Unix one (caching the value), or is the system call really that slow on Symbian too? If it is slow, then at least there needs to be a check to see if the thread handle is the same to validate the cached value, like in the Unix branch. Janne, do you have any insights? 209608 9 52733 hausmann 2010-04-07 06:29:03 -0700 Created attachment 52733 Patch 209609 10 webkit.review.bot 2010-04-07 06:30:05 -0700 Attachment 52733 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/runtime/Collector.cpp:535: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 209669 11 ogoffart 2010-04-07 09:19:45 -0700 (In reply to comment #7) > Right, the patch only addresses the concurrency issue 1). With that patch > there's a chance of getting less crashes, but we'll continue to collect less > objects than we could. We would still crash in case 2). Since we will look the memory between the base of the stack of one thread, and the top of the stack of the current thread. That cannot work. 215299 12 kent.hansen 2010-04-21 07:18:33 -0700 (In reply to comment #9) > Created an attachment (id=52733) [details] > Patch Builds on Mac now, at least. 215316 13 kent.hansen 2010-04-21 07:46:28 -0700 (In reply to comment #11) > (In reply to comment #7) > > Right, the patch only addresses the concurrency issue 1). With that patch > > there's a chance of getting less crashes, but we'll continue to collect less > > objects than we could. > > We would still crash in case 2). Since we will look the memory between the base > of the stack of one thread, and the top of the stack of the current thread. > That cannot work. Nobody from S60 have responded (Norbert, are you there? :) ), and I can't even find an API reference for RThread and friends, so I don't know what the appropriate fix is. 215340 14 kent.hansen 2010-04-21 08:44:27 -0700 Alright, I got some great information from two Symbian guys on IRC. They believed that the construction of RThread + calling stackInfo() every time is not that expensive. To make the current implementation reentrant, we would have to mutex-lock _and_ call RThread::Id(); whereas not locking and calling stackInfo() would solve the stale cache + reentrancy issue, simplifies the code, and might actually be faster. 215342 15 53961 kent.hansen 2010-04-21 08:49:21 -0700 Created attachment 53961 Patch for Symbian (untested) Does anyone on Symbian have a chance to test it? If it works, I'll add the ChangeLog so we can get this committed, then Simon can rebase his patch. 217601 16 54401 hausmann 2010-04-27 02:07:39 -0700 Created attachment 54401 Patch 217602 17 hausmann 2010-04-27 02:09:13 -0700 (In reply to comment #16) > Created an attachment (id=54401) [details] > Patch Combined Kent and my patch, so that the return value on Symbian is always thread specific and reentrant. 217604 18 webkit.review.bot 2010-04-27 02:11:02 -0700 Attachment 54401 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/runtime/Collector.cpp:535: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 217689 19 s.mathur 2010-04-27 07:26:19 -0700 (In reply to comment #14) > Alright, I got some great information from two Symbian guys on IRC. > They believed that the construction of RThread + calling stackInfo() every time > is not that expensive. To make the current implementation reentrant, we would > have to mutex-lock _and_ call RThread::Id(); whereas not locking and calling > stackInfo() would solve the stale cache + reentrancy issue, simplifies the > code, and might actually be faster. While the proposed patch is OK for Symbian (simple is good), we should at least add a comment there saying that RThread::StackInfo() involves a call to kernel mode code: http://developer.symbian.org/xref/oss/xref/MCL/sf/os/kernelhwsrv/kernel/eka/euser/us_exec.cpp So, there is a possibility of slowdown because currentThreadStackBase() is called frequently, IIRC. 217838 20 54401 darin 2010-04-27 12:16:33 -0700 Comment on attachment 54401 Patch Looks OK. Seems to me it would be fine to repeat the single line three times: AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex); Rather than having a function for it, though. 217908 21 hausmann 2010-04-27 13:50:34 -0700 (In reply to comment #20) > (From update of attachment 54401 [details]) > Looks OK. Seems to me it would be fine to repeat the single line three times: > > AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex); > > Rather than having a function for it, though. Good idea! I'll change that before landing. Thanks for the review. 218300 22 hausmann 2010-04-28 03:05:57 -0700 Committed r58393: <http://trac.webkit.org/changeset/58393> 218307 23 webkit.review.bot 2010-04-28 03:42:46 -0700 http://trac.webkit.org/changeset/58393 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/58393 http://trac.webkit.org/changeset/58394 http://trac.webkit.org/changeset/58395 218868 24 hausmann 2010-04-29 00:15:33 -0700 Revision r58393 cherry-picked into qtwebkit-2.0 with commit 76fc13db1b9a2116d6bee35c0e2c8fbfd940cd34 52715 2010-04-07 01:55:14 -0700 2010-04-07 06:28:55 -0700 Patch bug-37195-20100407105512.patch text/plain 2540 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1ZjU2NDdlLi5hMTYxOGU2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDQtMDcgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTQydz IGN1cnJlbnRUaHJlYWRTdGFja0Jhc2UgaXMgbm90IHJlZW50cmFudCBvbiBzb21lIHBsYXRmb3Jt cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxOTUK KworICAgICAgICBUaGlzIGZ1bmN0aW9uIG5lZWRzIHRvIGJlIHJlZW50cmFudCB0byBhdm9pZCBt ZW1vcnkgY29ycnVwdGlvbiBvbiBwbGF0Zm9ybXMgd2hlcmUKKyAgICAgICAgdGhlIGltcGxlbWVu dGF0aW9uIHVzZXMgZ2xvYmFsIHZhcmlhYmxlcy4KKworICAgICAgICAqIHJ1bnRpbWUvQ29sbGVj dG9yLmNwcDogTWFrZSB0aGUgZnVuY3Rpb24gcmVlbnRyYW50IG9uIHRoZSBwbGF0Zm9ybXMgd2hl cmUgbmVjZXNzYXJ5IGJ5IGFkZGluZyBhIG11dGV4IGxvY2suCisgICAgICAgIChKU0M6OmN1cnJl bnRUaHJlYWRTdGFja0Jhc2VNdXRleCk6CisgICAgICAgIChKU0M6OmN1cnJlbnRUaHJlYWRTdGFj a0Jhc2UpOgorCiAyMDEwLTA0LTA2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxl Y3Rvci5jcHAKaW5kZXggMWIzYTBkYi4uOTJkMjYyZiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Db2xsZWN0b3IuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29s bGVjdG9yLmNwcApAQCAtNTMyLDYgKzUzMiwxMiBAQCBzdGF0aWMgaW5saW5lIHZvaWQgKmN1cnJl bnRUaHJlYWRTdGFja0Jhc2VRTlgoKQogfQogI2VuZGlmCiAKK3N0YXRpYyBNdXRleCYgY3VycmVu dFRocmVhZFN0YWNrQmFzZU11dGV4KCkKK3sKKyAgICBBdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0 aWMoTXV0ZXgmLCBtdXRleCA9ICpuZXcgTXV0ZXgpOworICAgIHJldHVybiBtdXRleDsKK30KKwog c3RhdGljIGlubGluZSB2b2lkKiBjdXJyZW50VGhyZWFkU3RhY2tCYXNlKCkKIHsKICNpZiBPUyhE QVJXSU4pCkBAIC01NTgsNiArNTY0LDcgQEAgc3RhdGljIGlubGluZSB2b2lkKiBjdXJyZW50VGhy ZWFkU3RhY2tCYXNlKCkKICAgICBQTlRfVElCNjQgcFRpYiA9IHJlaW50ZXJwcmV0X2Nhc3Q8UE5U X1RJQjY0PihOdEN1cnJlbnRUZWIoKSk7CiAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8dm9p ZCo+KHBUaWItPlN0YWNrQmFzZSk7CiAjZWxpZiBPUyhRTlgpCisgICAgTXV0ZXhMb2NrZXIgbG9j a2VyKGN1cnJlbnRUaHJlYWRTdGFja0Jhc2VNdXRleCgpKTsKICAgICByZXR1cm4gY3VycmVudFRo cmVhZFN0YWNrQmFzZVFOWCgpOwogI2VsaWYgT1MoU09MQVJJUykKICAgICBzdGFja190IHM7CkBA IC01NjksNiArNTc2LDcgQEAgc3RhdGljIGlubGluZSB2b2lkKiBjdXJyZW50VGhyZWFkU3RhY2tC YXNlKCkKICAgICBwdGhyZWFkX3N0YWNrc2VnX25wKHRocmVhZCwgJnN0YWNrKTsKICAgICByZXR1 cm4gc3RhY2suc3Nfc3A7CiAjZWxpZiBPUyhTWU1CSUFOKQorICAgIE11dGV4TG9ja2VyIGxvY2tl cihjdXJyZW50VGhyZWFkU3RhY2tCYXNlTXV0ZXgoKSk7CiAgICAgc3RhdGljIHZvaWQqIHN0YWNr QmFzZSA9IDA7CiAgICAgaWYgKHN0YWNrQmFzZSA9PSAwKSB7CiAgICAgICAgIFRUaHJlYWRTdGFj a0luZm8gaW5mbzsKQEAgLTU4Miw2ICs1OTAsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGN1cnJl bnRUaHJlYWRTdGFja0Jhc2UoKQogICAgIGdldF90aHJlYWRfaW5mbyhmaW5kX3RocmVhZChOVUxM KSwgJnRocmVhZEluZm8pOwogICAgIHJldHVybiB0aHJlYWRJbmZvLnN0YWNrX2VuZDsKICNlbGlm IE9TKFVOSVgpCisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKGN1cnJlbnRUaHJlYWRTdGFja0Jhc2VN dXRleCgpKTsKICAgICBzdGF0aWMgdm9pZCogc3RhY2tCYXNlID0gMDsKICAgICBzdGF0aWMgc2l6 ZV90IHN0YWNrU2l6ZSA9IDA7CiAgICAgc3RhdGljIHB0aHJlYWRfdCBzdGFja1RocmVhZDsKQEAg LTYwNCw2ICs2MTMsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJlYWRTdGFja0Jh c2UoKQogICAgIH0KICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Y2hhcio+KHN0YWNrQmFzZSkgKyBz dGFja1NpemU7CiAjZWxpZiBPUyhXSU5DRSkKKyAgICBNdXRleExvY2tlciBsb2NrZXIoY3VycmVu dFRocmVhZFN0YWNrQmFzZU11dGV4KCkpOwogICAgIGlmIChnX3N0YWNrQmFzZSkKICAgICAgICAg cmV0dXJuIGdfc3RhY2tCYXNlOwogICAgIGVsc2Ugewo= 52733 2010-04-07 06:29:03 -0700 2010-04-27 02:08:19 -0700 Patch bug-37195-20100407152901.patch text/plain 2637 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1ZjU2NDdlLi5hMTYxOGU2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDQtMDcgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTQydz IGN1cnJlbnRUaHJlYWRTdGFja0Jhc2UgaXMgbm90IHJlZW50cmFudCBvbiBzb21lIHBsYXRmb3Jt cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxOTUK KworICAgICAgICBUaGlzIGZ1bmN0aW9uIG5lZWRzIHRvIGJlIHJlZW50cmFudCB0byBhdm9pZCBt ZW1vcnkgY29ycnVwdGlvbiBvbiBwbGF0Zm9ybXMgd2hlcmUKKyAgICAgICAgdGhlIGltcGxlbWVu dGF0aW9uIHVzZXMgZ2xvYmFsIHZhcmlhYmxlcy4KKworICAgICAgICAqIHJ1bnRpbWUvQ29sbGVj dG9yLmNwcDogTWFrZSB0aGUgZnVuY3Rpb24gcmVlbnRyYW50IG9uIHRoZSBwbGF0Zm9ybXMgd2hl cmUgbmVjZXNzYXJ5IGJ5IGFkZGluZyBhIG11dGV4IGxvY2suCisgICAgICAgIChKU0M6OmN1cnJl bnRUaHJlYWRTdGFja0Jhc2VNdXRleCk6CisgICAgICAgIChKU0M6OmN1cnJlbnRUaHJlYWRTdGFj a0Jhc2UpOgorCiAyMDEwLTA0LTA2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxl Y3Rvci5jcHAKaW5kZXggMWIzYTBkYi4uOWYzMTE2MCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Db2xsZWN0b3IuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29s bGVjdG9yLmNwcApAQCAtNTMyLDYgKzUzMiwxNCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgKmN1cnJl bnRUaHJlYWRTdGFja0Jhc2VRTlgoKQogfQogI2VuZGlmCiAKKyNpZiAoT1MoVU5JWCkgJiYgIShP UyhEQVJXSU4pIHx8IE9TKEhBSUtVKSB8fCBPUyhPUEVOQlNEKSB8fCBPUyhTT0xBUklTKSkpIHx8 IE9TKFdJTkNFKQorc3RhdGljIE11dGV4JiBjdXJyZW50VGhyZWFkU3RhY2tCYXNlTXV0ZXgoKQor eworICAgIEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYyhNdXRleCYsIG11dGV4ID0gKm5ldyBN dXRleCk7CisgICAgcmV0dXJuIG11dGV4OworfQorI2VuZGlmCisKIHN0YXRpYyBpbmxpbmUgdm9p ZCogY3VycmVudFRocmVhZFN0YWNrQmFzZSgpCiB7CiAjaWYgT1MoREFSV0lOKQpAQCAtNTU4LDYg KzU2Niw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0YWNrQmFzZSgpCiAg ICAgUE5UX1RJQjY0IHBUaWIgPSByZWludGVycHJldF9jYXN0PFBOVF9USUI2ND4oTnRDdXJyZW50 VGViKCkpOwogICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHZvaWQqPihwVGliLT5TdGFja0Jh c2UpOwogI2VsaWYgT1MoUU5YKQorICAgIE11dGV4TG9ja2VyIGxvY2tlcihjdXJyZW50VGhyZWFk U3RhY2tCYXNlTXV0ZXgoKSk7CiAgICAgcmV0dXJuIGN1cnJlbnRUaHJlYWRTdGFja0Jhc2VRTlgo KTsKICNlbGlmIE9TKFNPTEFSSVMpCiAgICAgc3RhY2tfdCBzOwpAQCAtNTY5LDYgKzU3OCw3IEBA IHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0YWNrQmFzZSgpCiAgICAgcHRocmVh ZF9zdGFja3NlZ19ucCh0aHJlYWQsICZzdGFjayk7CiAgICAgcmV0dXJuIHN0YWNrLnNzX3NwOwog I2VsaWYgT1MoU1lNQklBTikKKyAgICBNdXRleExvY2tlciBsb2NrZXIoY3VycmVudFRocmVhZFN0 YWNrQmFzZU11dGV4KCkpOwogICAgIHN0YXRpYyB2b2lkKiBzdGFja0Jhc2UgPSAwOwogICAgIGlm IChzdGFja0Jhc2UgPT0gMCkgewogICAgICAgICBUVGhyZWFkU3RhY2tJbmZvIGluZm87CkBAIC01 ODIsNiArNTkyLDcgQEAgc3RhdGljIGlubGluZSB2b2lkKiBjdXJyZW50VGhyZWFkU3RhY2tCYXNl KCkKICAgICBnZXRfdGhyZWFkX2luZm8oZmluZF90aHJlYWQoTlVMTCksICZ0aHJlYWRJbmZvKTsK ICAgICByZXR1cm4gdGhyZWFkSW5mby5zdGFja19lbmQ7CiAjZWxpZiBPUyhVTklYKQorICAgIE11 dGV4TG9ja2VyIGxvY2tlcihjdXJyZW50VGhyZWFkU3RhY2tCYXNlTXV0ZXgoKSk7CiAgICAgc3Rh dGljIHZvaWQqIHN0YWNrQmFzZSA9IDA7CiAgICAgc3RhdGljIHNpemVfdCBzdGFja1NpemUgPSAw OwogICAgIHN0YXRpYyBwdGhyZWFkX3Qgc3RhY2tUaHJlYWQ7CkBAIC02MDQsNiArNjE1LDcgQEAg c3RhdGljIGlubGluZSB2b2lkKiBjdXJyZW50VGhyZWFkU3RhY2tCYXNlKCkKICAgICB9CiAgICAg cmV0dXJuIHN0YXRpY19jYXN0PGNoYXIqPihzdGFja0Jhc2UpICsgc3RhY2tTaXplOwogI2VsaWYg T1MoV0lOQ0UpCisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKGN1cnJlbnRUaHJlYWRTdGFja0Jhc2VN dXRleCgpKTsKICAgICBpZiAoZ19zdGFja0Jhc2UpCiAgICAgICAgIHJldHVybiBnX3N0YWNrQmFz ZTsKICAgICBlbHNlIHsK 53961 2010-04-21 08:49:21 -0700 2010-04-27 02:08:36 -0700 Patch for Symbian (untested) SymbianCurrentThreadStackBase.diff text/plain 874 kent.hansen ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvSmF2YVNjcmlwdENvcmUvcnVudGltZS9D b2xsZWN0b3IuY3BwIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NvbGxlY3Rvci5jcHAKaW5kZXggMjg1OTI5MC4uYjM1NjNkYSAxMDA2NDQKLS0tIGEvc3JjLzNy ZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAKKysrIGIv c3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAK QEAgLTU2OSwxNCArNTY5LDEwIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0 YWNrQmFzZSgpCiAgICAgcHRocmVhZF9zdGFja3NlZ19ucCh0aHJlYWQsICZzdGFjayk7CiAgICAg cmV0dXJuIHN0YWNrLnNzX3NwOwogI2VsaWYgT1MoU1lNQklBTikKLSAgICBzdGF0aWMgdm9pZCog c3RhY2tCYXNlID0gMDsKLSAgICBpZiAoc3RhY2tCYXNlID09IDApIHsKLSAgICAgICAgVFRocmVh ZFN0YWNrSW5mbyBpbmZvOwotICAgICAgICBSVGhyZWFkIHRocmVhZDsKLSAgICAgICAgdGhyZWFk LlN0YWNrSW5mbyhpbmZvKTsKLSAgICAgICAgc3RhY2tCYXNlID0gKHZvaWQqKWluZm8uaUJhc2U7 Ci0gICAgfQotICAgIHJldHVybiAodm9pZCopc3RhY2tCYXNlOworICAgIFRUaHJlYWRTdGFja0lu Zm8gaW5mbzsKKyAgICBSVGhyZWFkIHRocmVhZDsKKyAgICB0aHJlYWQuU3RhY2tJbmZvKGluZm8p OworICAgIHJldHVybiAodm9pZCopaW5mby5pQmFzZTsKICNlbGlmIE9TKEhBSUtVKQogICAgIHRo cmVhZF9pbmZvIHRocmVhZEluZm87CiAgICAgZ2V0X3RocmVhZF9pbmZvKGZpbmRfdGhyZWFkKE5V TEwpLCAmdGhyZWFkSW5mbyk7Cg== 54401 2010-04-27 02:07:39 -0700 2010-04-27 12:16:33 -0700 Patch bug-37195-20100427110737.patch text/plain 2992 hausmann ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyYTM4OGVkOWU3YWNmZjRmZmQwOTkyZTlkNDZkMWVjZjZjNzQzZWJhLi44 ZTY3OWIwMTM0YTE4ZTI0OGU4ZjViNWE2ZWVmMmI4Zjk1MmEyNDg2IDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTAtMDQtMjcgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5A bm9raWEuY29tPiwgS2VudCBIYW5zZW4gPGtlbnQuaGFuc2VuQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0MncyBjdXJyZW50VGhy ZWFkU3RhY2tCYXNlIGlzIG5vdCByZWVudHJhbnQgb24gc29tZSBwbGF0Zm9ybXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTk1CisKKyAgICAgICAg VGhpcyBmdW5jdGlvbiBuZWVkcyB0byBiZSByZWVudHJhbnQgdG8gYXZvaWQgbWVtb3J5IGNvcnJ1 cHRpb24gb24gcGxhdGZvcm1zIHdoZXJlCisgICAgICAgIHRoZSBpbXBsZW1lbnRhdGlvbiB1c2Vz IGdsb2JhbCB2YXJpYWJsZXMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgbXV0ZXggbG9j ayB3aGVyZSBuZWNlc3NhcnkgYW5kIG1ha2VzIHRoZSBTeW1iaWFuIGltcGxlbWVudGF0aW9uCisg ICAgICAgIHJlZW50cmFudC4KKworICAgICAgICAqIHJ1bnRpbWUvQ29sbGVjdG9yLmNwcDoKKyAg ICAgICAgKEpTQzo6Y3VycmVudFRocmVhZFN0YWNrQmFzZU11dGV4KToKKyAgICAgICAgKEpTQzo6 Y3VycmVudFRocmVhZFN0YWNrQmFzZSk6CisKIDIwMTAtMDQtMjYgIE9saXZlciBIdW50ICA8b2xp dmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggd2luZG93cwpkaWZmIC0tZ2l0IGEvSmF2YVNj cmlwdENvcmUvcnVudGltZS9Db2xsZWN0b3IuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9D b2xsZWN0b3IuY3BwCmluZGV4IDJiZDllNzcxYTc0MDIxMDUwZDhhZTUzYWE0M2IwMGIxZWQ4ZDkx OGQuLmI4YTkxZmM5YjViMGQ3ODM3Nzk3ZmFjMjIzOTJlMzhhZTc2ZDBlMDEgMTAwNjQ0Ci0tLSBh L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29sbGVjdG9yLmNwcAorKysgYi9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0NvbGxlY3Rvci5jcHAKQEAgLTUzMiw2ICs1MzIsMTQgQEAgc3RhdGljIGlubGlu ZSB2b2lkICpjdXJyZW50VGhyZWFkU3RhY2tCYXNlUU5YKCkKIH0KICNlbmRpZgogCisjaWYgKE9T KFVOSVgpICYmICEoT1MoREFSV0lOKSB8fCBPUyhIQUlLVSkgfHwgT1MoT1BFTkJTRCkgfHwgT1Mo U09MQVJJUykpKSB8fCBPUyhXSU5DRSkKK3N0YXRpYyBNdXRleCYgY3VycmVudFRocmVhZFN0YWNr QmFzZU11dGV4KCkKK3sKKyAgICBBdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0aWMoTXV0ZXgmLCBt dXRleCA9ICpuZXcgTXV0ZXgpOworICAgIHJldHVybiBtdXRleDsKK30KKyNlbmRpZgorCiBzdGF0 aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJlYWRTdGFja0Jhc2UoKQogewogI2lmIE9TKERBUldJ TikKQEAgLTU1OCw2ICs1NjYsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGN1cnJlbnRUaHJlYWRT dGFja0Jhc2UoKQogICAgIFBOVF9USUI2NCBwVGliID0gcmVpbnRlcnByZXRfY2FzdDxQTlRfVElC NjQ+KE50Q3VycmVudFRlYigpKTsKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4o cFRpYi0+U3RhY2tCYXNlKTsKICNlbGlmIE9TKFFOWCkKKyAgICBNdXRleExvY2tlciBsb2NrZXIo Y3VycmVudFRocmVhZFN0YWNrQmFzZU11dGV4KCkpOwogICAgIHJldHVybiBjdXJyZW50VGhyZWFk U3RhY2tCYXNlUU5YKCk7CiAjZWxpZiBPUyhTT0xBUklTKQogICAgIHN0YWNrX3QgczsKQEAgLTU2 OSwxOSArNTc4LDE2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0YWNrQmFz ZSgpCiAgICAgcHRocmVhZF9zdGFja3NlZ19ucCh0aHJlYWQsICZzdGFjayk7CiAgICAgcmV0dXJu IHN0YWNrLnNzX3NwOwogI2VsaWYgT1MoU1lNQklBTikKLSAgICBzdGF0aWMgdm9pZCogc3RhY2tC YXNlID0gMDsKLSAgICBpZiAoc3RhY2tCYXNlID09IDApIHsKLSAgICAgICAgVFRocmVhZFN0YWNr SW5mbyBpbmZvOwotICAgICAgICBSVGhyZWFkIHRocmVhZDsKLSAgICAgICAgdGhyZWFkLlN0YWNr SW5mbyhpbmZvKTsKLSAgICAgICAgc3RhY2tCYXNlID0gKHZvaWQqKWluZm8uaUJhc2U7Ci0gICAg fQotICAgIHJldHVybiAodm9pZCopc3RhY2tCYXNlOworICAgIFRUaHJlYWRTdGFja0luZm8gaW5m bzsKKyAgICBSVGhyZWFkIHRocmVhZDsKKyAgICB0aHJlYWQuU3RhY2tJbmZvKGluZm8pOworICAg IHJldHVybiAodm9pZCopaW5mby5pQmFzZTsKICNlbGlmIE9TKEhBSUtVKQogICAgIHRocmVhZF9p bmZvIHRocmVhZEluZm87CiAgICAgZ2V0X3RocmVhZF9pbmZvKGZpbmRfdGhyZWFkKE5VTEwpLCAm dGhyZWFkSW5mbyk7CiAgICAgcmV0dXJuIHRocmVhZEluZm8uc3RhY2tfZW5kOwogI2VsaWYgT1Mo VU5JWCkKKyAgICBNdXRleExvY2tlciBsb2NrZXIoY3VycmVudFRocmVhZFN0YWNrQmFzZU11dGV4 KCkpOwogICAgIHN0YXRpYyB2b2lkKiBzdGFja0Jhc2UgPSAwOwogICAgIHN0YXRpYyBzaXplX3Qg c3RhY2tTaXplID0gMDsKICAgICBzdGF0aWMgcHRocmVhZF90IHN0YWNrVGhyZWFkOwpAQCAtNjA0 LDYgKzYxMCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0YWNrQmFzZSgp CiAgICAgfQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxjaGFyKj4oc3RhY2tCYXNlKSArIHN0YWNr U2l6ZTsKICNlbGlmIE9TKFdJTkNFKQorICAgIE11dGV4TG9ja2VyIGxvY2tlcihjdXJyZW50VGhy ZWFkU3RhY2tCYXNlTXV0ZXgoKSk7CiAgICAgaWYgKGdfc3RhY2tCYXNlKQogICAgICAgICByZXR1 cm4gZ19zdGFja0Jhc2U7CiAgICAgZWxzZSB7Cg==