37182 2010-04-06 18:16:15 -0700 WebCore config.h hardcodes the wince OS policies. 2010-11-23 07:47:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED DUPLICATE 49887 P2 Normal --- 0 jasonr webkit-unassigned eric jasonr paroga staikos oldest_to_newest 209375 0 jasonr 2010-04-06 18:16:15 -0700 I'm looking to start submitting changes to support the Windows CE platform; I picked this as a first change so that I can see the patch review process through; hopefully without affecting anything. The following definition in config.h forces OS(WINCE) into a set of policies on building that cannot be overriden easily to be different to the windows build. #if PLATFORM(WIN) #if defined(WIN_CAIRO) #undef WTF_PLATFORM_CG #define WTF_PLATFORM_CAIRO 1 #undef WTF_USE_CFNETWORK #define WTF_USE_CURL 1 #ifndef _WINSOCKAPI_ #define _WINSOCKAPI_ // Prevent inclusion of winsock.h in windows.h #endif #else #define WTF_PLATFORM_CG 1 #undef WTF_PLATFORM_CAIRO #define WTF_USE_CFNETWORK 1 #undef WTF_USE_CURL #endif #undef WTF_USE_WININET #define WTF_PLATFORM_CF 1 #define WTF_USE_PTHREADS 0 #endif I would like to change this to #if PLATFORM(WIN) && !OS(WINCE) so that WINCE can set the policies in wtf/platform.h (or have them overriden from the default); especially items like using WININET and WTF_PLATFORM_CF which are not available on windows CE. I am using a build that is windows CE for CAIRO+WININET+PTHREADS and these hardcoded values for the policies for PLATFORM(WIN) don't allow options for the build configuration. I have a patch for this change available. 209387 1 52693 jasonr 2010-04-06 18:43:21 -0700 Created attachment 52693 Proposed patch 209400 2 52693 eric 2010-04-06 19:25:44 -0700 Comment on attachment 52693 Proposed patch r- for lack of ChangeLog, see http://webkit.org/coding/contributing.html 312838 3 paroga 2010-11-23 07:47:05 -0800 *** This bug has been marked as a duplicate of bug 49887 *** 52693 2010-04-06 18:43:21 -0700 2010-06-11 10:44:20 -0700 Proposed patch webcoreconfig.patch text/plain 501 jasonr SW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jb25maWcuaAko cmV2aXNpb24gNTMyODMpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MzgsMTAgKzEzOCwxMyBAQAogI2RlZmluZSBTS0lQX1NUQVRJQ19DT05TVFJVQ1RPUlNfT05fR0ND IDEKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oV0lOKQogI2lmIGRlZmluZWQoV0lOX0NBSVJPKQot I3VuZGVmIFdURl9QTEFURk9STV9DRwogI2RlZmluZSBXVEZfUExBVEZPUk1fQ0FJUk8gMQorI2Vu ZGlmCisKKyNpZiBQTEFURk9STShXSU4pICYmICFPUyhXSU5DRSkKKyNpZiBkZWZpbmVkKFdJTl9D QUlSTykKKyN1bmRlZiBXVEZfUExBVEZPUk1fQ0cKICN1bmRlZiBXVEZfVVNFX0NGTkVUV09SSwog I2RlZmluZSBXVEZfVVNFX0NVUkwgMQogI2lmbmRlZiBfV0lOU09DS0FQSV8K