<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37173</bug_id>
          
          <creation_ts>2010-04-06 15:39:13 -0700</creation_ts>
          <short_desc>[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)</short_desc>
          <delta_ts>2021-05-10 09:38:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35784</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Rodrigo Belem">rclbelem</reporter>
          <assigned_to name="Rodrigo Belem">rclbelem</assigned_to>
          <cc>11a_wgpj</cc>
    
    <cc>commit-queue</cc>
    
    <cc>diegohcg</cc>
    
    <cc>hausmann</cc>
    
    <cc>jturcotte</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>209291</commentid>
    <comment_count>0</comment_count>
    <who name="Rodrigo Belem">rclbelem</who>
    <bug_when>2010-04-06 15:39:13 -0700</bug_when>
    <thetext>The build system is installing everything fine apart from some headers, like QGraphicsWebView QWebDatabase, etc.

It is important to have the build system install these files because qtwebkit-2.0 now builds separately from qt.

* Building qtwebkit cmd:
WebKitTools/Scripts/build-webkit --qt

* Installing cmd:
cd WebKitBuild/Release/
make install</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209312</commentid>
    <comment_count>1</comment_count>
      <attachid>52680</attachid>
    <who name="Rodrigo Belem">rclbelem</who>
    <bug_when>2010-04-06 16:15:22 -0700</bug_when>
    <thetext>Created attachment 52680
Patch that fixes this bug.

Trivial patch that replaces the .. by the $$OUTPUT_DIR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209313</commentid>
    <comment_count>2</comment_count>
    <who name="Rodrigo Belem">rclbelem</who>
    <bug_when>2010-04-06 16:16:57 -0700</bug_when>
    <thetext>Adding Qt to the Keywords.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209590</commentid>
    <comment_count>3</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2010-04-07 05:51:53 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=52680) [details]
&gt; Patch that fixes this bug.
&gt; 
&gt; Trivial patch that replaces the .. by the $$OUTPUT_DIR.

I like the patch because it makes things clearer, however I don&apos;t understand why this fixes your issue since $$OUTPUT_DIR == ..

I probably miss something in the picture, do you have more information on why it helps?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209593</commentid>
    <comment_count>4</comment_count>
      <attachid>52680</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-07 05:57:01 -0700</bug_when>
    <thetext>Comment on attachment 52680
Patch that fixes this bug.

Looks good to me and Jocelyn (we just discussed it in the office :)

Thanks Rodrigo!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209677</commentid>
    <comment_count>5</comment_count>
      <attachid>52680</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-07 09:44:00 -0700</bug_when>
    <thetext>Comment on attachment 52680
Patch that fixes this bug.

Clearing flags on attachment: 52680

Committed r57213: &lt;http://trac.webkit.org/changeset/57213&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209678</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-07 09:44:06 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210060</commentid>
    <comment_count>7</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-08 00:53:57 -0700</bug_when>
    <thetext>Revision r57213 cherry-picked into qtwebkit-2.0 with commit 33c7a75414a4847b395f4ac78527e7d137a844f6</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52680</attachid>
            <date>2010-04-06 16:15:22 -0700</date>
            <delta_ts>2010-04-07 09:44:00 -0700</delta_ts>
            <desc>Patch that fixes this bug.</desc>
            <filename>0001-Qt-The-build-system-is-not-installing-the-generated-.patch</filename>
            <type>text/plain</type>
            <size>1851</size>
            <attacher name="Rodrigo Belem">rclbelem</attacher>
            
              <data encoding="base64">RnJvbSA4MzRiYmUwYWI1YzhkOWEzMjliNWUzYjk5MGZiZjI2MTU2ZGI1YTRjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2RyaWdvIEJlbGVtIDxyb2RyaWdvLmJlbGVtQG9wZW5ib3Nz
YS5vcmc+CkRhdGU6IFR1ZSwgNiBBcHIgMjAxMCAxOToxMTo1MCAtMDQwMApTdWJqZWN0OiBbUEFU
Q0hdIFtRdF0gVGhlIGJ1aWxkIHN5c3RlbSBpcyBub3QgaW5zdGFsbGluZyB0aGUgZ2VuZXJhdGVk
IGhlYWRlcnMgKFFHcmFwaGljc1dlYlZpZXcsIFFXZWJEYXRhYmFzZSwgZXRjKQogaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTczCgpSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KClRoaXMgcGF0Y2ggc2V0cyB0aGUgY29ycmVjdCBwYXRoIHRvIHRoZSBjbGFzc2hl
YWRlcnMucHJpIGFuZCB0aGVuCmZpeGVzIHRoZSBpbnN0YWxsYXRpb24gb2YgdGhlIGdlbmVyYXRl
ZCBoZWFkZXJzLgoKKiBXZWJDb3JlLnBybzoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgIHwgICAx
MiArKysrKysrKysrKysKIFdlYkNvcmUvV2ViQ29yZS5wcm8gfCAgICAyICstCiAyIGZpbGVzIGNo
YW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkOWYyMzY4Li4zZTFkM2Y5
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE1IEBACisyMDEwLTA0LTA2ICBSb2RyaWdvIEJlbGVtICA8cm9kcmlnby5iZWxl
bUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFtRdF0gVGhlIGJ1aWxkIHN5c3RlbSBpcyBub3QgaW5zdGFsbGluZyB0aGUgZ2Vu
ZXJhdGVkIGhlYWRlcnMgKFFHcmFwaGljc1dlYlZpZXcsIFFXZWJEYXRhYmFzZSwgZXRjKQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxNzMKKworICAg
ICAgICBUaGlzIHBhdGNoIHNldHMgdGhlIGNvcnJlY3QgcGF0aCB0byB0aGUgY2xhc3NoZWFkZXJz
LnByaSBhbmQgdGhlbgorICAgICAgICBmaXhlcyB0aGUgaW5zdGFsbGF0aW9uIG9mIHRoZSBnZW5l
cmF0ZWQgaGVhZGVycy4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDEwLTA0LTA2ICBB
bmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi
eSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvV2Vi
Q29yZS9XZWJDb3JlLnBybwppbmRleCBhYmY0YzQ1Li5lYWIxMGUzIDEwMDY0NAotLS0gYS9XZWJD
b3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTI4NTMsNyArMjg1
Myw3IEBAIGluY2x1ZGUoJCRQV0QvLi4vV2ViS2l0L3F0L0FwaS9oZWFkZXJzLnByaSkKIEhFQURF
UlMgKz0gJCRXRUJLSVRfQVBJX0hFQURFUlMKIAogIUNPTkZJRyhRVERJUl9idWlsZCkgewotICAg
IGV4aXN0cyguLi9pbmNsdWRlL1F0V2ViS2l0L2NsYXNzaGVhZGVycy5wcmkpOmluY2x1ZGUoLi4v
aW5jbHVkZS9RdFdlYktpdC9jbGFzc2hlYWRlcnMucHJpKQorICAgIGV4aXN0cygkJE9VVFBVVF9E
SVIvaW5jbHVkZS9RdFdlYktpdC9jbGFzc2hlYWRlcnMucHJpKTogaW5jbHVkZSgkJE9VVFBVVF9E
SVIvaW5jbHVkZS9RdFdlYktpdC9jbGFzc2hlYWRlcnMucHJpKQogICAgIFdFQktJVF9JTlNUQUxM
X0hFQURFUlMgPSAkJFdFQktJVF9BUElfSEVBREVSUyAkJFdFQktJVF9DTEFTU19IRUFERVJTCiAK
ICAgICAhc3ltYmlhbiB7Ci0tIAoxLjcuMAoK
</data>

          </attachment>
      

    </bug>

</bugzilla>