37168 2010-04-06 13:47:29 -0700 [chromium] Linux: respect the scale factor during printing 2010-04-09 19:50:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned commit-queue eric estade evan fishd hamaji levin oldest_to_newest 209221 0 estade 2010-04-06 13:47:29 -0700 chrome side is here: http://codereview.chromium.org/1520014 layout test run is here: http://build.chromium.org/buildbot/try-server/buildstatus?builder=layout_linux&number=1664 209223 1 52665 estade 2010-04-06 13:49:14 -0700 Created attachment 52665 try1 209229 2 evan 2010-04-06 13:55:04 -0700 ChangeLog should mention if it's covered by tests or what new tests cover it. 209233 3 estade 2010-04-06 14:03:25 -0700 I don't know if we have the infrastructure for running printing tests on chromium. From test_expectations.txt: // These tests try to print a PDF file as the expected result. I don't think // we plan on supporting this anytime soon. WONTFIX SKIP : printing/media-queries-print.html = PASS WONTFIX SKIP : printing/compositing-layer-printing.html = PASS 209393 4 eric 2010-04-06 18:59:53 -0700 No one runs those printing tests, sadly. PDFs are not portable. Some folks in the TKO office were working on printing support though. 210354 5 estade 2010-04-08 13:36:22 -0700 +darin, levin need this for mstone 5. 210963 6 53000 estade 2010-04-09 15:21:37 -0700 Created attachment 53000 update changelog updated changelog to explain test situation. 210964 7 53000 eric 2010-04-09 15:23:21 -0700 Comment on attachment 53000 update changelog Well, there are other ways than pdfs these days. But OK. You should be sure to notify the TKO folks and perhaps they can help you come up with a test after the fact. 210981 8 hamaji 2010-04-09 15:45:07 -0700 > Well, there are other ways than pdfs these days. But OK. You should be sure > to notify the TKO folks and perhaps they can help you come up with a test after > the fact. I think we cannot test this for now. Once I finish Bug 37203 and Bug 20011, this patch should be able to be tested by image diff. I'll add a test case for this patch, so please wait for a while. When I post a patch to test this change, I'll CC Evan to make sure the test is suitable for this issue. 210988 9 estade 2010-04-09 15:49:03 -0700 thanks a ton :) 211098 10 53000 commit-queue 2010-04-09 19:50:11 -0700 Comment on attachment 53000 update changelog Clearing flags on attachment: 53000 Committed r57402: <http://trac.webkit.org/changeset/57402> 211099 11 commit-queue 2010-04-09 19:50:17 -0700 All reviewed patches have been landed. Closing bug. 52665 2010-04-06 13:49:14 -0700 2010-04-09 15:21:37 -0700 try1 print.diff text/plain 1819 estade SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTcxNjQpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDYgIEV2YW4g U3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gTGludXg6IHJlc3BlY3QgdGhlIHNjYWxl IGZhY3RvciBkdXJpbmcgcHJpbnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3MTY4CisKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6Q2hyb21lUHJpbnRDb250ZXh0OjpzcG9vbFBhZ2UpOgorCiAyMDEw LTA0LTA2ICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZy YW1lSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwCShyZXZpc2lvbiA1NzA5MykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJ bXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg4LDE1ICsyODgsMjAgQEAgcHVibGljOgogICAg ICAgICByZXR1cm4gbV9wcmludGVkUGFnZVdpZHRoIC8gcGFnZVJlY3Qud2lkdGgoKTsKICAgICB9 CiAKLSAgICAvLyBTcG9vbHMgdGhlIHByaW50ZWQgcGFnZSwgYSBzdWJyZWN0IG9mIG1fZnJhbWUu ICBTa2lwIHRoZSBzY2FsZSBzdGVwLgorICAgIC8vIFNwb29scyB0aGUgcHJpbnRlZCBwYWdlLCBh IHN1YnJlY3Qgb2YgbV9mcmFtZS4gU2tpcCB0aGUgc2NhbGUgc3RlcC4KICAgICAvLyBOYXRpdmVU aGVtZSBkb2Vzbid0IHBsYXkgd2VsbCB3aXRoIHNjYWxpbmcuIFNjYWxpbmcgaXMgZG9uZSBicm93 c2VyIHNpZGUKLSAgICAvLyBpbnN0ZWFkLiAgUmV0dXJucyB0aGUgc2NhbGUgdG8gYmUgYXBwbGll ZC4KKyAgICAvLyBpbnN0ZWFkLiBSZXR1cm5zIHRoZSBzY2FsZSB0byBiZSBhcHBsaWVkLgorICAg IC8vIE9uIExpbnV4LCB3ZSBkb24ndCBoYXZlIHRoZSBwcm9ibGVtIHdpdGggTmF0aXZlVGhlbWUs IGhlbmNlIHdlIGxldCBXZWJLaXQKKyAgICAvLyBkbyB0aGUgc2NhbGluZyBhbmQgaWdub3JlIHRo ZSByZXR1cm4gdmFsdWUuCiAgICAgdmlydHVhbCBmbG9hdCBzcG9vbFBhZ2UoR3JhcGhpY3NDb250 ZXh0JiBjdHgsIGludCBwYWdlTnVtYmVyKQogICAgIHsKICAgICAgICAgSW50UmVjdCBwYWdlUmVj dCA9IG1fcGFnZVJlY3RzW3BhZ2VOdW1iZXJdOwogICAgICAgICBmbG9hdCBzY2FsZSA9IG1fcHJp bnRlZFBhZ2VXaWR0aCAvIHBhZ2VSZWN0LndpZHRoKCk7CiAKICAgICAgICAgY3R4LnNhdmUoKTsK KyNpZiBPUyhMSU5VWCkKKyAgICAgICAgY3R4LnNjYWxlKFdlYkNvcmU6OkZsb2F0U2l6ZShzY2Fs ZSwgc2NhbGUpKTsKKyNlbmRpZgogICAgICAgICBjdHgudHJhbnNsYXRlKHN0YXRpY19jYXN0PGZs b2F0PigtcGFnZVJlY3QueCgpKSwKICAgICAgICAgICAgICAgICAgICAgICBzdGF0aWNfY2FzdDxm bG9hdD4oLXBhZ2VSZWN0LnkoKSkpOwogICAgICAgICBjdHguY2xpcChwYWdlUmVjdCk7Cg== 53000 2010-04-09 15:21:37 -0700 2010-04-09 19:50:11 -0700 update changelog print.diff text/plain 1953 estade SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTczNDYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDkgIEV2YW4g U3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gTGludXg6IHJlc3BlY3QgdGhlIHNjYWxl IGZhY3RvciBkdXJpbmcgcHJpbnRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3MTY4CisKKyAgICAgICAgQ2hyb21pdW0gZG9lc24ndCBzdXBwb3J0 IHRlc3RpbmcgLnBkZnMgZnJvbSBwcmludGluZyBhdCB0aGUgbW9tZW50LCBzbworICAgICAgICB0 aGlzIGNoYW5nZSBpcyBub3QgY292ZXJlZCBieSBhbnkgdGVzdHMuCisKKyAgICAgICAgKiBzcmMv V2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lUHJpbnRDb250ZXh0Ojpz cG9vbFBhZ2UpOgorCiAyMDEwLTA0LTA5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDU3MzQ2KQorKysgV2ViS2l0L2No cm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODgsMTUgKzI4 OCwyMCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBtX3ByaW50ZWRQYWdlV2lkdGggLyBwYWdl UmVjdC53aWR0aCgpOwogICAgIH0KIAotICAgIC8vIFNwb29scyB0aGUgcHJpbnRlZCBwYWdlLCBh IHN1YnJlY3Qgb2YgbV9mcmFtZS4gIFNraXAgdGhlIHNjYWxlIHN0ZXAuCisgICAgLy8gU3Bvb2xz IHRoZSBwcmludGVkIHBhZ2UsIGEgc3VicmVjdCBvZiBtX2ZyYW1lLiBTa2lwIHRoZSBzY2FsZSBz dGVwLgogICAgIC8vIE5hdGl2ZVRoZW1lIGRvZXNuJ3QgcGxheSB3ZWxsIHdpdGggc2NhbGluZy4g U2NhbGluZyBpcyBkb25lIGJyb3dzZXIgc2lkZQotICAgIC8vIGluc3RlYWQuICBSZXR1cm5zIHRo ZSBzY2FsZSB0byBiZSBhcHBsaWVkLgorICAgIC8vIGluc3RlYWQuIFJldHVybnMgdGhlIHNjYWxl IHRvIGJlIGFwcGxpZWQuCisgICAgLy8gT24gTGludXgsIHdlIGRvbid0IGhhdmUgdGhlIHByb2Js ZW0gd2l0aCBOYXRpdmVUaGVtZSwgaGVuY2Ugd2UgbGV0IFdlYktpdAorICAgIC8vIGRvIHRoZSBz Y2FsaW5nIGFuZCBpZ25vcmUgdGhlIHJldHVybiB2YWx1ZS4KICAgICB2aXJ0dWFsIGZsb2F0IHNw b29sUGFnZShHcmFwaGljc0NvbnRleHQmIGN0eCwgaW50IHBhZ2VOdW1iZXIpCiAgICAgewogICAg ICAgICBJbnRSZWN0IHBhZ2VSZWN0ID0gbV9wYWdlUmVjdHNbcGFnZU51bWJlcl07CiAgICAgICAg IGZsb2F0IHNjYWxlID0gbV9wcmludGVkUGFnZVdpZHRoIC8gcGFnZVJlY3Qud2lkdGgoKTsKIAog ICAgICAgICBjdHguc2F2ZSgpOworI2lmIE9TKExJTlVYKQorICAgICAgICBjdHguc2NhbGUoV2Vi Q29yZTo6RmxvYXRTaXplKHNjYWxlLCBzY2FsZSkpOworI2VuZGlmCiAgICAgICAgIGN0eC50cmFu c2xhdGUoc3RhdGljX2Nhc3Q8ZmxvYXQ+KC1wYWdlUmVjdC54KCkpLAogICAgICAgICAgICAgICAg ICAgICAgIHN0YXRpY19jYXN0PGZsb2F0PigtcGFnZVJlY3QueSgpKSk7CiAgICAgICAgIGN0eC5j bGlwKHBhZ2VSZWN0KTsK