<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>37164</bug_id>
          
          <creation_ts>2010-04-06 12:22:10 -0700</creation_ts>
          <short_desc>Poor rendering on lala.com with frame flattening</short_desc>
          <delta_ts>2010-04-08 00:53:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://lala.com</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>35784</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Greg Bolsinga">bolsinga</reporter>
          <assigned_to name="Kenneth Rohde Christiansen">kenneth</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>hausmann</cc>
    
    <cc>hyatt</cc>
    
    <cc>kenneth</cc>
    
    <cc>koivisto</cc>
    
    <cc>luiz</cc>
    
    <cc>ossy</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit-ews</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>209171</commentid>
    <comment_count>0</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 12:22:10 -0700</bug_when>
    <thetext>This site does not render properly with iframe/frameset flattening enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209173</commentid>
    <comment_count>1</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 12:24:01 -0700</bug_when>
    <thetext>There is an offscreen iframe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209178</commentid>
    <comment_count>2</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 12:34:30 -0700</bug_when>
    <thetext>I forgot to add that I enabled flat frames for the Mac OS X build to see this problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209188</commentid>
    <comment_count>3</comment_count>
      <attachid>52657</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 12:58:17 -0700</bug_when>
    <thetext>Created attachment 52657
This patch addresses the problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209194</commentid>
    <comment_count>4</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 13:09:55 -0700</bug_when>
    <thetext>What about intersecting node()-&gt;document()-&gt;view()-&gt;visibleContentRect() with node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209198</commentid>
    <comment_count>5</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-06 13:13:39 -0700</bug_when>
    <thetext>
(In reply to comment #4)
&gt; What about intersecting node()-&gt;document()-&gt;view()-&gt;visibleContentRect() 

kenne, maybe mainFrame&apos;s view  not document&apos;s view (?)

&gt; with node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209200</commentid>
    <comment_count>6</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 13:15:19 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; What about intersecting node()-&gt;document()-&gt;view()-&gt;visibleContentRect() 
&gt; 
&gt; kenne, maybe mainFrame&apos;s view  not document&apos;s view (?)
&gt; 
&gt; &gt; with node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()?

Yes, you are right.

I can confirm that my suggestion works, and should take care of some additional
cases.

Could you provide a layout test as well?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209215</commentid>
    <comment_count>7</comment_count>
      <attachid>52664</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 13:38:33 -0700</bug_when>
    <thetext>Created attachment 52664
iframe offscreen

I wasn&apos;t able to build DRT on my Mac at the moment. Can you try this one out?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209225</commentid>
    <comment_count>8</comment_count>
      <attachid>52657</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 13:53:30 -0700</bug_when>
    <thetext>Comment on attachment 52657
This patch addresses the problem.

&gt; +    if (isPositioned() &amp;&amp; containingBlock() == view() &amp;&amp; ((x() + width() &lt;= 0) || (y() + height() &lt;= 0)))
&gt; +        return false;

&quot;x() + width()&quot; is &quot;frameRect().right()&quot; and I think we should use that instead.

&quot;y() + height()&quot; is &quot;frameRect().bottom()&quot; and I think we should use that instead

A much better way to do this would be to call frameRect().intersects(xxx), where xxx is the viewport. Checking specifically for right and bottom that are off the left and top edge is too specific and will miss other valuable cases.

r=me despite these concerns</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209227</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 13:54:11 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; What about intersecting node()-&gt;document()-&gt;view()-&gt;visibleContentRect() with
&gt; node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()?

Something like that would be much better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209228</commentid>
    <comment_count>10</comment_count>
      <attachid>52657</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 13:54:47 -0700</bug_when>
    <thetext>Comment on attachment 52657
This patch addresses the problem.

Perhaps someone should clear my review flag since there is no regression test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209230</commentid>
    <comment_count>11</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 13:56:13 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #5)
&gt; &gt; (In reply to comment #4)
&gt; &gt; &gt; What about intersecting node()-&gt;document()-&gt;view()-&gt;visibleContentRect() 
&gt; &gt; 
&gt; &gt; kenne, maybe mainFrame&apos;s view  not document&apos;s view (?)
&gt; &gt; 
&gt; &gt; &gt; with node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()?
&gt; 
&gt; Yes, you are right.
&gt; 
&gt; I can confirm that my suggestion works, and should take care of some additional
&gt; cases.
&gt; 
&gt; Could you provide a layout test as well?

Kenneth, maybe you should do review-. I didn&apos;t see your comments when I did a review+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209232</commentid>
    <comment_count>12</comment_count>
      <attachid>52657</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 13:57:38 -0700</bug_when>
    <thetext>Comment on attachment 52657
This patch addresses the problem.

r-, due to my comments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209234</commentid>
    <comment_count>13</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:04:49 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Created an attachment (id=52664) [details]
&gt; iframe offscreen
&gt; 
&gt; I wasn&apos;t able to build DRT on my Mac at the moment. Can you try this one out?

This one works for me, with my suggestion as well. If you can provide an updated patch with mac results then I will get the Qt results for you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209236</commentid>
    <comment_count>14</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 14:10:23 -0700</bug_when>
    <thetext>Since Mac doesn&apos;t have frame flattening on, then what are Mac results exactly?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209238</commentid>
    <comment_count>15</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:11:41 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #7)
&gt; &gt; Created an attachment (id=52664) [details] [details]
&gt; &gt; iframe offscreen
&gt; &gt; 
&gt; &gt; I wasn&apos;t able to build DRT on my Mac at the moment. Can you try this one out?
&gt; 
&gt; This one works for me, with my suggestion as well. If you can provide an
&gt; updated patch with mac results then I will get the Qt results for you.

Actually, regarding &quot;400px in each direction, disregarding the border&quot;. We
cannot verify this as it will not be part of the render tree dump.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209239</commentid>
    <comment_count>16</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:12:12 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; Since Mac doesn&apos;t have frame flattening on, then what are Mac results exactly?

Mac supports enabling frame flattening when used from the DRT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209240</commentid>
    <comment_count>17</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 14:15:41 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #7)
&gt; &gt; Created an attachment (id=52664) [details] [details]
&gt; &gt; iframe offscreen
&gt; &gt; 
&gt; &gt; I wasn&apos;t able to build DRT on my Mac at the moment. Can you try this one out?
&gt; 
&gt; This one works for me, with my suggestion as well. If you can provide an
&gt; updated patch with mac results then I will get the Qt results for you.

Can you attach your patch, so we&apos;re testing the same? ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209260</commentid>
    <comment_count>18</comment_count>
      <attachid>52671</attachid>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 14:49:38 -0700</bug_when>
    <thetext>Created attachment 52671
intersects the rects as suggested

I&apos;m not sure what to do with DRT and offscreen iframes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209261</commentid>
    <comment_count>19</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:51:14 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; (In reply to comment #13)
&gt; &gt; (In reply to comment #7)
&gt; &gt; &gt; Created an attachment (id=52664) [details] [details] [details]
&gt; &gt; &gt; iframe offscreen
&gt; &gt; &gt; 
&gt; &gt; &gt; I wasn&apos;t able to build DRT on my Mac at the moment. Can you try this one out?
&gt; &gt; 
&gt; &gt; This one works for me, with my suggestion as well. If you can provide an
&gt; &gt; updated patch with mac results then I will get the Qt results for you.
&gt; 
&gt; Can you attach your patch, so we&apos;re testing the same? ;)

Oh yeah of course, but it is not a real patch, just testing code. One sec, let
me add it for you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209263</commentid>
    <comment_count>20</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:51:49 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; Created an attachment (id=52671) [details]
&gt; intersects the rects as suggested
&gt; 
&gt; I&apos;m not sure what to do with DRT and offscreen iframes.

We are OK as long as it is offscreen, so I think that is sufficient.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209265</commentid>
    <comment_count>21</comment_count>
      <attachid>52672</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:53:39 -0700</bug_when>
    <thetext>Created attachment 52672
Potential patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209267</commentid>
    <comment_count>22</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 14:55:53 -0700</bug_when>
    <thetext>Yours is much safer than mine! I&apos;ll obsolete mine. You should nominate yours.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209269</commentid>
    <comment_count>23</comment_count>
      <attachid>52672</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 14:59:36 -0700</bug_when>
    <thetext>Comment on attachment 52672
Potential patch

&gt; +    RenderObject* render = node()-&gt;renderer();

The thing here called &quot;render&quot; is the same as &quot;this&quot;.

&gt; +    FrameView* view = frame-&gt;tree()-&gt;top()-&gt;view();

I would make this go via page()-&gt;mainFrame()-&gt;view(). But you&apos;d have to null check page().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209270</commentid>
    <comment_count>24</comment_count>
      <attachid>52671</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 14:59:51 -0700</bug_when>
    <thetext>Comment on attachment 52671
intersects the rects as suggested


&gt; +    if (!node()-&gt;document()-&gt;topDocument()-&gt;frame()-&gt;view()-&gt;visibleContentRect().intersects(node()-&gt;renderer()-&gt;absoluteClippedOverflowRect()))
&gt; +        return false;
&gt; +
&gt;      return frame-&gt;document()-&gt;frame() &amp;&amp; frame-&gt;document()-&gt;frame()-&gt;settings()-&gt;frameFlatteningEnabled();

I guess that doing the intersection is more costly than checking the setting, so the common case of not having frame flattening so not be made slower. I suggest swapping the tests.

Also, are you sure that all of these will always remain non-null?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209272</commentid>
    <comment_count>25</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 15:00:40 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; (From update of attachment 52672 [details])
&gt; &gt; +    RenderObject* render = node()-&gt;renderer();
&gt; 
&gt; The thing here called &quot;render&quot; is the same as &quot;this&quot;.
&gt; 
&gt; &gt; +    FrameView* view = frame-&gt;tree()-&gt;top()-&gt;view();
&gt; 
&gt; I would make this go via page()-&gt;mainFrame()-&gt;view(). But you&apos;d have to null
&gt; check page().

Ok, I will fix that and put a real patch up for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209274</commentid>
    <comment_count>26</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 15:04:52 -0700</bug_when>
    <thetext>&gt; &gt; +    FrameView* view = frame-&gt;tree()-&gt;top()-&gt;view();
&gt; 
&gt; I would make this go via page()-&gt;mainFrame()-&gt;view(). But you&apos;d have to null
&gt; check page().

Any particular reason for this, beyond code clarify?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209277</commentid>
    <comment_count>27</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 15:07:20 -0700</bug_when>
    <thetext>(In reply to comment #26)
&gt; Any particular reason for this, beyond code clarify?

No practical reason, but conceptually: Calling top() on the frame free means walking up the tree in a loop until you hit the top. Calling page()-&gt;mainFrame() means going directly to the main frame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209279</commentid>
    <comment_count>28</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 15:12:41 -0700</bug_when>
    <thetext>(In reply to comment #25)
&gt; (In reply to comment #23)
&gt; &gt; (From update of attachment 52672 [details] [details])
&gt; &gt; &gt; +    RenderObject* render = node()-&gt;renderer();
&gt; &gt; 
&gt; &gt; The thing here called &quot;render&quot; is the same as &quot;this&quot;.

absoluteClippedOverflowRect() is non const, so it a const_cast or removing const from the method the preferred solution?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209280</commentid>
    <comment_count>29</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-04-06 15:14:48 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; (In reply to comment #25)
&gt; &gt; (In reply to comment #23)
&gt; &gt; &gt; (From update of attachment 52672 [details] [details] [details])
&gt; &gt; &gt; &gt; +    RenderObject* render = node()-&gt;renderer();
&gt; &gt; &gt; 
&gt; &gt; &gt; The thing here called &quot;render&quot; is the same as &quot;this&quot;.
&gt; 
&gt; absoluteClippedOverflowRect() is non const, so it a const_cast or removing
&gt; const from the method the preferred solution?

also, please consider [1] while using it


[1] http://lists.macosforge.org/pipermail/webkit-dev/2010-March/012075.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209294</commentid>
    <comment_count>30</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-06 15:41:48 -0700</bug_when>
    <thetext>(In reply to comment #28)
&gt; (In reply to comment #25)
&gt; &gt; (In reply to comment #23)
&gt; &gt; &gt; (From update of attachment 52672 [details] [details] [details])
&gt; &gt; &gt; &gt; +    RenderObject* render = node()-&gt;renderer();
&gt; &gt; &gt; 
&gt; &gt; &gt; The thing here called &quot;render&quot; is the same as &quot;this&quot;.
&gt; 
&gt; absoluteClippedOverflowRect() is non const, so it a const_cast or removing
&gt; const from the method the preferred solution?

Removing const, I think.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209316</commentid>
    <comment_count>31</comment_count>
      <attachid>52681</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-06 16:19:07 -0700</bug_when>
    <thetext>Created attachment 52681
Better solution

I don&apos;t have time to finish this today with the layout tests, but the following works on http://www.samisite.com/test-csb2nf/id43.htm, lala.com and with our current layout tests.

I will do an additional test tomorrow where the iframe is within the contents of the main frame, but outside the viewport of the DRT.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209338</commentid>
    <comment_count>32</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-06 16:52:36 -0700</bug_when>
    <thetext>FWIW, this works for me too. Is there a DRT example I can crib from for an offscreen iframe?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209695</commentid>
    <comment_count>33</comment_count>
      <attachid>52744</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:12:26 -0700</bug_when>
    <thetext>Created attachment 52744
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209697</commentid>
    <comment_count>34</comment_count>
      <attachid>52744</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-07 10:18:55 -0700</bug_when>
    <thetext>Comment on attachment 52744
Patch

&gt; +    // do not flatten offscreen inner frames during frame flattening.

This comment needs to go closer to the logic, probably on the last paragraph.

&gt; +    IntRect rect(IntPoint(0, 0), view-&gt;contentsSize());
&gt; +    return rect.intersects(absoluteBoundingBoxRect());

I don&apos;t think we need a local variable here. I would write it in one line like this:

    return absoluteBoundingBoxRect().intersects(IntPoint(), view-&gt;contentsSize());

I guess I&apos;ll say r=me as is, but I&apos;m not going to set commit-queue+ yet. You can change it back to + if you want to land this patch as-is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209712</commentid>
    <comment_count>35</comment_count>
      <attachid>52749</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:35:09 -0700</bug_when>
    <thetext>Created attachment 52749
Patch fixing issues pointed out by Darin Adler

Darin, could you please re-set the r+?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209715</commentid>
    <comment_count>36</comment_count>
      <attachid>52749</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:38:46 -0700</bug_when>
    <thetext>Comment on attachment 52749
Patch fixing issues pointed out by Darin Adler

Removing cq, I did a minor mistake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209717</commentid>
    <comment_count>37</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-07 10:39:45 -0700</bug_when>
    <thetext>(In reply to comment #36)
&gt; Removing cq, I did a minor mistake.

You should capitalize the sentence comment if you are doing another patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209719</commentid>
    <comment_count>38</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2010-04-07 10:42:08 -0700</bug_when>
    <thetext>Attachment 52749 did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1607288</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209721</commentid>
    <comment_count>39</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-07 10:43:14 -0700</bug_when>
    <thetext>My bad, I left out an IntRect() in my suggested code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209725</commentid>
    <comment_count>40</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:44:36 -0700</bug_when>
    <thetext>Yes, that is what I&apos;m fixing, btw, do you prefer IntRect() over IntRect(0, 0) ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209726</commentid>
    <comment_count>41</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:45:33 -0700</bug_when>
    <thetext>(In reply to comment #40)
&gt; Yes, that is what I&apos;m fixing, btw, do you prefer IntRect() over IntRect(0, 0) ?

IntPoint(), I mean.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209728</commentid>
    <comment_count>42</comment_count>
      <attachid>52754</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-07 10:48:46 -0700</bug_when>
    <thetext>Created attachment 52754
Patch fixing compilation issue and capitalize the comment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209731</commentid>
    <comment_count>43</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-04-07 10:50:40 -0700</bug_when>
    <thetext>(In reply to comment #41)
&gt; (In reply to comment #40)
&gt; &gt; Yes, that is what I&apos;m fixing, btw, do you prefer IntRect() over IntRect(0, 0) ?
&gt; 
&gt; IntPoint(), I mean.

I think IntPoint() is pretty unclear, so I guess IntPoint(0, 0) is slightly better, but I wish there was a zeroPoint of some sort.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209743</commentid>
    <comment_count>44</comment_count>
    <who name="Luiz Agostini">luiz</who>
    <bug_when>2010-04-07 11:16:17 -0700</bug_when>
    <thetext>(In reply to comment #43)
&gt; (In reply to comment #41)
&gt; &gt; (In reply to comment #40)
&gt; &gt; &gt; Yes, that is what I&apos;m fixing, btw, do you prefer IntRect() over IntRect(0, 0) ?
&gt; &gt; 
&gt; &gt; IntPoint(), I mean.
&gt; 
&gt; I think IntPoint() is pretty unclear, so I guess IntPoint(0, 0) is slightly
&gt; better, but I wish there was a zeroPoint of some sort.

implemented in bug 37220. is it what you mean?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209803</commentid>
    <comment_count>45</comment_count>
      <attachid>52754</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-07 13:22:50 -0700</bug_when>
    <thetext>Comment on attachment 52754
Patch fixing compilation issue and capitalize the comment 

Clearing flags on attachment: 52754

Committed r57225: &lt;http://trac.webkit.org/changeset/57225&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209804</commentid>
    <comment_count>46</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-07 13:22:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209814</commentid>
    <comment_count>47</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-04-07 13:45:43 -0700</bug_when>
    <thetext>Platform specific expected files landed in http://trac.webkit.org/changeset/57228</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>209829</commentid>
    <comment_count>48</comment_count>
    <who name="Greg Bolsinga">bolsinga</who>
    <bug_when>2010-04-07 14:12:59 -0700</bug_when>
    <thetext>Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210055</commentid>
    <comment_count>49</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-04-08 00:48:09 -0700</bug_when>
    <thetext>Revision r57225 cherry-picked into qtwebkit-2.0 with commit 2705c83cb30eb31addfc7e93a60636ea60d93c38</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52657</attachid>
            <date>2010-04-06 12:58:17 -0700</date>
            <delta_ts>2010-04-06 14:49:38 -0700</delta_ts>
            <desc>This patch addresses the problem.</desc>
            <filename>0001-https-bugs.webkit.org-show_bug.cgi-id-37164.patch</filename>
            <type>text/plain</type>
            <size>1747</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">RnJvbSBhZGZkNTMxODcxYzExNjU2ZDE0ZTM4ZWIzMDNjZTI1MmFjYzE2YzBhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIEJvbHNpbmdhIDxib2xzaW5nYUBhcHBsZS5jb20+CkRh
dGU6IFR1ZSwgNiBBcHIgMjAxMCAxMjo1NzoyNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAoKUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMuIChPT1BTISkKCiogcmVuZGVyaW5nL1JlbmRlclBh
cnRPYmplY3QuY3BwOgooV2ViQ29yZTo6UmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKTog
T25seSBmbGF0dGVuIGZyYW1lcyB0aGF0IGFyZSB2aXNpYmxlLgotLS0KIFdlYkNvcmUvQ2hhbmdl
TG9nICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViQ29yZS9yZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAx
NCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh
bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWIwMzRkMC4uNWExYzVjNiAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNCBAQAorMjAxMC0wNC0wNiAgR3JlZyBCb2xzaW5nYSAgPGJvbHNpbmdhQGFwcGxlLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxNjQKKworICAgICAgICBObyBuZXcg
dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSk6IE9u
bHkgZmxhdHRlbiBmcmFtZXMgdGhhdCBhcmUgdmlzaWJsZS4KKwogMjAxMC0wNC0wNiAgQW5keSBF
c3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGFu
IEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmpl
Y3QuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRj
NTE1ZS4uNDc0ZjJjNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9i
amVjdC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAg
LTYyLDYgKzYyLDkgQEAgYm9vbCBSZW5kZXJQYXJ0T2JqZWN0OjpmbGF0dGVuRnJhbWUoKSBjb25z
dAogICAgIGlmICghaXNTY3JvbGxhYmxlICYmIHN0eWxlKCktPndpZHRoKCkuaXNGaXhlZCgpCiAg
ICAgICAgICYmIHN0eWxlKCktPmhlaWdodCgpLmlzRml4ZWQoKSkKICAgICAgICAgcmV0dXJuIGZh
bHNlOworICAgIAorICAgIGlmIChpc1Bvc2l0aW9uZWQoKSAmJiBjb250YWluaW5nQmxvY2soKSA9
PSB2aWV3KCkgJiYgKCh4KCkgKyB3aWR0aCgpIDw9IDApIHx8ICh5KCkgKyBoZWlnaHQoKSA8PSAw
KSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHJldHVybiBmcmFtZS0+ZG9jdW1lbnQo
KS0+ZnJhbWUoKSAmJiBmcmFtZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+c2V0dGluZ3MoKS0+ZnJh
bWVGbGF0dGVuaW5nRW5hYmxlZCgpOwogfQotLSAKMS42LjIKCg==
</data>
<flag name="review"
          id="36193"
          type_id="1"
          status="-"
          setter="kenneth"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>52664</attachid>
            <date>2010-04-06 13:38:33 -0700</date>
            <delta_ts>2010-04-06 13:38:33 -0700</delta_ts>
            <desc>iframe offscreen</desc>
            <filename>iframe-flattening-offscreen.html</filename>
            <type>text/html</type>
            <size>1032</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAg
IGZ1bmN0aW9uIHRlc3QoKQogICAgICAgIHsKICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRU
ZXN0Q29udHJvbGxlcikgewogICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2Fp
dFVudGlsRG9uZSgpOwogICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0RnJh
bWVGbGF0dGVuaW5nRW5hYmxlZCh0cnVlKTsKICAgICAgICAgICAgfQoKICAgICAgICAgICAgc2V0
VGltZW91dChmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVz
dENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90
aWZ5RG9uZSgpOwogICAgICAgICAgICB9LCAwKTsKICAgICAgICB9CiAgICA8L3NjcmlwdD4KPC9o
ZWFkPgo8Ym9keSBvbmxvYWQ9InRlc3QoKSI+CiAgICA8c3R5bGU+Ym9keSB7IGJhY2tncm91bmQt
Y29sb3I6IGdyZWVuOyB9PC9zdHlsZT4KICAgIDxwPlRlc3QgZm9yIGlmcmFtZSBmbGF0dGVuaW5n
LiBUaGUgZmxhdHRlbmluZyBvbmx5IHdvcmtzIGluc2lkZSB0aGUgRFJULgogICAgPHA+VGhpcyBp
bm5lciBmcmFtZSBzaG91bGQgYmUgNDAwcHggaW4gZWFjaCBkaXJlY3Rpb24sIGRpc3JlZ2FyZGlu
ZyB0aGUKICAgICAgIGJvcmRlciwgYW5kIGl0IG11c3QgYmUgb2Zmc2NyZWVuLgoKICAgIDxwPjxp
ZnJhbWUgc3R5bGU9J3Bvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogLTE1MHB4OyB0b3A6IC01NTBw
eDsnIHNyYz0iZGF0YTp0ZXh0L2h0bWwsCiAgICAgICAgPHN0eWxlPmJvZHkgeyBiYWNrZ3JvdW5k
LWNvbG9yOiByZWQ7IH08L3N0eWxlPgogICAgICAgIDxib2R5PgogICAgICAgICAgICA8ZGl2IHN0
eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA0MDBweDsgaGVpZ2h0OiA0MDBweDsgbGVm
dDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KICAgICAgICA8L2JvZHk+CiAgICAiPgo8L2JvZHk+Cjwv
aHRtbD4K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52671</attachid>
            <date>2010-04-06 14:49:38 -0700</date>
            <delta_ts>2010-04-07 10:12:26 -0700</delta_ts>
            <desc>intersects the rects as suggested</desc>
            <filename>0001-https-bugs.webkit.org-show_bug.cgi-id-37164.patch</filename>
            <type>text/plain</type>
            <size>1731</size>
            <attacher name="Greg Bolsinga">bolsinga</attacher>
            
              <data encoding="base64">RnJvbSAyZTAyOTk3MmFmODcwMzU4ZWE2OGM5MWQ0ODg1MTdjMDJiYmQ5ODMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHcmVnIEJvbHNpbmdhIDxib2xzaW5nYUBhcHBsZS5jb20+CkRh
dGU6IFR1ZSwgNiBBcHIgMjAxMCAxNDo0ODoyNyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAoKUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMuIChPT1BTISkKCiogcmVuZGVyaW5nL1JlbmRlclBh
cnRPYmplY3QuY3BwOgooV2ViQ29yZTo6UmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKTog
T25seSBmbGF0dGVuIGZyYW1lcyB0aGF0IGFyZSB2aXNpYmxlLgotLS0KIFdlYkNvcmUvQ2hhbmdl
TG9nICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViQ29yZS9yZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAx
NCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh
bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWIwMzRkMC4uNWExYzVjNiAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNCBAQAorMjAxMC0wNC0wNiAgR3JlZyBCb2xzaW5nYSAgPGJvbHNpbmdhQGFwcGxlLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxNjQKKworICAgICAgICBObyBuZXcg
dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSk6IE9u
bHkgZmxhdHRlbiBmcmFtZXMgdGhhdCBhcmUgdmlzaWJsZS4KKwogMjAxMC0wNC0wNiAgQW5keSBF
c3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGFu
IEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmpl
Y3QuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRj
NTE1ZS4uNDYxYmRiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9i
amVjdC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAg
LTYzLDYgKzYzLDkgQEAgYm9vbCBSZW5kZXJQYXJ0T2JqZWN0OjpmbGF0dGVuRnJhbWUoKSBjb25z
dAogICAgICAgICAmJiBzdHlsZSgpLT5oZWlnaHQoKS5pc0ZpeGVkKCkpCiAgICAgICAgIHJldHVy
biBmYWxzZTsKIAorICAgIGlmICghbm9kZSgpLT5kb2N1bWVudCgpLT50b3BEb2N1bWVudCgpLT5m
cmFtZSgpLT52aWV3KCktPnZpc2libGVDb250ZW50UmVjdCgpLmludGVyc2VjdHMobm9kZSgpLT5y
ZW5kZXJlcigpLT5hYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKSkpCisgICAgICAgIHJldHVy
biBmYWxzZTsKKwogICAgIHJldHVybiBmcmFtZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSAmJiBmcmFt
ZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+c2V0dGluZ3MoKS0+ZnJhbWVGbGF0dGVuaW5nRW5hYmxl
ZCgpOwogfQogCi0tIAoxLjYuMgoK
</data>
<flag name="review"
          id="36211"
          type_id="1"
          status="-"
          setter="bolsinga"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52672</attachid>
            <date>2010-04-06 14:53:39 -0700</date>
            <delta_ts>2010-04-06 16:19:07 -0700</delta_ts>
            <desc>Potential patch</desc>
            <filename>Patch.diff</filename>
            <type>text/plain</type>
            <size>1377</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwIGIvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRjNTE1ZS4uMjE2Y2Mz
NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKKysr
IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAgLTU2LDE0ICs1Niwy
NiBAQCBib29sIFJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSgpIGNvbnN0CiAgICAgaWYg
KCFub2RlKCkgfHwgIW5vZGUoKS0+aGFzVGFnTmFtZShpZnJhbWVUYWcpKQogICAgICAgICByZXR1
cm4gZmFsc2U7CiAKLSAgICBIVE1MSUZyYW1lRWxlbWVudCogZnJhbWUgPSBzdGF0aWNfY2FzdDxI
VE1MSUZyYW1lRWxlbWVudCo+KG5vZGUoKSk7Ci0gICAgYm9vbCBpc1Njcm9sbGFibGUgPSBmcmFt
ZS0+c2Nyb2xsaW5nTW9kZSgpICE9IFNjcm9sbGJhckFsd2F5c09mZjsKKyAgICBIVE1MSUZyYW1l
RWxlbWVudCogZWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxJRnJhbWVFbGVtZW50Kj4obm9kZSgp
KTsKKyAgICBib29sIGlzU2Nyb2xsYWJsZSA9IGVsZW1lbnQtPnNjcm9sbGluZ01vZGUoKSAhPSBT
Y3JvbGxiYXJBbHdheXNPZmY7CiAKICAgICBpZiAoIWlzU2Nyb2xsYWJsZSAmJiBzdHlsZSgpLT53
aWR0aCgpLmlzRml4ZWQoKQogICAgICAgICAmJiBzdHlsZSgpLT5oZWlnaHQoKS5pc0ZpeGVkKCkp
CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIHJldHVybiBmcmFtZS0+ZG9jdW1lbnQoKS0+
ZnJhbWUoKSAmJiBmcmFtZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+c2V0dGluZ3MoKS0+ZnJhbWVG
bGF0dGVuaW5nRW5hYmxlZCgpOworICAgIEZyYW1lKiBmcmFtZSA9IGVsZW1lbnQtPmRvY3VtZW50
KCktPmZyYW1lKCk7CisKKyAgICBib29sIGVuYWJsZWQgPSBmcmFtZSAmJiBmcmFtZS0+c2V0dGlu
Z3MoKS0+ZnJhbWVGbGF0dGVuaW5nRW5hYmxlZCgpOworICAgIGlmICghZW5hYmxlZCkKKyAgICAg
ICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gZG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlubmVy
IGZyYW1lcy4KKyAgICBSZW5kZXJPYmplY3QqIHJlbmRlciA9IG5vZGUoKS0+cmVuZGVyZXIoKTsK
KyAgICBGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+dHJlZSgpLT50b3AoKS0+dmlldygpOworICAg
IGlmICghdmlldyB8fCAhcmVuZGVyKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICByZXR1
cm4gdmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KCkuaW50ZXJzZWN0cyhyZW5kZXItPmFic29sdXRl
Q2xpcHBlZE92ZXJmbG93UmVjdCgpKTsKIH0KIAogdm9pZCBSZW5kZXJQYXJ0T2JqZWN0OjpjYWxj
SGVpZ2h0KCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52681</attachid>
            <date>2010-04-06 16:19:07 -0700</date>
            <delta_ts>2010-04-07 10:12:26 -0700</delta_ts>
            <desc>Better solution</desc>
            <filename>Patch2.diff</filename>
            <type>text/plain</type>
            <size>1893</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwIGIvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRjNTE1ZS4uMzZhZDMy
MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKKysr
IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAgLTUxLDE5ICs1MSwz
MSBAQCBSZW5kZXJQYXJ0T2JqZWN0OjpSZW5kZXJQYXJ0T2JqZWN0KEVsZW1lbnQqIGVsZW1lbnQp
CiB7CiB9CiAKLWJvb2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkgY29uc3QKK2Jv
b2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkKIHsKICAgICBpZiAoIW5vZGUoKSB8
fCAhbm9kZSgpLT5oYXNUYWdOYW1lKGlmcmFtZVRhZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsK
IAotICAgIEhUTUxJRnJhbWVFbGVtZW50KiBmcmFtZSA9IHN0YXRpY19jYXN0PEhUTUxJRnJhbWVF
bGVtZW50Kj4obm9kZSgpKTsKLSAgICBib29sIGlzU2Nyb2xsYWJsZSA9IGZyYW1lLT5zY3JvbGxp
bmdNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmOworICAgIEhUTUxJRnJhbWVFbGVtZW50KiBl
bGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTElGcmFtZUVsZW1lbnQqPihub2RlKCkpOworICAgIGJv
b2wgaXNTY3JvbGxhYmxlID0gZWxlbWVudC0+c2Nyb2xsaW5nTW9kZSgpICE9IFNjcm9sbGJhckFs
d2F5c09mZjsKIAogICAgIGlmICghaXNTY3JvbGxhYmxlICYmIHN0eWxlKCktPndpZHRoKCkuaXNG
aXhlZCgpCiAgICAgICAgICYmIHN0eWxlKCktPmhlaWdodCgpLmlzRml4ZWQoKSkKICAgICAgICAg
cmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpICYm
IGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpLT5zZXR0aW5ncygpLT5mcmFtZUZsYXR0ZW5pbmdF
bmFibGVkKCk7CisgICAgRnJhbWUqIGZyYW1lID0gZWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUo
KTsKKyAgICBib29sIGVuYWJsZWQgPSBmcmFtZSAmJiBmcmFtZS0+c2V0dGluZ3MoKS0+ZnJhbWVG
bGF0dGVuaW5nRW5hYmxlZCgpOworCisgICAgLy8gZG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlu
bmVyIGZyYW1lcyBkdXJpbmcgZnJhbWUgZmxhdHRlbmluZy4KKyAgICBpZiAoIWVuYWJsZWQgfHwg
IWZyYW1lLT5wYWdlKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIEZyYW1lVmlldyog
dmlldyA9IGZyYW1lLT5wYWdlKCktPm1haW5GcmFtZSgpLT52aWV3KCk7CisgICAgaWYgKCF2aWV3
KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBJbnRSZWN0IHJlY3QoSW50UG9pbnQoMCwg
MCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpKTsKKyAgICByZXR1cm4gcmVjdC5pbnRlcnNlY3RzKGFi
c29sdXRlQm91bmRpbmdCb3hSZWN0KCkpOwogfQogCiB2b2lkIFJlbmRlclBhcnRPYmplY3Q6OmNh
bGNIZWlnaHQoKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVj
dC5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oCmluZGV4IDVjNzI3N2Uu
LjU4OTg5NjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3Qu
aAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmgKQEAgLTQyLDcgKzQy
LDcgQEAgcHJpdmF0ZToKIAogICAgIHZpcnR1YWwgdm9pZCB2aWV3Q2xlYXJlZCgpOwogCi0gICAg
Ym9vbCBmbGF0dGVuRnJhbWUoKSBjb25zdDsKKyAgICBib29sIGZsYXR0ZW5GcmFtZSgpOwogfTsK
IAogaW5saW5lIFJlbmRlclBhcnRPYmplY3QqIHRvUmVuZGVyUGFydE9iamVjdChSZW5kZXJPYmpl
Y3QqIG9iamVjdCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52744</attachid>
            <date>2010-04-07 10:12:26 -0700</date>
            <delta_ts>2010-04-07 10:35:09 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>0001-Poor-rendering-on-lala.com-with-frame-flattening.patch</filename>
            <type>text/plain</type>
            <size>6296</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSBmOTI0MmNlM2Q4ZjMzNGNjNDhlYzk3MmZjZTUwNjkwYTdhM2VmZTRmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBXZWQsIDcgQXByIDIwMTAgMTE6MTg6NDUgLTAzMDAKU3ViamVjdDog
W1BBVENIXSBQb29yIHJlbmRlcmluZyBvbiBsYWxhLmNvbSB3aXRoIGZyYW1lIGZsYXR0ZW5pbmcK
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAoKUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCgpEbyBub3QgZmxhdHRlbiBvZmZzY3JlZW4gaWZyYW1lcy4KClRl
c3Q6IGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0
bWwKCiogcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwOgooV2ViQ29yZTo6UmVuZGVyUGFy
dE9iamVjdDo6ZmxhdHRlbkZyYW1lKToKKiByZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oOgot
LS0KIC4uLi9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sICAgIHwg
ICA1NiArKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k
ZXJQYXJ0T2JqZWN0LmNwcCAgICAgICAgICAgICB8ICAgMjAgKysrKysrLS0KIFdlYkNvcmUvcmVu
ZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuaCAgICAgICAgICAgICAgIHwgICAgMiArLQogNCBmaWxl
cyBjaGFuZ2VkLCA4OCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUg
MTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5p
bmctb2Zmc2NyZWVuLmh0bWwKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9m
bGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sIGIvTGF5b3V0VGVzdHMv
ZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmluZy1vZmZzY3JlZW4uaHRtbApu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hZjZjODdlCi0tLSAvZGV2L251bGwK
KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmlu
Zy1vZmZzY3JlZW4uaHRtbApAQCAtMCwwICsxLDU2IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDxz
Y3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgZnVuY3Rpb24gdGVzdCgpCisg
ICAgICAgIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsK
KyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cisg
ICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0RnJhbWVGbGF0dGVuaW5nRW5h
YmxlZCh0cnVlKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgc2V0VGltZW91dChmdW5j
dGlvbigpIHsKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy
KQorICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7
CisgICAgICAgICAgICB9LCAwKTsKKyAgICAgICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgor
PGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorICAgIDxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0
ZTsgdG9wOiAyMDAiPgorICAgICAgICA8cD5UZXN0IGZvciBpZnJhbWUgZmxhdHRlbmluZywgd2l0
aCB0aHJlZSBpbm5lciBmcmFtZXMganVzdCBvdXRzaWRlIHRoZSB2aWV3CisgICAgICAgIGFuZCBv
ZiB0aGUgc2l6ZSAyMDB4MjAwIHB4LCBwbHVzIG9uZSBpbm5lciBmcmFtZSBpcyBwYXJ0bHkgdmlz
aWJsZS4KKyAgICAgICAgPHA+VGhpcyB5ZWxsb3csIHJlZCBhbmQgYmx1ZSBpbm5lciBmcmFtZXMg
bXVzdCByZW1haW4gb2Zmc2NyZWVuLCBhbmQgdGhlCisgICAgICAgIGdyZWVuIGlubmVyIGZyYW1l
cyBzaG91bGQgYmUgb2Ygc2l6ZSAzMDB4MzAwICgyMDB4MjAwIHZpc2libGUpLgorICAgICAgICA8
cD5OT1RFOiBUaGUgdGVzdCBvbmx5IHdvcmtzIGluIHRoZSBEUlQgb3Igd2l0aCBmcmFtZSBmbGF0
dGVuaW5nIGVuYWJsZWQuCisgICAgPC9kaXY+CisKKyAgICA8IS0tIERSVCBzaXplIGlzIDgwMHg2
MDAgcGl4ZWxzLCBvbmUgbmVlZHMgdG8gYmUgZmxleGlibGUgaW4gb3JkZXIgdG8gdXNlIGZyYW1l
IGZsYXR0ZW5pbmcgLS0+CisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIg
c3R5bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IDBweDsgdG9wOiAt
MjAwcHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJhY2tn
cm91bmQtY29sb3I6IHJlZDsgfTwvc3R5bGU+CisgICAgICAgIDxib2R5PgorICAgICAgICAgICAg
PGRpdiBzdHlsZT0ncG9zaXRpb246IGFic29sdXRlOyB3aWR0aDogODAwcHg7IGhlaWdodDogODAw
cHg7IGxlZnQ6IDA7IHRvcDogMHB4Oyc+PC9kaXY+CisgICAgICAgIDwvYm9keT4KKyAgICAgICAg
Ij48L2lmcmFtZT4KKworICAgIDxwPjxpZnJhbWUgd2lkdGg9IjI1JSIgaGVpZ2h0PSIyMDAiIHN0
eWxlPSdib3JkZXI6IDBweDsgcG9zaXRpb246IGFic29sdXRlOyBsZWZ0OiAtMjAwcHg7IHRvcDog
MHB4Oycgc3JjPSJkYXRhOnRleHQvaHRtbCwKKyAgICAgICAgPHN0eWxlPmJvZHkgeyBiYWNrZ3Jv
dW5kLWNvbG9yOiBibHVlOyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAgICAgICA8
ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA4MDBweDsgaGVpZ2h0OiA4MDBw
eDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAgICAgICAi
PjwvaWZyYW1lPgorCisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIgc3R5
bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IC0yMDBweDsgdG9wOiAt
MjAwcHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJhY2tn
cm91bmQtY29sb3I6IHllbGxvdzsgfTwvc3R5bGU+CisgICAgICAgIDxib2R5PgorICAgICAgICAg
ICAgPGRpdiBzdHlsZT0ncG9zaXRpb246IGFic29sdXRlOyB3aWR0aDogODAwcHg7IGhlaWdodDog
ODAwcHg7IGxlZnQ6IDA7IHRvcDogMHB4Oyc+PC9kaXY+CisgICAgICAgIDwvYm9keT4KKyAgICAg
ICAgIj48L2lmcmFtZT4KKworICAgIDxwPjxpZnJhbWUgd2lkdGg9IjI1JSIgaGVpZ2h0PSIyMDAi
IHN0eWxlPSdib3JkZXI6IDBweDsgcG9zaXRpb246IGFic29sdXRlOyBsZWZ0OiAtMTAwcHg7IHRv
cDogLTEwMHB4Oycgc3JjPSJkYXRhOnRleHQvaHRtbCwKKyAgICAgICAgPHN0eWxlPmJvZHkgeyBi
YWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsgfTwvc3R5bGU+CisgICAgICAgIDxib2R5PgorICAgICAg
ICAgICAgPGRpdiBzdHlsZT0ncG9zaXRpb246IGFic29sdXRlOyB3aWR0aDogMzAwcHg7IGhlaWdo
dDogMzAwcHg7IGxlZnQ6IDA7IHRvcDogMHB4Oyc+PC9kaXY+CisgICAgICAgIDwvYm9keT4KKyAg
ICAgICAgIj48L2lmcmFtZT4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv
Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhkNzA1NS4uZWE4NDRiMSAxMDA2
NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOCBAQAorMjAxMC0wNC0wNyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxrZW5u
ZXRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgUG9vciByZW5kZXJpbmcgb24gbGFsYS5jb20gd2l0aCBmcmFtZSBmbGF0dGVuaW5n
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAor
CisgICAgICAgIERvIG5vdCBmbGF0dGVuIG9mZnNjcmVlbiBpZnJhbWVzLgorCisgICAgICAgIFRl
c3Q6IGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0
bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSk6CisgICAgICAgICogcmVu
ZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuaDoKKwogMjAxMC0wNC0wNyAgRGF3aXQgQWxlbWF5ZWh1
ICA8YWRhd2l0QGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4u
CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmNwcCBiL1dl
YkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwCmluZGV4IGM0YzUxNWUuLjM2YWQz
MjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwCisr
KyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwCkBAIC01MSwxOSArNTEs
MzEgQEAgUmVuZGVyUGFydE9iamVjdDo6UmVuZGVyUGFydE9iamVjdChFbGVtZW50KiBlbGVtZW50
KQogewogfQogCi1ib29sIFJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSgpIGNvbnN0Citi
b29sIFJlbmRlclBhcnRPYmplY3Q6OmZsYXR0ZW5GcmFtZSgpCiB7CiAgICAgaWYgKCFub2RlKCkg
fHwgIW5vZGUoKS0+aGFzVGFnTmFtZShpZnJhbWVUYWcpKQogICAgICAgICByZXR1cm4gZmFsc2U7
CiAKLSAgICBIVE1MSUZyYW1lRWxlbWVudCogZnJhbWUgPSBzdGF0aWNfY2FzdDxIVE1MSUZyYW1l
RWxlbWVudCo+KG5vZGUoKSk7Ci0gICAgYm9vbCBpc1Njcm9sbGFibGUgPSBmcmFtZS0+c2Nyb2xs
aW5nTW9kZSgpICE9IFNjcm9sbGJhckFsd2F5c09mZjsKKyAgICBIVE1MSUZyYW1lRWxlbWVudCog
ZWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxJRnJhbWVFbGVtZW50Kj4obm9kZSgpKTsKKyAgICBi
b29sIGlzU2Nyb2xsYWJsZSA9IGVsZW1lbnQtPnNjcm9sbGluZ01vZGUoKSAhPSBTY3JvbGxiYXJB
bHdheXNPZmY7CiAKICAgICBpZiAoIWlzU2Nyb2xsYWJsZSAmJiBzdHlsZSgpLT53aWR0aCgpLmlz
Rml4ZWQoKQogICAgICAgICAmJiBzdHlsZSgpLT5oZWlnaHQoKS5pc0ZpeGVkKCkpCiAgICAgICAg
IHJldHVybiBmYWxzZTsKIAotICAgIHJldHVybiBmcmFtZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSAm
JiBmcmFtZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+c2V0dGluZ3MoKS0+ZnJhbWVGbGF0dGVuaW5n
RW5hYmxlZCgpOworICAgIEZyYW1lKiBmcmFtZSA9IGVsZW1lbnQtPmRvY3VtZW50KCktPmZyYW1l
KCk7CisgICAgYm9vbCBlbmFibGVkID0gZnJhbWUgJiYgZnJhbWUtPnNldHRpbmdzKCktPmZyYW1l
RmxhdHRlbmluZ0VuYWJsZWQoKTsKKworICAgIC8vIGRvIG5vdCBmbGF0dGVuIG9mZnNjcmVlbiBp
bm5lciBmcmFtZXMgZHVyaW5nIGZyYW1lIGZsYXR0ZW5pbmcuCisgICAgaWYgKCFlbmFibGVkIHx8
ICFmcmFtZS0+cGFnZSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBGcmFtZVZpZXcq
IHZpZXcgPSBmcmFtZS0+cGFnZSgpLT5tYWluRnJhbWUoKS0+dmlldygpOworICAgIGlmICghdmll
dykKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgSW50UmVjdCByZWN0KEludFBvaW50KDAs
IDApLCB2aWV3LT5jb250ZW50c1NpemUoKSk7CisgICAgcmV0dXJuIHJlY3QuaW50ZXJzZWN0cyhh
YnNvbHV0ZUJvdW5kaW5nQm94UmVjdCgpKTsKIH0KIAogdm9pZCBSZW5kZXJQYXJ0T2JqZWN0Ojpj
YWxjSGVpZ2h0KCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmpl
Y3QuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuaAppbmRleCA1YzcyNzdl
Li41ODk4OTYwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0
LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oCkBAIC00Miw3ICs0
Miw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIHZvaWQgdmlld0NsZWFyZWQoKTsKIAotICAg
IGJvb2wgZmxhdHRlbkZyYW1lKCkgY29uc3Q7CisgICAgYm9vbCBmbGF0dGVuRnJhbWUoKTsKIH07
CiAKIGlubGluZSBSZW5kZXJQYXJ0T2JqZWN0KiB0b1JlbmRlclBhcnRPYmplY3QoUmVuZGVyT2Jq
ZWN0KiBvYmplY3QpCi0tIAoxLjcuMC4zCgo=
</data>
<flag name="review"
          id="36307"
          type_id="1"
          status="+"
          setter="darin"
    />
    <flag name="commit-queue"
          id="36308"
          type_id="3"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52749</attachid>
            <date>2010-04-07 10:35:09 -0700</date>
            <delta_ts>2010-04-07 10:48:46 -0700</delta_ts>
            <desc>Patch fixing issues pointed out by Darin Adler</desc>
            <filename>0001-Poor-rendering-on-lala.com-with-frame-flattening.patch</filename>
            <type>text/plain</type>
            <size>6266</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSA1ZTNlZmNhZTcxODlmMGRjM2Q0NTYyZmFjZTlkYWM0N2EzY2IyYmMwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBXZWQsIDcgQXByIDIwMTAgMTE6MTg6NDUgLTAzMDAKU3ViamVjdDog
W1BBVENIXSBQb29yIHJlbmRlcmluZyBvbiBsYWxhLmNvbSB3aXRoIGZyYW1lIGZsYXR0ZW5pbmcK
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAoKUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCgpEbyBub3QgZmxhdHRlbiBvZmZzY3JlZW4gaWZyYW1lcy4KClRl
c3Q6IGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0
bWwKCiogcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwOgooV2ViQ29yZTo6UmVuZGVyUGFy
dE9iamVjdDo6ZmxhdHRlbkZyYW1lKToKKiByZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oOgot
LS0KIC4uLi9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sICAgIHwg
ICA1NiArKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k
ZXJQYXJ0T2JqZWN0LmNwcCAgICAgICAgICAgICB8ICAgMTkgKysrKystLQogV2ViQ29yZS9yZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oICAgICAgICAgICAgICAgfCAgICAyICstCiA0IGZpbGVz
IGNoYW5nZWQsIDg3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx
MDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmlu
Zy1vZmZzY3JlZW4uaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2Zs
YXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0bWwgYi9MYXlvdXRUZXN0cy9m
YXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sCm5l
dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmFmNmM4N2UKLS0tIC9kZXYvbnVsbAor
KysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5n
LW9mZnNjcmVlbi5odG1sCkBAIC0wLDAgKzEsNTYgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPHNj
cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICBmdW5jdGlvbiB0ZXN0KCkKKyAg
ICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor
ICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg
ICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRGcmFtZUZsYXR0ZW5pbmdFbmFi
bGVkKHRydWUpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0
aW9uKCkgeworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp
CisgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsK
KyAgICAgICAgICAgIH0sIDApOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8
Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRl
OyB0b3A6IDIwMCI+CisgICAgICAgIDxwPlRlc3QgZm9yIGlmcmFtZSBmbGF0dGVuaW5nLCB3aXRo
IHRocmVlIGlubmVyIGZyYW1lcyBqdXN0IG91dHNpZGUgdGhlIHZpZXcKKyAgICAgICAgYW5kIG9m
IHRoZSBzaXplIDIwMHgyMDAgcHgsIHBsdXMgb25lIGlubmVyIGZyYW1lIGlzIHBhcnRseSB2aXNp
YmxlLgorICAgICAgICA8cD5UaGlzIHllbGxvdywgcmVkIGFuZCBibHVlIGlubmVyIGZyYW1lcyBt
dXN0IHJlbWFpbiBvZmZzY3JlZW4sIGFuZCB0aGUKKyAgICAgICAgZ3JlZW4gaW5uZXIgZnJhbWVz
IHNob3VsZCBiZSBvZiBzaXplIDMwMHgzMDAgKDIwMHgyMDAgdmlzaWJsZSkuCisgICAgICAgIDxw
Pk5PVEU6IFRoZSB0ZXN0IG9ubHkgd29ya3MgaW4gdGhlIERSVCBvciB3aXRoIGZyYW1lIGZsYXR0
ZW5pbmcgZW5hYmxlZC4KKyAgICA8L2Rpdj4KKworICAgIDwhLS0gRFJUIHNpemUgaXMgODAweDYw
MCBwaXhlbHMsIG9uZSBuZWVkcyB0byBiZSBmbGV4aWJsZSBpbiBvcmRlciB0byB1c2UgZnJhbWUg
ZmxhdHRlbmluZyAtLT4KKyAgICA8cD48aWZyYW1lIHdpZHRoPSIyNSUiIGhlaWdodD0iMjAwIiBz
dHlsZT0nYm9yZGVyOiAwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogMHB4OyB0b3A6IC0y
MDBweDsnIHNyYz0iZGF0YTp0ZXh0L2h0bWwsCisgICAgICAgIDxzdHlsZT5ib2R5IHsgYmFja2dy
b3VuZC1jb2xvcjogcmVkOyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAgICAgICA8
ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA4MDBweDsgaGVpZ2h0OiA4MDBw
eDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAgICAgICAi
PjwvaWZyYW1lPgorCisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIgc3R5
bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IC0yMDBweDsgdG9wOiAw
cHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJhY2tncm91
bmQtY29sb3I6IGJsdWU7IH08L3N0eWxlPgorICAgICAgICA8Ym9keT4KKyAgICAgICAgICAgIDxk
aXYgc3R5bGU9J3Bvc2l0aW9uOiBhYnNvbHV0ZTsgd2lkdGg6IDgwMHB4OyBoZWlnaHQ6IDgwMHB4
OyBsZWZ0OiAwOyB0b3A6IDBweDsnPjwvZGl2PgorICAgICAgICA8L2JvZHk+CisgICAgICAgICI+
PC9pZnJhbWU+CisKKyAgICA8cD48aWZyYW1lIHdpZHRoPSIyNSUiIGhlaWdodD0iMjAwIiBzdHls
ZT0nYm9yZGVyOiAwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogLTIwMHB4OyB0b3A6IC0y
MDBweDsnIHNyYz0iZGF0YTp0ZXh0L2h0bWwsCisgICAgICAgIDxzdHlsZT5ib2R5IHsgYmFja2dy
b3VuZC1jb2xvcjogeWVsbG93OyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAgICAg
ICA8ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA4MDBweDsgaGVpZ2h0OiA4
MDBweDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAgICAg
ICAiPjwvaWZyYW1lPgorCisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIg
c3R5bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IC0xMDBweDsgdG9w
OiAtMTAwcHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJh
Y2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAg
ICAgICA8ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiAzMDBweDsgaGVpZ2h0
OiAzMDBweDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAg
ICAgICAiPjwvaWZyYW1lPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0OGQ3MDU1Li5lYTg0NGIxIDEwMDY0
NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE4IEBACisyMDEwLTA0LTA3ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5l
dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBQb29yIHJlbmRlcmluZyBvbiBsYWxhLmNvbSB3aXRoIGZyYW1lIGZsYXR0ZW5pbmcK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTY0CisK
KyAgICAgICAgRG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlmcmFtZXMuCisKKyAgICAgICAgVGVz
dDogZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmluZy1vZmZzY3JlZW4uaHRt
bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6UmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKToKKyAgICAgICAgKiByZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oOgorCiAyMDEwLTA0LTA3ICBEYXdpdCBBbGVtYXllaHUg
IDxhZGF3aXRAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwIGIvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRjNTE1ZS4uODVkNzFk
NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKKysr
IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAgLTUxLDE5ICs1MSwz
MCBAQCBSZW5kZXJQYXJ0T2JqZWN0OjpSZW5kZXJQYXJ0T2JqZWN0KEVsZW1lbnQqIGVsZW1lbnQp
CiB7CiB9CiAKLWJvb2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkgY29uc3QKK2Jv
b2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkKIHsKICAgICBpZiAoIW5vZGUoKSB8
fCAhbm9kZSgpLT5oYXNUYWdOYW1lKGlmcmFtZVRhZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsK
IAotICAgIEhUTUxJRnJhbWVFbGVtZW50KiBmcmFtZSA9IHN0YXRpY19jYXN0PEhUTUxJRnJhbWVF
bGVtZW50Kj4obm9kZSgpKTsKLSAgICBib29sIGlzU2Nyb2xsYWJsZSA9IGZyYW1lLT5zY3JvbGxp
bmdNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmOworICAgIEhUTUxJRnJhbWVFbGVtZW50KiBl
bGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTElGcmFtZUVsZW1lbnQqPihub2RlKCkpOworICAgIGJv
b2wgaXNTY3JvbGxhYmxlID0gZWxlbWVudC0+c2Nyb2xsaW5nTW9kZSgpICE9IFNjcm9sbGJhckFs
d2F5c09mZjsKIAogICAgIGlmICghaXNTY3JvbGxhYmxlICYmIHN0eWxlKCktPndpZHRoKCkuaXNG
aXhlZCgpCiAgICAgICAgICYmIHN0eWxlKCktPmhlaWdodCgpLmlzRml4ZWQoKSkKICAgICAgICAg
cmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpICYm
IGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpLT5zZXR0aW5ncygpLT5mcmFtZUZsYXR0ZW5pbmdF
bmFibGVkKCk7CisgICAgRnJhbWUqIGZyYW1lID0gZWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUo
KTsKKyAgICBib29sIGVuYWJsZWQgPSBmcmFtZSAmJiBmcmFtZS0+c2V0dGluZ3MoKS0+ZnJhbWVG
bGF0dGVuaW5nRW5hYmxlZCgpOworCisgICAgaWYgKCFlbmFibGVkIHx8ICFmcmFtZS0+cGFnZSgp
KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+
cGFnZSgpLT5tYWluRnJhbWUoKS0+dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0
dXJuIGZhbHNlOworCisgICAgLy8gZG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlubmVyIGZyYW1l
cyBkdXJpbmcgZnJhbWUgZmxhdHRlbmluZy4KKyAgICByZXR1cm4gYWJzb2x1dGVCb3VuZGluZ0Jv
eFJlY3QoKS5pbnRlcnNlY3RzKEludFBvaW50KCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpKTsKIH0K
IAogdm9pZCBSZW5kZXJQYXJ0T2JqZWN0OjpjYWxjSGVpZ2h0KCkKZGlmZiAtLWdpdCBhL1dlYkNv
cmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl
clBhcnRPYmplY3QuaAppbmRleCA1YzcyNzdlLi41ODk4OTYwIDEwMDY0NAotLS0gYS9XZWJDb3Jl
L3JlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu
ZGVyUGFydE9iamVjdC5oCkBAIC00Miw3ICs0Miw3IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFs
IHZvaWQgdmlld0NsZWFyZWQoKTsKIAotICAgIGJvb2wgZmxhdHRlbkZyYW1lKCkgY29uc3Q7Cisg
ICAgYm9vbCBmbGF0dGVuRnJhbWUoKTsKIH07CiAKIGlubGluZSBSZW5kZXJQYXJ0T2JqZWN0KiB0
b1JlbmRlclBhcnRPYmplY3QoUmVuZGVyT2JqZWN0KiBvYmplY3QpCi0tIAoxLjcuMC4zCgo=
</data>
<flag name="review"
          id="36314"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>52754</attachid>
            <date>2010-04-07 10:48:46 -0700</date>
            <delta_ts>2010-04-07 13:22:50 -0700</delta_ts>
            <desc>Patch fixing compilation issue and capitalize the comment </desc>
            <filename>0001-Poor-rendering-on-lala.com-with-frame-flattening.patch</filename>
            <type>text/plain</type>
            <size>6279</size>
            <attacher name="Kenneth Rohde Christiansen">kenneth</attacher>
            
              <data encoding="base64">RnJvbSBlNWFmNmYyMWM3MDRjNzk1ODE3Zjg0ODcxZjkzZjMyZDMxYjUwN2RjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3
ZWJraXQub3JnPgpEYXRlOiBXZWQsIDcgQXByIDIwMTAgMTE6MTg6NDUgLTAzMDAKU3ViamVjdDog
W1BBVENIXSBQb29yIHJlbmRlcmluZyBvbiBsYWxhLmNvbSB3aXRoIGZyYW1lIGZsYXR0ZW5pbmcK
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE2NAoKUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCgpEbyBub3QgZmxhdHRlbiBvZmZzY3JlZW4gaWZyYW1lcy4KClRl
c3Q6IGZhc3QvZnJhbWVzL2ZsYXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0
bWwKCiogcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwOgooV2ViQ29yZTo6UmVuZGVyUGFy
dE9iamVjdDo6ZmxhdHRlbkZyYW1lKToKKiByZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oOgot
LS0KIC4uLi9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sICAgIHwg
ICA1NiArKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrCiBXZWJDb3JlL3JlbmRlcmluZy9SZW5k
ZXJQYXJ0T2JqZWN0LmNwcCAgICAgICAgICAgICB8ICAgMTkgKysrKystLQogV2ViQ29yZS9yZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oICAgICAgICAgICAgICAgfCAgICAyICstCiA0IGZpbGVz
IGNoYW5nZWQsIDg3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx
MDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmlu
Zy1vZmZzY3JlZW4uaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2Zs
YXR0ZW5pbmcvaWZyYW1lLWZsYXR0ZW5pbmctb2Zmc2NyZWVuLmh0bWwgYi9MYXlvdXRUZXN0cy9m
YXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5nLW9mZnNjcmVlbi5odG1sCm5l
dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmFmNmM4N2UKLS0tIC9kZXYvbnVsbAor
KysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS1mbGF0dGVuaW5n
LW9mZnNjcmVlbi5odG1sCkBAIC0wLDAgKzEsNTYgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPHNj
cmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgICBmdW5jdGlvbiB0ZXN0KCkKKyAg
ICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor
ICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg
ICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRGcmFtZUZsYXR0ZW5pbmdFbmFi
bGVkKHRydWUpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0
aW9uKCkgeworICAgICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp
CisgICAgICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsK
KyAgICAgICAgICAgIH0sIDApOworICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8
Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisgICAgPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRl
OyB0b3A6IDIwMCI+CisgICAgICAgIDxwPlRlc3QgZm9yIGlmcmFtZSBmbGF0dGVuaW5nLCB3aXRo
IHRocmVlIGlubmVyIGZyYW1lcyBqdXN0IG91dHNpZGUgdGhlIHZpZXcKKyAgICAgICAgYW5kIG9m
IHRoZSBzaXplIDIwMHgyMDAgcHgsIHBsdXMgb25lIGlubmVyIGZyYW1lIGlzIHBhcnRseSB2aXNp
YmxlLgorICAgICAgICA8cD5UaGlzIHllbGxvdywgcmVkIGFuZCBibHVlIGlubmVyIGZyYW1lcyBt
dXN0IHJlbWFpbiBvZmZzY3JlZW4sIGFuZCB0aGUKKyAgICAgICAgZ3JlZW4gaW5uZXIgZnJhbWVz
IHNob3VsZCBiZSBvZiBzaXplIDMwMHgzMDAgKDIwMHgyMDAgdmlzaWJsZSkuCisgICAgICAgIDxw
Pk5PVEU6IFRoZSB0ZXN0IG9ubHkgd29ya3MgaW4gdGhlIERSVCBvciB3aXRoIGZyYW1lIGZsYXR0
ZW5pbmcgZW5hYmxlZC4KKyAgICA8L2Rpdj4KKworICAgIDwhLS0gRFJUIHNpemUgaXMgODAweDYw
MCBwaXhlbHMsIG9uZSBuZWVkcyB0byBiZSBmbGV4aWJsZSBpbiBvcmRlciB0byB1c2UgZnJhbWUg
ZmxhdHRlbmluZyAtLT4KKyAgICA8cD48aWZyYW1lIHdpZHRoPSIyNSUiIGhlaWdodD0iMjAwIiBz
dHlsZT0nYm9yZGVyOiAwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogMHB4OyB0b3A6IC0y
MDBweDsnIHNyYz0iZGF0YTp0ZXh0L2h0bWwsCisgICAgICAgIDxzdHlsZT5ib2R5IHsgYmFja2dy
b3VuZC1jb2xvcjogcmVkOyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAgICAgICA8
ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA4MDBweDsgaGVpZ2h0OiA4MDBw
eDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAgICAgICAi
PjwvaWZyYW1lPgorCisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIgc3R5
bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IC0yMDBweDsgdG9wOiAw
cHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJhY2tncm91
bmQtY29sb3I6IGJsdWU7IH08L3N0eWxlPgorICAgICAgICA8Ym9keT4KKyAgICAgICAgICAgIDxk
aXYgc3R5bGU9J3Bvc2l0aW9uOiBhYnNvbHV0ZTsgd2lkdGg6IDgwMHB4OyBoZWlnaHQ6IDgwMHB4
OyBsZWZ0OiAwOyB0b3A6IDBweDsnPjwvZGl2PgorICAgICAgICA8L2JvZHk+CisgICAgICAgICI+
PC9pZnJhbWU+CisKKyAgICA8cD48aWZyYW1lIHdpZHRoPSIyNSUiIGhlaWdodD0iMjAwIiBzdHls
ZT0nYm9yZGVyOiAwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogLTIwMHB4OyB0b3A6IC0y
MDBweDsnIHNyYz0iZGF0YTp0ZXh0L2h0bWwsCisgICAgICAgIDxzdHlsZT5ib2R5IHsgYmFja2dy
b3VuZC1jb2xvcjogeWVsbG93OyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAgICAg
ICA8ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiA4MDBweDsgaGVpZ2h0OiA4
MDBweDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAgICAg
ICAiPjwvaWZyYW1lPgorCisgICAgPHA+PGlmcmFtZSB3aWR0aD0iMjUlIiBoZWlnaHQ9IjIwMCIg
c3R5bGU9J2JvcmRlcjogMHB4OyBwb3NpdGlvbjogYWJzb2x1dGU7IGxlZnQ6IC0xMDBweDsgdG9w
OiAtMTAwcHg7JyBzcmM9ImRhdGE6dGV4dC9odG1sLAorICAgICAgICA8c3R5bGU+Ym9keSB7IGJh
Y2tncm91bmQtY29sb3I6IGdyZWVuOyB9PC9zdHlsZT4KKyAgICAgICAgPGJvZHk+CisgICAgICAg
ICAgICA8ZGl2IHN0eWxlPSdwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiAzMDBweDsgaGVpZ2h0
OiAzMDBweDsgbGVmdDogMDsgdG9wOiAwcHg7Jz48L2Rpdj4KKyAgICAgICAgPC9ib2R5PgorICAg
ICAgICAiPjwvaWZyYW1lPgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0OGQ3MDU1Li5lYTg0NGIxIDEwMDY0
NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE4IEBACisyMDEwLTA0LTA3ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5l
dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBQb29yIHJlbmRlcmluZyBvbiBsYWxhLmNvbSB3aXRoIGZyYW1lIGZsYXR0ZW5pbmcK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTY0CisK
KyAgICAgICAgRG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlmcmFtZXMuCisKKyAgICAgICAgVGVz
dDogZmFzdC9mcmFtZXMvZmxhdHRlbmluZy9pZnJhbWUtZmxhdHRlbmluZy1vZmZzY3JlZW4uaHRt
bAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6UmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKToKKyAgICAgICAgKiByZW5k
ZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oOgorCiAyMDEwLTA0LTA3ICBEYXdpdCBBbGVtYXllaHUg
IDxhZGF3aXRAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuY3BwIGIvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKaW5kZXggYzRjNTE1ZS4uMDk1ODk0
MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKKysr
IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5jcHAKQEAgLTUxLDE5ICs1MSwz
MCBAQCBSZW5kZXJQYXJ0T2JqZWN0OjpSZW5kZXJQYXJ0T2JqZWN0KEVsZW1lbnQqIGVsZW1lbnQp
CiB7CiB9CiAKLWJvb2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkgY29uc3QKK2Jv
b2wgUmVuZGVyUGFydE9iamVjdDo6ZmxhdHRlbkZyYW1lKCkKIHsKICAgICBpZiAoIW5vZGUoKSB8
fCAhbm9kZSgpLT5oYXNUYWdOYW1lKGlmcmFtZVRhZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsK
IAotICAgIEhUTUxJRnJhbWVFbGVtZW50KiBmcmFtZSA9IHN0YXRpY19jYXN0PEhUTUxJRnJhbWVF
bGVtZW50Kj4obm9kZSgpKTsKLSAgICBib29sIGlzU2Nyb2xsYWJsZSA9IGZyYW1lLT5zY3JvbGxp
bmdNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmOworICAgIEhUTUxJRnJhbWVFbGVtZW50KiBl
bGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTElGcmFtZUVsZW1lbnQqPihub2RlKCkpOworICAgIGJv
b2wgaXNTY3JvbGxhYmxlID0gZWxlbWVudC0+c2Nyb2xsaW5nTW9kZSgpICE9IFNjcm9sbGJhckFs
d2F5c09mZjsKIAogICAgIGlmICghaXNTY3JvbGxhYmxlICYmIHN0eWxlKCktPndpZHRoKCkuaXNG
aXhlZCgpCiAgICAgICAgICYmIHN0eWxlKCktPmhlaWdodCgpLmlzRml4ZWQoKSkKICAgICAgICAg
cmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpICYm
IGZyYW1lLT5kb2N1bWVudCgpLT5mcmFtZSgpLT5zZXR0aW5ncygpLT5mcmFtZUZsYXR0ZW5pbmdF
bmFibGVkKCk7CisgICAgRnJhbWUqIGZyYW1lID0gZWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUo
KTsKKyAgICBib29sIGVuYWJsZWQgPSBmcmFtZSAmJiBmcmFtZS0+c2V0dGluZ3MoKS0+ZnJhbWVG
bGF0dGVuaW5nRW5hYmxlZCgpOworCisgICAgaWYgKCFlbmFibGVkIHx8ICFmcmFtZS0+cGFnZSgp
KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+
cGFnZSgpLT5tYWluRnJhbWUoKS0+dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0
dXJuIGZhbHNlOworCisgICAgLy8gRG8gbm90IGZsYXR0ZW4gb2Zmc2NyZWVuIGlubmVyIGZyYW1l
cyBkdXJpbmcgZnJhbWUgZmxhdHRlbmluZy4KKyAgICByZXR1cm4gYWJzb2x1dGVCb3VuZGluZ0Jv
eFJlY3QoKS5pbnRlcnNlY3RzKEludFJlY3QoSW50UG9pbnQoMCwgMCksIHZpZXctPmNvbnRlbnRz
U2l6ZSgpKSk7CiB9CiAKIHZvaWQgUmVuZGVyUGFydE9iamVjdDo6Y2FsY0hlaWdodCgpCmRpZmYg
LS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmggYi9XZWJDb3JlL3Jl
bmRlcmluZy9SZW5kZXJQYXJ0T2JqZWN0LmgKaW5kZXggNWM3Mjc3ZS4uNTg5ODk2MCAxMDA2NDQK
LS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUGFydE9iamVjdC5oCisrKyBiL1dlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlclBhcnRPYmplY3QuaApAQCAtNDIsNyArNDIsNyBAQCBwcml2YXRlOgog
CiAgICAgdmlydHVhbCB2b2lkIHZpZXdDbGVhcmVkKCk7CiAKLSAgICBib29sIGZsYXR0ZW5GcmFt
ZSgpIGNvbnN0OworICAgIGJvb2wgZmxhdHRlbkZyYW1lKCk7CiB9OwogCiBpbmxpbmUgUmVuZGVy
UGFydE9iamVjdCogdG9SZW5kZXJQYXJ0T2JqZWN0KFJlbmRlck9iamVjdCogb2JqZWN0KQotLSAK
MS43LjAuMwoK
</data>

          </attachment>
      

    </bug>

</bugzilla>