37150 2010-04-06 06:58:54 -0700 [V8][Android] PageCache crashes when JavaScript is disabled 2010-04-06 10:49:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned abarth android-webkit-unforking commit-queue oldest_to_newest 209029 0 andreip 2010-04-06 06:58:54 -0700 WebKit's Page Cache mechanism always attempts to save the script state, regardless of whether JavaScript is enabled or not in the browser. When JS is disabled, a frame's JS execution context is null. However, the Android V8 bindings always expect it to be non-null. The saving and restoration of the script state should be a no-op when JS is disabled. Patch coming. 209031 1 52633 andreip 2010-04-06 07:04:25 -0700 Created attachment 52633 Check the context to avoid crashing when it's null. 209052 2 52633 dglazkov 2010-04-06 08:31:08 -0700 Comment on attachment 52633 Check the context to avoid crashing when it's null. ok. 209114 3 52633 commit-queue 2010-04-06 10:49:41 -0700 Comment on attachment 52633 Check the context to avoid crashing when it's null. Clearing flags on attachment: 52633 Committed r57157: <http://trac.webkit.org/changeset/57157> 209115 4 commit-queue 2010-04-06 10:49:48 -0700 All reviewed patches have been landed. Closing bug. 52633 2010-04-06 07:04:25 -0700 2010-04-06 10:49:41 -0700 Check the context to avoid crashing when it's null. 37150.patch text/plain 2158 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzE0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDQtMDYgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtWOF1bQW5kcm9pZF0gUGFnZUNhY2hlIGNyYXNoZXMgd2hlbiBKYXZhU2NyaXB0IGlzIGRpc2Fi bGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzE1 MAorCisgICAgICAgIFRoaXMgcGF0Y2ggZW5zdXJlcyB0aGF0IHNhdmluZyBhbmQgcmVzdG9yYXRp b24gb2YgdGhlIHNjcmlwdAorICAgICAgICBzdGF0ZSBvbmx5IGhhcHBlbnMgd2hlbiBKUyBpcyBl bmFibGVkIGFuZCBlYWNoIGZyYW1lIGhhcyBhCisgICAgICAgIG5vbi1udWxsIGNvbnRleHQuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzOiBleGlzdGluZyB0ZXN0cyBzaG93IHRoZSBmZWF0dXJlIGlz IHdvcmtpbmcKKyAgICAgICAgd2hlbiBKUyBpcyBlbmFibGVkLiBXaGVuIEpTIGlzIGRpc2FibGVk LCBtYW51YWwgdGVzdGluZworICAgICAgICBpcyByZXF1aXJlZC4KKworICAgICAgICAqIGJpbmRp bmdzL3Y4L1NjcmlwdENhY2hlZEZyYW1lRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3Jp cHRDYWNoZWRGcmFtZURhdGE6OlNjcmlwdENhY2hlZEZyYW1lRGF0YSk6CisgICAgICAgIChXZWJD b3JlOjpTY3JpcHRDYWNoZWRGcmFtZURhdGE6OnJlc3RvcmUpOgorCiAyMDEwLTA0LTA2ICBNYXR0 aWFzIE5pc3NsZXIgIDxtbmlzc2xlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q2FjaGVk RnJhbWVEYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENh Y2hlZEZyYW1lRGF0YS5jcHAJKHJldmlzaW9uIDU3MTQzKQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMyArMzMs MTcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogU2NyaXB0Q2FjaGVkRnJhbWVEYXRhOjpTY3Jp cHRDYWNoZWRGcmFtZURhdGEoRnJhbWUqIGZyYW1lKQotICAgIDogbV9kb21XaW5kb3coZnJhbWUt PmRvbVdpbmRvdygpKQorICAgIDogbV9kb21XaW5kb3coMCkKIHsKICAgICB2ODo6SGFuZGxlU2Nv cGUgaGFuZGxlU2NvcGU7CiAgICAgLy8gVGhlIGNvbnRleHQgY2FuIG9ubHkgYmUgdGhlIGNvbnRl eHQgb2YgdGhlIG1haW4gd29ybGQuCiAgICAgQVNTRVJUKFY4UHJveHk6Om1haW5Xb3JsZENvbnRl eHQoZnJhbWUpID09IFY4UHJveHk6OmNvbnRleHQoZnJhbWUpKTsKICAgICBtX2NvbnRleHQuc2V0 KFY4UHJveHk6Om1haW5Xb3JsZENvbnRleHQoZnJhbWUpKTsKKyAgICAvLyBUaGUgY29udGV4dCBj YW4gYmUgMCwgZS5nLiBpZiBKUyBpcyBkaXNhYmxlZCBpbiB0aGUgYnJvd3Nlci4KKyAgICBpZiAo bV9jb250ZXh0LmdldCgpLklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIG1fZ2xvYmFs LnNldChtX2NvbnRleHQuZ2V0KCktPkdsb2JhbCgpKTsKKyAgICBtX2RvbVdpbmRvdyA9IGZyYW1l LT5kb21XaW5kb3coKTsKIH0KIAogRE9NV2luZG93KiBTY3JpcHRDYWNoZWRGcmFtZURhdGE6OmRv bVdpbmRvdygpIGNvbnN0CkBAIC00OSw2ICs1Myw5IEBAIERPTVdpbmRvdyogU2NyaXB0Q2FjaGVk RnJhbWVEYXRhOjpkb21XaW4KIAogdm9pZCBTY3JpcHRDYWNoZWRGcmFtZURhdGE6OnJlc3RvcmUo RnJhbWUqIGZyYW1lKQogeworICAgIGlmIChtX2NvbnRleHQuZ2V0KCkuSXNFbXB0eSgpKQorICAg ICAgICByZXR1cm47CisKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7CiAgICAgdjg6 OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShtX2NvbnRleHQuZ2V0KCkpOwogCg==