37149 2010-04-06 06:44:27 -0700 JS code generator does not support feature conditional attributes that are writable 2010-04-07 00:48:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All CLOSED FIXED Qt P2 Normal --- 36750 1 hausmann hausmann abarth commit-queue eric laszlo.gombos webkit.review.bot oldest_to_newest 209019 0 hausmann 2010-04-06 06:44:27 -0700 When using the conditional keyword for attributes that can be written, then the generated code is missing the feature #ifdefs for the setter functions. The getter functions do have the correct #ifdefs in place. For example: attribute [Conditional=TOUCH_EVENTS] EventListener ontouchstart; 209027 1 52631 hausmann 2010-04-06 06:55:27 -0700 Created attachment 52631 Patch 209185 2 52631 commit-queue 2010-04-06 12:51:06 -0700 Comment on attachment 52631 Patch Clearing flags on attachment: 52631 Committed r57163: <http://trac.webkit.org/changeset/57163> 209186 3 commit-queue 2010-04-06 12:51:11 -0700 All reviewed patches have been landed. Closing bug. 209226 4 webkit.review.bot 2010-04-06 13:54:00 -0700 http://trac.webkit.org/changeset/57163 might have broken Tiger Intel Release 209231 5 abarth 2010-04-06 13:56:17 -0700 Sorry for the noise. You're running into https://bugs.webkit.org/show_bug.cgi?id=37145. 209516 6 hausmann 2010-04-07 00:48:37 -0700 Revision r57163 cherry-picked into qtwebkit-2.0 with commit 6dcb7f961c5941963b288f5fc4ef3c64877f62ae 52631 2010-04-06 06:55:27 -0700 2010-04-06 12:51:06 -0700 Patch bug-37149-20100406155524.patch text/plain 2248 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTk3Yjg5Yy4uZDVhZWJmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0wNiAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSlMgY29kZSBnZW5lcmF0b3IgZG9lcyBub3Qgc3VwcG9y dCBmZWF0dXJlIGNvbmRpdGlvbmFsIGF0dHJpYnV0ZXMgdGhhdCBhcmUgd3JpdGFibGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTQ5CisKKyAgICAg ICAgV3JpdGUgb3V0IHRoZSBmZWF0dXJlICNpZmRlZiBub3Qgb25seSBmb3IgdGhlIGdldHRlciwg YnV0IGFsc28gZm9yIHRoZSBzZXR0ZXIKKyAgICAgICAgZnVuY3Rpb24uCisKKyAgICAgICAgKiBi aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKwogMjAxMC0wNC0wNiAgQ3NhYmEg T3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVp bGRmaXggZm9yIC0tbWluaW1hbCBidWlsZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCmluZGV4IDgzZWFlZDQuLjVhMjM2YTcgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtMTQ2Niw2ICsxNDY2LDEyIEBAIHN1 YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAgICAgICAgICAgICBteSAkcHV0 RnVuY3Rpb25OYW1lID0gInNldEpTIiAuICRpbnRlcmZhY2VOYW1lIC4gICRjb2RlR2VuZXJhdG9y LT5XS191Y2ZpcnN0KCRuYW1lKSAuICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGUgPX4gL0Nv bnN0cnVjdG9yJC8gPyAiQ29uc3RydWN0b3IiIDogIiIpOwogICAgICAgICAgICAgICAgICAgICAg ICAgbXkgJGltcGxTZXR0ZXJGdW5jdGlvbk5hbWUgPSAkY29kZUdlbmVyYXRvci0+V0tfdWNmaXJz dCgkbmFtZSk7CiAKKyAgICAgICAgICAgICAgICAgICAgICAgIG15ICRjb25kaXRpb25hbCA9ICRh dHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbmRpdGlvbmFsIn07 CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoJGNvbmRpdGlvbmFsKSB7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJGNvbmRpdGlvbmFsU3RyaW5nID0gIkVOQUJMRSgiIC4gam9pbigi KSAmJiBFTkFCTEUoIiwgc3BsaXQoLyYvLCAkY29uZGl0aW9uYWwpKSAuICIpIjsKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiNpZiAke2NvbmRpdGlvbmFs U3RyaW5nfVxuIik7CisgICAgICAgICAgICAgICAgICAgICAgICB9CisKICAgICAgICAgICAgICAg ICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAidm9pZCAke3B1dEZ1bmN0aW9uTmFtZX0oRXhl Y1N0YXRlKiBleGVjLCBKU09iamVjdCogdGhpc09iamVjdCwgSlNWYWx1ZSB2YWx1ZSlcbiIpOwog ICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ7XG4iKTsKIApAQCAt MTUzNCw3ICsxNTQwLDEzIEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAg ICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVu dCwgIn1cblxuIik7CisgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwg In1cbiIpOworCisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoJGNvbmRpdGlvbmFsKSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIjZW5kaWZcbiIp OworICAgICAgICAgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIlxuIik7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9Cg==