37143 2010-04-06 02:33:11 -0700 Chromium: worker exceptions are not shown in console 2010-04-06 03:14:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 0 caseq webkit-unassigned commit-queue yurys oldest_to_newest 208953 0 caseq 2010-04-06 02:33:11 -0700 workerExceptions.html: <html> <script> var w = new Worker("workerException.js"); </script> </html> workerException.js: throw { }; EXPECTED: Loading workerException.html should cause a console message "Uncaught #<an Object>" to be printed to console. ACTUAL: nothing happens This stopped working after r56402, when semantics of EventTarget.dispatchEvent() was slightly changed. The code in WebWorkerClientImpl::postExceptionToWorkerObject(), however, was incorrect before, as EventTarget.dispatchEvent() is supposed to return true iff no event handlers called preventDefault() (i.e. event is unhandled). 208967 1 52619 caseq 2010-04-06 03:01:32 -0700 Created attachment 52619 Fixed reporting of unhandled worker exceptions by inverting check for EventTarget.dispatchEvent result in accordance with its spec 208970 2 52619 yurys 2010-04-06 03:03:48 -0700 Comment on attachment 52619 Fixed reporting of unhandled worker exceptions by inverting check for EventTarget.dispatchEvent result in accordance with its spec Please make sure this change doesn't break layout tests. 208973 3 52619 commit-queue 2010-04-06 03:14:11 -0700 Comment on attachment 52619 Fixed reporting of unhandled worker exceptions by inverting check for EventTarget.dispatchEvent result in accordance with its spec Clearing flags on attachment: 52619 Committed r57138: <http://trac.webkit.org/changeset/57138> 208974 4 commit-queue 2010-04-06 03:14:15 -0700 All reviewed patches have been landed. Closing bug. 52619 2010-04-06 03:01:32 -0700 2010-04-06 03:14:10 -0700 Fixed reporting of unhandled worker exceptions by inverting check for EventTarget.dispatchEvent result in accordance with its spec worker-exceptions.patch text/plain 1552 caseq SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTcxMzUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMDYgIEFuZHJl eSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBsb2dnaW5nIG9mIHVuaG5kbGVkIHdvcmtl ciBleGNlcHRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzcxNDMKKworICAgICAgICAqIHNyYy9XZWJXb3JrZXJDbGllbnRJbXBsLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViV29ya2VyQ2xpZW50SW1wbDo6cG9zdEV4Y2VwdGlvblRvV29ya2Vy T2JqZWN0KToKKwogMjAxMC0wNC0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViV29ya2VyQ2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL3NyYy9XZWJXb3JrZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNTcwNjgpCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYldvcmtlckNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNDUsMTEgKzI0NSwxMCBAQCB2b2lkIFdlYldvcmtlckNsaWVudEltcGw6OnBvc3RFeGNl cHRpb25UCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBib29sIGhhbmRsZWQgPSBmYWxz ZTsKLSAgICBoYW5kbGVkID0gbV93b3JrZXItPmRpc3BhdGNoRXZlbnQoRXJyb3JFdmVudDo6Y3Jl YXRlKGVycm9yTWVzc2FnZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNvdXJjZVVSTCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpbmVOdW1iZXIpKTsKLSAgICBpZiAoIWhh bmRsZWQpCisgICAgYm9vbCB1bmhhbmRsZWQgPSBtX3dvcmtlci0+ZGlzcGF0Y2hFdmVudChFcnJv ckV2ZW50OjpjcmVhdGUoZXJyb3JNZXNzYWdlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNvdXJjZVVSTCwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs aW5lTnVtYmVyKSk7CisgICAgaWYgKHVuaGFuZGxlZCkKICAgICAgICAgbV9zY3JpcHRFeGVjdXRp b25Db250ZXh0LT5yZXBvcnRFeGNlcHRpb24oZXJyb3JNZXNzYWdlLCBsaW5lTnVtYmVyLCBzb3Vy Y2VVUkwpOwogfQogCg==