37135 2010-04-05 21:32:36 -0700 Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable 2010-04-20 13:16:43 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 18662 35784 1 tonikitoo tonikitoo hausmann kenneth simon.fraser oldest_to_newest 208890 0 tonikitoo 2010-04-05 21:32:36 -0700 After calling distanceDataForNode, it is possible to verify if current focus candidate node is applicable or not to Spatial Navigation logic: if it is not applicable , distanceDataForNode will assign a very big valur to node.distance (numeric_limits<long long int>::max()). It might happen when node is not in direction, for example, and indicates that current focus candidate is not an applicable focusable node. In such cases, we should bail out earlier than later. patch coming ... 208892 1 52604 tonikitoo 2010-04-05 21:40:33 -0700 Created attachment 52604 (committed in r57211) patch 211519 2 52604 tonikitoo 2010-04-11 20:06:28 -0700 Comment on attachment 52604 (committed in r57211) patch Clearing flags on attachment: 52604 Committed r57211: <http://trac.webkit.org/changeset/57211> 214905 3 hausmann 2010-04-20 13:16:32 -0700 Revision r57211 cherry-picked into qtwebkit-2.0 with commit ae6f9f4464f61661fafb5ef702659e47d82a89cc 52604 2010-04-05 21:40:33 -0700 2010-04-11 20:06:28 -0700 (committed in r57211) patch 0001-Spatial-Navigation-bail-out-as-soon-as-algorithm-fi.patch text/plain 2605 tonikitoo RnJvbSBmODZmNzBhY2M1YjNhNWU4YTE0MGRlMGVmMzYwODRjY2FkMjliYWNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVHVlLCA2IEFwciAyMDEwIDAwOjM2OjMwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gU3Bh dGlhbCBOYXZpZ2F0aW9uOiBiYWlsIG91dCBhcyBzb29uIGFzIGFsZ29yaXRobSBmaW5kcyBhIGZv Y3VzIGNhbmRpZGF0ZSBpcyBub3QgYXBwbGljYWJsZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3MTM1CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2gg YnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CgpJdCBoYXBwZW5zLCBmb3Ig ZXhhbXBsZSwgd2hlbiBkaXN0YW5jZURhdGFGb3JOb2RlIGFzc2lnbnMgbnVtZXJpY19saW1pdHM8 bG9uZyBsb25nPiB0bwpjdXJyZW50IGZvY3VzIGNhbmRpZGF0ZSdzLiBJdCBtZWFucyB0aGF0IGN1 cnJlbnQgY2FuZGlkYXRlIGlzIG5vdCBpbiBkaXJlY3Rpb24sIG9yIG5vdAphIHZhbGlkIHRhcmdl dCBub2RlLgoKKiBwYWdlL0ZvY3VzQ29udHJvbGxlci5jcHA6CihXZWJDb3JlOjpGb2N1c0NvbnRy b2xsZXI6OmZpbmRGb2N1c2FibGVOb2RlSW5EaXJlY3Rpb24pOgotLS0KIFdlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL0Zv Y3VzQ29udHJvbGxlci5jcHAgfCAgICA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0 aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBi L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDhiNjU4NzYuLjcxY2Y1NDkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBTcGF0aWFs IE5hdmlnYXRpb246IGJhaWwgb3V0IGFzIHNvb24gYXMgYWxnb3JpdGhtIGZpbmRzIGEgZm9jdXMg Y2FuZGlkYXRlIGlzIG5vdCBhcHBsaWNhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNzEzNQorCisgICAgICAgIEl0IGhhcHBlbnMsIGZvciBleGFt cGxlLCB3aGVuIGRpc3RhbmNlRGF0YUZvck5vZGUgYXNzaWducyBudW1lcmljX2xpbWl0czxsb25n IGxvbmc+IHRvCisgICAgICAgIGN1cnJlbnQgZm9jdXMgY2FuZGlkYXRlJ3MuIEl0IG1lYW5zIHRo YXQgY3VycmVudCBjYW5kaWRhdGUgaXMgbm90IGluIGRpcmVjdGlvbiwgb3Igbm90CisgICAgICAg IGEgdmFsaWQgdGFyZ2V0IG5vZGUuCisKKyAgICAgICAgKiBwYWdlL0ZvY3VzQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NvbnRyb2xsZXI6OmZpbmRGb2N1c2FibGVOb2Rl SW5EaXJlY3Rpb24pOgorCisyMDEwLTA0LTA1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAg ICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBtYWtlIGl0IHdvcmsgd2l0aCBmb2N1c2FibGUgZWxlbWVu dHMgaW4gb3ZlcmZsb3cgY29udGVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzY0NjMKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0ZvY3VzQ29u dHJvbGxlci5jcHAgYi9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcAppbmRleCAzN2I3 MmFmLi45ODU1MjBlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNw cAorKysgYi9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcApAQCAtNDM0LDYgKzQzNCwx MCBAQCB2b2lkIEZvY3VzQ29udHJvbGxlcjo6ZmluZEZvY3VzYWJsZU5vZGVJbkRpcmVjdGlvbihE b2N1bWVudCogZG9jdW1lbnQsIE5vZGUqIGZvYwogICAgICAgICAgICAgLy8gR2V0IGRpc3RhbmNl IGFuZCBhbGlnbm1lbnQgZnJvbSBjdXJyZW50IGNhbmRpZGF0ZS4KICAgICAgICAgICAgIGRpc3Rh bmNlRGF0YUZvck5vZGUoZGlyZWN0aW9uLCBmb2N1c2VkTm9kZSwgY3VycmVudEZvY3VzQ2FuZGlk YXRlKTsKIAorICAgICAgICAgICAgLy8gQmFpbCBvdXQgaWYgZGlzdGFuY2UgaXMgbWF4aW11bS4K KyAgICAgICAgICAgIGlmIChjdXJyZW50Rm9jdXNDYW5kaWRhdGUuZGlzdGFuY2UgPT0gbWF4RGlz dGFuY2UoKSkKKyAgICAgICAgICAgICAgICBjb250aW51ZTsKKwogICAgICAgICAgICAgLy8gSWYg Y2FuZGlkYXRlUGFyZW50IGlzIG5vdCBudWxsLCBpdCBtZWFucyB0aGF0IHdlIGFyZSBpbiBhIHJl Y3Vyc2l2ZSBjYWxsCiAgICAgICAgICAgICAvLyBmcm9tIGRlZXBGaW5lRm9jdXNhYmxlTm9kZUlu RGlyZWN0aW9uIChpLmUuIHByb2Nlc3NpbmcgYW4gZWxlbWVudCBpbiBhbiBpZnJhbWUpLAogICAg ICAgICAgICAgLy8gYW5kIGhvbGRzIHRoZSBkaXN0YW5jZSBhbmQgYWxpZ25tZW50IGRhdGEgb2Yg dGhlIGlmcmFtZSBlbGVtZW50IGl0c2VsZi4KLS0gCjEuNi4wLjQKCg==