37125 2010-04-05 16:14:30 -0700 Remove obsolete MOBILE flag 2010-04-06 21:58:43 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned aroben benm commit-queue dacarson dbates ddkilzer eric koivisto ostap73 staikos steveblock oldest_to_newest 208774 0 laszlo.gombos 2010-04-05 16:14:30 -0700 Currently the MOBILE flag is unconditionally disabled in WebCore/config.h. 208783 1 52587 laszlo.gombos 2010-04-05 16:30:30 -0700 Created attachment 52587 1st try, remove the define Alternatively we can put the define around guards like other feature flags, like this: #ifndef MOBILE #define MOBILE 0 #endif I'm also happy to change the name of the define if there is a better proposal. I think a global define like MOBILE does not quite make sense. 208797 2 eric 2010-04-05 16:56:12 -0700 I suspect this was added for iPhone: http://trac.webkit.org/changeset/23281 That or windows mobile. ;p It probably isn't needed anymore, but only someone on team iPhone (like ddkilzer) would know. 208798 3 eric 2010-04-05 16:56:31 -0700 This bug is not security sensitive, removing flag. 208821 4 laszlo.gombos 2010-04-05 17:54:06 -0700 The MOBILE flag only used in WebCore/html/HTMLTokenizer.cpp at the moment and sets up some sensible defaults for CPU-constrained environments. Those defaults that are controlled by this flag can be changed runtime, so I have no strong preference to keep the build flag around. Hope others can chip in as well. 208826 5 staikos 2010-04-05 18:12:21 -0700 This flag is really old - I think it predates everything except S60 browser in terms of mobile webkit. We don't use it. 208862 6 eric 2010-04-05 19:44:06 -0700 If we don't here back from ddkilzer and co. then I suggest changing this to #ifndef MOBILE and then I would feel comfortable r+ing it. 208908 7 52608 laszlo.gombos 2010-04-05 23:03:00 -0700 Created attachment 52608 2nd try Change the patch based on Eric's feedback to keep a default value for the MOBILE flag in config.h but only set it if it was not defined before. Also took the liberty of renaming the flag to ENABLE_MOBILE_TOKENIZER. 209063 8 ddkilzer 2010-04-06 08:45:10 -0700 (In reply to comment #6) > If we don't here back from ddkilzer and co. then I suggest changing this to > #ifndef MOBILE and then I would feel comfortable r+ing it. This macro was added for Android in r16821. http://trac.webkit.org/changeset/16821 You'll have to ask them if they still use it. 209065 9 ddkilzer 2010-04-06 08:47:42 -0700 (In reply to comment #8) > (In reply to comment #6) > > If we don't here back from ddkilzer and co. then I suggest changing this to > > #ifndef MOBILE and then I would feel comfortable r+ing it. > > This macro was added for Android in r16821. > > http://trac.webkit.org/changeset/16821 > > You'll have to ask them if they still use it. Or maybe it was Nokia. In either case, it was not added for iPhone and we don't use it. :) 209088 10 benm 2010-04-06 10:08:50 -0700 Android does not use this flag. 209339 11 eric 2010-04-06 16:56:03 -0700 S60 never built out of trunk, right? And Nokia is now Qt. So it seems we should just rip out this flag and all the associated code. 209438 12 52701 laszlo.gombos 2010-04-06 21:13:33 -0700 Created attachment 52701 3rd try - remove the MOBILE flag Thanks for all the feedback. 209446 13 52701 commit-queue 2010-04-06 21:58:36 -0700 Comment on attachment 52701 3rd try - remove the MOBILE flag Clearing flags on attachment: 52701 Committed r57193: <http://trac.webkit.org/changeset/57193> 209447 14 commit-queue 2010-04-06 21:58:43 -0700 All reviewed patches have been landed. Closing bug. 52587 2010-04-05 16:30:30 -0700 2010-04-05 23:03:00 -0700 1st try, remove the define 37125.patch text/plain 881 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzEwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMDUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEVuYWJsZSBzZXR0aW5nIE1PQklMRSBmbGFnIGF0IGJ1aWxkIHRpbWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTI1CisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAg ICogY29uZmlnLmg6CisKIDIwMTAtMDQtMDUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI1NzA4MS4K SW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jb25maWcuaAko cmV2aXNpb24gNTcwOTgpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC00 Myw4ICs0Myw2IEBACiAjZGVmaW5lIFdFQktJVF9FWFBPUlREQVRBCiAjZW5kaWYKIAotI2RlZmlu ZSBNT0JJTEUgMAotCiAjaWZkZWYgX19BUFBMRV9fCiAjZGVmaW5lIEhBVkVfRlVOQ19VU0xFRVAg MQogI2VuZGlmIC8qIF9fQVBQTEVfXyAqLwo= 52608 2010-04-05 23:03:00 -0700 2010-04-06 21:13:33 -0700 2nd try 37125.patch text/plain 1979 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzEyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMDUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEVuYWJsZSBzZXR0aW5nIE1PQklMRSBmbGFnIGF0IGJ1aWxkIHRpbWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3MTI1CisKKyAgICAgICAg T25seSBzZXQgdGhlIGZsYWcgaWYgaXQgd2FzIG5vdCBkZWZpbmVkIGJlZm9yZS4KKyAgICAgICAg UmVuYW1lIHRoZSBNT0JJTEUgZmxhZyB0byBFTkFCTEVfTU9CSUxFX1RPS0VOSVpFUi4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAg ICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgKiBodG1sL0hUTUxUb2tlbml6ZXIuY3BwOgorCiAy MDEwLTA0LTA1ICBMZWFuZHJvIFBlcmVpcmEgIDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2Vi Q29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiA1 NzExNykKKysrIFdlYkNvcmUvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQzLDkg QEAKICNkZWZpbmUgV0VCS0lUX0VYUE9SVERBVEEKICNlbmRpZgogCi0jZGVmaW5lIE1PQklMRSAw CisjaWZuZGVmIEVOQUJMRV9NT0JJTEVfVE9LRU5JWkVSCisjZGVmaW5lIEVOQUJMRV9NT0JJTEVf VE9LRU5JWkVSIDAKKyNlbmRpZgogCiAjaWZkZWYgX19BUFBMRV9fCiAjZGVmaW5lIEhBVkVfRlVO Q19VU0xFRVAgMQpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcAkocmV2aXNpb24gNTcxMTcpCisr KyBXZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3LDcg KzY3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVz OwogCi0jaWYgTU9CSUxFCisjaWYgRU5BQkxFX01PQklMRV9UT0tFTklaRVIKIC8vIFRoZSBtb2Jp bGUgZGV2aWNlIG5lZWRzIHRvIGJlIHJlc3BvbnNpdmUsIGFzIHN1Y2ggdGhlIHRva2VuaXplciBj aHVuayBzaXplIGlzIHJlZHVjZWQuCiAvLyBUaGlzIHZhbHVlIGlzIHVzZWQgdG8gZGVmaW5lIGhv dyBtYW55IGNoYXJhY3RlcnMgdGhlIHRva2VuaXplciB3aWxsIHByb2Nlc3MgYmVmb3JlIAogLy8g eWVpbGRpbmcgY29udHJvbC4KQEAgLTc2LDcgKzc2LDcgQEAgc3RhdGljIGNvbnN0IGludCBkZWZh dWx0VG9rZW5pemVyQ2h1bmtTaQogc3RhdGljIGNvbnN0IGludCBkZWZhdWx0VG9rZW5pemVyQ2h1 bmtTaXplID0gNDA5NjsKICNlbmRpZgogCi0jaWYgTU9CSUxFCisjaWYgRU5BQkxFX01PQklMRV9U T0tFTklaRVIKIC8vIEFzIHRoZSBjaHVua3MgYXJlIHNtYWxsZXIgKGFib3ZlKSwgdGhlIHRva2Vu aXplciBzaG91bGQgbm90IHlpZWxkIGZvciBhcyBsb25nIGEgcGVyaW9kLCBvdGhlcndpc2UKIC8v IGl0IHdpbGwgdGFrZSB3YXkgdG8gbG9uZyB0byBsb2FkIGEgcGFnZS4KIHN0YXRpYyBjb25zdCBk b3VibGUgZGVmYXVsdFRva2VuaXplclRpbWVEZWxheSA9IDAuMzAwOwo= 52701 2010-04-06 21:13:33 -0700 2010-04-06 21:58:36 -0700 3rd try - remove the MOBILE flag 37125.patch text/plain 2537 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzE5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMDYgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBvYnNvbGV0ZSBNT0JJTEUgZmxhZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxMjUKKworICAgICAgICBUaGUgTU9CSUxFIGZs YWcgaXMgbm8gbG9uZ2VyIHVzZWQgYnkgYW55IG9mIHRoZSBwb3J0cy4KKyAgICAgICAgVGhlIGZs YWcgdXNlIHRvIGNvbnRyb2wgc29tZSB0b2tlbml6ZXIgZGVmYXVsdHMgdGhhdCAKKyAgICAgICAg Y2FuIGJlIGNoYW5nZWQgcnVudGltZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhlcmUg aXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBjb25maWcuaDoKKyAgICAgICAg KiBodG1sL0hUTUxUb2tlbml6ZXIuY3BwOgorCiAyMDEwLTA0LTA2ICBLaW51a28gWWFzdWRhICA8 a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKaWFuIExpLgpJbmRl eDogV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2NvbmZpZy5oCShyZXZp c2lvbiA1NzE5MCkKKysrIFdlYkNvcmUvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDgg KzQzLDYgQEAKICNkZWZpbmUgV0VCS0lUX0VYUE9SVERBVEEKICNlbmRpZgogCi0jZGVmaW5lIE1P QklMRSAwCi0KICNpZmRlZiBfX0FQUExFX18KICNkZWZpbmUgSEFWRV9GVU5DX1VTTEVFUCAxCiAj ZW5kaWYgLyogX19BUFBMRV9fICovCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTFRva2VuaXplci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lv biA1NzE5MCkKKysrIFdlYkNvcmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjcsMjUgKzY3LDE3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNw YWNlIEhUTUxOYW1lczsKIAotI2lmIE1PQklMRQotLy8gVGhlIG1vYmlsZSBkZXZpY2UgbmVlZHMg dG8gYmUgcmVzcG9uc2l2ZSwgYXMgc3VjaCB0aGUgdG9rZW5pemVyIGNodW5rIHNpemUgaXMgcmVk dWNlZC4KIC8vIFRoaXMgdmFsdWUgaXMgdXNlZCB0byBkZWZpbmUgaG93IG1hbnkgY2hhcmFjdGVy cyB0aGUgdG9rZW5pemVyIHdpbGwgcHJvY2VzcyBiZWZvcmUgCiAvLyB5ZWlsZGluZyBjb250cm9s Lgotc3RhdGljIGNvbnN0IGludCBkZWZhdWx0VG9rZW5pemVyQ2h1bmtTaXplID0gMjU2OwotI2Vs c2UKKy8vIFRvIGluY3JlYXNlIHJlc3BvbnNpdm5lc3MgcmVkdWNlIHRoZSB0b2tlbml6ZXIgY2h1 bmsgc2l6ZS4KIHN0YXRpYyBjb25zdCBpbnQgZGVmYXVsdFRva2VuaXplckNodW5rU2l6ZSA9IDQw OTY7Ci0jZW5kaWYKIAotI2lmIE1PQklMRQotLy8gQXMgdGhlIGNodW5rcyBhcmUgc21hbGxlciAo YWJvdmUpLCB0aGUgdG9rZW5pemVyIHNob3VsZCBub3QgeWllbGQgZm9yIGFzIGxvbmcgYSBwZXJp b2QsIG90aGVyd2lzZQotLy8gaXQgd2lsbCB0YWtlIHdheSB0byBsb25nIHRvIGxvYWQgYSBwYWdl Lgotc3RhdGljIGNvbnN0IGRvdWJsZSBkZWZhdWx0VG9rZW5pemVyVGltZURlbGF5ID0gMC4zMDA7 Ci0jZWxzZQogLy8gRklYTUU6IFdlIHdvdWxkIGxpa2UgdGhpcyBjb25zdGFudCB0byBiZSAyMDBt cy4KIC8vIFlpZWxkaW5nIG1vcmUgYWdncmVzc2l2ZWx5IHJlc3VsdHMgaW4gaW5jcmVhc2VkIHJl c3BvbnNpdmVuZXNzIGFuZCBiZXR0ZXIgaW5jcmVtZW50YWwgcmVuZGVyaW5nLgogLy8gSXQgc2xv d3MgZG93biBvdmVyYWxsIHBhZ2UtbG9hZCBvbiBzbG93ZXIgbWFjaGluZXMsIHRob3VnaCwgc28g Zm9yIG5vdyB3ZSBzZXQgYSB2YWx1ZSBvZiA1MDAuCisvLyBGb3Igc21hbGxlciBjaHVua3MgKGFi b3ZlKSBkZWNyZWFzZSB0aGUgdmFsdWUgb2YgVGltZXJEZWxheSBhcyB0aGUgdGhlIHRva2VuaXpl ciBzaG91bGQgbm90IAorLy8geWllbGQgZm9yIGFzIGxvbmcgYSBwZXJpb2Qgb3RoZXJ3aXNlIGl0 IHdpbGwgdGFrZSB3YXkgdG8gbG9uZyB0byBsb2FkIGEgcGFnZS4KIHN0YXRpYyBjb25zdCBkb3Vi bGUgZGVmYXVsdFRva2VuaXplclRpbWVEZWxheSA9IDAuNTAwOwotI2VuZGlmCiAKIHN0YXRpYyBj b25zdCBjaGFyIGNvbW1lbnRTdGFydCBbXSA9ICI8IS0tIjsKIHN0YXRpYyBjb25zdCBjaGFyIGRv Y3R5cGVTdGFydCBbXSA9ICI8IWRvY3R5cGUiOwo=