37120 2010-04-05 15:40:39 -0700 ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups 2010-04-05 15:57:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson webkit-unassigned oldest_to_newest 208746 0 beidson 2010-04-05 15:40:39 -0700 ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups If you use multiple PageGroups and point them both to the same path for LocalStorage, you can get an ASSERT closing the same storage area twice: ASSERT(!m_isShutdown); #0 0x102938f3e in WebCore::StorageNamespaceImpl::close at StorageNamespaceImpl.cpp:122 #1 0x102740fc5 in WebCore::PageGroup::closeLocalStorage at PageGroup.cpp:106 #2 0x101adf881 in +[WebView _applicationWillTerminate] at WebView.mm:2482 I've traced through what happens when you *do* try to close it twice, and it appears there's no ill effects. But it actually ends up trying to do synchronous I/O just to support the second close, which is a waste. The ASSERT is invalid - we thought this case shouldn't happen, but it clearly can. It should just be an early return instead. In radar as <rdar://problem/7828420> 208750 1 52583 beidson 2010-04-05 15:44:44 -0700 Created attachment 52583 Early return instead of ASSERT 208756 2 52583 oliver 2010-04-05 15:52:01 -0700 Comment on attachment 52583 Early return instead of ASSERT r=me 208760 3 beidson 2010-04-05 15:57:24 -0700 http://trac.webkit.org/changeset/57099 52583 2010-04-05 15:44:44 -0700 2010-04-05 15:52:01 -0700 Early return instead of ASSERT patch.txt text/plain 1293 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzA5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMDUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFT U0VSVCBjbG9zZSgpaW5nIHRoZSBzYW1lIFN0b3JhZ2VBcmVhSW1wbCB0d2ljZSB3aGVuIHVzaW5n IG11bHRpcGxlIFBhZ2VHcm91cHMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4Mjg0MjA+IGFu ZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxMjAKKworICAgICAg ICBObyBuZXcgdGVzdHMuIChObyBiZWhhdmlvciBjaGFuZ2UpCisKKyAgICAgICAgKiBzdG9yYWdl L1N0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2VOYW1l c3BhY2VJbXBsOjpjbG9zZSk6IENoYW5nZSB0aGlzIGludmFsaWQgQVNTRVJUIHRvIGFuIGVhcmx5 IHJldHVybi4KKwogMjAxMC0wNC0wNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjU3MDMwLgpJbmRl eDogV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VOYW1lc3BhY2VJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZUltcGwuY3BwCShyZXZpc2lvbiA1NzA4 OCkKKysrIFdlYkNvcmUvc3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTExOSw3ICsxMTksOSBAQCBQYXNzUmVmUHRyPFN0b3JhZ2VBcmVhPiBTdG9yYWdl TmFtZXNwYWNlCiB2b2lkIFN0b3JhZ2VOYW1lc3BhY2VJbXBsOjpjbG9zZSgpCiB7CiAgICAgQVNT RVJUKGlzTWFpblRocmVhZCgpKTsKLSAgICBBU1NFUlQoIW1faXNTaHV0ZG93bik7CisKKyAgICBp ZiAobV9pc1NodXRkb3duKQorICAgICAgICByZXR1cm47CiAKICAgICAvLyBJZiB3ZSdyZSBzZXNz aW9uIHN0b3JhZ2UsIHdlIHNob3VsZG4ndCBuZWVkIHRvIGRvIGFueSB3b3JrIGhlcmUuCiAgICAg aWYgKG1fc3RvcmFnZVR5cGUgPT0gU2Vzc2lvblN0b3JhZ2UpIHsK