37113 2010-04-05 14:17:12 -0700 SheriffBot should include blamelist when posting to bugs 2010-04-05 20:02:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 208694 0 abarth 2010-04-05 14:17:12 -0700 SheriffBot should include blamelist when posting to bugs 208697 1 52570 abarth 2010-04-05 14:18:47 -0700 Created attachment 52570 Patch 208716 2 52570 eric 2010-04-05 14:46:38 -0700 Comment on attachment 52570 Patch Please add a test for what blame_comment_on_bug actually spits out. 208865 3 abarth 2010-04-05 20:02:30 -0700 Committed r57115: <http://trac.webkit.org/changeset/57115> 52570 2010-04-05 14:18:47 -0700 2010-04-05 14:46:38 -0700 Patch bug-37113-20100405141846.patch text/plain 7256 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlNWRiMWIxLi4yNDgzMzgxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTAtMDQt MDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaGVyaWZmQm90IHNob3VsZCBpbmNsdWRlIGJs YW1lbGlzdCB3aGVuIHBvc3RpbmcgdG8gYnVncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcxMTMKKworICAgICAgICBXaGVuIHBvc3Rpbmcgb24gYnVn cywgd2Ugc2hvdWxkIGluY2x1ZGUgdGhlIGZ1bGwgbGlzdCBvZiBTVk4gcmV2aXNpb25zCisgICAg ICAgIHRoYXQgY2F1c2VkIHRoZSByZWdyZXNzaW9uIHRvIGZvbGtzIGhhdmUgYSBiZXR0ZXIgc2Vu c2Ugb2Ygd2hldGhlciB0aGV5CisgICAgICAgIGFyZSB0byBibGFtZS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlmZi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZfdW5pdHRlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3QucHk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3RfdW5pdHRlc3QucHk6CisKKzIwMTAtMDQt MDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBVbnJldmlld2Vk LiAgQWRkIFZpdGFseSBSZXBlc2hrbyBhcyBhIGNvbW1pdHRlci4KIAogICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5OgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmLnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmLnB5CmluZGV4IDJjYzAzZjUuLjQz ZmIzM2YgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qv c2hlcmlmZi5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3No ZXJpZmYucHkKQEAgLTk1LDEyICs5NSwxNSBAQCBjbGFzcyBTaGVyaWZmKG9iamVjdCk6CiAgICAg ICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIGxvZygiRmFpbGVkIHRvIGNy ZWF0ZS1yb2xsb3V0LiIpCiAKLSAgICBkZWYgcG9zdF9ibGFtZV9jb21tZW50X29uX2J1ZyhzZWxm LCBjb21taXRfaW5mbywgYnVpbGRlcnMpOgorICAgIGRlZiBwb3N0X2JsYW1lX2NvbW1lbnRfb25f YnVnKHNlbGYsIGNvbW1pdF9pbmZvLCBidWlsZGVycywgYmxhbWVfbGlzdCk6CiAgICAgICAgIGlm IG5vdCBjb21taXRfaW5mby5idWdfaWQoKToKICAgICAgICAgICAgIHJldHVybgogICAgICAgICBj b21tZW50ID0gIiVzIG1pZ2h0IGhhdmUgYnJva2VuICVzIiAlICgKICAgICAgICAgICAgIHZpZXdf c291cmNlX3VybChjb21taXRfaW5mby5yZXZpc2lvbigpKSwKICAgICAgICAgICAgIGpvaW5fd2l0 aF9zZXBhcmF0b3JzKFtidWlsZGVyLm5hbWUoKSBmb3IgYnVpbGRlciBpbiBidWlsZGVyc10pKQor ICAgICAgICBpZiBsZW4oYmxhbWVfbGlzdCkgPiAxOgorICAgICAgICAgICAgY29tbWVudCArPSAi XG5UaGUgZm9sbG93aW5nIGNoYW5nZXMgYXJlIG9uIHRoZSBibGFtZSBsaXN0OlxuIgorICAgICAg ICAgICAgY29tbWVudCArPSAiXG4iLmpvaW4obWFwKHZpZXdfc291cmNlX3VybCwgYmxhbWVfbGlz dCkpCiAgICAgICAgIHNlbGYuX3Rvb2wuYnVncy5wb3N0X2NvbW1lbnRfdG9fYnVnKGNvbW1pdF9p bmZvLmJ1Z19pZCgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb21tZW50LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj Yz1zZWxmLl9zaGVyaWZmYm90LndhdGNoZXJzKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zaGVyaWZmX3VuaXR0ZXN0LnB5CmluZGV4IDQxOTEw NzAuLjdmNDljMzcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9ib3Qvc2hlcmlmZl91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvYm90L3NoZXJpZmZfdW5pdHRlc3QucHkKQEAgLTY0LDcgKzY0LDkgQEAgY2xhc3Mg U2hlcmlmZlRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBjb21taXRfaW5mby5idWdf aWQgPSBsYW1iZGE6IE5vbmUKICAgICAgICAgY29tbWl0X2luZm8ucmV2aXNpb24gPSBsYW1iZGE6 IDQzMjEKICAgICAgICAgIyBTaG91bGQgZG8gbm90aGluZyB3aXRoIG5vIGJ1Z19pZAotICAgICAg ICBzaGVyaWZmLnBvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8sIGJ1aWxkZXJz KQorICAgICAgICBzaGVyaWZmLnBvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8s IGJ1aWxkZXJzLCBbXSkKKyAgICAgICAgc2hlcmlmZi5wb3N0X2JsYW1lX2NvbW1lbnRfb25fYnVn KGNvbW1pdF9pbmZvLCBidWlsZGVycywgWzI0NjgsIDU2NDZdKQogICAgICAgICAjIFNob3VsZCB0 cnkgdG8gcG9zdCBhIGNvbW1lbnQgdG8gdGhlIGJ1ZywgYnV0IE1vY2tUb29sLmJ1Z3MgZG9lcyBu b3RoaW5nLgogICAgICAgICBjb21taXRfaW5mby5idWdfaWQgPSBsYW1iZGE6IDEyMzQKLSAgICAg ICAgc2hlcmlmZi5wb3N0X2JsYW1lX2NvbW1lbnRfb25fYnVnKGNvbW1pdF9pbmZvLCBidWlsZGVy cykKKyAgICAgICAgc2hlcmlmZi5wb3N0X2JsYW1lX2NvbW1lbnRfb25fYnVnKGNvbW1pdF9pbmZv LCBidWlsZGVycywgW10pCisgICAgICAgIHNoZXJpZmYucG9zdF9ibGFtZV9jb21tZW50X29uX2J1 Zyhjb21taXRfaW5mbywgYnVpbGRlcnMsIFs4NDFdKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3NoZXJpZmZib3QucHkgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQppbmRleCA1MzYz ZDMyLi5kOTQ1ZDUxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdC5weQpAQCAtNTQsNDMgKzU0LDQxIEBAIGNsYXNz IFNoZXJpZmZCb3QoQWJzdHJhY3RRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKICAg ICAgICAgc2VsZi5faXJjX2JvdCA9IFNoZXJpZmZJUkNCb3Qoc2VsZi50b29sLCBzZWxmLl9zaGVy aWZmKQogICAgICAgICBzZWxmLnRvb2wuZW5zdXJlX2lyY19jb25uZWN0ZWQoc2VsZi5faXJjX2Jv dC5pcmNfZGVsZWdhdGUoKSkKIAotICAgIGRlZiB3b3JrX2l0ZW1fbG9nX3BhdGgoc2VsZiwgZmFp bHVyZV9pbmZvKToKLSAgICAgICAgcmV0dXJuIG9zLnBhdGguam9pbigiJXMtbG9ncyIgJSBzZWxm Lm5hbWUsICIlcy5sb2ciICUgZmFpbHVyZV9pbmZvWyJzdm5fcmV2aXNpb24iXSkKKyAgICBkZWYg d29ya19pdGVtX2xvZ19wYXRoKHNlbGYsIG5ld19mYWlsdXJlcyk6CisgICAgICAgIHJldHVybiBv cy5wYXRoLmpvaW4oIiVzLWxvZ3MiICUgc2VsZi5uYW1lLCAiJXMubG9nIiAlIG5ld19mYWlsdXJl cy5rZXlzKClbMF0pCiAKICAgICBkZWYgbmV4dF93b3JrX2l0ZW0oc2VsZik6CiAgICAgICAgIHNl bGYuX2lyY19ib3QucHJvY2Vzc19wZW5kaW5nX21lc3NhZ2VzKCkKICAgICAgICAgc2VsZi5fdXBk YXRlKCkKKyAgICAgICAgbmV3X2ZhaWx1cmVzID0ge30KICAgICAgICAgZm9yIHN2bl9yZXZpc2lv biwgYnVpbGRlcnMgaW4gc2VsZi50b29sLmJ1aWxkYm90LnJldmlzaW9uc19jYXVzaW5nX2ZhaWx1 cmVzKCkuaXRlbXMoKToKICAgICAgICAgICAgIGlmIHNlbGYudG9vbC5zdGF0dXNfc2VydmVyLnN2 bl9yZXZpc2lvbihzdm5fcmV2aXNpb24pOgogICAgICAgICAgICAgICAgICMgRklYTUU6IFdlIHNo b3VsZCByZS1wcm9jZXNzIHRoZSB3b3JrIGl0ZW0gYWZ0ZXIgc29tZSB0aW1lIGRlbGF5LgogICAg ICAgICAgICAgICAgICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2 NTgxCiAgICAgICAgICAgICAgICAgY29udGludWUKLSAgICAgICAgICAgIHJldHVybiB7Ci0gICAg ICAgICAgICAgICAgInN2bl9yZXZpc2lvbiI6IHN2bl9yZXZpc2lvbiwKLSAgICAgICAgICAgICAg ICAiYnVpbGRlcnMiOiBidWlsZGVycywKLSAgICAgICAgICAgICAgICAjIEZJWE1FOiBTaGVyaWZm Ll9yb2xsb3V0X3JlYXNvbiBuZWVkcyBCdWlsZCBvYmplY3RzIHdoaWNoIHdlIGNvdWxkIHBhc3Mg aGVyZS4KLSAgICAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIE5vbmUKKyAgICAgICAgICAgIG5l d19mYWlsdXJlc1tzdm5fcmV2aXNpb25dID0gYnVpbGRlcnMKKyAgICAgICAgcmV0dXJuIG5ld19m YWlsdXJlcwogCi0gICAgZGVmIHNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19pdGVtKHNlbGYsIGZh aWx1cmVfaW5mbyk6CisgICAgZGVmIHNob3VsZF9wcm9jZWVkX3dpdGhfd29ya19pdGVtKHNlbGYs IG5ld19mYWlsdXJlcyk6CiAgICAgICAgICMgQ3VycmVudGx5LCB3ZSBkb24ndCBoYXZlIGFueSBy ZWFzb25zIG5vdCB0byBwcm9jZWVkIHdpdGggd29yayBpdGVtcy4KICAgICAgICAgcmV0dXJuIFRy dWUKIAotICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBmYWlsdXJlX2luZm8pOgotICAg ICAgICBzdm5fcmV2aXNpb24gPSBmYWlsdXJlX2luZm9bInN2bl9yZXZpc2lvbiJdCi0gICAgICAg IGJ1aWxkZXJzID0gZmFpbHVyZV9pbmZvWyJidWlsZGVycyJdCi0KLSAgICAgICAgc2VsZi5fdXBk YXRlKCkKLSAgICAgICAgY29tbWl0X2luZm8gPSBzZWxmLnRvb2wuY2hlY2tvdXQoKS5jb21taXRf aW5mb19mb3JfcmV2aXNpb24oc3ZuX3JldmlzaW9uKQotICAgICAgICBzZWxmLl9zaGVyaWZmLnBv c3RfaXJjX3dhcm5pbmcoY29tbWl0X2luZm8sIGJ1aWxkZXJzKQotICAgICAgICBzZWxmLl9zaGVy aWZmLnBvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8sIGJ1aWxkZXJzKQotICAg ICAgICBzZWxmLl9zaGVyaWZmLnBvc3RfYXV0b21hdGljX3JvbGxvdXRfcGF0Y2goY29tbWl0X2lu Zm8sIGJ1aWxkZXJzKQotCi0gICAgICAgIGZvciBidWlsZGVyIGluIGJ1aWxkZXJzOgotICAgICAg ICAgICAgc2VsZi50b29sLnN0YXR1c19zZXJ2ZXIudXBkYXRlX3N2bl9yZXZpc2lvbihzdm5fcmV2 aXNpb24sIGJ1aWxkZXIubmFtZSgpKQorICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBu ZXdfZmFpbHVyZXMpOgorICAgICAgICBibGFtZV9saXN0ID0gbmV3X2ZhaWx1cmVzLmtleXMoKQor ICAgICAgICBmb3Igc3ZuX3JldmlzaW9uLCBidWlsZGVycyBpbiBuZXdfZmFpbHVyZXMuaXRlbXMo KToKKyAgICAgICAgICAgIGNvbW1pdF9pbmZvID0gc2VsZi50b29sLmNoZWNrb3V0KCkuY29tbWl0 X2luZm9fZm9yX3JldmlzaW9uKHN2bl9yZXZpc2lvbikKKyAgICAgICAgICAgIHNlbGYuX3NoZXJp ZmYucG9zdF9pcmNfd2FybmluZyhjb21taXRfaW5mbywgYnVpbGRlcnMpCisgICAgICAgICAgICBz ZWxmLl9zaGVyaWZmLnBvc3RfYmxhbWVfY29tbWVudF9vbl9idWcoY29tbWl0X2luZm8sCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVpbGRlcnMs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmxh bWVfbGlzdCkKKyAgICAgICAgICAgIHNlbGYuX3NoZXJpZmYucG9zdF9hdXRvbWF0aWNfcm9sbG91 dF9wYXRjaChjb21taXRfaW5mbywgYnVpbGRlcnMpCisKKyAgICAgICAgICAgIGZvciBidWlsZGVy IGluIGJ1aWxkZXJzOgorICAgICAgICAgICAgICAgIHNlbGYudG9vbC5zdGF0dXNfc2VydmVyLnVw ZGF0ZV9zdm5fcmV2aXNpb24oc3ZuX3JldmlzaW9uLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVpbGRlci5uYW1lKCkpCiAgICAg ICAgIHJldHVybiBUcnVlCiAKLSAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Ioc2VsZiwg ZmFpbHVyZV9pbmZvLCBtZXNzYWdlKToKKyAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Io c2VsZiwgbmV3X2ZhaWx1cmVzLCBtZXNzYWdlKToKICAgICAgICAgbG9nKG1lc3NhZ2UpCiAKICAg ICAjIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlciBtZXRob2RzCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc2hlcmlmZmJvdF91bml0dGVzdC5w eSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zaGVyaWZmYm90 X3VuaXR0ZXN0LnB5CmluZGV4IDAwOWRiNTkuLmU2Y2YzZmMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zaGVyaWZmYm90X3VuaXR0ZXN0LnB5 CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9zaGVyaWZm Ym90X3VuaXR0ZXN0LnB5CkBAIC0zNiw4ICszNiw3IEBAIGZyb20gd2Via2l0cHkudG9vbC5tb2Nr dG9vbCBpbXBvcnQgbW9ja19idWlsZGVyCiBjbGFzcyBTaGVyaWZmQm90VGVzdChRdWV1ZXNUZXN0 KToKICAgICBkZWYgdGVzdF9zaGVyaWZmX2JvdChzZWxmKToKICAgICAgICAgbW9ja193b3JrX2l0 ZW0gPSB7Ci0gICAgICAgICAgICAic3ZuX3JldmlzaW9uIjogMjk4MzcsCi0gICAgICAgICAgICAi YnVpbGRlcnMiOiBbbW9ja19idWlsZGVyXQorICAgICAgICAgICAgMjk4Mzc6IFttb2NrX2J1aWxk ZXJdLAogICAgICAgICB9CiAgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9IHsKICAgICAgICAgICAg ICJiZWdpbl93b3JrX3F1ZXVlIjogIkNBVVRJT046IHNoZXJpZmYtYm90IHdpbGwgZGlzY2FyZCBh bGwgbG9jYWwgY2hhbmdlcyBpbiBcIiVzXCJcblJ1bm5pbmcgV2ViS2l0IHNoZXJpZmYtYm90Llxu IiAlIG9zLmdldGN3ZCgpLAo=